Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDVFx-0006eS-Bn for pgadmin-hackers@arkaria.postgresql.org; Thu, 16 Jun 2016 11:14:41 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bDVFw-0007U1-UZ for pgadmin-hackers@arkaria.postgresql.org; Thu, 16 Jun 2016 11:14:40 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bDVFj-0007G2-MS for pgadmin-hackers@postgresql.org; Thu, 16 Jun 2016 11:14:27 +0000 Received: from mail-oi0-x22f.google.com ([2607:f8b0:4003:c06::22f]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bDVFf-0005ON-Ji for pgadmin-hackers@postgresql.org; Thu, 16 Jun 2016 11:14:27 +0000 Received: by mail-oi0-x22f.google.com with SMTP id w5so63418377oib.2 for ; Thu, 16 Jun 2016 04:14:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=3NzUscX2Vdf1sBmyzX0079uFe98nC8/7yfXPwtJW/K8=; b=Rysqdahof+lFqDWe+zv5jfigI1IUfo2I2EvHZpzDLyZFU2Vhe8jPgMyoDewIHu1xI8 jUZ1zY5vObuFjslREKZayFZRYCkAsaXe81P27sWwpFY13I74bCfY32f+JA2vkbUZF0KZ c+RnNxBoPBrMm0V2W9LbThVTVEa25unW3QGJs0j8fkEw+K1V2eskSShKXhqEOs76tdNz tzoTi/GaExwp7pkmsQMlJuREJVHorkSIOzpuhyJGfLYERoScrrx4bUo3f6Mm8ef00y9W GokhQgJlJgi1Rz1Iwob/OSY7aoVXfaPshiVa8NgE/EaU3tz5obktfnO+gZ4fhlHmXcmE +HfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=3NzUscX2Vdf1sBmyzX0079uFe98nC8/7yfXPwtJW/K8=; b=VsrWRJQoZ4Ub1JpPqu9dD5/OqarliOBEKJ0kNAM+poTCxZT/0nn0//IllmYg1TFkQR jXYgoG0zaEoqIjIkqUuSUGA4am7LWXrRJ2tIHn3yeGtEkFzURTAevNowzSDgnQFN58GO z8lXrK1ogGLeq4gY+hflYv0AGWvPz29mlJL+6DwRweNhq1SVqqn7Fp1sKPxLO6AIkRGk ZgNMFojE6Xi/n+giWe62jgdoxEtTdZX9E9gNonlgtZ/sDJIg8aouQln1LwXgfSof5Zmw DoFokAql7ckYanjx+vavfL/MBcEsa7b3GS4ff3JYx9JmkpIqnVjXJ35y+mvZXVGM8nhH 4UJQ== X-Gm-Message-State: ALyK8tIAq+nRliWQnn+0Sq3pbvcZ9hx1QAIvRFJ/WTnuRu+jMlWG0fd5LUYgMZy5UZd1omh4+Y5REWuAZACwSC0E MIME-Version: 1.0 X-Received: by 10.202.214.216 with SMTP id n207mr1769990oig.1.1466075661770; Thu, 16 Jun 2016 04:14:21 -0700 (PDT) Received: by 10.157.20.182 with HTTP; Thu, 16 Jun 2016 04:14:21 -0700 (PDT) In-Reply-To: References: Date: Thu, 16 Jun 2016 16:44:21 +0530 Message-ID: Subject: Re: Fix for issue RM1336 [pgadmin4] From: Harshal Dhumal To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a113b1b3608bbe305356357e7 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113b1b3608bbe305356357e7 Content-Type: text/plain; charset=UTF-8 Hi, As per my offline discussion with Ashesh; He is suggesting not to use Function keys as shortcuts. And regarding configurable key options, I suspect It is going to be time consuming task, please let me know if you want me to start working it. Or can we keep current shortcuts from my last patch? On Thu, Jun 16, 2016 at 4:19 PM, Dave Page wrote: > Hi > > Hmm, I guess that's system dependent. What about Ctrl+F5? Or we bite > the bullet and make it configurable. > On Thu, Jun 16, 2016 at 11:47 AM, Harshal Dhumal > wrote: > > Hi Dave, > > > > Function keys won't work properly with browser as they already have > > predefined bindings. > > > > e.g. > > > > F5 for refresh (standard) > > F7 for Caret Browsing in firefox > > > > > > -- > > Harshal Dhumal > > Software Engineer > > > > EnterpriseDB India: http://www.enterprisedb.com > > The Enterprise PostgreSQL Company > > > > On Thu, Jun 16, 2016 at 4:10 PM, Harshal Dhumal > > wrote: > >> > >> Hi Dave, > >> > >> Ok, I'll change shortcut keys > >> > >> New shortcuts would be: > >> > >> Execute --> F5 > >> Explain --> F7 > >> Explain analyze --> Shift+F7 > >> > >> > >> > >> -- > >> Harshal Dhumal > >> Software Engineer > >> > >> EnterpriseDB India: http://www.enterprisedb.com > >> The Enterprise PostgreSQL Company > >> > >> On Thu, Jun 16, 2016 at 4:03 PM, Dave Page wrote: > >>> > >>> Hi, > >>> > >>> Can we not make them compatible with pgAdmin 3? Ctrl + Shift + E is > >>> significantly less convenient than F5. > >>> > >>> On Thu, Jun 16, 2016 at 11:28 AM, Harshal Dhumal > >>> wrote: > >>> > Hi, > >>> > > >>> > PAF patch for issue RM1336 > >>> > > >>> > Changes: Added keyboard shortcuts (static/non configurable) to some > >>> > query > >>> > tool operations. > >>> > > >>> > Execute --> Ctrl + Shift + E > >>> > Explain --> Ctrl + Shift + X > >>> > Explain analyze --> Ctrl + Shift + A > >>> > > >>> > Note: Keyboard shortcuts do not work if focus is set on any disabled > >>> > button > >>> > inside query tool or out side the query tool. > >>> > > >>> > > >>> > -- > >>> > Harshal Dhumal > >>> > Software Engineer > >>> > > >>> > EnterpriseDB India: http://www.enterprisedb.com > >>> > The Enterprise PostgreSQL Company > >>> > > >>> > > >>> > -- > >>> > Sent via pgadmin-hackers mailing list ( > pgadmin-hackers@postgresql.org) > >>> > To make changes to your subscription: > >>> > http://www.postgresql.org/mailpref/pgadmin-hackers > >>> > > >>> > >>> > >>> > >>> -- > >>> Dave Page > >>> Blog: http://pgsnake.blogspot.com > >>> Twitter: @pgsnake > >>> > >>> EnterpriseDB UK: http://www.enterprisedb.com > >>> The Enterprise PostgreSQL Company > >> > >> > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a113b1b3608bbe305356357e7 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

=
As per my offline discussion with A= shesh; He is suggesting not to use Function keys as shortcuts.
<= /div>
And regarding = configurable key options, I suspect It is going to be time consuming task, = please let me know if you want me to start working it. Or can we keep curre= nt shortcuts from my last patch?


<= /div>
On Thu,= Jun 16, 2016 at 4:19 PM, Dave Page <dpage@pgadmin.org> wrot= e:
Hi

Hmm, I guess that's system dependent. What about Ctrl+F5? Or we bite the bullet and make it configurable.=C2=A0
On Thu, Jun 16, 2016 at 11:47 AM, Harshal Dhumal
<harshal.dhumal@enterprisedb.com> wrote:
> Hi Dave,
>
> Function keys won't work properly with browser as they already hav= e
> predefined bindings.
>
> e.g.
>
> F5 for refresh (standard)
> F7 for Caret Browsing in firefox
>
>
> --
> Harshal Dhumal
> Software Engineer
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Thu, Jun 16, 2016 at 4:10 PM, Harshal Dhumal
> <harshal.dhumal@= enterprisedb.com> wrote:
>>
>> Hi Dave,
>>
>> Ok, I'll change shortcut keys
>>
>> New shortcuts would be:
>>
>> Execute=C2=A0 -->=C2=A0 =C2=A0F5
>> Explain=C2=A0 -->=C2=A0 =C2=A0 F7
>> Explain analyze=C2=A0 --> Shift+F7
>>
>>
>>
>> --
>> Harshal Dhumal
>> Software Engineer
>>
>> EnterpriseDB India: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Thu, Jun 16, 2016 at 4:03 PM, Dave Page <dpage@pgadmin.org> wrote:
>>>
>>> Hi,
>>>
>>> Can we not make them compatible with pgAdmin 3? Ctrl + Shift += E is
>>> significantly less convenient than F5.
>>>
>>> On Thu, Jun 16, 2016 at 11:28 AM, Harshal Dhumal
>>> <harshal= .dhumal@enterprisedb.com> wrote:
>>> > Hi,
>>> >
>>> > PAF patch for issue RM1336
>>> >
>>> > Changes: Added keyboard shortcuts (static/non configurabl= e) to some
>>> > query
>>> > tool operations.
>>> >
>>> > Execute=C2=A0 -->=C2=A0 =C2=A0Ctrl + Shift + E
>>> > Explain=C2=A0 -->=C2=A0 =C2=A0 Ctrl + Shift + X
>>> > Explain analyze=C2=A0 -->=C2=A0 =C2=A0Ctrl + Shift + A=
>>> >
>>> > Note: Keyboard shortcuts do not work if focus is set on a= ny disabled
>>> > button
>>> > inside query tool or out side the query tool.
>>> >
>>> >
>>> > --
>>> > Harshal Dhumal
>>> > Software Engineer
>>> >
>>> > EnterpriseDB India: http://www.enterprisedb.com
>>> > The Enterprise PostgreSQL Company
>>> >
>>> >
>>> > --
>>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>>> > To make changes to your subscription:
>>> > http://www.postgresql.org/mailpr= ef/pgadmin-hackers
>>> >
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>
>>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a113b1b3608bbe305356357e7--