Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1az319-0007hy-NT for pgadmin-hackers@arkaria.postgresql.org; Sat, 07 May 2016 14:15:39 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1az319-0003uE-AC for pgadmin-hackers@arkaria.postgresql.org; Sat, 07 May 2016 14:15:39 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1az318-0003rg-2I for pgadmin-hackers@postgresql.org; Sat, 07 May 2016 14:15:38 +0000 Received: from mail-oi0-x22d.google.com ([2607:f8b0:4003:c06::22d]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1az314-0007zL-WE for pgadmin-hackers@postgresql.org; Sat, 07 May 2016 14:15:36 +0000 Received: by mail-oi0-x22d.google.com with SMTP id v145so168078878oie.0 for ; Sat, 07 May 2016 07:15:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=JKG3USR7b8roqRrCrXjxfnaX3KgQXfjyjJ5awJjEP3g=; b=gbx/XCZFGdwnFqgxXuKGmxG1GUY/UWwqzvE52+jOakARZzmiIP5YjDMBlZFkk3OaMM KpaFcFeVN1Xiy11QEGwVmMeRSFjUprDYXHXXzuoGUlO6Q7QiF80va34a4iS30ohsCzrI cA/7rFD/CriP5dWNIWY+LUyj4/IKQWIEqvgIzykiwfMMlt+rIorPowUFgYkN03UsyRbR 3IwPYr2X5/39XxV8gYgru9TY0PnKxoF6Aj/ORIj7aIPkMPB8T9n/ybrb/W0/K78Sz+Dq NfghLMvmQTbCSlZ1RxC7xpKlcZ4UYfYQCWu31g4l7gVl4fic20LoJQjVX61PRA9owZLv YOig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=JKG3USR7b8roqRrCrXjxfnaX3KgQXfjyjJ5awJjEP3g=; b=T+2NmMk1OOEYB3OmZ3fgT/McXr08oNKWTWkk/n7yb/waAfAnzBKK6tmWPqA89lzKa9 eUTfRJN6hjHgiekYflGpUoPkoipsYNPHwYT+as3d3DkoYZ5Ea5Qt7Dsz4uGA/E5F97FW cryYTjfA0gL+dPPazp9yvdHdYEiLhxZNCaGeOqUw6+E01n6efH8CV/qBm1WzXDNsbYCx ge0h7TXEbHxEpI4EfXliBC3S6JSS229hkRSSWWTq8N1dA7sPsbnDcYXI4bR6uja4Apj/ A9pJSuDzHFTRMMsg6w+fJt0sOKRAxduS3ERy7ETNNON8JHdmBkXEiftEqYYFx9wdPMr9 JXxA== X-Gm-Message-State: AOPr4FVWJ1BXOmYVe9E9Y4vbXj6IVjKyGqB69OWvMSuUMNjejRCCabQXradpKyOVt+2vrtah07gRxenFFJdYsw44 MIME-Version: 1.0 X-Received: by 10.202.77.150 with SMTP id a144mr12047259oib.74.1462630534562; Sat, 07 May 2016 07:15:34 -0700 (PDT) Received: by 10.157.54.226 with HTTP; Sat, 7 May 2016 07:15:34 -0700 (PDT) In-Reply-To: References: Date: Sat, 7 May 2016 19:45:34 +0530 Message-ID: Subject: Re: [PATCH] Tables node (pgAdmin4) From: Harshal Dhumal To: pgadmin-hackers Cc: Khushboo Vashi Content-Type: multipart/alternative; boundary=001a11c15388735ad905324135cc X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a11c15388735ad905324135cc Content-Type: text/plain; charset=UTF-8 Hi, Please find below responses. > > Please find the review comments so far: > > 1. On the Table Collection node, The fields in the grid should be Name, > Owner and Comments. OID is not required. Please follow same for the other > Nodes like Index, Constraints etc. > Fixed > 2. While Updating the Table, Add any column as well as Inherits any table, > then the check the SQL tab. > ALTER TABLE SQL should be come in the new line > > *Current SQL Tab:* > > ALTER TABLE pem.agent_heartbeat > INHERIT pem.alert_history;ALTER TABLE pem.agent_heartbeat > ADD COLUMN test bigint; > Fixed > 3. While Creating/updating table, if the Schema is other than selected > one, then after saving the table, it is not falling under the same schema. > And also in update mode it gives an error. > TODO > 4. Unlogged setting does not honor the change of value. > Not reproducible. > 5. Please Check SQL tab for all the Nodes as most of them having problem > of No blank lines/More than one Blank Lines/Blank Lines at the end etc. > Fixed > 6. Creating Table with auto_vacuum and updating only one field then wrong > SQL is generated. > WITH ( > OIDS = TRUE, > FILLFACTOR = 12, > autovacuum_enabled = TRUE, > , > autovacuum_vacuum_cost_delay = 21 > ) > > Fixed. > 7. Same as toast > WITH ( > OIDS = TRUE, > FILLFACTOR = 12, > autovacuum_enabled = TRUE, > toast.autovacuum_enabled = TRUE, > autovacuum_analyze_scale_factor = 1, > autovacuum_analyze_threshold = 2, > autovacuum_freeze_max_age = 2, > , > toast.autovacuum_vacuum_cost_limit = 2, > toast.autovacuum_freeze_min_age = 4 > ) > Fixed > > 8. Sometimes while creating table and checking sql table, below error is > coming > > File > "/home/khushboo/Projects/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py", > line 1060, in properties > data = res['rows'][0] > IndexError: list index out of range > TODO. (Need exact steps to reproduce.) > > 9. Please check all the Grid table columns. It should not be expanded > while editing directly into the grid. For ref: Check constraint grid > TODO > > 10. Constraint Nodes are not covered yet due to validation issue on which > Harshal is working. > Done. > > 11. While creating the table if auto-vacuume has been enabled by user, > then it should stay enabled in Edit mode also. Currently it is not. > Fixed > 12 .If I just enable 'custom auto activated' and don't update anything > then SQL tab is generating below SQL which is wrong. > > ALTER TABLE pem.khushboo1 SET ( > > ); > Fixed > > 13. IF I Change privileges from pem_agent to agent1 then the SQL i like > below, which is not corrent > > REVOKE ALL ON TABLE pem.khushboo1 FROM agent1; > GRANT SELECT ON TABLE pem.khushboo1 TO agent1; > Not reproducible Or please provide steps to reproduce. > 14. In check constraint, change "Don't Validate" to Validated? Please > refer Domain Constraint for the same. > Fixed. > > 15. SQL for the Column is coming as below, which is not correct. > > -- Column: col3 -- ALTER TABLE pem.khushboo1 DROP > COLUMN col3; ALTER TABLE pem.khushboo1 ADD COLUMN col3 integer NOT > NULL; > Not reproducible Or please provide steps to reproduce. > > 16. While updating table columns from column node. Below SQL generating an > error. > > ALTER TABLE pem.khushboo1 > ALTER COLUMN col2 numeric(1, 1); > Fixed > > 17. After deleting any column, the properties of the another column of the > same table doesn't show up. Gives below error. > > TypeError: self.canDrop.apply is not a function > > ...lf.canDrop) ? function() { return self.canDrop.apply(self, arguments); > } : fals > This issue is already raised. > 18. Table Node : Exclusion constraint : Grid validates DESC instead of > operator. > Not reproducible. > > 19. Please check validation of the Exclusion control, as some JS error is > coming and due to this, we can not close the dialogue. > > The select2('destroy') method was called on an element that is not > using Select2. > > > ...this.$dropdown.on(d.join(" > "),function(a){a.stopPropagation()})},a}),b.define("s... > > select2....min.js (line 3) > TypeError: c is undefined > This is already fixed. > > 20. While updating the comments field of the Index node, it throws below > error: > > TypeError: obj is null > > } else if ((obj.sessChanged && obj.sessChanged()) || isNew) { > This is already fixed. > 21. Job Trigger : Validation missing, so user can't get an idea what is > missing while checking the SQL tab > Fixed. > 22. For the reverse Engineering SQL tab, the constraints should be start > with Schema.Table.Constraint. Please follow same path for all the nodes. > I cross checked with pgadmin3. Reverse Engineering SQL looks good to me. Please let me know what is missing? > 23. Indexes : Comments can not be updated. Please check the attached > screen-shot for reference. > Fixed > 24. Spelling mistake of 'Definition' in Indexes. > Fixed > > NOTE: I haven't check Constraints properly due to validation issue. Also I > have checked only functional flow, I will review the code today evening or > tomorrow. > > > Thanks, > Khushboo > > > > On Wed, Apr 27, 2016 at 2:52 PM, Harshal Dhumal < > harshal.dhumal@enterprisedb.com> wrote: > >> Hi, >> >> PFA attached patches for table node and all table child nodes. >> >> This patch includes below nodes, >> >> 1) Table node *-- Initial patch by Murtuza, >> constraints compatibility by Harshal. * >> 2) Column node *-- by Murtuza. * >> 3) Index node *-- by Murtuza. * >> 4) Trigger node *-- by Murtuzz. * >> 6) Rules node >> *-- by Surinder.* >> 7) Constraints nodes: >> i] Index Constraint *-- Initial patch by Harshal, >> Integration with table node by **Murtuza.* >> ii] Foreign key *-- Initial patch and >> Integration with table node by Harshal**.* >> iii] Check constraint *-- Initial patch and >> Integration with table node by Harshal**.* >> iv] Exclusion constraint *-- Initial patch and >> Integration with table node by Harshal**.* >> >> Please apply patches in following order as all of them depends on each >> other. >> >> >> >> *Order: Table Node ----> Index constraint ---> remaining patches in any >> order.* >> >> >> >> >> >> >> -- >> *Harshal Dhumal* >> *Software Engineer * >> >> >> >> EenterpriseDB >> >> On Mon, Apr 18, 2016 at 7:04 PM, Murtuza Zabuawala < >> murtuza.zabuawala@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find initial patch for tables node. >>> >>> This patch includes below nodes, >>> >>> 1) Tables node >>> 2) Columns node >>> 3) Index node >>> 4) Trigger node >>> 5) Constraints node (Primary key & Unique constraints only) *-- >>> From: Harshal* >>> 6) Roles node >>> *-- From: Surinder* >>> >>> This patch also includes "VacuumSettings control" required by table node. >>> >>> Please apply Fieldset Control UI patch sent earlier. >>> >>> >>> *Please note that constraint node is still partial, It has Primary Key & >>> Unique constraint working & integrated in tables node.* >>> >>> 1) I have used initial patch of index constraints node from Harshal & >>> further extend it it to work with table node. >>> [ Harshal will integrate rest of constraints in tables node, he is >>> working on it.] >>> >>> 2) I have also used initial patches of rules node and VacuumSettings >>> control from Surinder & further extend them it to work with table node. >>> >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> >>> -- >>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>> To make changes to your subscription: >>> http://www.postgresql.org/mailpref/pgadmin-hackers >>> >>> >> >> >> -- >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >> To make changes to your subscription: >> http://www.postgresql.org/mailpref/pgadmin-hackers >> >> > --001a11c15388735ad905324135cc Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

Please find below responses.=C2=A0<= br>
=

Please find the review comments so far:
<= br>1. On the Table=20 Collection node, The fields in the grid should be Name, Owner and=20 Comments. OID is not required. Please follow same for the other Nodes=20 like Index, Constraints etc.

Fixed=C2=A0
= 2. While Updating the Table, Add any column as well as Inherits any table, = then the check the SQL tab.
ALTER TABLE SQL should be come in the = new line

Current SQL Ta= b:

ALTER TABLE pem.agent_heartbeat
=C2=A0=C2=A0=C2=A0 INHERIT= pem.alert_history;ALTER TABLE pem.agent_heartbeat
=C2=A0=C2=A0=C2=A0 AD= D COLUMN test bigint;
Fixed
=C2=A0
3. While Creating/updating table, if the Schema is other than selected=20 one, then after saving the table, it is not falling under the same=20 schema. And also in update mode it gives an error.
TODO
=C2=A0
4. Unlogged setting does not honor the change of value.
Not reproducible.
=C2=A0
5. Please Check SQL tab for all the Nodes as most of them having problem=20 of No blank lines/More than one Blank Lines/Blank Lines at the end etc.
=
Fixed
=C2=A0
6. Creating Table with=C2=A0 au= to_vacuum and updating only one field then wrong SQL is generated.
WITH (
=C2=A0=C2=A0=C2=A0 OIDS =3D TRUE= ,
=C2=A0=C2=A0=C2=A0 FILLFACTOR =3D 12,
=C2=A0=C2=A0=C2=A0 aut= ovacuum_enabled =3D TRUE,
,
=C2=A0=C2=A0=C2=A0 autovacuum_vacuum_cost= _delay =3D 21
)

Fixed.<= /div>
=C2=A0
7. Same as toast
WITH (
=C2=A0=C2= =A0=C2=A0 OIDS =3D TRUE,
=C2=A0=C2=A0=C2=A0 FILLFACTOR =3D 12,=C2=A0=C2=A0=C2=A0 autovacuum_enabled =3D TRUE,
=C2=A0=C2=A0=C2=A0 toas= t.autovacuum_enabled =3D TRUE,
=C2=A0=C2=A0=C2=A0 autovacuum_analyze_sca= le_factor =3D 1,
=C2=A0=C2=A0=C2=A0 autovacuum_analyze_threshold =3D 2,<= br>=C2=A0=C2=A0=C2=A0 autovacuum_freeze_max_age =3D 2,
,
=C2=A0=C2=A0= =C2=A0 toast.autovacuum_vacuum_cost_limit =3D 2,
=C2=A0=C2=A0=C2=A0 toas= t.autovacuum_freeze_min_age =3D 4
)
Fixed
=C2=A0
=
8. Sometimes while creating table and checking sql table, be= low error is coming

=C2=A0 File=20 "/home/khushboo/Projects/pgadmin4/web/pgadmin/browser/server_groups/se= rvers/databases/schemas/tables/__init__.py", line 1060, in properties
=C2=A0=C2=A0=C2=A0 data =3D res['rows'= ][0]
IndexError: list index out of range
TODO. (Need exact steps to reproduce.)
=C2=A0

9. Please check all the Grid table columns. It should not be expanded=20 while editing directly into the grid. For ref: Check constraint grid
TODO

=C2=A0
=

10. Constraint N= odes are not covered yet due to validation issue on which Harshal is workin= g.
Done.
=C2=A0

11. While creating the table if auto-vacuume has been enabled by user, then it should stay enabled in Edit mode also. Currently it is not.
Fixed
=C2=A0
=C2=A0
12 .If I just enable 'custom = auto activated' and don't update anything then SQL tab is generatin= g below SQL which is wrong.

ALTER TABLE pem.khushboo1 SET (

)= ;
Fixed
=C2=A0

13. IF I Change privileges from p= em_agent to agent1 then the SQL i like below, which is not corrent

R= EVOKE ALL ON TABLE pem.khushboo1 FROM agent1;
GRANT SELECT ON TABLE pem.= khushboo1 TO agent1;
=C2=A0
Not reproducible Or please provide steps to reproduce.

=
=C2=A0
14. In c= heck constraint, change "Don't Validate" to Validated? Please= refer Domain Constraint for the same.
Fixed.
=C2=A0

15. SQL for the Column is coming as below, which is not correct.
<html><head></head><body>-- Column: col3 -- ALTER TABLE pem.khushboo1 DROP COLUMN col3; ALTER TABLE pem.khushboo1 ADD COLUMN col3 integer NOT=20 NULL;</body></html>

=
Not reproducible Or please provide steps to reproduce.
=

=C2=A0

16. While updating table columns from column node. Below SQL generati= ng an error.

ALTER TABLE pem.khushboo1
=C2=A0=C2=A0=C2=A0 ALTER C= OLUMN col2 numeric(1, 1);
Fixed
=C2=A0

17. After= deleting any column, the properties of the another column of the same tabl= e doesn't show up. Gives below error.

TypeError: self.canDrop.ap= ply is not a function
=C2=A0=C2=A0
...lf.canDrop) ? function() { ret= urn self.canDrop.apply(self, arguments); } : fals
=C2=A0
This issue is already raised.=C2=A0


18.=C2=A0 T= able Node : Exclusion constraint : Grid validates DESC instead of=C2=A0 ope= rator.

Not reproducib= le.
=C2=A0
<= br>
19. Please check validation of the Exclusion control, as some JS error is=20 coming and due to this, we can not close the dialogue.

<= div style=3D"margin-left:40px">=C2=A0=C2=A0=C2=A0 The select2('destroy&= #39;) method was called on an element that is not using Select2.
=C2=A0= =C2=A0=C2=A0

...this.$dropdown.on(d.join(" "),function(a)= {a.stopPropagation()})},a}),b.define("s...

select2....min.js (l= ine 3)
TypeError: c is undefined

This is already = fixed.
=C2=A0

20. While updating the comments fie= ld of the Index node, it throws below error:

TypeError: obj is null
=C2=A0=C2=A0=C2=A0
} else if ((obj.s= essChanged && obj.sessChanged()) || isNew) {
<= /div>

This is already fixed.
=
=C2=A0
21. Job Trigger : Validation m= issing, so user can't get an idea what is missing while checking the SQ= L tab

Fixed.
=C2=A0
22. For the reverse Engineering SQL tab, the constraints should be start=20 with Schema.Table.Constraint. Please follow same path for all the nodes.

I cross checked with pg= admin3. Reverse Engineering SQL looks good to me. Please let me know what i= s missing?
=C2=A0
23. Indexes : Comments can not be updated. Please check the attached scre= en-shot for reference.
Fixed
=C2=A0
24. Spelling mis= take of 'Definition' in Indexes.
=

Fixed=C2=A0

NOTE: I haven't check Constraints properly due to validation issue. Also I= =20 have checked only functional flow, I will review the code today evening=20 or tomorrow.


Thanks,
Khushbo= o



On Wed, Apr 27, 2016 at 2:52 PM, Harshal Dhu= mal <harshal.dhumal@enterprisedb.com> wrote:
Hi= ,

PFA attached patches for table node and all table child node= s.

This patch includes below nodes,

<= /span>
1) Table node=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -- Initial patch by M= urtuza, constraints compatibility by Harshal. =
2) Column node=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 --=C2=A0by Murtuza. <= /span>
3) Index node=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 --=C2=A0by Murt= uza.
4) Trigger node=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -- by = Murtuzz.
6) Rules node =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0=C2=A0 -- by Surinder.
7) Constrain= ts nodes:
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 i]=C2=A0 Index Constraint= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 -- Initial patch by Harshal, Integration wit= h table node by Murtuza.
= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ii] Foreign key=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -- Initial patch and Integration wit= h table node by Harshal.
<= div>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 iii] Check constraint=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = -- Initial patch and Integration with table node by Harshal.
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 iv]= Exclusion constraint=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 -- Initial patch and Integration with table node by Harshal= .

Pleas= e apply patches in following order as all of them depends on each other.
Order:=C2=A0 Table Node ----> Index constraint --->= ; remaining patches in any order.


=C2=A0




--=C2=A0
Harshal Dhumal
Software Engineer= =C2=A0



<= /div>

On Mon, Apr 18, 2016 at 7:04 PM, M= urtuza Zabuawala <murtuza.zabuawala@enterprisedb.com&= gt; wrote:
Hi,

Please find initial patch for tables node.

This patch includes below nodes,

1) Tables node
2) Columns node
3) Index node
4) Trigger node
5) Constraints node (Primary key & Unique co= nstraints only) =C2=A0 =C2=A0-- From: Harshal
6) Roles node =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0-- From: Surinder

T= his patch also includes "VacuumSettings control" required by tabl= e node.

Please apply Fieldset Control UI patch sen= t earlier.


Please note that constraint node is still partial, It has Primary Key = & Unique constraint working & integrated in tables node.
<= div>
1) =C2=A0I have used ini= tial patch of index constraints=C2=A0node from Harshal & further extend= it it to work with table node.
[ Harshal will integrate rest of constraints i= n tables node, he is working on it.]

2) I have also used initial patches of rule= s node and VacuumSettings control from Surinder & further extend them i= t to work with table node.


--
Regards= ,
Murtuza Zabuawala
= EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise Post= greSQL Company


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=




--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=



--001a11c15388735ad905324135cc--