Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bIJsF-00083z-OL for pgadmin-hackers@arkaria.postgresql.org; Wed, 29 Jun 2016 18:06:07 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bIJsF-0004S9-As for pgadmin-hackers@arkaria.postgresql.org; Wed, 29 Jun 2016 18:06:07 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bIJsE-0004P6-86 for pgadmin-hackers@postgresql.org; Wed, 29 Jun 2016 18:06:06 +0000 Received: from mail-ob0-x235.google.com ([2607:f8b0:4003:c01::235]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bIJs7-00048D-12 for pgadmin-hackers@postgresql.org; Wed, 29 Jun 2016 18:06:05 +0000 Received: by mail-ob0-x235.google.com with SMTP id mu6so37059523obc.3 for ; Wed, 29 Jun 2016 11:05:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=8eGoJKmgyb3OQiKVPLFw4BjHc3VfeGGAi5VAd1ZLKmw=; b=Kff+VJf0xu+L4hE9UwAJsdGiy4OXaGhaGpdZbhYnPpACB6E7BVQRgzfgq4oHKFykc9 HjgJNPVHqbSV3rang3ID3vSc3EKPSlrI1K23ABbtyrUzx35IAhstd2z/vZVP+tsDKkJX 3GuZetruwYA5ZT1cZvmvhy0sfbekjc52W4yp2/zY4n6dHdYVqOYfMkMb5zVjGCdtUCO3 +gZaNGRlSWdjT6KBvpgxsSXmv/bSEvX0fU5RWh5SNWQLwzO3BwUIvL/2nPDppxeIJGJP v7FkeFzfcLALKrmZ+FuzBZYThmkIYCrsv9+loUvbk1Ygzglq7X+nYWwSR6odyJ12r6mK MwGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=8eGoJKmgyb3OQiKVPLFw4BjHc3VfeGGAi5VAd1ZLKmw=; b=Ha0+LEIXZ9zfO8voQn3qPHr5MlTqVl1EXHPjG9NJQkW9ombDl+q6BzFB1ojfKojgB3 RftOpkkstMWqCeoNzPNf6Uy/b5DR00tVDLp5ewMyexIer9ioTbK0luZlEDoCLv9yaaeR 6GORtpeIdAShKrMVbSpWFkLzzRuHJg1rYB7S3XzKnNq706iw3pb0uYH4nJhCzhYcCg6/ 7dLB+ULety9/WEZJmORxyBH4dlOU3c1BPAaZA43B18nZV2SLzBQE0myL4VHrEXT0Gkcf AuBFEnZ1QsiTGRQRHc72RZSv1t6NOoDQAVO0NxGKRN4TIzrnjmwW415Qfw+g3Zfe0mZ3 8ysQ== X-Gm-Message-State: ALyK8tIlrrV0h8ttsYgrL1KnWRWzS7dCy3GQipCzBmLycaEm0bHySgzUOvnak2xeMQ+Xj++ih0CJHeN5OLHNpBxg X-Received: by 10.202.168.203 with SMTP id r194mr5972267oie.1.1467223558094; Wed, 29 Jun 2016 11:05:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.5.100 with HTTP; Wed, 29 Jun 2016 11:05:57 -0700 (PDT) In-Reply-To: References: <5767F4E1.6020308@kingston.net> From: Harshal Dhumal Date: Wed, 29 Jun 2016 23:35:57 +0530 Message-ID: Subject: Re: Fix for issue RM1336 [pgadmin4] To: pgadmin-hackers Content-Type: multipart/mixed; boundary=001a113cd77cfcffa005366e9a4a X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113cd77cfcffa005366e9a4a Content-Type: multipart/alternative; boundary=001a113cd77cfcff9b05366e9a48 --001a113cd77cfcff9b05366e9a48 Content-Type: text/plain; charset=UTF-8 Hi, PFA upadated patch for RM1336 Issue fixed: Query tool shortcuts weren't working on mac runtime. Also changed shortcut key for "Explain analyze" from Ctrl+Shift+A ---> Alt+Shift+N as Ctrl+Shift+A was conflicting with shortcut to show "about" dialog in runtime. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jun 20, 2016 at 7:30 PM, Dave Page wrote: > On Mon, Jun 20, 2016 at 2:51 PM, Colin Beckingham > wrote: > > > > On 20/06/16 09:33, Dave Page wrote: > >> > >> It's not that it's necessarily hard, it's that there are only 24 hours > in > >> the day to get things done. We've got a long list of improvements to > make - > >> some immediate (i.e. in time for betaX - 2 being today in fact), others > for > >> GA and others for future releases. Meanwhile, much as I'd like to, I > cannot > >> keep 10 people assigned to pgAdmin indefinitely. I do need to get them > >> working on other projects, for which there are also deadlines. > > > > Since pgadmin4 is at the top of the stack browser - window environment - > OS > > - kernel, all of which have their call on some specific set of > shortcuts, a > > couple of thoughts: > > 1. are there other applications similar to pgadmin which are in the same > > position where they too are looking for shortcuts? In which case is > there a > > possibility of cross-fertilization of ideas? > > The only app I've found so far like that is Gmail, but 95% of it's > shortcuts are single keys that only work when you're not already > focussed in an editable field. In pgAdmin, that doesn't help much in > cases like this, when you're likely editing a query. > > > 2. in the world of software shortcuts, the needs of dependent > applications > > such as pgadmin might not have been foreseen, but is there in the > hierarchy > > a moral obligation to keep a certain subset of combinations free? At the > > moment it seems like a free for all... > > Yeah, you'd think there should be some moral obligation, but you're > right - it is a free for all. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > --001a113cd77cfcff9b05366e9a48 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

PFA upadated patch for RM1= 336

Issue fixed: Query tool shortcuts weren't working on m= ac runtime. Also changed shortcut key for "Explain analyze" from = Ctrl+Shift+A ---> Alt+Shift+N as Ctrl+Shift+A was conflicting with short= cut to show "about" dialog in runtime.



--=C2=A0
Harshal Dhumal
Software Engineer

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, Jun 20, 2016 at 7:30 PM, Dave Page <= span dir=3D"ltr"><dpage@pgadmin.org> wrote:
= On Mon, Jun 20, 2016 at 2:51 PM, Colin Beckingham <colbec@kingston.net> wrote:
>
> On 20/06/16 09:33, Dave Page wrote:
>>
>> It's not that it's necessarily hard, it's that there a= re only 24 hours in
>> the day to get things done. We've got a long list of improveme= nts to make -
>> some immediate (i.e. in time for betaX - 2 being today in fact), o= thers for
>> GA and others for future releases. Meanwhile, much as I'd like= to, I cannot
>> keep 10 people assigned to pgAdmin indefinitely. I do need to get = them
>> working on other projects, for which there are also deadlines.
>
> Since pgadmin4 is at the top of the stack browser - window environment= - OS
> - kernel, all of which have their call on some specific set of shortcu= ts, a
> couple of thoughts:
> 1. are there other applications similar to pgadmin which are in the sa= me
> position where they too are looking for shortcuts? In which case is th= ere a
> possibility of cross-fertilization of ideas?

The only app I've found so far like that is Gmail, but 95% of it= 's
shortcuts are single keys that only work when you're not already
focussed in an editable field. In pgAdmin, that doesn't help much in
cases like this, when you're likely editing a query.

> 2. in the world of software shortcuts, the needs of dependent applicat= ions
> such as pgadmin might not have been foreseen, but is there in the hier= archy
> a moral obligation to keep a certain subset of combinations free? At t= he
> moment it seems like a free for all...

Yeah, you'd think there should be some moral obligation, but you= 're
right - it is a free for all.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=

--001a113cd77cfcff9b05366e9a48-- --001a113cd77cfcffa005366e9a4a Content-Type: text/x-patch; charset=US-ASCII; name="RM1336_V2.patch" Content-Disposition: attachment; filename="RM1336_V2.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iq19348j0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRvci90ZW1w bGF0ZXMvc3FsZWRpdG9yL2pzL3NxbGVkaXRvci5qcyBiL3dlYi9wZ2FkbWlu L3Rvb2xzL3NxbGVkaXRvci90ZW1wbGF0ZXMvc3FsZWRpdG9yL2pzL3NxbGVk aXRvci5qcwppbmRleCA5MjU3OWYxLi40MDAxMDY2IDEwMDY0NAotLS0gYS93 ZWIvcGdhZG1pbi90b29scy9zcWxlZGl0b3IvdGVtcGxhdGVzL3NxbGVkaXRv ci9qcy9zcWxlZGl0b3IuanMKKysrIGIvd2ViL3BnYWRtaW4vdG9vbHMvc3Fs ZWRpdG9yL3RlbXBsYXRlcy9zcWxlZGl0b3IvanMvc3FsZWRpdG9yLmpzCkBA IC0xMDE1LDE5ICsxMDE1LDIzIEBAIGRlZmluZSgKIAogICAgICAgLy8gQ2Fs bGJhY2sgZm9yIGtleWJvYXJkIGV2ZW50CiAgICAgICBrZXlBY3Rpb246IGZ1 bmN0aW9uKGV2KSB7Ci0gICAgICAgIGlmKGV2LmN0cmxLZXkgJiYgZXYuc2hp ZnRLZXkpIHsKLSAgICAgICAgICBpZihldi5rZXlDb2RlID09IDY5KSB7Ci0g ICAgICAgICAgICAvLyBjaGFyIGUvRQotICAgICAgICAgICAgLy8gRXhlY3V0 ZSBxdWVyeS4KLSAgICAgICAgICAgIHRoaXMub25fZmxhc2goZXYpOwotICAg ICAgICAgIH0gZWxzZSBpZihldi5rZXlDb2RlID09IDg4KXsKLSAgICAgICAg ICAgIC8vIGNoYXIgeC9YCi0gICAgICAgICAgICAvLyBFeHBsYWluIHF1ZXJ5 LgotICAgICAgICAgICAgdGhpcy5vbl9leHBsYWluKGV2KTsKLSAgICAgICAg ICB9IGVsc2UgaWYoZXYua2V5Q29kZSA9PSA2NSkgewotICAgICAgICAgICAg Ly8gY2hhciBhL0EKLSAgICAgICAgICAgIC8vIEV4cGxhaW4gYW5hbHl6ZSBx dWVyeS4KLSAgICAgICAgICAgIHRoaXMub25fZXhwbGFpbl9hbmFseXplKGV2 KTsKKyAgICAgICAgaWYoZXYuc2hpZnRLZXkpIHsKKyAgICAgICAgICBpZihl di5jdHJsS2V5KSB7CisgICAgICAgICAgICBpZihldi5rZXlDb2RlID09IDY5 KSB7CisgICAgICAgICAgICAgIC8vIGNoYXIgZS9FCisgICAgICAgICAgICAg IC8vIEV4ZWN1dGUgcXVlcnkuCisgICAgICAgICAgICAgIHRoaXMub25fZmxh c2goZXYpOworICAgICAgICAgICAgfSBlbHNlIGlmKGV2LmtleUNvZGUgPT0g ODgpIHsKKyAgICAgICAgICAgICAgLy8gY2hhciB4L1gKKyAgICAgICAgICAg ICAgLy8gRXhwbGFpbiBxdWVyeS4KKyAgICAgICAgICAgICAgdGhpcy5vbl9l eHBsYWluKGV2KTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgICB9IGVsc2Ug aWYoZXYuYWx0S2V5KSB7CisgICAgICAgICAgICBpZihldi5rZXlDb2RlID09 IDc4KSB7CisgICAgICAgICAgICAgIC8vIGNoYXIgbi9OCisgICAgICAgICAg ICAgIC8vIEV4cGxhaW4gYW5hbHl6ZSBxdWVyeS4KKyAgICAgICAgICAgICAg dGhpcy5vbl9leHBsYWluX2FuYWx5emUoZXYpOworICAgICAgICAgICAgfQog ICAgICAgICAgIH0KICAgICAgICAgfQogICAgICAgfQo= --001a113cd77cfcffa005366e9a4a Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a113cd77cfcffa005366e9a4a--