Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1az2zm-0007ad-6b for pgadmin-hackers@arkaria.postgresql.org; Sat, 07 May 2016 14:14:14 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1az2zl-0002I1-Kd for pgadmin-hackers@arkaria.postgresql.org; Sat, 07 May 2016 14:14:13 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1az2zY-00023w-Dy for pgadmin-hackers@postgresql.org; Sat, 07 May 2016 14:14:00 +0000 Received: from mail-oi0-x22f.google.com ([2607:f8b0:4003:c06::22f]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1az2zR-0007tG-Oi for pgadmin-hackers@postgresql.org; Sat, 07 May 2016 14:13:59 +0000 Received: by mail-oi0-x22f.google.com with SMTP id k142so168493489oib.1 for ; Sat, 07 May 2016 07:13:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=pJKxiUc3CmPTb77xUYA9nj8kGKo0FQrqb4TbENtjrSY=; b=QpKZx0FdwfSw3ymseU7tC00HOsQal2EWR6MaPF6ao2AiaTG2cdMFhUYBCTSysLHFac FHJxkZK7jlN9M0kifUhtRzHzDg7oeFoq1IOqsPaZVD09fdTaEzvfYj7N3Ob1U4IPRuUh 7zlTWZtjuZQ+N48t2Zd4icmImOVTc/AvQE2MB0SWBUU7G5gCfiLXgN9XYwS4fDhg7Yj2 fA2xZ7k6OYftTbNNPnAp8/+cQ7srOXfLDrVVPfIj0VaLL9qHvS8+J92RBePO4TzIZY+F W5K1tmL38AkVkIM+ySm+wCvkiKRhsPJUrLd4yja4cTOlLfl5EIhm2EfA1l67FB6I67Wj ufMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=pJKxiUc3CmPTb77xUYA9nj8kGKo0FQrqb4TbENtjrSY=; b=LbiIeTjkesMPFU4HdYucMvEklo4w/P3yQPpFfnocnaYh/eqUhv8puhQjYP8JCmMEgl Ifu0/GVvu1sWVm/72acTkhcQDK97eQzcuutOodLkmcC046eLeS6HKKa5UVLfo2BsEc7P kamtilrWLErEpA2NPwCWRmYZodLAxlxfC/sq7hgcoqtRfhmZGgCaMZYKpLlplq/jrsAm gsQCM1bl8RQG6ql3SjXUFMItGIW0CKieiqPVhasXY3VI5ByCEk6Ri6VnqZCQIbKvG8/F oSVEhoR3PIC1EByxvJRvyD5Tx55cJANTHrSK9iAvB30Qqq97Hf2JPdqh0aEiq2gS1jwB 1RLg== X-Gm-Message-State: AOPr4FUQgDlteHTP1bZYH26YtbFI0iM/cCNBdJQTFIbV+2yW7Wujtr1u5LSY7rvNB6CpbgYu49x9Z0gbVBPdo/S1 MIME-Version: 1.0 X-Received: by 10.157.20.217 with SMTP id r25mr12738626otr.72.1462630433209; Sat, 07 May 2016 07:13:53 -0700 (PDT) Received: by 10.157.54.226 with HTTP; Sat, 7 May 2016 07:13:53 -0700 (PDT) In-Reply-To: References: Date: Sat, 7 May 2016 19:43:53 +0530 Message-ID: Subject: Re: [PATCH] Tables node (pgAdmin4) From: Harshal Dhumal To: Thom Brown Cc: pgadmin-hackers , Murtuza Zabuawala , Surinder Kumar Content-Type: multipart/alternative; boundary=001a113e2a7668d2d30532412fdd X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113e2a7668d2d30532412fdd Content-Type: text/plain; charset=UTF-8 Hi, i have fixed all of below mentioned issues. > A couple more: > > > If I go to create a new table, give it a name, select a table to > inherit from, and then do nothing else, I get an error: > > ERROR: syntax error at or near "INHERITS" > LINE 2: INHERITS (test) > ^ > > This is because no column list was provided, and in this case, an > empty one would be needed. So instead of: > > CREATE TABLE public.test2 > ( > ) > INHERITS (test) > WITH ( > OIDS = FALSE > ) > TABLESPACE pg_default; > > It should be: > > CREATE TABLE public.test2 > INHERITS (test) > WITH ( > OIDS = FALSE > ) > TABLESPACE pg_default; > > > If I go to create another new table, give it a name, and then in the > Like section on the Advance tab, I select a table, and enable each of > the With * options, the following SQL is produced: > > CREATE TABLE public.test2 > LIKE public.test > INCLUDING DEFAULTS > INCLUDING CONSTRAINTS > INCLUDING INDEXES > INCLUDING STORAGE > INCLUDING COMMENTSWITH ( > OIDS = FALSE > ) > TABLESPACE pg_default; > > The LIKE statement should appear in the column list section, so should > be surrounded in parentheses. Also, the WITH statement here is not on > a new line. > > So this should be: > > CREATE TABLE public.test2 > ( > LIKE public.test > INCLUDING DEFAULTS > INCLUDING CONSTRAINTS > INCLUDING INDEXES > INCLUDING STORAGE > INCLUDING COMMENTS > ) > WITH ( > OIDS = FALSE > ) > TABLESPACE pg_default; > > > > > Thom > --001a113e2a7668d2d30532412fdd Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

i have fixed all of below mentioned = issues.


A couple more:
=C2=A0

If I go to create a new table, give it a name, select a table to
inherit from, and then do nothing else, I get an error:

ERROR: syntax error at or near "INHERITS"
LINE 2: INHERITS (test)
^

This is because no column list was provided, and in this case, an
empty one would be needed.=C2=A0 So instead of:

CREATE TABLE public.test2
(
)
=C2=A0 =C2=A0 INHERITS (test)
WITH (
=C2=A0 =C2=A0 OIDS =3D FALSE
)
TABLESPACE pg_default;

It should be:

CREATE TABLE public.test2
=C2=A0 =C2=A0 INHERITS (test)
WITH (
=C2=A0 =C2=A0 OIDS =3D FALSE
)
TABLESPACE pg_default;


If I go to create another new table, give it a name, and then in the
Like section on the Advance tab, I select a table, and enable each of
the With * options, the following SQL is produced:

CREATE TABLE public.test2
=C2=A0 =C2=A0 LIKE public.test
=C2=A0 =C2=A0 =C2=A0 =C2=A0 INCLUDING DEFAULTS
=C2=A0 =C2=A0 =C2=A0 =C2=A0 INCLUDING CONSTRAINTS
=C2=A0 =C2=A0 =C2=A0 =C2=A0 INCLUDING INDEXES
=C2=A0 =C2=A0 =C2=A0 =C2=A0 INCLUDING STORAGE
=C2=A0 =C2=A0 =C2=A0 =C2=A0 INCLUDING COMMENTSWITH (
=C2=A0 =C2=A0 OIDS =3D FALSE
)
TABLESPACE pg_default;

The LIKE statement should appear in the column list section, so should
be surrounded in parentheses.=C2=A0 Also, the WITH statement here is not on=
a new line.

So this should be:

CREATE TABLE public.test2
(
=C2=A0 =C2=A0 LIKE public.test
=C2=A0 =C2=A0 =C2=A0 =C2=A0 INCLUDING DEFAULTS
=C2=A0 =C2=A0 =C2=A0 =C2=A0 INCLUDING CONSTRAINTS
=C2=A0 =C2=A0 =C2=A0 =C2=A0 INCLUDING INDEXES
=C2=A0 =C2=A0 =C2=A0 =C2=A0 INCLUDING STORAGE
=C2=A0 =C2=A0 =C2=A0 =C2=A0 INCLUDING COMMENTS
)
WITH (
=C2=A0 =C2=A0 OIDS =3D FALSE
)
TABLESPACE pg_default;


=C2=A0

Thom

--001a113e2a7668d2d30532412fdd--