Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDUpv-0005TK-Af for pgadmin-hackers@arkaria.postgresql.org; Thu, 16 Jun 2016 10:47:47 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bDUpu-0003Qe-Qf for pgadmin-hackers@arkaria.postgresql.org; Thu, 16 Jun 2016 10:47:46 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bDUpu-0003QX-7b for pgadmin-hackers@postgresql.org; Thu, 16 Jun 2016 10:47:46 +0000 Received: from mail-oi0-x22c.google.com ([2607:f8b0:4003:c06::22c]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bDUpp-0004rE-VA for pgadmin-hackers@postgresql.org; Thu, 16 Jun 2016 10:47:45 +0000 Received: by mail-oi0-x22c.google.com with SMTP id p204so62538497oih.3 for ; Thu, 16 Jun 2016 03:47:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=bh0QzCF/xf1Pm53OY0SgH1/h1pwpmc6pEfKJsIj0HtE=; b=TLxiY1Sw1kC+Rw9fA3QOBno/Z3GUNaWXxPhc0R71GlgYUyA2kbyYSfLz6GBuMlfNAf NDLmnl1FI6gSbZ6gR6kZiZp0ikG3Qd/DO75onohAenG3Qta0Nx/84/MR9A9+GECmymMD m/VxVnHVBK7fvxERvnquqEGa7spPSiJTd66O4sfWr87xsl/TGvtVQTiX1yzA78OtkBy1 tq+u9s+mcCIOJYFGcOG/wpjjFz+c+/IU7m3XQkD//gWWbK7xo/ycpuVdi5RBeF7B/a0u 5zKFAoLZk7R+Qb7vHVES564v1OHKlIgqUAyh+U3hkB9M99O8/2RQCZYZG7R1+F9PNJBE OzhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=bh0QzCF/xf1Pm53OY0SgH1/h1pwpmc6pEfKJsIj0HtE=; b=TeQAHNm5HSE/V+up9wK2582aUqdoPZjVu/O4o1syGA03S6VD+47tSEXRYnNpJGoquQ MkNi3SE9fEzRdhFUkjeyuTzqTo4q5OWjy/Gb6m6IHjgQs2gyCz08mgU/FygBGj+zrjgD WXPXM9ns/f9bo2WzAyQAjkTSR74xzzluBEAGN8FqDrTjODaFKf29FBD8icNQcgbd95do YIYCmTsU25u4eIIOQh64/f+xvKd3TLEOPcdCuX+I/FfD7D81/pGSkRC3Scd12R1P0ssC fo/hq/2K+UQpJ3R13BDOyy0Ud0JLUnEv0HYYY+VGOFASJGzpvDrHW84RtDJU+mps9QMO 2Egw== X-Gm-Message-State: ALyK8tJAB2qXjAMQjwSsM/joJ5S2yAZWNDpLbaefzk66TYkuEvyPzJ1n8QsbVdW8f6n7x1eKDaGDA3sa5B51uw67 MIME-Version: 1.0 X-Received: by 10.202.214.216 with SMTP id n207mr1706885oig.1.1466074059958; Thu, 16 Jun 2016 03:47:39 -0700 (PDT) Received: by 10.157.20.182 with HTTP; Thu, 16 Jun 2016 03:47:39 -0700 (PDT) In-Reply-To: References: Date: Thu, 16 Jun 2016 16:17:39 +0530 Message-ID: Subject: Re: Fix for issue RM1336 [pgadmin4] From: Harshal Dhumal To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a113b1b368f04c1053562f7d6 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113b1b368f04c1053562f7d6 Content-Type: text/plain; charset=UTF-8 Hi Dave, Function keys won't work properly with browser as they already have predefined bindings. e.g. F5 for refresh (standard) F7 for Caret Browsing in firefox -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 16, 2016 at 4:10 PM, Harshal Dhumal < harshal.dhumal@enterprisedb.com> wrote: > Hi Dave, > > Ok, I'll change shortcut keys > > New shortcuts would be: > > Execute --> F5 > Explain --> F7 > Explain analyze --> Shift+F7 > > > > -- > *Harshal Dhumal* > *Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Thu, Jun 16, 2016 at 4:03 PM, Dave Page wrote: > >> Hi, >> >> Can we not make them compatible with pgAdmin 3? Ctrl + Shift + E is >> significantly less convenient than F5. >> >> On Thu, Jun 16, 2016 at 11:28 AM, Harshal Dhumal >> wrote: >> > Hi, >> > >> > PAF patch for issue RM1336 >> > >> > Changes: Added keyboard shortcuts (static/non configurable) to some >> query >> > tool operations. >> > >> > Execute --> Ctrl + Shift + E >> > Explain --> Ctrl + Shift + X >> > Explain analyze --> Ctrl + Shift + A >> > >> > Note: Keyboard shortcuts do not work if focus is set on any disabled >> button >> > inside query tool or out side the query tool. >> > >> > >> > -- >> > Harshal Dhumal >> > Software Engineer >> > >> > EnterpriseDB India: http://www.enterprisedb.com >> > The Enterprise PostgreSQL Company >> > >> > >> > -- >> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >> > To make changes to your subscription: >> > http://www.postgresql.org/mailpref/pgadmin-hackers >> > >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > --001a113b1b368f04c1053562f7d6 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Dave,

Function keys won't work p= roperly with browser as they already have predefined bindings.
e.g.

F5 for refresh (standard)
<= div>F7 for Caret Browsing in firefox=C2=A0


=
--=C2=A0
Harshal Dhumal
Softwar= e Engineer

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Thu, Jun 16, 2016 at 4:10 PM, Harshal Dhu= mal <harshal.dhumal@enterprisedb.com> wrote:
Hi Dave,

Ok, I'l= l change shortcut keys

New shortcuts would be:

Execute=C2=A0 -->= =C2=A0=C2=A0 F5
Explain=C2=A0 -->=C2=A0=C2=A0=C2=A0 F7
Explain analyze=C2=A0 -->= ; Shift+F7



=
--= =C2=A0
Harshal Dhumal
Software Engineer

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
The Ente= rprise PostgreSQL Company

On Thu, Jun 16= , 2016 at 4:03 PM, Dave Page <dpage@pgadmin.org> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);pa= dding-left:1ex">Hi,

Can we not make them compatible with pgAdmin 3? Ctrl + Shift + E is
significantly less convenient than F5.

On Thu, Jun 16, 2016 at 11:28 AM, Harshal Dhumal
<ha= rshal.dhumal@enterprisedb.com> wrote:
> Hi,
>
> PAF patch for issue RM1336
>
> Changes: Added keyboard shortcuts (static/non configurable) to some qu= ery
> tool operations.
>
> Execute=C2=A0 -->=C2=A0 =C2=A0Ctrl + Shift + E
> Explain=C2=A0 -->=C2=A0 =C2=A0 Ctrl + Shift + X
> Explain analyze=C2=A0 -->=C2=A0 =C2=A0Ctrl + Shift + A
>
> Note: Keyboard shortcuts do not work if focus is set on any disabled b= utton
> inside query tool or out side the query tool.
>
>
> --
> Harshal Dhumal
> Software Engineer
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-ha= ckers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--001a113b1b368f04c1053562f7d6--