Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1alvXq-0008SS-Ck for pgadmin-hackers@arkaria.postgresql.org; Fri, 01 Apr 2016 09:39:10 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1alvXp-0004Lr-9x for pgadmin-hackers@arkaria.postgresql.org; Fri, 01 Apr 2016 09:39:09 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1alvXb-00047G-R0 for pgadmin-hackers@postgresql.org; Fri, 01 Apr 2016 09:38:55 +0000 Received: from mail-io0-x229.google.com ([2607:f8b0:4001:c06::229]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1alvXX-0006kR-Mm for pgadmin-hackers@postgresql.org; Fri, 01 Apr 2016 09:38:55 +0000 Received: by mail-io0-x229.google.com with SMTP id a129so137275023ioe.0 for ; Fri, 01 Apr 2016 02:38:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=tHb/mvYoJ/taB5f45TF22J6VI6ZcjWK1+ce7NiG3OjE=; b=WI7SdeWMTCb73yFo56vNAyP0nut0Jc2KP/c6IA+cZF37AXO0rVrMBWICFgebbLXewN zKBEpSkB78I0ijmgY0hMeK4Gbtj1Ruryjxiy3IH0XDLbz8TRh0o2PVHs6uRpUug7CaMM KE2CeJ/5OK4phmloLds/4W4BrtMPwVR51iOdSHaOQQ2gvgzAsXCNDr7kJNulj75QAMpu w7M6oixjn1bsZLEBzqORBISt/E9EY6gtt/slgB+65U/E85P+nD8ye3OvoILE/nwNN/Gt 1DVBqCFD64Xnh4Y1bpUMRBRUNfwBiCyr0G20RYiUY/Cyy/IcvnKyQKcUteCPxHxsNOm8 h4Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=tHb/mvYoJ/taB5f45TF22J6VI6ZcjWK1+ce7NiG3OjE=; b=fEWDTUdRLKTFYbfKr0QprzNI4/cocytT93+X8xMX/4+H2O1YOHPnRYP46hS3rzDuUy 0WfIuZETzEDRFA23yP0yBMgE14QCSIx1V19q8p/AK9eUQ1dXBvaza+Gh/xRyH9AFlJIZ oCBgYZoWincntuv4rDRDVBshu6HmLYDun3zRpLKZ6F1DHhRCIZvqHsxse2YMxa9VxJF0 hVE9b37H9p/FjIOx7T5Swivhb2dfyWZ+wDArddP6IwyHEAfCEbOCGvYN5BUem3YbRFrr jldutehDcH9AZmy5cOcHvUr3jrIi7o+RsYY3RTAuAf+CUOJwdMYwjyz5yLNe4PBhe+co svAA== X-Gm-Message-State: AD7BkJLIPD/Vt0TSw/DdU6f50a2R2QsdtTeO7QZnZytIzW3emH8MvpFrqYhva+ZzEpy+9Ljnc0MXO7LsNZBQBNj9 X-Received: by 10.107.41.210 with SMTP id p201mr1735148iop.106.1459503529562; Fri, 01 Apr 2016 02:38:49 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.39.5 with HTTP; Fri, 1 Apr 2016 02:38:30 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Fri, 1 Apr 2016 15:08:30 +0530 Message-ID: Subject: Re: Patch: Added select2cell editor for backgrid [pgAdmin4] To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a1141f3a26dd624052f6925ff X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1141f3a26dd624052f6925ff Content-Type: text/plain; charset=UTF-8 On Thu, Mar 31, 2016 at 12:27 PM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi, > > We have added Select2Cell Editor for backgrid, eariler as it was not > present & causing issue in rendering in subnode control. > Looks good to me, but - have some feedback. 1. Can you please mention - why do we need 'openOnEnter: false' in select2 options? 2. There is a difference between UI, when rendered from the editor, and from the Select2Cell. (I can see padding, when the Cell is rendered, but - not when editor is rendered.) Can you please fix this two? -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > --001a1141f3a26dd624052f6925ff Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On Thu, Mar 31, 2016 at 12:27 PM, Murtuza Zabuawala = <murtuza.zabuawala@enterprisedb.com> wrote:

= Hi,

We have added Select2Cell Editor for backgrid, earil= er as it was not present & causing issue in rendering in subnode contro= l.
Looks good to me, but - have some feedback.=
1. Can you please mention - why do we need 'openOnEnter: fal= se' in select2 options?
2. There is a difference between UI, = when rendered from the editor, and from the Select2Cell. (I can see padding= , when the Cell is rendered, but - not when editor is rendered.)
=
Can you please fix this two?

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:=C2=A0Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi



--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterpr= ise PostgreSQL Company


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=


--001a1141f3a26dd624052f6925ff--