public inbox for [email protected]
help / color / mirror / Atom feedFrom: Ashesh Vashi <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: Re: PATCH: RM#1735
Date: Sat, 24 Sep 2016 04:34:02 +0530
Message-ID: <CAG7mmow1dHq5TZfnOJhj21hE-KdFi2O2XYh=aJBn4KRHmfZ21g@mail.gmail.com> (raw)
In-Reply-To: <CAG7mmox6bkyzjZVRCdgP5dZCOMco5d_=j856sKaQikq4oTAizg@mail.gmail.com>
References: <CAG7mmox6bkyzjZVRCdgP5dZCOMco5d_=j856sKaQikq4oTAizg@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Hi Team,
On Sat, Sep 24, 2016 at 3:23 AM, Ashesh Vashi <[email protected]
> wrote:
> Hi Dave/Team,
>
> I've fixed the issue "No default schema when creating some schema objects".
>
> For package, allowing to change the schema at the create time only, as the
> logic required to change schema of an existing package required a lot of
> changes. And, I am reluctant to do it at this phase of the project.
>
I also find out that - when we refresh the schema node, it was returning an
array of node data instead of an individual node data.
Please find the fix for it as part # 2.
NOTE: First patch is still applicable.
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com/;
*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi;
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com;
>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.linkedin.com/in/asheshvashi;
>
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Attachments:
[application/octet-stream] RM1735_part2.patch (1.2K, 3-RM1735_part2.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/__init__.py b/web/pgadmin/browser/server_groups/servers/databases/schemas/__init__.py
index fd779c1..61db480 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/__init__.py
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/__init__.py
@@ -408,14 +408,26 @@ class SchemaView(PGChildNodeView):
if not status:
return internal_server_error(errormsg=rset)
+ icon = 'icon-{0}'.format(self.node_type)
+
if scid is not None:
if len(rset['rows']) == 0:
return gone(gettext("""
Could not find the schema in the database.
It may have been removed by another user.
"""))
-
- icon = 'icon-{0}'.format(self.node_type)
+ row = rset['rows'][0]
+ return make_json_response(
+ data=self.blueprint.generate_browser_node(
+ row['oid'],
+ did,
+ row['name'],
+ icon=icon,
+ can_create=row['can_create'],
+ has_usage=row['has_usage']
+ ),
+ status=200
+ )
for row in rset['rows']:
res.append(
view thread (4+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: PATCH: RM#1735
In-Reply-To: <CAG7mmow1dHq5TZfnOJhj21hE-KdFi2O2XYh=aJBn4KRHmfZ21g@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox