Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aifK6-0003ET-Ta for pgadmin-hackers@arkaria.postgresql.org; Wed, 23 Mar 2016 09:43:31 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1aifK6-0003kh-G0 for pgadmin-hackers@arkaria.postgresql.org; Wed, 23 Mar 2016 09:43:30 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1aifK5-0003ka-Eh for pgadmin-hackers@postgresql.org; Wed, 23 Mar 2016 09:43:29 +0000 Received: from mail-io0-x22a.google.com ([2607:f8b0:4001:c06::22a]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1aifK1-000427-79 for pgadmin-hackers@postgresql.org; Wed, 23 Mar 2016 09:43:28 +0000 Received: by mail-io0-x22a.google.com with SMTP id c63so28471079iof.0 for ; Wed, 23 Mar 2016 02:43:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=/aLI8wF33VXIx+TYBPEZKzkRa2c1BRYKRe+cqwVhSwM=; b=f2YkzIoYMrLgyp4ba3e9yNl7SWpOcs6CdTltofCJFWwQ7OPXz5SF2Kirqck+rZYKUh X5C+SJ84li46JRtVMh4eB6yiIPzpMsJESfrJFEbdGKJF6o5+038jhKa2B5HIvtqaD1xo o+lwK13bn6D9ytrpbdcXvCTxwkxXm3DgWGfu0Vg2An9qkN65sBNuxoimnMCkmvOw1YBb KAU38uLUD5JYvoiFUuraTrG2Uf62SO9F5vSKshcvBDTvx+taTPD3MpiFyKQxOXPu+CS9 JCLrrsFZXRiF3Sb6jv3Gzqh/Dw5ZvPATiKWyHpS2gBUB2XhuUyLZGY1mZBU9urpFRuZD 3k1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=/aLI8wF33VXIx+TYBPEZKzkRa2c1BRYKRe+cqwVhSwM=; b=kJULtzOFzIdymV2i1HZfCvhQiyyLgB0TkmB+g+8KVKmK/xwrAQtFXaF7E2l4bs8ADT 36EUMHcH2LuXKdG3sL+8n+3WMUOVhhLAOWLoU/lAidiVY4P7HxAvuUJ/yT0iHAvTDeu8 1pGmLzYdZJYSEJIrB2gClkCb3mnGfFYFtAlTn7s3gVuE7w8Qg4Ry1NOrZTXhLReEyCTl 5KugRWmbXchkZZV0ZiWefJm1KBG6UKC58fDOCl0IUT7raN0ah0oqJPQyPQ0tr0gHsP+K uneR6LDIULaOruFI9CciR/wA9EYFrAXxXcUGFU5YcTQjnuLVKAm8Qa8nW4ANiTsz7FBK oA4A== X-Gm-Message-State: AD7BkJJLfbqienS4RQei31o3pvGKkRAwVEyhjprvmXNrLOQ3aNFSFH3GXmUHJnT+T3QWFyoeDO/XXWdk6Ca3WTlY X-Received: by 10.50.97.39 with SMTP id dx7mr2407697igb.70.1458726185310; Wed, 23 Mar 2016 02:43:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.39.5 with HTTP; Wed, 23 Mar 2016 02:42:45 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Wed, 23 Mar 2016 15:12:45 +0530 Message-ID: Subject: Re: pgAdmin4 PATCH: Domain Module To: Dave Page Cc: Khushboo Vashi , pgadmin-hackers Content-Type: multipart/alternative; boundary=047d7b10d01b19b351052eb42894 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --047d7b10d01b19b351052eb42894 Content-Type: text/plain; charset=UTF-8 On Wed, Mar 23, 2016 at 3:09 PM, Dave Page wrote: > Did you forget to attach the latest patch? > She did it in the previous patch only. She forgot to mention about the help string, which she did in later mail. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* > > On Wed, Mar 23, 2016 at 7:27 AM, Khushboo Vashi > wrote: > > Updated one comment. > > > > On Wed, Mar 23, 2016 at 12:48 PM, Khushboo Vashi > > wrote: > >> > >> Hi, > >> > >> Please find attached updated patch for the Domains module. > >> > >> On Wed, Mar 16, 2016 at 9:40 PM, Dave Page wrote: > >>> > >>> Hi > >>> > >>> On Wed, Mar 16, 2016 at 2:03 PM, Khushboo Vashi > >>> wrote: > >>> > Hi, > >>> > > >>> > Please find the updated Domain Module Patch. > >>> > > >>> > To test this patch, please apply Backgrid Textarea Cell Patch before > >>> > this. > >>> > >>> Thanks. I believe with the following fixes, we'll be done :-) > >>> > >>> - Default values should be auto-quoted when necessary (ie. strings, on > >>> a text-based domain). > >> > >> As per our discussion, this should leave unquoted. > > > > And also added a hint to the field stated 'Enter an expression or a > value.' > >> > >> > >>> - "System Domain?" should be in the General section, between owner and > >>> comment. > >> > >> Done > >>> > >>> - The switches should use the same colouring/styling as other objects, > >>> e.g. > >>> > >>> options: { > >>> 'onText': 'Yes', 'offText': 'No', > >>> 'onColor': 'success', 'offColor': 'primary', > >>> 'size': 'small' > >>> } > >> > >> Done > >>> > >>> - Please remove the Schema property from the main properties tab (not > >>> the properties dialogue). > >> > >> Done > >>> > >>> - No icon is show for Checks on the Dependents tab for a domain. > >> > >> Done > >>> > >>> - The add button on the Security Labels tab is spelt "Add". Why is > >>> that? Other instances of this grid use "ADD" which is the default in > >>> backform.pgadmin.js. > >> > >> Done > >>> > >>> - Dependencies on domain check constraints are listed as being on a > >>> "Type" not a "Domain". > >> > >> Done > >>> > >>> - If adding a domain constraint using the grid on the Domain dialogue, > >>> I cannot specify "NOT VALID". We need a checkbox for that in a narrow > >>> columns at the end. Unchecking it for an existing constraint should be > >>> the equivalent of doing "ALTER DOMAIN ... VALIDATE CONSTRAINT" > >> > >> Done > >>> > >>> - If I switch the "Don't Validate" switch on a constraint, there are > >>> leading blank lines in the generated SQL. The same occurs when adding > >>> a comment to a constraint. > >> > >> Done > >>> > >>> - I think we need to reverse the meaning of "Don't Validate" and > >>> rename to match the "Valid?" field that's on the properties list. > >>> Otherwise it's not clear they're the same thing. > >> > >> Done > >>> > >>> - s/Not Null/Not Null?/ > >> > >> Done > >>> > >>> > >>> > >>> -- > >>> Dave Page > >>> Blog: http://pgsnake.blogspot.com > >>> Twitter: @pgsnake > >>> > >>> EnterpriseDB UK: http://www.enterprisedb.com > >>> The Enterprise PostgreSQL Company > >> > >> > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > --047d7b10d01b19b351052eb42894 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On Wed, Mar 23, 2016 at 3:0= 9 PM, Dave Page <dpage@pgadmin.org> wrote:
Did you forget to attach the latest patch?
She did it in the previous patch only.
She for= got to mention about the help string, which she did in later mail.

--

=

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:=C2=A0Enterprise PostgreSQL Company<= /a>



On Wed, Mar 23, 2016 at 7:27 AM, Khushboo Vashi
<khushboo.vashi@enter= prisedb.com> wrote:
> Updated one comment.
>
> On Wed, Mar 23, 2016 at 12:48 PM, Khushboo Vashi
> <khushboo.vashi@= enterprisedb.com> wrote:
>>
>> Hi,
>>
>> Please find attached updated patch for the Domains module.
>>
>> On Wed, Mar 16, 2016 at 9:40 PM, Dave Page <dpage@pgadmin.org> wrote:
>>>
>>> Hi
>>>
>>> On Wed, Mar 16, 2016 at 2:03 PM, Khushboo Vashi
>>> <khushbo= o.vashi@enterprisedb.com> wrote:
>>> > Hi,
>>> >
>>> > Please find the updated Domain Module Patch.
>>> >
>>> > To test this patch, please apply Backgrid Textarea Cell P= atch before
>>> > this.
>>>
>>> Thanks. I believe with the following fixes, we'll be done = :-)
>>>
>>> - Default values should be auto-quoted when necessary (ie. str= ings, on
>>> a text-based domain).
>>
>> As per our discussion, this should leave unquoted.
>
> And also added a hint to the field stated 'Enter an expression or = a value.'
>>
>>
>>> - "System Domain?" should be in the General section,= between owner and
>>> comment.
>>
>> Done
>>>
>>> - The switches should use the same colouring/styling as other = objects,
>>> e.g.
>>>
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0options: {
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0'onText'= ;: 'Yes', 'offText': 'No',
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0'onColor= 9;: 'success', 'offColor': 'primary',
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0'size':= 'small'
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}
>>
>> Done
>>>
>>> - Please remove the Schema property from the main properties t= ab (not
>>> the properties dialogue).
>>
>> Done
>>>
>>> - No icon is show for Checks on the Dependents tab for a domai= n.
>>
>> Done
>>>
>>> - The add button on the Security Labels tab is spelt "Add= ". Why is
>>> that? Other instances of this grid use "ADD" which i= s the default in
>>> backform.pgadmin.js.
>>
>> Done
>>>
>>> - Dependencies on domain check constraints are listed as being= on a
>>> "Type" not a "Domain".
>>
>> Done
>>>
>>> - If adding a domain constraint using the grid on the Domain d= ialogue,
>>> I cannot specify "NOT VALID". We need a checkbox for= that in a narrow
>>> columns at the end. Unchecking it for an existing constraint s= hould be
>>> the equivalent of doing "ALTER DOMAIN ... VALIDATE CONSTR= AINT"
>>
>> Done
>>>
>>> - If I switch the "Don't Validate" switch on a c= onstraint, there are
>>> leading blank lines in the generated SQL. The same occurs when= adding
>>> a comment to a constraint.
>>
>> Done
>>>
>>> - I think we need to reverse the meaning of "Don't Va= lidate" and
>>> rename to match the "Valid?" field that's on the= properties list.
>>> Otherwise it's not clear they're the same thing.
>>
>> Done
>>>
>>> - s/Not Null/Not Null?/
>>
>> Done
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>
>>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=

--047d7b10d01b19b351052eb42894--