Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bn57p-0004t7-Up for pgadmin-hackers@arkaria.postgresql.org; Thu, 22 Sep 2016 14:37:22 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bn57p-0006z7-Da for pgadmin-hackers@arkaria.postgresql.org; Thu, 22 Sep 2016 14:37:21 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bn57b-0006Fx-Rt for pgadmin-hackers@postgresql.org; Thu, 22 Sep 2016 14:37:07 +0000 Received: from mail-it0-x231.google.com ([2607:f8b0:4001:c0b::231]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bn57Y-0006Ik-2m for pgadmin-hackers@postgresql.org; Thu, 22 Sep 2016 14:37:07 +0000 Received: by mail-it0-x231.google.com with SMTP id n143so83391218ita.1 for ; Thu, 22 Sep 2016 07:37:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ScvNOnL5iO0G5RqT3SmvIJ0nBQjoh/u4n3KqlZZcnUA=; b=UzajG4EDYI7/cU8tMrjN3Ec8t1UraVEzzbLdRugsRaVOe0cL+L1rmeNuvLw87a6C7l 7Lb7DQ8xYcMcp2M/GSHoiZXNVATNyFwLqm7WST2d/mk6ZhArQmrl+uv9Bb7wxIqwHw7O /EIce5oZvIRLRh2h5/XHruzfa66ndw07NQztD870FGjCdWqZjNcA8a8keZ3Md3iHeBF2 N71aCoJgyy9wfx8kcMBwTRYETbLvqhgbFhnUSBjj9AJsT0lhcGk6VR0q+8pMxjkkB0R1 ZiA/j888FsFed9sUstqrm70SFpnASn/FwQA8SFvgGNMcNH9LxqQC6pauv4t/JN/b4Ca8 4Z6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ScvNOnL5iO0G5RqT3SmvIJ0nBQjoh/u4n3KqlZZcnUA=; b=JjviI1rjZCZ4eybEG+dXlwQvH0aQxVMsGNouwda5EckgD0SBIPTN/TF9rYPalBqJD2 +Pz4ctmPN+ZtqOEwkIrsMJQ+vpae5oYjfS3BoQeEIvSGGD48SyiuYz2srWreF/kG0pfr JknT1dOZ80LVN88m52UaUs+8cUq+mKZQmsc/9ecuHaGtrk1EZ/5BGQRN4Yiup8qFXld6 vrCUNdjJQ1mBR8U/3ztnbYuZIIGhM2AXhUhdFrCBkuwMGYJepNLMhl9eVmH+DvvNz9g5 uuLGDMld9QU5V1UavJPY/RYn4dSQvgyGNgdKUc1fqZvJsN7su09jRyn8pyv5E4W1ivyJ EdSA== X-Gm-Message-State: AE9vXwNkPQcjtvfI1QC/2iQrwhVa32SRloL38dbNGMdlPjoinB3Oyzl69dSyqjMnNvK5rkusBlO+6Cm9zCQy7PUY X-Received: by 10.36.152.11 with SMTP id n11mr11616617itd.18.1474555022013; Thu, 22 Sep 2016 07:37:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.50.212 with HTTP; Thu, 22 Sep 2016 07:37:01 -0700 (PDT) Received: by 10.107.50.212 with HTTP; Thu, 22 Sep 2016 07:37:01 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Thu, 22 Sep 2016 20:07:01 +0530 Message-ID: Subject: Re: PATCH: pgAgent support To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=94eb2c05a22a4a38cb053d1998f1 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c05a22a4a38cb053d1998f1 Content-Type: text/plain; charset=UTF-8 I sent an updated patch immediately. On Sep 22, 2016 20:01, "Dave Page" wrote: > Hi > > On Thu, Sep 22, 2016 at 11:47 AM, Ashesh Vashi < > ashesh.vashi@enterprisedb.com> wrote: > >> Hi Dave, >> >> Please find the patch for support for paAgent in pgAdmin 4. >> > > Did you forget the binary switch? > > piranha:web dpage$ git apply --binary ~/Downloads/pgagent_v2.patch > error: cannot apply binary patch to 'web/pgadmin/browser/server_ > groups/servers/pgAgent/schedules/static/img/coll-pga_schedule.png' > without full index line > error: web/pgadmin/browser/server_groups/servers/pgAgent/ > schedules/static/img/coll-pga_schedule.png: patch does not apply > error: cannot apply binary patch to 'web/pgadmin/browser/server_ > groups/servers/pgAgent/schedules/static/img/pga_schedule.png' without > full index line > error: web/pgadmin/browser/server_groups/servers/pgAgent/ > schedules/static/img/pga_schedule.png: patch does not apply > error: cannot apply binary patch to 'web/pgadmin/browser/server_ > groups/servers/pgAgent/static/img/coll-pga_job.png' without full index > line > error: web/pgadmin/browser/server_groups/servers/pgAgent/static/img/coll-pga_job.png: > patch does not apply > error: cannot apply binary patch to 'web/pgadmin/browser/server_ > groups/servers/pgAgent/static/img/pga_job-disabled.png' without full > index line > error: web/pgadmin/browser/server_groups/servers/pgAgent/static/img/pga_job-disabled.png: > patch does not apply > error: cannot apply binary patch to 'web/pgadmin/browser/server_ > groups/servers/pgAgent/static/img/pga_job.png' without full index line > error: web/pgadmin/browser/server_groups/servers/pgAgent/static/img/pga_job.png: > patch does not apply > error: cannot apply binary patch to 'web/pgadmin/browser/server_ > groups/servers/pgAgent/steps/static/img/coll-pga_jobstep.png' without > full index line > error: web/pgadmin/browser/server_groups/servers/pgAgent/steps/ > static/img/coll-pga_jobstep.png: patch does not apply > error: cannot apply binary patch to 'web/pgadmin/browser/server_ > groups/servers/pgAgent/steps/static/img/pga_jobstep.png' without full > index line > error: web/pgadmin/browser/server_groups/servers/pgAgent/steps/static/img/pga_jobstep.png: > patch does not apply > >> >> I have also attached another patch for miscellaneous fixes, and adding >> new controls. >> It includes: >> - Added DatetimepickerControl, MomentCell (using moment.js) >> - Used the 'DatetimepickerControl' in Role (Also - resolved an issue, >> when unset the datetime for 'Valid Until'.) >> - Added a 'Select All/Unselect All' adaptor for Select2 used by pgAgent >> nodes. >> - Fixed an issue with SubNodeCollectionControl, which was not starting >> the modification session of the child model, when created default value for >> collection is not null/undefined. And, hence - validation on the child >> model was not working. >> - Fixed a memory leak with SqlFieldControl, and SqlTabControl, which was >> not releasing the CodeMirror properly. >> > > Urgh, that's big. Applied - but can you look at the following please? > > - Account expires has a hint of 'MMM D YYYY HH:mm:ss.SSS Z". Are > milliseconds really needed? I also get 00 as a fractional timezone offset. > Perhaps we should hide that, when it's 00? > > - The date format differs from the ISO format displayed by the query tool. > They should be consistent - and really should be either based on the > client's locale settings, or ISO format. > > Thanks. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --94eb2c05a22a4a38cb053d1998f1 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

I sent an updated patch immediately.


On Sep 22, 2016 2= 0:01, "Dave Page" <dpage@= pgadmin.org> wrote:
Hi

On Thu, Sep 22, 2016 at 11:47 AM, Ashesh Vashi <a= shesh.vashi@enterprisedb.com> wrote:
Hi Dave,

<= div>Please find the patch for support for paAgent in pgAdmin 4.
=

Did you forget the binary switch?

piranha:web dpage$ git apply --binary ~/Downloads/pgagent_= v2.patch=C2=A0
error: cannot apply binary patch to 'web/pgadm= in/browser/server_groups/servers/pgAgent/schedules/static/img/col= l-pga_schedule.png' without full index line
error: web/p= gadmin/browser/server_groups/servers/pgAgent/schedules/static/img= /coll-pga_schedule.png: patch does not apply
error: cannot a= pply binary patch to 'web/pgadmin/browser/server_groups/servers/pg= Agent/schedules/static/img/pga_schedule.png' without full ind= ex line
error: web/pgadmin/browser/server_groups/servers/pgA= gent/schedules/static/img/pga_schedule.png: patch does not apply<= /div>
error: cannot apply binary patch to 'web/pgadmin/browser/serv= er_groups/servers/pgAgent/static/img/coll-pga_job.png' withou= t full index line
error: web/pgadmin/browser/server_groups/s= ervers/pgAgent/static/img/coll-pga_job.png: patch does not apply
=
error: cannot apply binary patch to 'web/pgadmin/browser/server_groups/servers/pgAgent/static/img/pga_job-disabled.png' without= full index line
error: web/pgadmin/browser/server_groups/se= rvers/pgAgent/static/img/pga_job-disabled.png: patch does not apply
error: cannot apply binary patch to 'web/pgadmin/browser/server= _groups/servers/pgAgent/static/img/pga_job.png' without full = index line
error: web/pgadmin/browser/server_groups/servers/= pgAgent/static/img/pga_job.png: patch does not apply
error: = cannot apply binary patch to 'web/pgadmin/browser/server_groups/se= rvers/pgAgent/steps/static/img/coll-pga_jobstep.png' without = full index line
error: web/pgadmin/browser/server_groups/ser= vers/pgAgent/steps/static/img/coll-pga_jobstep.png: patch does no= t apply
error: cannot apply binary patch to 'web/pgadmin/brow= ser/server_groups/servers/pgAgent/steps/static/img/pga_jobstep.pn= g' without full index line
error: web/pgadmin/browser/server_= groups/servers/pgAgent/steps/static/img/pga_jobstep.png: patch do= es not apply=C2=A0

I have also attached another patch = for miscellaneous fixes, and adding new controls.
It includes:
- Added DatetimepickerControl, MomentCell (using moment.js)
- Used the 'DatetimepickerControl' in Role (Also - resolved an i= ssue, when unset the datetime for 'Valid Until'.)
- Added= a 'Select All/Unselect All' adaptor for Select2 used by pgAgent no= des.
- Fixed an issue with SubNodeCollectionControl, which was no= t starting the modification session of the child model, when created defaul= t value for collection is not null/undefined. And, hence - validation on th= e child model was not working.
- Fixed a memory leak with SqlFiel= dControl, and SqlTabControl, which was not releasing the CodeMirror properl= y.

Urgh, that's big. Applie= d - but can you look at the following please?=C2=A0

- Account expires has a hint of 'MMM D YYYY HH:mm:ss.SS= S Z". Are milliseconds really needed? I also get 00 as a fractional ti= mezone offset. Perhaps we should hide that, when it's 00?
- The date format differs from the ISO format displayed by the = query tool. They should be consistent - and really should be either based o= n the client's locale settings, or ISO format.

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.= com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The = Enterprise PostgreSQL Company
--94eb2c05a22a4a38cb053d1998f1--