Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fSJMu-0001Qh-7G for pgadmin-hackers@arkaria.postgresql.org; Mon, 11 Jun 2018 09:44:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fSJMs-0004Px-Tj for pgadmin-hackers@arkaria.postgresql.org; Mon, 11 Jun 2018 09:44:06 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fSJMs-0004Pn-GF for pgadmin-hackers@lists.postgresql.org; Mon, 11 Jun 2018 09:44:06 +0000 Received: from mail-ot0-x22c.google.com ([2607:f8b0:4003:c0f::22c]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fSJMo-0004Hl-LG for pgadmin-hackers@postgresql.org; Mon, 11 Jun 2018 09:44:04 +0000 Received: by mail-ot0-x22c.google.com with SMTP id 92-v6so22993939otw.9 for ; Mon, 11 Jun 2018 02:44:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=JACP+k6LvvXKb921PL9bhiWWJ3zDDuj+tI4IOoA7+H0=; b=B+Ep5l14bNi0hUVpVGyPtT0Qt8KfsFax7Rweoce5fYKwP82hMhIs7754/EuBdCOJZ1 nxlTOyoPg+iPj227qYRK+fKmyf0HYdSBXlWAPJ1ItxAdSiTb+ilCZT+zdmKLEYOzMaYH YSEoMhcaGxwqh+1fNpAi3h5t9C+vuoeSbW6CMP0QmpLgg9TsqGl0X+9yut+ASNmPmmJn GDuJvdsjZdvfKXkEh+A+LTuYlZmuNhcGj0T+M0VqPDC+d6m7DYf5Q6Rk24n9d5tuW3jn Bhj22MuwkhZ7g7RkiVJmMB6IHRv6Yn4JSs+HjzyiyxdX0TYwmf7KkI30WjpjPcWq9ruU LCcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=JACP+k6LvvXKb921PL9bhiWWJ3zDDuj+tI4IOoA7+H0=; b=gpOHOxDhZosq6IarpmevtOhKBafwPyYolBvefIvBVnjeIndwQb0f6qXkWOWGsoKbL1 mB/rXMY/lgZTpaFmVK8aEn2AG3VW7gWP0P9hbpiN52HgAQdskjKYmO7FRvXAUDeIjUyZ DCqy4wfGFx6P8Nju0WQA0XVdy3V42hzAGjF1YhsGu3ENtxxpV9oIvn+tKkjM2EJzspNX XmiOIUbGbuDBmOvg1W3W6FXoG4DiteNTtmal0EDs6GGmJJvnCCMwJlTBCcLhP0gpufs7 ZCOzZ3OPhAb183zBWWmUBV7ErRw9+CFOJCdRHy6h99uOfjyjTNL0d6fcUwrhpCcW3fpC 2ulw== X-Gm-Message-State: APt69E2x9ayyBDaS+r8Rt9U1wHJ8bm2kyFbObO7B3lPFlX6RmvIgKgtz nEHt+HZFM1aQPzP0yvCbx6ySQTIZjqWeIWVG9SiVTw== X-Google-Smtp-Source: ADUXVKJKb9CUpVCR9goOgjxYToUYdQXpQkfEVoKwq2l6K3GXlp034NGQTFgg13w04JcdskpReUnuFF7bsBM0K54Uogs= X-Received: by 2002:a9d:4343:: with SMTP id y3-v6mr10071722oti.362.1528710241786; Mon, 11 Jun 2018 02:44:01 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ac9:7a54:0:0:0:0:0 with HTTP; Mon, 11 Jun 2018 02:43:41 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Mon, 11 Jun 2018 15:13:41 +0530 Message-ID: Subject: Re: PGAgent 4.0 error feedback To: Robert Emery Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000ed33a3056e5a964b" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000ed33a3056e5a964b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jun 11, 2018 at 1:38 PM, Robert Emery wrote: > Hello Again, > > I've just tested the patch and the output is *much* more verbose with the > same > set of flags now, even more so than the old version (see attached). > Yes. A many systems, pgAgent service starts before the database service file on opearting system start. Hence - instead of quitting on first connection failure, we attempt to connect the database server at least 10 time before quitting, and that would give the database server to start. -- Thanks, Ashesh > > Thanks, > Rob > > On 11/06/2018, Ashesh Vashi wrote: > > Hi Rob, > > > > > > On Mon, Jun 11, 2018 at 12:50 PM, Rob Emery > > wrote: > > > >> Hi Ashesh, > >> > >> Log-level wise I was using the same command for both versions: > >> > >> ./pgagent -f -l 2 -t 1 -r 1 'hostaddr=3Dserver user=3Dusername > >> password=3Dpassword dbname=3Dpostgres' > >> > >> and messing up the connection string in various ways (missing dbname, > >> incorrect password, incorrect hostaddr) > >> > >> This was built and tested on Debian GNU/Linux 9.4 (stretch). > >> > > If you're working on the source, would please test the patch sent by me= ? > > > >> > >> I've attached an example of the differing output when the dbname is > >> missing > >> from the connectionstring; basically it's the same for all errors. > >> > > > > Thanks a lot for the information. > > > > -- Thanks, Ashesh > > > >> > >> Many Thanks, > >> Rob > >> > >> On 11/06/2018, Ashesh Vashi wrote: > >> > Hi Rob, > >> > > >> > On Sun, Jun 10, 2018 at 2:26 AM, Rob Emery > >> > wrote: > >> > > >> >> Hi Guys, > >> >> > >> >> I've been testing out PGAgent 4 (build today from master at commit > >> >> 86ca5c5ed1ad572075ba27e05e4680ebdf5b9feb) to check the connection > >> >> handling on error is still fixed with the boost reimplementation > >> >> (which it is!) > >> >> and noticed a few issues compared to PGAgent 3 around feedback to t= he > >> >> user if the connection string is incorrect. > >> >> > >> >> I've tested with incorrect username and password, user not in the > hba, > >> >> db doesn't exist, postgresql not running on the host (or incorrect > >> >> hostaddr) and 4 seems to always returns the error : > >> >> ` > >> >> ERROR: Couldn't find the function 'pgagent_schema_version' - please > >> >> run pgagent_upgrade.sql. > >> >> ` > >> >> > >> >> whereas 3.4.1 tends to output from the pgconnection itself like: > >> >> ` > >> >> Sat Jun 9 21:32:13 2018 : WARNING: Couldn't create the primary > >> >> connection (attempt 1): FATAL: no pg_hba.conf entry for host > >> >> "172.30.0.16", user "pgagent_login_role", database > >> >> "pgagent_login_role", SSL on > >> >> FATAL: no pg_hba.conf entry for host "172.30.0.16", user > >> >> "pgagent_login_role", database "pgagent_login_role", SSL off > >> >> ` > >> >> > >> >> which at least points the user towards the actual error! > >> >> > >> >> Not sure if this is known already, but I thought I'd raise it prior > to > >> >> release. > >> >> > >> > Thanks for sharing the information. > >> > > >> > Is it possible for you to share the logs with log level set to debug= ? > >> > Also - please share the operating system details? > >> > > >> > -- > >> > > >> > Thanks & Regards, > >> > > >> > Ashesh Vashi > >> > EnterpriseDB INDIA: Enterprise PostgreSQL Company > >> > > >> > > >> > > >> > *http://www.linkedin.com/in/asheshvashi* > >> > > >> > > >> > > >> > > >> >> > >> >> Thanks, > >> >> Rob > >> >> -- > >> >> > >> >> -- > >> >> > >> >> > >> >> > >> >> Codeweavers May Newsletter > >> >> l > Codeweavers > >> >> April > >> >> Finance Trends > >> >> april-finance-trends> > >> >> > >> >> > >> >> April=E2=80=99s Dealer Highlights > >> >> > >> >> >> march-car-finance-trends > >> >> > > >> >> > >> >> _ > >> >> _ > >> >> > >> >> > >> >> > >> >> *Phone:* 0800 021 0888 Email: contactus@codeweavers.net > >> >> > >> >> Codeweavers Ltd | Barn 4 | Dunston > >> >> Business Village | Dunston | ST18 9AB > >> >> Registered in England and Wales No. > >> >> 04092394 | VAT registration no. 974 9705 63 > >> >> > >> >> > >> >> > >> >> > >> >> > >> >> > >> >> > >> >> > >> >> > >> >> > >> >> > >> > > >> > >> -- > >> > >> > >> > >> Codeweavers May Newsletter > >> l Codeweavers > >> April > >> Finance Trends > >> > >> > >> > >> April=E2=80=99s Dealer Highlights > >> > >> march-car-finance-trends > >> > > >> > >> _ > >> _ > >> > >> > >> > >> *Phone:* 0800 021 0888 Email: contactus@codeweavers.net > >> > >> Codeweavers Ltd | Barn 4 | Dunston > >> Business Village | Dunston | ST18 9AB > >> Registered in England and Wales No. > >> 04092394 | VAT registration no. 974 9705 63 > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > > > > > -- > Robert Emery > Infrastructure Director > > E: robertemery@codeweavers.net | T: 01785 711633 | W: www.codeweavers.net > > -- > > > > Codeweavers May Newsletter > l Codeweavers > April > Finance Trends > > > > April=E2=80=99s Dealer Highlights > > > > > _ > _ > > > > *Phone:* 0800 021 0888 Email: contactus@codeweavers.net > > Codeweavers Ltd | Barn 4 | Dunston > Business Village | Dunston | ST18 9AB > Registered in England and Wales No. > 04092394 | VAT registration no. 974 9705 63 > > > > > > > > > > --000000000000ed33a3056e5a964b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
<= div style=3D"margin:0pt 0pt 8px">

On Mon, Jun 11, 20= 18 at 1:38 PM, Robert Emery <robertemery@codeweavers.net>= wrote:

Hello Again,

I've just tested the patch and the output is *much* more verbose with t= he same
set of flags now, even more so than the old version (see attached).
Yes.

A many systems, pgAgent service= starts before the database service file on opearting system start.
Hence - instead of quitting on first connection failure, we attempt to c= onnect the database server at least 10 time before quitting, and that would= give the database server to start.

-- Thanks, Ash= esh

Thanks,
Rob

On 11/06/2018, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
> Hi Rob,
>
>
> On Mon, Jun 11, 2018 at 12:50 PM, Rob Emery <re-pgsql@codeweavers.net>
> wrote:
>
>> Hi Ashesh,
>>
>> Log-level wise I was using the same command for both versions:
>>
>>=C2=A0 ./pgagent -f -l 2 -t 1 -r 1 'hostaddr=3Dserver user=3Dus= ername
>> password=3Dpassword dbname=3Dpostgres'
>>
>> and messing up the connection string in various ways (missing dbna= me,
>> incorrect password, incorrect hostaddr)
>>
>> This was built and tested on=C2=A0 Debian GNU/Linux 9.4 (stretch).=
>>
> If you're working on the source, would please test the patch sent = by me?
>
>>
>> I've attached an example of the differing output when the dbna= me is
>> missing
>> from the connectionstring; basically it's the same for all err= ors.
>>
>
> Thanks a lot for the information.
>
> -- Thanks, Ashesh
>
>>
>> Many Thanks,
>> Rob
>>
>> On 11/06/2018, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
>> > Hi Rob,
>> >
>> > On Sun, Jun 10, 2018 at 2:26 AM, Rob Emery <re-pgsql@codeweavers.net>
>> > wrote:
>> >
>> >> Hi Guys,
>> >>
>> >> I've been testing out PGAgent 4 (build today from mas= ter at commit
>> >> 86ca5c5ed1ad572075ba27e05e4680ebdf5b9feb) to check t= he connection
>> >> handling on error is still fixed with the boost reimpleme= ntation
>> >> (which it is!)
>> >> and noticed a few issues compared to PGAgent 3 around fee= dback to the
>> >> user if the connection string is incorrect.
>> >>
>> >> I've tested with incorrect username and password, use= r not in the hba,
>> >> db doesn't exist, postgresql not running on the host = (or incorrect
>> >> hostaddr) and 4 seems to always returns the error :
>> >> `
>> >> ERROR: Couldn't find the function 'pgagent_schema= _version' - please
>> >> run pgagent_upgrade.sql.
>> >> `
>> >>
>> >> whereas 3.4.1 tends to output from the pgconnection itsel= f like:
>> >> `
>> >> Sat Jun=C2=A0 9 21:32:13 2018 : WARNING: Couldn't cre= ate the primary
>> >> connection (attempt 1): FATAL:=C2=A0 no pg_hba.conf entry= for host
>> >> "172.30.0.16", user "pgagent_login_role&qu= ot;, database
>> >> "pgagent_login_role", SSL on
>> >> FATAL:=C2=A0 no pg_hba.conf entry for host "172.30.0= .16", user
>> >> "pgagent_login_role", database "pgagent_lo= gin_role", SSL off
>> >> `
>> >>
>> >> which at least points the user towards the actual error!<= br> >> >>
>> >> Not sure if this is known already, but I thought I'd = raise it prior to
>> >> release.
>> >>
>> > Thanks for sharing the information.
>> >
>> > Is it possible for you to share the logs with log level set t= o debug?
>> > Also - please share the operating system details?
>> >
>> > --
>> >
>> > Thanks & Regards,
>> >
>> > Ashesh Vashi
>> > EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> > <http://www.enterprisedb.com/>
>> >
>> >
>> > *http://www.linkedin.com/in/asheshvashi*
>> > <http://www.linkedin.com/in/asheshvashi<= /a>>
>> >
>> >
>> >
>> >>
>> >> Thanks,
>> >> Rob
>> >> --
>> >>
>> >> --
>> >>=C2=A0 <https://codeweavers.net>
>> >>
>> >>
>> >> Codeweavers May Newsletter
>> >> <https://mailchi.mp/cod= eweavers/march-edition-336883>=C2=A0 l=C2=A0 Codeweavers
>> >> April
>> >> Finance Trends
>> >> <https://c= odeweavers.net/company-blog/codeweavers-april-finance-trends&= gt;
>> >>
>> >>
>> >> April=E2=80=99s Dealer Highlights
>> >> <https://codeweave= rs.net/company-blog/aprils-dealer-highlights>
>> >> <https://codeweavers.net/= company-blog/codeweavers-
>> march-car-finance-trends
>> >> >
>> >>
>> >> _
>> >> _
>> >>
>> >>
>> >>
>> >> *Phone:* 0800 021 0888=C2=A0 =C2=A0Email: contactus@codeweavers.net
>> >> <mailto:c= ontactus@codeweavers.net>
>> >> Codeweavers Ltd | Barn 4 | Dunston
>> >> Business Village | Dunston | ST18 9AB
>> >> Registered in England and Wales No.
>> >> 04092394 | VAT registration no. 974 9705 63
>> >>
>> >>
>> >>
>> >>
>> >> <https://www.linkedin.com/<= wbr>company/codeweavers-limited>
>> >> <https://vimeo.com/codeweaversltd><= br> >> >> <https://plus.go= ogle.com/b/105942302039373248738/+CodeweaversNet>
>> >> <https://twitter.com/CodeweaversTeam<= /a>>
>> >>
>> >>
>> >>
>> >
>>
>> --
>>=C2=A0 <https://codeweavers.net>
>>
>>
>> Codeweavers May Newsletter
>> <https://mailchi.mp/codeweavers/= march-edition-336883>=C2=A0 l=C2=A0 Codeweavers
>> April
>> Finance Trends
>> <https://codeweaver= s.net/company-blog/codeweavers-april-finance-trends>
>>
>>
>> April=E2=80=99s Dealer Highlights
>> <https://codeweavers.net/company-blog/aprils-dealer-highlights>
>> <https://codewe= avers.net/company-blog/codeweavers-march-car-finance-trends >> >
>>
>> _
>> _
>>
>>
>>
>> *Phone:* 0800 021 0888=C2=A0 =C2=A0Email: contactus@codeweavers.net
>> <mailto:contactus@= codeweavers.net>
>> Codeweavers Ltd | Barn 4 | Dunston
>> Business Village | Dunston | ST18 9AB
>> Registered in England and Wales No.
>> 04092394 | VAT registration no. 974 9705 63
>>
>>
>>
>>
>> <https://www.linkedin.com/compa= ny/codeweavers-limited>
>> <https://vimeo.com/codeweaversltd>
>> <https://plus.google.com/= b/105942302039373248738/+CodeweaversNet>
>> <https://twitter.com/CodeweaversTeam>
>>
>>
>


--
Robert Emery
Infrastructure Director

E: robertemery@codeweavers.n= et | T: 01785 711633 | W: www.codeweavers.net

--
=C2=A0<https://codeweavers.net>


Codeweavers May Newsletter
<https://mailchi.mp/codeweavers/march-edi= tion-336883>=C2=A0=C2=A0l=C2=A0 Codeweavers April
Finance Trends
<https://codeweavers.net/company-blog/codeweavers-april-finance-trends>


April=E2=80=99s Dealer Highlights
<https://codeweavers.net/compan= y-blog/aprils-dealer-highlights>
<https://codeweavers.net= /company-blog/codeweavers-march-car-finance-trends>

_
_



*Phone:*=C2=A00800 021 0888=C2=A0=C2=A0=C2=A0Email:=C2=A0contactus@codeweavers.net
<mailto:contactus@codeweave= rs.net>
Codeweavers Ltd=C2=A0| Barn 4 | Dunston
Business Village | Dunston | ST18 9AB
Registered in England and Wales No.
04092394 | VAT registration no. 974 9705 63=C2=A0




<https://www.linkedin.com/company/codewe= avers-limited>=C2=A0=C2=A0
<https://vimeo.com/codeweaversltd>=C2=A0=C2=A0
<https://plus.google.com/b/10= 5942302039373248738/+CodeweaversNet>=C2=A0=C2=A0
<https://twitter.com/CodeweaversTeam>


--000000000000ed33a3056e5a964b--