Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMZ06-0004YQ-HB for pgadmin-hackers@arkaria.postgresql.org; Mon, 11 Jul 2016 11:03:46 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bMZ06-0005ZF-4J for pgadmin-hackers@arkaria.postgresql.org; Mon, 11 Jul 2016 11:03:46 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bMYzt-0005LQ-0w for pgadmin-hackers@postgresql.org; Mon, 11 Jul 2016 11:03:33 +0000 Received: from mail-it0-x22e.google.com ([2607:f8b0:4001:c0b::22e]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bMYzp-00013T-Sx for pgadmin-hackers@postgresql.org; Mon, 11 Jul 2016 11:03:31 +0000 Received: by mail-it0-x22e.google.com with SMTP id f6so52037474ith.0 for ; Mon, 11 Jul 2016 04:03:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=tW0NBtnZ+0wjO9zJl8JzqP9B3MHMfaN3+pbRDOUMSxE=; b=AGGwv+Ws67vBQgK/foqrHTqMSudXuywJusO9Ww9xg1GP7SwNssc3/KjmuXZFc2mh6g QaI5ZawhYJYljK9+gJkaa6rDpRMdBTYGPRLToHdKqxq2fIavyysiJSiyWhnbNdUIpfZ9 n/c0cBvM1qeGKsDP9bCcc9uvGYSipeJEd41IjjbvSSAN5V7nQHNvK+hxj9ehOo4o7R+8 Xthdm3M6iIPCQqX21H/xNRwYzmxLIOBFb6NbIV9YbwCD/to8VdczrRUF0v8H1SnT7jRz mtPX9r+BAIHeQTvt65rPJveJYQ/+az9eFTlqqdAeuqfJyEiObgkZZ3oILf4ocEQh6Afj 11uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=tW0NBtnZ+0wjO9zJl8JzqP9B3MHMfaN3+pbRDOUMSxE=; b=Et37kFJ4ZcrTmzV9YHNqzJyi4Ve1A/k6Dfm36wPbU+x9itZgwtXjKzsissDljmAtar Q0YicXf7QBaPcZTnCM4cLEJPhEvYKQm9qnsKtGMnC8ge5T7iO0ubh6XJ2pcx9Lvqq9uc 3PLWXPwqB0aNHK0B/Oe7Hl1tuANpq5MHmxgTeVzU69KVt/1710dMXYVfHNaDE0uRcyqx lVwX6W+L5MDumLuqc/DDzC1LLAN5nBV1CanscM3y6Gk8V+Dw1FZCJwjKoATcDlfR5u0N swhZQREpJjPB3lsuW4iaZSv0pw20ZIZtUFLMCRy4AQaW/jASA0wo6M0PDckfFDiJmcue 7y0A== X-Gm-Message-State: ALyK8tIEpWUGTj8wYAxvZnn0+HYqhQy7b13rfVRMay181GsUbGzyJG9n3vpUhhV2zH/hvH1bNL6goVTaVB3UyS5Y X-Received: by 10.36.55.2 with SMTP id r2mr9694590itr.73.1468235009170; Mon, 11 Jul 2016 04:03:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.133.217 with HTTP; Mon, 11 Jul 2016 04:03:09 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Mon, 11 Jul 2016 16:33:09 +0530 Message-ID: Subject: Re: PATCH: To fix salt generation in session.py To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a1140cd742b5cfe05375a1aaf X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1140cd742b5cfe05375a1aaf Content-Type: text/plain; charset=UTF-8 I've committed the patch. Thanks for testing it. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Mon, Jul 11, 2016 at 4:30 PM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi, > > Tested, I'm able to login now. > > > Thanks, > Murtuza > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Mon, Jul 11, 2016 at 4:05 PM, Ashesh Vashi < > ashesh.vashi@enterprisedb.com> wrote: > >> Hi Murtuza, >> >> Can you please test this patch for the same? >> >> -- >> >> Thanks & Regards, >> >> Ashesh Vashi >> EnterpriseDB INDIA: Enterprise PostgreSQL Company >> >> >> >> *http://www.linkedin.com/in/asheshvashi* >> >> >> On Mon, Jul 11, 2016 at 12:44 PM, Murtuza Zabuawala < >> murtuza.zabuawala@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please hold on in this patch, Need additional changes. >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> On Mon, Jul 11, 2016 at 12:41 PM, Murtuza Zabuawala < >>> murtuza.zabuawala@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> With latest pull session.py fails with below error with python3 because >>>> in python3 strings 'lowercase' method has been renamed to >>>> 'ascii_lowercase', PFA patch to fix the issue. >>>> >>>> Issue: >>>> ---------- >>>> * File "../pgadmin4/web/pgadmin/utils/session.py", line 59, in sign* >>>> * self.randval = >>>> ''.join(random.sample(string.lowercase+string.digits, 20))* >>>> *AttributeError: module 'string' has no attribute 'lowercase'* >>>> >>>> >>>> -- >>>> Regards, >>>> Murtuza Zabuawala >>>> EnterpriseDB: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> >> > --001a1140cd742b5cfe05375a1aaf Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I've committed the patch.
Thanks for testing it.

--=

Thanks & Regar= ds,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise Post= greSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Mon, Jul 11, 2016 at 4:30 PM, Murtuza Zab= uawala <murtuza.zabuawala@enterprisedb.com>= wrote:
Hi,

Tested, I'm able to login now.


Thanks,
Murtuza

--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Comp= any

On Mon, Jul 11= , 2016 at 4:05 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com= > wrote:
H= i Murtuza,

Can you please test this patch for the same?<= /div>

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company=

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Mon, Jul 11, 2016 at 12:44 PM, Murtuza Za= buawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

Please hold on in this patch, Need additional changes.
<= div class=3D"gmail_extra">
--
<= font color=3D"#888888">Murtuza Zabuawala
EnterpriseDB:=C2=A0<= a href=3D"http://www.enterprisedb.com/" rel=3D"noreferrer" style=3D"color:r= gb(17,85,204)" target=3D"_blank">http://www.enterprisedb.com
The Ente= rprise PostgreSQL Company

On Mon, Jul 11, 2016 at 12:= 41 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.= com> wrote:
Hi,

With latest pull session.py fails with below error= with python3 because in python3 strings 'lowercase' method has bee= n renamed to 'ascii_lowercase', PFA patch to fix the issue.

Issue:
----------
=C2=A0 File= "../pgadmin4/web/pgadmin/utils/session.py", line 59, in sign=
=C2=A0 =C2=A0 self.randval =3D ''.join(random.sample(= string.lowercase+string.digits, 20))
AttributeError: modul= e 'string' has no attribute 'lowercase'

<= /div>

--
<= font color=3D"#888888">Murtuza Zabuawala
EnterpriseDB:=C2=A0<= a href=3D"http://www.enterprisedb.com/" rel=3D"noreferrer" style=3D"color:r= gb(17,85,204)" target=3D"_blank">http://www.enterprisedb.com
The Ente= rprise PostgreSQL Company

<= /span>



--001a1140cd742b5cfe05375a1aaf--