Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1an1RD-0007n4-T9 for pgadmin-hackers@arkaria.postgresql.org; Mon, 04 Apr 2016 10:08:52 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1an1RD-0001n4-9S for pgadmin-hackers@arkaria.postgresql.org; Mon, 04 Apr 2016 10:08:51 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1an1Qz-0001X0-Eb for pgadmin-hackers@postgresql.org; Mon, 04 Apr 2016 10:08:37 +0000 Received: from mail-ig0-x233.google.com ([2607:f8b0:4001:c05::233]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1an1Qw-0000bb-9o for pgadmin-hackers@postgresql.org; Mon, 04 Apr 2016 10:08:36 +0000 Received: by mail-ig0-x233.google.com with SMTP id f1so64778519igr.1 for ; Mon, 04 Apr 2016 03:08:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=7HVCzMhmk9LdVNmDgtc9+92zln76CMnXVI4esM51jP4=; b=md35A5E4UoyZKLu8qfIvaG/4haNciUJVoVgz0we9N4jN9XG4c3CNuktG1tbNDcZ8AS mMuonHhpCQoy4sgG+lFhej3I2NX5QiX9mCG+JPG7EyKHArriNu5wwzToIC6iLG6rqRLC IFROkDleZ8qzxDXGL1N8n0HL1FHv+CVCIslpC56N/FYjcf+nnL+1KKsuRuvYq8UTZbDf dkpdPJd4a4kYUPvm71/b9LtTUizKdfb9aeaSiqNLjpNvqWi76/HZb6sjcp+Yu0DT7L6y azJ8hhE+RRPvagdSj3zO0ENtd6c9HFHbI7HA8L3euxoTwW83WUKk8hMDOVC1LrEKGtE0 RujA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=7HVCzMhmk9LdVNmDgtc9+92zln76CMnXVI4esM51jP4=; b=kJVPITQDuixLjMkb6TB6ZU18O/QMDD6rpayU6EP/g4fhzI6t05Ew1PjmjUfGLc6305 nX3el2ronUIEO2ML4DLi/J95ion7AVTWsJ1FbBTfwl8UEnpLCV1rBOO5hJjJLMHNO4DV uTKDu8C3oX84YIeglOIGs+YbQUqwiJDbJXTJ937X7kcmvKZIDDdWxjN2hIEnpgktSpJF SAqNIZlyZmWkkgQiNYlapy/HQeY1livXRbpceEzoEO5O8spaVpJkTiTtTQ7KP7ljoIAW oSvaTOU/IyoSXfB3UvEzNd9NuxM9BvndsTMVn+RDpg/VN+BC+KeDoYuXS0osPeguUrpB 69lg== X-Gm-Message-State: AD7BkJIa5cNlS3xikRp9hWqnVCgyFHPDfm+xmwI5qq2uLjshs2/T2IpRUtJffqeRfMWIx0XcGsLptnVvyicSUkhh X-Received: by 10.50.97.39 with SMTP id dx7mr9118598igb.70.1459764449410; Mon, 04 Apr 2016 03:07:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.39.5 with HTTP; Mon, 4 Apr 2016 03:07:09 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Mon, 4 Apr 2016 15:37:09 +0530 Message-ID: Subject: Re: Patch: Added select2cell editor for backgrid [pgAdmin4] To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=047d7b10d01b769b50052fa5e5e0 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --047d7b10d01b769b50052fa5e5e0 Content-Type: text/plain; charset=UTF-8 Thanks - committed with small changes. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Mon, Apr 4, 2016 at 1:09 PM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi, > > PFA updated patch. > > Regards, > Murtuza > > > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Fri, Apr 1, 2016 at 3:08 PM, Ashesh Vashi < > ashesh.vashi@enterprisedb.com> wrote: > >> On Thu, Mar 31, 2016 at 12:27 PM, Murtuza Zabuawala < >> murtuza.zabuawala@enterprisedb.com> wrote: >> >>> Hi, >>> >>> We have added Select2Cell Editor for backgrid, eariler as it was not >>> present & causing issue in rendering in subnode control. >>> >> Looks good to me, but - have some feedback. >> 1. Can you please mention - why do we need 'openOnEnter: false' in >> select2 options? >> 2. There is a difference between UI, when rendered from the editor, and >> from the Select2Cell. (I can see padding, when the Cell is rendered, but - >> not when editor is rendered.) >> >> Can you please fix this two? >> >> -- >> >> Thanks & Regards, >> >> Ashesh Vashi >> EnterpriseDB INDIA: Enterprise PostgreSQL Company >> >> >> >> *http://www.linkedin.com/in/asheshvashi* >> >> >>> >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> >>> -- >>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>> To make changes to your subscription: >>> http://www.postgresql.org/mailpref/pgadmin-hackers >>> >>> >> > --047d7b10d01b769b50052fa5e5e0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thanks - committed with small changes.

--

Th= anks & Regards,

Ashesh Vashi
Enterpri= seDB INDIA: Enterprise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Mon, Apr 4, 2016 at 1:09 PM, Murtuza Zabu= awala <murtuza.zabuawala@enterprisedb.com> = wrote:
Hi,

PFA updated patch.

Regards,
Murtuz= a




--
Regards,
Murtuza Zabuawal= a
EnterpriseDB:=C2=A0http:/= /www.enterprisedb.com
The Enterprise PostgreSQL Company=

On Fri, Apr 1,= 2016 at 3:08 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com<= /a>> wrote:
Hi,

We have added Select2C= ell Editor for backgrid, eariler as it was not present & causing issue = in rendering in subnode control.
Looks good to= me, but - have some feedback.
1. Can you please mention - why do= we need 'openOnEnter: false' in select2 options?
2. Ther= e is a difference between UI, when rendered from the editor, and from the S= elect2Cell. (I can see padding, when the Cell is rendered, but - not when e= ditor is rendered.)

Can you please fix this two?

--

Thanks & Regards= ,

Ashesh Vashi
EnterpriseDB INDIA:=C2=A0Enterprise Postgre= SQL Company


<= span style=3D"font-family:'courier new',monospace">http://www.linkedin= .com/in/asheshvashi



=
--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL = Company
=


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=




--047d7b10d01b769b50052fa5e5e0--