Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1evbLW-00073M-P5 for pgadmin-hackers@arkaria.postgresql.org; Tue, 13 Mar 2018 04:15:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1evbLV-00047n-DJ for pgadmin-hackers@arkaria.postgresql.org; Tue, 13 Mar 2018 04:15:29 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1evbLV-00047d-6f for pgadmin-hackers@lists.postgresql.org; Tue, 13 Mar 2018 04:15:29 +0000 Received: from mail-io0-x236.google.com ([2607:f8b0:4001:c06::236]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1evbLQ-00013f-8l for pgadmin-hackers@postgresql.org; Tue, 13 Mar 2018 04:15:28 +0000 Received: by mail-io0-x236.google.com with SMTP id h23so14049252iob.11 for ; Mon, 12 Mar 2018 21:15:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=S8nKu5P95wAZTPjRxFgGTSoJPe2y+q+liMvOo+/3sgQ=; b=E8mP7WXa870xp60RTrNtpMJuY9Gvm2F0V99Rgpngkf0wBsV9X/8EW+szhtmD93KZSU jsWIcJRbifxHk/Gt0r5DpLyGslu+OmEM87Ecyw5zWAwfIW42g4HVfV4V0nSNSoOigkQt 6YWhZWSP7zOZF6N09ZAbvQGQvIHvjC78GBk+HLAPpoyYZOIMc+dWfBTY3E99G4Y78gkE c27XtoG/ywdfAaI5O7IIcNh3MpUr790a4OXivKY6XwOnNx166pGe7na57NzzFraKBzVH 2XwjyDIIe+quFR/JJDmqbdt7xFp6iE8m6qFtKOUNzLagfE5GykUpQ/X/xSMzA5mJhz0b +vvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=S8nKu5P95wAZTPjRxFgGTSoJPe2y+q+liMvOo+/3sgQ=; b=AiCZONUkeAJhnb6ktflk/iXfoeXBZxYBa7n1i6Da6gEd6pxx4GZewyB8r0e6lGL+gq OByE3SsF2Aw/5pasGqkkdOaR8qfzx7NCzvxaWI4duizBZamOzYn4G255nvnHT/WrL1Xk bwrhHzhVwieH82PqstNzKyIODDxyH0suLehJ3kIheRvRJ1uUxSCMWT/1bAykwG7H7/o2 eRoMtFWd4b6qx7WyDg+fuZzMrSg7kZRIJiIyO+oVrbc61CXfpE81Jsu80cINUyO4cS4G NvLCemgja019DUV80+gR5n4NxovBEx2apNPwAzLJcXtMzMu+cdrvnIF0xlgmWeU6f5/l sFsQ== X-Gm-Message-State: AElRT7HxBFKrmxpJHZF1Ntx+FrzHutJKXcaxa5VPgX76pq7jGzZY0IK/ AP6GXkhd5vvSgtIFw4XEoAq+gyniwl1sdlLGNCaZNA== X-Google-Smtp-Source: AG47ELvTT28ZjxStY3u0PG0RmnYBN7lVUN2GMDvV1BaNM20WV2fmuyMVBxMXHNecqvlT+TwfeB09YWPwvMrkBepBc3I= X-Received: by 10.107.12.230 with SMTP id 99mr2009179iom.117.1520914521418; Mon, 12 Mar 2018 21:15:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.141.195 with HTTP; Mon, 12 Mar 2018 21:15:00 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Tue, 13 Mar 2018 09:45:00 +0530 Message-ID: Subject: Re: [pgAdmin4][RM#3140] Add service parameter To: Murtuza Zabuawala Cc: Dave Page , Joao De Almeida Pereira , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a113f8efcc8823605674381aa" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a113f8efcc8823605674381aa Content-Type: text/plain; charset="UTF-8" On Tue, Mar 13, 2018 at 9:42 AM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi Ashesh, > > I haven't implemented that intentionally because Khushboo is working on > the same for SSL and our code will conflict, So once Khushboo's patch gets > committed, I'll make changes for Service file as well. > No - that's a bad practice. You need to work on full feature set, not partial. If you have intentionally skipped that, you should have informed the list. -- Thanks, Ashesh > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Tue, Mar 13, 2018 at 9:01 AM, Ashesh Vashi < > ashesh.vashi@enterprisedb.com> wrote: > >> Murtuza/Dave, >> >> I have to reviewed/seen the patch yet. >> But - I have a question. >> Have we used the service file in the external tools for backup, restore, >> and import/export functionalities? >> If not - we should fix that asap. >> >> We had missed that during SSL support, and now - we're fixing that. >> >> -- >> >> Thanks & Regards, >> >> Ashesh Vashi >> EnterpriseDB INDIA: Enterprise PostgreSQL Company >> >> >> >> *http://www.linkedin.com/in/asheshvashi* >> >> >> On Tue, Mar 13, 2018 at 6:18 AM, Dave Page wrote: >> >>> Hi >>> >>> On Mon, Mar 12, 2018 at 5:18 PM, Joao De Almeida Pereira < >>> jdealmeidapereira@pivotal.io> wrote: >>> >>>> Hi Dave and Murtuza, >>>> >>>> Regarding this patch we refactored the Javascript code so that is lives >>>> in a different file and added some tests. >>>> >>>> Also we found an issue with karma-jasmine that does not allow us to use >>>> jasmine 3.1 yet. You can find attached a patch that reverts that commit. >>>> >>> >>> Sounds good, but neither patch will apply (in fact, the Jasmine one >>> looks entirely backwards). One of the error messages was changed in >>> Murtuza's patch, and wasn't reflected in your update for example. >>> >>> Can you rebase please? >>> >>> Thanks. >>> >>> >>>> >>>> Thanks >>>> Victoria && Joao >>>> >>>> On Mon, Mar 12, 2018 at 4:46 PM Dave Page wrote: >>>> >>>>> Thanks, patch applied! >>>>> >>>>> On Mon, Mar 12, 2018 at 3:31 AM, Murtuza Zabuawala < >>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>> >>>>>> Hi Dave, >>>>>> >>>>>> PFA updated patch. >>>>>> >>>>>> -- >>>>>> Regards, >>>>>> Murtuza Zabuawala >>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>>> >>>>>> On Fri, Mar 9, 2018 at 9:29 PM, Murtuza Zabuawala < >>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Dave, >>>>>>> >>>>>>> I'll change the name and send you updated patch. >>>>>>> >>>>>>> >>>>>>> On Fri, Mar 9, 2018 at 9:25 PM, Dave Page wrote: >>>>>>> >>>>>>>> HI >>>>>>>> >>>>>>>> On Fri, Mar 9, 2018 at 11:47 AM, Murtuza Zabuawala < >>>>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> PFA patch to add service parameter in server dialog. >>>>>>>>> - Docs updated >>>>>>>>> - Test case added for Service ID parameter >>>>>>>>> >>>>>>>>> Please note, >>>>>>>>> I have extracted Connection class and Server manager class from >>>>>>>>> our own custom Psycopg2 driver module. >>>>>>>>> >>>>>>>>> Patch also covers RM#3120 >>>>>>>>> >>>>>>>> >>>>>>>> This patch seems a little confused. The "Service" and "Service ID" >>>>>>>> fields from pgAdmin 3 are very different things. The Redmine ticket seems >>>>>>>> to be asking for the Service field (the pg_service.conf service name), >>>>>>>> *not* Service ID (the operating system's service ID, used to start/stop the >>>>>>>> database server service). >>>>>>>> >>>>>>>> -- >>>>>>>> Dave Page >>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>> Twitter: @pgsnake >>>>>>>> >>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>> The Enterprise PostgreSQL Company >>>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > --001a113f8efcc8823605674381aa Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
<= div style=3D"margin:0pt 0pt 8px">


On Tue, Mar 13, 2018 at 9:42= AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.co= m> wrote:
=
Hi Ashesh,

I haven't imple= mented that intentionally because Khushboo is working on the same for SSL a= nd our code will conflict, So once Khushboo's patch gets committed, I&#= 39;ll make changes for Service file as well.
N= o - that's a bad practice.
You need to work on full feature s= et, not partial.

If you have intentionally skipped= that, you should have informed the list.

-- Thank= s, Ashesh=C2=A0


=
--
Regards,
Murtuza Zabuaw= ala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The En= terprise PostgreSQL Company
=

On Tue, Mar 13= , 2018 at 9:01 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com= > wrote:
Murtuza/Dave,

I have to reviewed/seen the patch ye= t.
But - I have a question.
Have we used the service file in the external tools for ba= ckup, restore, and import/export functionalities?
If not= - we should fix that asap.

We had missed that during SSL support, and now = - we're fixing that.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Tue, Mar 13, 2018 at 6:18 AM, Dave Page <= span dir=3D"ltr"><dpage@pgadmin.org> wrote:
=
Hi

On Mon, Mar 12, 2018 at 5:18 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hi Dave and Murtuza,

R= egarding this patch we refactored the Javascript code so that is lives in a= different file and added some tests.

Also we foun= d an issue with karma-jasmine that does not allow us to use jasmine 3.1 yet= . You can find attached a patch that reverts that commit.

Sounds good, but neither patch will apply= (in fact, the Jasmine one looks entirely backwards). One of the error mess= ages was changed in Murtuza's patch, and wasn't reflected in your u= pdate for example.

Can you rebase please?

Thanks.
=C2=A0

Thanks
Vict= oria && Joao

On Mon, Mar 12, 2018 at 4:46 PM Dave Pag= e <dpage@pgadmin.= org> wrote:
Thanks, patch applied!

On Mon, Mar 12, 2018 at 3:31 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,

PFA updated patch.

= --Regards,=
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterpris= edb.com
The Enterprise PostgreSQL Company
<= div><= img src=3D"https://drive.google.com/a/enterprisedb.com/uc?id=3D0B6jGeB3BfKR= MV0t4MEp0YnZCTTA&export=3Ddownload" width=3D"420" height=3D"31">

On Fri, Mar 9, 2018 at 9:29 PM, Murtuza Zabu= awala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,

I'll change the name and s= end you updated patch.
<= div dir=3D"ltr">
=
<= /div>
On Fri, Mar 9, 2018 at 9:25 PM, Dave Page <= dpage@pgadmin.org> wrote:
<= div dir=3D"ltr">HI

On Fri, Mar 9, 2018 at 11:47 AM, Murtuza Zabuawala &= lt;= murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to add=C2=A0service parameter in se= rver dialog.
- Docs updated
- Test case added for Service ID parameter

Please note,
I have= extracted Connection class and Server manager class from our own custom Ps= ycopg2 driver module.

Patch also covers RM#3120
<= br>
=C2=A0This patch seems a little confused. The "Service&q= uot; and "Service ID" fields from pgAdmin 3 are very different th= ings. The Redmine ticket seems to be asking for the Service field (the pg_s= ervice.conf service name), *not* Service ID (the operating system's ser= vice ID, used to start/stop the database server service).

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake=

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Compan= y





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @= pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL= Company


=

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pg= snake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL C= ompany



--001a113f8efcc8823605674381aa--