Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bX6fn-0001vB-0U for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 Aug 2016 13:02:23 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bX6fm-0005AK-Ji for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 Aug 2016 13:02:22 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bX6fZ-0004vw-5h for pgadmin-hackers@postgresql.org; Tue, 09 Aug 2016 13:02:09 +0000 Received: from mail-io0-x230.google.com ([2607:f8b0:4001:c06::230]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bX6fT-0005Go-Qm for pgadmin-hackers@postgresql.org; Tue, 09 Aug 2016 13:02:07 +0000 Received: by mail-io0-x230.google.com with SMTP id q83so10551375iod.1 for ; Tue, 09 Aug 2016 06:02:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=eze14poH7H2oEHpgNTjAowFBcM/evzfEYVE042KFJ9Y=; b=gQU1cbUUmqir3ragTYC4z4133LG6RlzziuKqb9H9V5ZY0/Vb4XvxEqr+bh5CydDpxp GxOt4FID5H4XeU2Yi6g9/5jGdZKlkUt3kKDK5bkGpphSkZRTzWE06Il8nLoOHMBdLbtU diK5sIbwUPtviZRTN9UTZCzyqv2Nxo8jp1ATVF3tygY1qEIj/xE60IooJi6xLrU+5Kmd bWuEc/gPhSRgyfBQTpBC/pqtpm2M3Lc07qFkxSe5agZj1wrnJ6rVTlphpMms9fk64RQ7 XhWsMQdrV1iw+xQZy5O/+PImicF/kgwIWXOqbsuu/q5Ctb+1dDRx1RrJcdeNvf+/gpzh A4Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=eze14poH7H2oEHpgNTjAowFBcM/evzfEYVE042KFJ9Y=; b=eYThavNfCwc0A3qtGdaGfLwcVe4rY7R85pp6522pesZojCoXZX78We24g6qBB/Xm1P n0NduyECEWU1EOxTtulUcEECCiR7H369JusADZmGrFXogA5LZiE2oOmK+9rYjcMtL1Jh PuJ51xWm+AyyBZdQVDMqJUBwueniwOtE5J275r8HTQFcoNHOp2jsQOTwzVF2zo3xXmP7 1skSKAdKIEeGjk2VQEO8nKWbQF+RmNg66UWLSHt/wqHddA9ks/nDSZhTPQ2NMli/9JMy Jjk5EfhV47Ok1ItxN3u8RgqpMxM266ceYTVmiW6oWFtRsuNMfm8Puhd1TKDuvxjXhIgm 9FQA== X-Gm-Message-State: AEkoouupFyefIenSOSOhPRzK1uuyvL8FjN7hKrJMsTmQ4+Ith6a/8IRqB9rLPWuCLGGfjR1WUj3t+JBgXh3LsRL9 X-Received: by 10.107.161.141 with SMTP id k135mr102738591ioe.149.1470747721842; Tue, 09 Aug 2016 06:02:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.6.76 with HTTP; Tue, 9 Aug 2016 06:01:41 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Tue, 9 Aug 2016 18:31:41 +0530 Message-ID: Subject: Re: PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4) To: Dave Page Cc: Murtuza Zabuawala , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a1140ffb683fd940539a323cf X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1140ffb683fd940539a323cf Content-Type: text/plain; charset=UTF-8 On Tue, Aug 9, 2016 at 6:28 PM, Dave Page wrote: > Hi > > On Tue, Aug 9, 2016 at 8:07 AM, Murtuza Zabuawala > wrote: > > Hi, > > > > PFA patch to fix the issue where message panel was showing incomplete > info. > > We may still miss some messages from Psycopg2 driver due to limited size > of > > notices queue. > > (RM#1523) > > A few thoughts on this (mostly based on my discussions with Ashesh): > > 1) You seem to have removed the poll delay. I assume that is to try to > avoid missing messages? Can we re-introduce the delay (to avoid > excessive network requests), but collect messages while we're waiting? > Using thread? Start a thread during the timeout? > > 2) If I run VACUUM, whilst I see messages as I should now, there is no > query time summary as there is for a query that returns data. > > 3) Can we incrementally display messages? e.g. each time we poll, we > add the new messages to the messages div, and scroll to the end > automatically? Yeah - that's a good idea. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > --001a1140ffb683fd940539a323cf Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On Tue, Aug 9, 2016 at 6:28 PM, Dav= e Page <dpage@pgadmin.org> wrote:

<= /div>
Hi

On Tue, Aug 9, 2016 at 8:07 AM, Murtuza Zabuawala
<murtuza.zabuawala= @enterprisedb.com> wrote:
> Hi,
>
> PFA patch to fix the issue where message panel was showing incomplete = info.
> We may still miss some messages from Psycopg2 driver due to limited si= ze of
> notices queue.
> (RM#1523)

A few thoughts on this (mostly based on my discussions with Ashesh):=

1) You seem to have removed the poll delay. I assume that is to try to
avoid missing messages? Can we re-introduce the delay (to avoid
excessive network requests), but collect messages while we're waiting?<= br>
Using thread?
Start a thread during the time= out?

2) If I run VACUUM, whilst I see messages as I should now, there is no
query time summary as there is for a query that returns data.

3) Can we incrementally display messages? e.g. each time we poll, we
add the new messages to the messages div, and scroll to the end
automatically?
Yeah - that's a good idea.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:=C2=A0Enterprise PostgreSQL Company<= /a>


=C2=A0
=C2=A0

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers

--001a1140ffb683fd940539a323cf--