Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1ZlcqB-0007Wm-Vl for pgadmin-hackers@arkaria.postgresql.org; Mon, 12 Oct 2015 13:08:36 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1ZlcqB-0000gM-IJ for pgadmin-hackers@arkaria.postgresql.org; Mon, 12 Oct 2015 13:08:35 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1Zlcpy-0000Rw-Ad for pgadmin-hackers@postgresql.org; Mon, 12 Oct 2015 13:08:22 +0000 Received: from mail-lb0-f175.google.com ([209.85.217.175]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1Zlcpu-0000HG-RM for pgadmin-hackers@postgresql.org; Mon, 12 Oct 2015 13:08:21 +0000 Received: by lbbk10 with SMTP id k10so30153646lbb.0 for ; Mon, 12 Oct 2015 06:08:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=zNInaUuiZblK6oaq/MNd+qD18KsVTow1AootWW5H8gw=; b=XnBZA1f3yoSNrxb4rNkw5Yw8JWahjPaBtrwA7mEJgTZMQqgXQNs9rtyPAxgfd25DkQ uErssmtXBV1zY1ufawFA7RghYD5tCsrUE00wxlzAVWyr1Z62P9tbiQd4jG2Mh+hoBfQo E55n312nswayXZjM5wGSX9BMmgeM8ZwvfVDDeCXY3JoiS9R0G63ozZUKm8UG/Pr9pmx9 E7vbEvRQ+5jxOB9f/qony30ySx4yhjf4qcfRXBAGUuTlLH9dJcaJuTvpLGDVrhx6+Qse MOgp8v3+YS9xshZM2DYxKQSbqMmhKUHJt6r0gMcjJscqdWU7/H3to2s3XzmHKWxIaUsS Rvtw== X-Gm-Message-State: ALoCoQllxQAZ1lxbLK9ZnaFHY6O+I6Tk728IPGkEPPPE36wFEEx/sD/O8EoD/mEJnQYzHQzJAfzo X-Received: by 10.112.205.69 with SMTP id le5mr12556591lbc.89.1444655297409; Mon, 12 Oct 2015 06:08:17 -0700 (PDT) MIME-Version: 1.0 Received: by 10.112.181.37 with HTTP; Mon, 12 Oct 2015 06:07:57 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Mon, 12 Oct 2015 18:37:57 +0530 Message-ID: Subject: Re: PATCH: move object to....(tablespace context) To: Sanket Mehta Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a11c3c1bed34fc60521e805a4 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a11c3c1bed34fc60521e805a4 Content-Type: text/plain; charset=UTF-8 On Mon, Oct 12, 2015 at 6:28 PM, Sanket Mehta wrote: > Hi Ashesh, > > PFA the updated patch which includes the changes you have suggested. > Please do review and commit it. > Hi Sanket, Thanks for the patch. It has been committed. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* > > Regards, > Sanket Mehta > Sr Software engineer > Enterprisedb > > On Mon, Oct 12, 2015 at 4:55 PM, Sanket Mehta < > sanket.mehta@enterprisedb.com> wrote: > >> Hi Ashesh, >> >> I have created a patch regarding an issue in pgadmin related to >> tablespace context. >> >> *Issue:* >> While moving Table/Index/materialized view/All to another tablespace, >> pgadmin gives error mentioned below: >> ERROR: syntax error at or near "MOVE" >> >> *Reason:* >> As mentioned in commit id: 3c4cf080879b386d4ed1814667aca025caafe608 >> in PostgreSQL database, ALTER TABLESPACE src MOVE dest OWNED BY username >> syntax has been changed >> >> *Current implementation in postgreSQL db is as below:* >> ALTER TABLE/INDEX/MATERIALIZED VIEW ALL IN TABLESPACE src OWNED BY >> username SET TABLESPACE dest >> >> *Changes made:* >> Changes made to generate sql as per current implementation in PostgreSQL. >> >> >> Please do review and commit it. >> >> >> Regards, >> Sanket Mehta >> Sr Software engineer >> Enterprisedb >> > > --001a11c3c1bed34fc60521e805a4 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Mon,= Oct 12, 2015 at 6:28 PM, Sanket Mehta <sanket.mehta@enterpris= edb.com> wrote:
<= div dir=3D"ltr">
Hi Ashesh,

PFA the updated patch whi= ch includes the changes you have suggested.
Pleas= e do review and commit it.
Hi Sanket,
=

Thanks for the patch.
It has been c= ommitted.

--

Thanks & Reg= ards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise Po= stgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi

= =C2=A0

Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Mon, Oct 12= , 2015 at 4:55 PM, Sanket Mehta <sanket.mehta@enterprisedb.com= > wrote:
Hi Ashesh,

I have c= reated a patch regarding an issue in pgadmin related to tablespace context.=

Issue:
While moving Table/Index/materialized = view/All to another tablespace, pgadmin gives error mentioned below:
ERR= OR: syntax error at or near "MOVE"

Reason:<= /b>
As mentioned in commit id: 3c4cf080879b386d4ed1814667aca0= 25caafe608
in PostgreSQL database, ALTER TABLESPACE src MOVE dest OWNED= BY username syntax has been changed

Current implement= ation in postgreSQL db is as below:
ALTER TABLE/INDEX/MAT= ERIALIZED VIEW ALL IN TABLESPACE src OWNED BY username SET TABLESPACE dest<= br>
Changes made:
Changes made to genera= te sql as per current implementation in PostgreSQL.


= Please do review and commit it.


Regards,
Sanket Mehta
=
Sr Software engineer
Enterprisedb


--001a11c3c1bed34fc60521e805a4--