Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b1Wat-0004WH-3h for pgadmin-hackers@arkaria.postgresql.org; Sat, 14 May 2016 10:14:47 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1b1Was-0004H7-N7 for pgadmin-hackers@arkaria.postgresql.org; Sat, 14 May 2016 10:14:46 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1b1Was-0004H1-9r for pgadmin-hackers@postgresql.org; Sat, 14 May 2016 10:14:46 +0000 Received: from mail-ig0-x236.google.com ([2607:f8b0:4001:c05::236]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1b1Wal-00067a-Mb for pgadmin-hackers@postgresql.org; Sat, 14 May 2016 10:14:45 +0000 Received: by mail-ig0-x236.google.com with SMTP id m9so21466900ige.1 for ; Sat, 14 May 2016 03:14:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=w6t2K4znidP5iHGk8fn/iTj89Z7C4OH4E5Z8U8lcnpU=; b=DaqTndECNx1yDXW31bJF0tBXAGHuL33QSpu7BN5tV585RyfMC+vHUs16K0fTMSvWuW BTvTlWvxOhD7knhmW5lu+UZY1rQhfoXQgIrTIyfP3y5NSxRr/BcMH5ifmGSw2T1lsDQS ql0MW1XeM5HEf3RRqKwqSE10UHg/VhSzBTY7N2YDzeKBwf8H+9sgBH7fKrG1lk5eFI10 h8SWmG23eKxLMPckVGMAQQzaOyIScSRlYFf6jqPlHQzm45yaIhmN6G1PYTNTgitxLm4c TY6vSbCBvLYtVJAG8imEqPZ7joiel4eQJYkz+1ZCoy0dLD8l6lwo4EqJ34JyqUQp38wG wrNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=w6t2K4znidP5iHGk8fn/iTj89Z7C4OH4E5Z8U8lcnpU=; b=j803guhYvADyTqSWup0UzklgdmfeRCJM/hkuwVq8W1zC4tl4oFIaGRWdGykRgvI3yM 3/UitzDd5COIqWoI1/JvIBxvS9O7Pkcw7bsc3v2kIV/YILPM1AImeU57niDwc9vQEmxr B6Db/bR1ueUqcq7UAgxNelQZk53FcwbGzRC2R1Z7j5h96fP69Y8Yn1QXQKgk0bIzx/c7 pMtqBV+CXYj0ToEPzmgxbgd+8FVWrfDRbg7YUkZ7UQahJh+zH76uq3G1EJAxmxtsPCru /XVOnCKvOPb3Mva/M1QvHECdOlK3kprVGcWuj5dzBSZQ8eZGw21RtyEwOeOxgQiYHz5k 5NZw== X-Gm-Message-State: AOPr4FXu/wpILHRYSUHxClSeP8XGg8ejT4E9ATcFzPGoQBE9b7DyUQAAgy6GvhbJ/iPSAZyS1BcTgCr7NVyEUd6C X-Received: by 10.50.111.72 with SMTP id ig8mr3495573igb.35.1463220878737; Sat, 14 May 2016 03:14:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.31.209 with HTTP; Sat, 14 May 2016 03:14:19 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Sat, 14 May 2016 15:44:19 +0530 Message-ID: Subject: Re: [pgAdmin4][patch]: Unable to create extension "postgis_topology" and "postgis_tiger_geocoder" installed through stack builder To: Surinder Kumar Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=089e013a2b54b4a5600532caa844 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --089e013a2b54b4a5600532caa844 Content-Type: text/plain; charset=UTF-8 Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Fri, May 6, 2016 at 4:32 PM, Surinder Kumar < surinder.kumar@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue: > Unable to create extension "postgis_topology" and > "postgis_tiger_geocoder", due to wrong schema name in generated SQL query. > > *For example*: > > It generates following query for '*postgis_toplology*' extension: > CREATE EXTENSION *postgis_topology* SCHEMA *topology*; > > which is wrong. the correct query should be: > CREATE EXTENSION *postgis_topology*; > > where it fetches '*topology*' schema from table *pg_available_extensions* > and > then sets schema when extension name is selected, but it should not set > schema on name change. > It is now fixed in this patch. > Thanks Fahar for reporting. > > Please review and let me know for comments. > > Thanks, > Surinder Kumar > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > --089e013a2b54b4a5600532caa844 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thanks - committed!

--

Thanks & Regards,=

Ashesh Vashi
EnterpriseDB INDIA: <= a href=3D"http://www.enterprisedb.com" target=3D"_blank">Enterprise Postgre= SQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Fri, May 6, 2016 at 4:32 PM, Surinder Kum= ar <surinder.kumar@enterprisedb.com> wrote:
Hi,

PFA= patch to fix the issue:
Unable to create extension "postgis= _topology" and "postgis_tiger_geocoder", due to wrong schema= name in generated SQL query.

For example:<= /div>

It generates following query for 'postgis_t= oplology' extension:
CREATE EXTENSION postgis_topology SCHEMA=C2=A0topology;
w= hich is wrong. the correct query should be:
CREATE EXTENSION postgis_topology;
=

where it fetches 'topology' schema= from table pg_available_extensions and=C2=A0
then sets sc= hema when extension name is selected, but it should not set schema on name = change.
It is now fixed in this patch.
Thanks Faha= r for reporting.

Please review and let me kn= ow for comments.

Thanks,
Surinder Kumar<= /div>


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=


--089e013a2b54b4a5600532caa844--