Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ar1J5-0000RZ-4Q for pgadmin-hackers@arkaria.postgresql.org; Fri, 15 Apr 2016 10:48:59 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1ar1J4-0006YZ-6V for pgadmin-hackers@arkaria.postgresql.org; Fri, 15 Apr 2016 10:48:58 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ar1Ip-0006KA-FX for pgadmin-hackers@postgresql.org; Fri, 15 Apr 2016 10:48:43 +0000 Received: from mail-io0-x229.google.com ([2607:f8b0:4001:c06::229]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1ar1Ih-0005ub-Rd for pgadmin-hackers@postgresql.org; Fri, 15 Apr 2016 10:48:42 +0000 Received: by mail-io0-x229.google.com with SMTP id 2so130893473ioy.1 for ; Fri, 15 Apr 2016 03:48:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=XKS4j4kgcDFp/ByZx2xcgMyc2BwnOo4T8MwpSo2n884=; b=Xw9L1R0t+UdVaydZfGO8euKwW1kv8F6xmcuzF1NSyokNG1JmemS7DLHlLKot+5zdVW NbVMNxGR0yItdizb+YiXWw54unV9PUFtK64T+FonFnGcB/VqlI5F5T5VhwavnOfpO1Bt QMru9uAlNX1H4wgv+iDrd56dH/xEqmC0dfd0HDjvaR06tKOJU+vT5UIRPMebnN+HwpVh 8QX2iss8u2v2vM/i/9kNv/5oEoR40CVDMbGRX4dYV1F/wJhu/g996/andgBC3mSkAJ9S k2lr1TSy2SbrRec5T21vpWOK7aojgR0MKUUHR0Mm/UCrTJMXU0kWCvW6KmmGEhZhzWyi at/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=XKS4j4kgcDFp/ByZx2xcgMyc2BwnOo4T8MwpSo2n884=; b=EiXJxr3nnz27akZ+OtCkKdoCrN3QR4KEVNWntyzc/1lCSmP0q1GHFOHJkgPOjGx8wM gHaD3tBdywoYzz4l6K9U7SWVo+MOS2GKQlf/INEEiqG2AuYsoJyF2racsqEJJ9bXh4ML CtlEOYEXDcsokTHZVuVRlxcCK5JZUCJWvZedK1xRzPXM6J1Qufm0+dks4nXSk2zN4pQI uhWoQZNQvRz3TM6OEGnxs+MXvy2I+JGxWO6dH09XUZHRv8oWUhmeR7vbmldJbtfMeCIc GdHLXbkMVo388bSm87qW8FnfWfNVo7CgC8fRKJXACWt1ILApxZJyYcQjVG2E7i5jpOZD pEnQ== X-Gm-Message-State: AOPr4FW3gI5R2RFThI9N+8c0TOyx+MbxVrDYKWfQ7KEkipj4Yc3cpYn9CukWfWIqkPZn96AR3OfGeAl5mEdkgHuc X-Received: by 10.107.156.193 with SMTP id f184mr20434774ioe.117.1460717314767; Fri, 15 Apr 2016 03:48:34 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.39.5 with HTTP; Fri, 15 Apr 2016 03:48:15 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Fri, 15 Apr 2016 16:18:15 +0530 Message-ID: Subject: Re: Dialogues not closing To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a1140cd38aa44e8053083c01e X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1140cd38aa44e8053083c01e Content-Type: text/plain; charset=UTF-8 Hi Dave, I was able to reproduce the issue with the help of Murtuza. I missed one corner case - it was not able to close the dialog, when the parent/collection has not yet been loaded. Please find the updated patch. This patch only includes the dialog issue. Please let me know - if you still see the issue. I've committed the patch about the objects (model/collection/views) release. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Fri, Apr 15, 2016 at 1:36 PM, Ashesh Vashi wrote: > Hi Dave, > > > On Fri, Apr 15, 2016 at 1:20 PM, Dave Page wrote: > >> >> >> On Fri, Apr 15, 2016 at 6:32 AM, Ashesh Vashi < >> ashesh.vashi@enterprisedb.com> wrote: >> >>> On Fri, Apr 15, 2016 at 2:23 AM, Dave Page wrote: >>> >>>> Hey Ashesh, >>>> >>>> We have an issue with dialogues not closing on Save button presses. >>>> One of the team told me yesterday or the day before that it's a >>>> general issue, not one specific to the patch I was reviewing at the >>>> time, which I've been finding seems to be the case. >>>> >>>> Any idea what this issue is? >>>> >>> Sure - I will look into it. >>> >> >> Thanks - please make it a priority; I'm at PG Conf NYC next week and >> expect to be doing lots of demos. >> > Please find the patch for the same. > > This also includes some of the cleanup required to solve some of the > memory leak issues. > > I was not able to reproduce the issue at my end, but - I've idea of when > it could fail to close the panel, which I have resolved in this patch. > Can you please test it? > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > > > > *http://www.linkedin.com/in/asheshvashi* > > > >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > --001a1140cd38aa44e8053083c01e Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Dave,

I was able to reproduce the is= sue with the help of Murtuza.
I missed one corner case - it was n= ot able to close the dialog, when the parent/collection has not yet been lo= aded.

Please find the updated patch.
Thi= s patch only includes the dialog issue.
Please let me know - if y= ou still see the issue.

I've committed the pat= ch about the objects (model/collection/views) release.

=

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Fri, Apr 15, 2016 at 1:36 PM, Ashesh Vash= i <ashesh.vashi@enterprisedb.com> wrote:

Hi Dave,


On Fri, Apr 15, 2016 at 1:20 PM, Dave Page <dpage@pgadmin.= org> wrote:


<= div class=3D"gmail_extra">
On Fri, Apr = 15, 2016 at 6:32 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.c= om> wrote:

On Fri, Apr 15, 2016 at 2:23 AM, Dave Page <= dpage@pgadmin.org> wrote:

Hey Ashesh,

We have an issue with dialogues not closing on Save button presses.
One of the team told me yesterday or the day before that it's a
general issue, not one specific to the patch I was reviewing at the
time, which I've been finding seems to be the case.

Any idea what this issue is?
Sure - I will look= into it.

Th= anks - please make it a priority; I'm at PG Conf NYC next week and expe= ct to be doing lots of demos.=C2=A0
Please find the patch for the same.

This = also includes some of the cleanup required to solve some of the memory leak= issues.

I was not able to reproduce the issue at = my end, but - I've idea of when it could fail to close the panel, which= I have resolved in this patch.
Can you please test it?

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:=C2=A0Enterprise PostgreSQL C= ompany


http://www.linkedin.com/= in/asheshvashi


<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;pa= dding-left:1ex">


--
Dave Page
Blog: http://pgsnake.blogs= pot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
= The Enterprise PostgreSQL Company


--001a1140cd38aa44e8053083c01e--