Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b5q45-00027h-34 for pgadmin-hackers@arkaria.postgresql.org; Thu, 26 May 2016 07:50:45 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1b5q44-0001nG-Lz for pgadmin-hackers@arkaria.postgresql.org; Thu, 26 May 2016 07:50:44 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1b5bIW-0007p8-04 for pgadmin-hackers@postgresql.org; Wed, 25 May 2016 16:04:40 +0000 Received: from mail-io0-x236.google.com ([2607:f8b0:4001:c06::236]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1b5bIS-0007tu-Rg for pgadmin-hackers@postgresql.org; Wed, 25 May 2016 16:04:38 +0000 Received: by mail-io0-x236.google.com with SMTP id p64so35080945ioi.2 for ; Wed, 25 May 2016 09:04:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=ll72yJjrwwHZTBPeHuUKk/qKQ7EbOcAeeh8/b5gYJ44=; b=0yjY7osxyytWc8ywub+6HILeI0hLRGH6eJ6LvHfwGfQ5ItS2FyHMuLgmOqibpo1q/S qwU6GpjOLzdTczIKgR+PhAA0rUF1aXNUxqEs737LQNNw5Vxro3betZBWf7r7lAeSZNgp WLoTGC6DQDBIK8Usff7BnUPRuDFYrZ/rjwhlBJZdgPxshRym0eXhqgSXlGGB42g41Qg0 JJUPSvU1Sw3MzPyCROo+id47fl0gzPhjpYzEJNf/7BW8O4BIibYUHOjh8lTTo4ZhnL06 yEZjihTRSAmx7xvsRTyQvcG+rmQ33MJY02ICobDTeEb6DJAouTUr0SEzMMp6ZY1dGmBS DF6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=ll72yJjrwwHZTBPeHuUKk/qKQ7EbOcAeeh8/b5gYJ44=; b=ZHS+U6wnPGG9UBTl0xxGoGCVuaaU7/8Xa+oJ6aT3RlJq4i/CBe2VD859L2kUOAzMvU DiBZfIvPFhs8Qey8RKyUdNp8NBmIPQNtpd+qQA3Yn3rf7Z7if8cDQkhVATn0ylQZzQ2J bEhPSJ9WBdc9G9AB3l3o1EAFHFXCa+7UoztcMRs0Uqd1u6qWL8xwobJlUnyEwJ97oJc/ OmuEy8wz7Bg6v/uw9J29sMSjQDmpPB/CgP2immAmc3LvTcf+XndPvaw3ULrYc8Gu8M2d daHLWVy8HOP5ZW/NO/FLW1WdrlE0tY5aYN7IJX2JISE82I7S/LUS/Riq7omv3atWayfO N4FQ== X-Gm-Message-State: ALyK8tKwMyu74q5aFDsp7eRAihhvugSK7r9WBs5YwaoakEmqXXMMxIUPYk5cd4dBSZaJnsBYNA1kq7r5u+yQ62US MIME-Version: 1.0 X-Received: by 10.107.32.79 with SMTP id g76mr4256620iog.117.1464192275630; Wed, 25 May 2016 09:04:35 -0700 (PDT) Received: by 10.107.142.86 with HTTP; Wed, 25 May 2016 09:04:34 -0700 (PDT) Received: by 10.107.142.86 with HTTP; Wed, 25 May 2016 09:04:34 -0700 (PDT) In-Reply-To: References: Date: Wed, 25 May 2016 21:34:34 +0530 Message-ID: Subject: Re: [PATCH] Tables node (pgAdmin4) From: Ashesh Vashi To: Thom Brown Cc: pgadmin-hackers , Murtuza Zabuawala , Dave Page , Harshal Dhumal , Akshay Joshi Content-Type: multipart/alternative; boundary=001a1140bfb87911a30533acd4da X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1140bfb87911a30533acd4da Content-Type: text/plain; charset=UTF-8 Thanks. On May 25, 2016 21:01, "Thom Brown" wrote: > Thanks. I've raised all of these in tickets 1231 to 1237. > > Thom > > On 25 May 2016 at 04:23, Ashesh Vashi > wrote: > >> Hi Thom, >> >> Can you please create RM cases for the same, it will be easy to track >> those issues? >> We're using "https://redmine.postgresql.org/projects/pgadmin4/" for the >> same. >> >> -- >> >> Thanks & Regards, >> >> Ashesh Vashi >> EnterpriseDB INDIA: Enterprise PostgreSQL Company >> >> >> >> *http://www.linkedin.com/in/asheshvashi* >> >> >> On Wed, May 25, 2016 at 6:42 AM, Thom Brown wrote: >> >>> On 25 May 2016 at 02:00, Thom Brown wrote: >>> > On 25 May 2016 at 00:29, Thom Brown wrote: >>> >> On 24 May 2016 at 19:09, Ashesh Vashi >>> wrote: >>> >>> >>> >>> On Mon, May 23, 2016 at 6:35 PM, Murtuza Zabuawala >>> >>> wrote: >>> >>>> >>> >>>> Hi, >>> >>>> >>> >>>> PFA patch, which will fixes below mentioned issues, >>> >>> >>> >>> Committed. >>> >> >>> >> >>> >> In the Create Table dialog, on the Advanced tab, the "Of type" >>> drop-down >>> >> lists tables and composite types, but those are supposed to just be >>> >> composite types. >>> >> >>> >> Also, when using OF in CREATE TABLE, LIKE is no longer valid, so LIKE >>> should >>> >> be disabled when using OF. Also, there should probably be a way of >>> setting >>> >> options for the columns taken from the composite type. For example: >>> >> >>> >> CREATE TYPE inventory AS (product_id bigint, product_name text, weight >>> >> numeric); >>> >> >>> >> CREATE TABLE stock OF inventory ( >>> >> PRIMARY KEY (product_id), >>> >> weight WITH OPTIONS DEFAULT 0 >>> >> ); >>> >> >>> >> There's currently no way of doing this (neither the primary key, nor >>> the >>> >> default value for any columns). It should probably automatically >>> populate >>> >> the columns from the composite type on the columns tab. >>> >> >>> >> Also, could the generated SQL have an empty line between each >>> statement? >>> > >>> > Another thing I've noticed is that, when adding columns, the "Is >>> > primary key?" column is greyed out. Why not just make those >>> > modifiable in that view rather than having to go into the details for >>> > each column? >>> > >>> > When there's something that hasn't been set up correctly, like adding >>> > variables for a column, but not actually selecting a variable, the SQL >>> > pane, correctly, doesn't show an output, but the error message, >>> > "Please provide input for variable." isn't enough to identify what >>> > needs checking. Could the relevant tab and field/row be >>> > highlighted/coloured in red/bold? This is more general, so doesn't >>> > just apply to the create table dialog. >>> >>> Last issue today: >>> >>> When using "Of type", it's not valid to allow additional columns to be >>> added, so those should be prevented. >>> >>> Thom >>> >> >> > --001a1140bfb87911a30533acd4da Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Thanks.

On May 25, 2016 21:01, "Thom Brown" &l= t;thom@linux.com> wrote:
Thank= s.=C2=A0 I've raised all of these in tickets 1231 to 1237.

Thom

On 25 May 2016 at 04:23, Ashesh Vashi <ashesh.vashi@enterpri= sedb.com> wrote:
Hi Thom,

Can you please create RM cases for the= same, it will be easy to track those issues?
We're using &qu= ot;https://redmine.postgresql.org/projects/pgadmin4/" for the= same.

<= div>

--

Thanks & Regards,

Ashesh = Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Wed, May 25, 2016 at 6:4= 2 AM, Thom Brown <thom@linux.com> wrote:
On 25 May 2016 at 02:00, Thom Brown <thom@linux.com> wrote:
> On 25 May 2016 at 00:29, Thom Brown <thom@linux.com> wrote:
>> On 24 May 2016 at 19:09, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
>>>
>>> On Mon, May 23, 2016 at 6:35 PM, Murtuza Zabuawala
>>> <murtuza.zabuawala@enterprisedb.com> wrote:
>>>>
>>>> Hi,
>>>>
>>>> PFA patch, which will fixes below mentioned issues,
>>>
>>> Committed.
>>
>>
>> In the Create Table dialog, on the Advanced tab, the "Of type= " drop-down
>> lists tables and composite types, but those are supposed to just b= e
>> composite types.
>>
>> Also, when using OF in CREATE TABLE, LIKE is no longer valid, so L= IKE should
>> be disabled when using OF.=C2=A0 Also, there should probably be a = way of setting
>> options for the columns taken from the composite type.=C2=A0 For e= xample:
>>
>> CREATE TYPE inventory AS (product_id bigint, product_name text, we= ight
>> numeric);
>>
>> CREATE TABLE stock OF inventory (
>>=C2=A0 =C2=A0 =C2=A0PRIMARY KEY (product_id),
>>=C2=A0 =C2=A0 =C2=A0weight WITH OPTIONS DEFAULT 0
>> );
>>
>> There's currently no way of doing this (neither the primary ke= y, nor the
>> default value for any columns).=C2=A0 It should probably automatic= ally populate
>> the columns from the composite type on the columns tab.
>>
>> Also, could the generated SQL have an empty line between each stat= ement?
>
> Another thing I've noticed is that, when adding columns, the "= ;Is
> primary key?" column is greyed out.=C2=A0 Why not just make those=
> modifiable in that view rather than having to go into the details for<= br> > each column?
>
> When there's something that hasn't been set up correctly, like= adding
> variables for a column, but not actually selecting a variable, the SQL=
> pane, correctly, doesn't show an output, but the error message, > "Please provide input for variable." isn't enough to ide= ntify what
> needs checking.=C2=A0 Could the relevant tab and field/row be
> highlighted/coloured in red/bold?=C2=A0 This is more general, so doesn= 't
> just apply to the create table dialog.

Last issue today:

When using "Of type", it's not valid to allow additional colu= mns to be
added, so those should be prevented.

Thom


--001a1140bfb87911a30533acd4da--