Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bL32A-0008Us-SB for pgadmin-hackers@arkaria.postgresql.org; Thu, 07 Jul 2016 06:43:38 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bL32A-0007Ul-B0 for pgadmin-hackers@arkaria.postgresql.org; Thu, 07 Jul 2016 06:43:38 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bL31x-0007Go-AB for pgadmin-hackers@postgresql.org; Thu, 07 Jul 2016 06:43:25 +0000 Received: from mail-it0-x22f.google.com ([2607:f8b0:4001:c0b::22f]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bL31u-0001wG-9a for pgadmin-hackers@postgresql.org; Thu, 07 Jul 2016 06:43:24 +0000 Received: by mail-it0-x22f.google.com with SMTP id j185so93266245ith.0 for ; Wed, 06 Jul 2016 23:43:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=tX+Xg/SM4PF+Dfs0cpNLwu0e8MrV7a+c8LRqTtU8Hys=; b=RiWGozmVdldk8utrCvOpFohayiIzI4UCR3JUz3fXUkVSqADrKrzvXK09D0xYq9Ro87 E+aG6DBfubOTFNcnj1DLubPcfDGTG57qn1ph0IHnIHBEzdcg5tposgtl7JPm5LWK3rIk YTevWlebWAlzPl4/Ob9KqFHkUUDU62zJZOO2sFdvMm0f2LB3zxsCcg+cx1V8AGHOFI5G hjxpAWm0lSqv3VbMZGTM6SrVC7pNS72e4Tscsmws1HLYssH1aaxku1PleBawhpm0xNXy iBkwWmYlEG009uM8AFUkxVbXZv6GCslyIAkx5MiQFI7OeHq/FEvUHChCEt4dBcsG6a17 G+Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=tX+Xg/SM4PF+Dfs0cpNLwu0e8MrV7a+c8LRqTtU8Hys=; b=S81tFIRbTn00xjBqlDiLo5C1ABWNVwtAY1VMsJuasaAF0arbYCm0OUCRuZqK/Db0ca rjhp4YLalQnb81JXUPwmlTwj9oBi0mFSVe28nolUmhwPN7tmD4YfVLUBiQsFDIRgbEuh 5PlZIalEDw24oGkfQ0FIryZ6EZXAiWDitO2JuZpDG+0FIGIAtGI1vPWmHkq1B7W1DqQV 3qhxYZiNdCLBEZNrTQxIeJSClW8ZFdqcmdShjM624BLWVprtiZvxN7RoFtfhH15cSKIS 4TNTnjvW46bnFlB1MziDN+t33qowAHnwTJmWTwt0bevgIH1MdqDC8AvJmlaB4/GPspJy awQg== X-Gm-Message-State: ALyK8tKxtYe84PJK7LNnfoMXtJFZjS4BAcmJbpYm5ZtqOLTNj63qHLBkPAJWyFf/VC9wLlwoxc2ONyMecUtFpaio X-Received: by 10.36.153.66 with SMTP id a63mr1055951ite.73.1467873801122; Wed, 06 Jul 2016 23:43:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.133.217 with HTTP; Wed, 6 Jul 2016 23:43:01 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Thu, 7 Jul 2016 12:13:01 +0530 Message-ID: Subject: Re: patch for issue RM1260 [pgAdmin4] To: Harshal Dhumal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=94eb2c0894d67dc9ef05370600eb X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c0894d67dc9ef05370600eb Content-Type: text/plain; charset=UTF-8 Hi Harshal, Can you please explain - what was missing in the last patch? -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Thu, Jul 7, 2016 at 12:12 PM, Harshal Dhumal < harshal.dhumal@enterprisedb.com> wrote: > Hi, > > PFA updated patch for issue RM1260 > > -- > *Harshal Dhumal* > *Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Thu, Jul 7, 2016 at 12:04 PM, Harshal Dhumal < > harshal.dhumal@enterprisedb.com> wrote: > >> Hi, >> Please ignore this patch as this has some minor issue. I'll sent updated >> one. >> >> -- >> *Harshal Dhumal* >> *Software Engineer* >> >> EnterpriseDB India: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> On Wed, Jul 6, 2016 at 5:30 PM, Harshal Dhumal < >> harshal.dhumal@enterprisedb.com> wrote: >> >>> Hi, >>> >>> PFA patch for issue RM1260. >>> >>> Changes: Issue wasn't related to foreign table but was due the Select2 >>> control. Now I have improved select2 control to handle null value in >>> multi-select mode. Initial it was returning "null" instead it should return >>> [] (empty array). >>> >>> >>> -- >>> *Harshal Dhumal* >>> *Software Engineer* >>> >>> EnterpriseDB India: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > --94eb2c0894d67dc9ef05370600eb Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Harshal,

Can you please explain - wh= at was missing in the last patch?

--

Thanks & Regards,

= Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Thu, Jul 7, 2016 at 12:12 PM, Harshal Dhu= mal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA= updated patch for issue RM1260

--=C2=A0
<= b>Harshal Dhumal
Software Engineer

Enterp= riseDB India:=C2=A0http://www.enterp= risedb.com
The Enterprise PostgreSQL = Company

On Thu, Jul 7, 2016 = at 12:04 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com= > wrote:
H= i,
Please ignore this patch as this has some minor issue. I'll sent= updated one.

--=C2=A0
Harshal Dhumal
<= div>Software Engineer

EnterpriseDB India:=C2=A0<= a href=3D"http://www.enterprisedb.com/" style=3D"color:rgb(17,85,204);font-= size:12.8px" target=3D"_blank">http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 6, 2016 at 5:30= PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com>= wrote:
Hi,

PFA patch for issue RM1260.

Changes: Issue w= asn't related to foreign table but was due the Select2 control. Now I h= ave improved select2 control to handle null value in multi-select mode. Ini= tial it was returning "null" instead it should return [] (empty a= rray).


--=C2=A0
Harshal Dhumal
=
Software Engineer

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company




--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=


--94eb2c0894d67dc9ef05370600eb--