Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b5Gm9-0003TX-6f for pgadmin-hackers@arkaria.postgresql.org; Tue, 24 May 2016 18:09:53 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1b5Gm8-0001ai-Kz for pgadmin-hackers@arkaria.postgresql.org; Tue, 24 May 2016 18:09:52 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1b5Gm7-0001Yv-H1 for pgadmin-hackers@postgresql.org; Tue, 24 May 2016 18:09:51 +0000 Received: from mail-io0-x22d.google.com ([2607:f8b0:4001:c06::22d]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1b5Gm2-00009J-AT for pgadmin-hackers@postgresql.org; Tue, 24 May 2016 18:09:51 +0000 Received: by mail-io0-x22d.google.com with SMTP id p64so17290698ioi.2 for ; Tue, 24 May 2016 11:09:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=YWGtd8miYHM/EXOpwEWmUdvqfnQEy1Ofb0tBPlJR2vY=; b=HPBby2npkGNkClHsaP5FOLTP7dRPDNOrxD+VDTfLZQFeGxkxuNiIaqfRYL/yuNh+vM cbXZ+duXJ3sh70IgPDKIZseewWEHNTkATki0HSCoeaSCryB4YxdFgpmifg8kx/YGw8nQ /fOqnmpeqxTH/meekxE2fYluSYLDOxGLBG0kYJh1xZ3VbVRWk97HKikz/6+8J22LyX5l bwzPUGrHDSJ9MBQBLp+VLHOdXvQrwDVBuHsrTrtxWKS9Neq9+vrdftUmTKTnFA1I5Mev fL4rffGLqVo/imxUfgNJuWNuVCieK7m8mVezxuzIsBVfyl/KLxWc6srJEDjrnluL46TC y0Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=YWGtd8miYHM/EXOpwEWmUdvqfnQEy1Ofb0tBPlJR2vY=; b=TCMBdj1DuNWzsQgXR8Mq0DVjlvvOC7suF6htY3KaBHUVOiMvb+LX5ZBKCMavX4CF19 8qH6i4urblVqU5uz80uyItV+tYF9yZl1xd24LEsEUdMVhP729XFLZBi7nvrJJ2i/h1o2 Q2hfgbi9np5j1+qB49tSfizOLRHSf9flrnQJqFv0agAzq087VJUxXflvUNJCbC3LbSS+ ZcIpf4JvoMMNg0zST62qVNHlFXeoI8ESdMGcprJkj2V8v3azP9/iYl7y+dXZZPnELvoY 2aFPsd+27GGYzw20QPxsUeAaMeK4wqtnIVkjxaBt5B4bGqa02WyONO6fPzK6VZO+wSB1 lp4w== X-Gm-Message-State: ALyK8tId0rGK2HTmJhjczTHVtNY6EAIYnPQ6VhoFB6alZUeSRu1W4MXFYLmktfYYFCZJBUDGZ58l6rEME9JcRq5X X-Received: by 10.107.161.206 with SMTP id k197mr103063ioe.149.1464113384249; Tue, 24 May 2016 11:09:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.142.86 with HTTP; Tue, 24 May 2016 11:09:24 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Tue, 24 May 2016 23:39:24 +0530 Message-ID: Subject: Re: [PATCH] Tables node (pgAdmin4) To: Murtuza Zabuawala Cc: Dave Page , Akshay Joshi , Harshal Dhumal , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a1140f9882e6d0605339a76d5 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1140f9882e6d0605339a76d5 Content-Type: text/plain; charset=UTF-8 On Mon, May 23, 2016 at 6:35 PM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi, > > PFA patch, which will fixes below mentioned issues, > Committed. > > - Fixed all the review comments given by Dave on tables & its child nodes. > Can you please list down, what has not yet been taken care in the review comments? > > *Additional enhancements* > - In Index node, We have updated the way columns were added, > earlier it was using subnode control now we can insert/update > values in-place using DepsCell functionality > > - In Type node, We have updated the way Composite types were added, > earlier it was using subnode control now we can insert/update > values in-place using DepsCell functionality > > - In Constraints nodes, Updated error messages handling earlier it was > throwing error when we open create dialog and no input has been > provided by user. > > > *Affected nodes by this patch:* > > > 1. Table > 2. Column > 3. Check constraint > 4. Exclusion constraint > 5. Foreign key > 6. Primary key > 7. Unique > 8. Index > 9. Trigger > 10. Type > 11. Materialized view > > -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* > > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Sat, May 21, 2016 at 2:45 PM, Dave Page wrote: > >> I think that makes sense, yes. >> >> Sent from my iPad >> >> On 21 May 2016, at 04:12, Ashesh Vashi >> wrote: >> >> >> On Sat, May 21, 2016 at 12:01 AM, Dave Page wrote: >> >>> Hi >>> >>> I just started to take a look at the table dialogue and friends. Here >>> are a few issues that we need to address - please take care of them: >>> >>> 1) Move columns to their own tab. Vertical scrolling is bad. >>> >> Should the 'inherit from table' part of columns tab? >> >>> >>> 2) Similarly, move constraints to their own tab. >>> >>> 3) Ensure all labels only have a capital letter on the first word, >>> except if following words are keywords or acronyms, e.g. >>> >>> With default values? >>> Has OIDs? >>> >>> 4) s/System tabel?/System table? >>> >>> 5) Error messages on fields should not be shown unless the field loses >>> focus and has an error (see Create Table) >>> >>> 6) The sections on the Properties view are not as they should be. As >>> I've pointed out before, the "General" section should have a limited subset >>> of information, e.g. name, oid, owner, tablespace, comment and "is system?" >>> Other properties should be in other appropriate sections. >>> >>> 7) Variables grids should not be on the Security tab (as also mentioned >>> previously). >>> >>> 8) Field labels that imply a question (e.g. usually those with a Yes/No >>> switch for input) should end in a ? - e.g. "Deferrable?" >>> >>> 9) On the Trigger dialogue, "Fires" and following controls should move >>> to a new tab. >>> >>> 10) On the MV dialogue, VACUUM settings should be on their own tab, as >>> on the Table dialogue. >>> >>> 11) Privileges controls on the Properties lists should be in a >>> "Security" group, not "General" >>> >>> I think there are a couple of basic principles to follow here: >>> >>> - Make properties lists and dialogues consistent with existing ones, >>> from control grouping right down to spelling and case of labels. >>> >>> - Dialogs should never need vertical scrolling by default (e.g. for a >>> new object with no columns/constraints/whatever yet defined). If you need >>> to scroll, then things should be moved to a new tab, grouped as appropriate. >>> >>> Thanks. >>> >>> On Fri, May 20, 2016 at 7:57 AM, Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> Thanks - Committed with minor changes. >>>> >>>> On Thu, May 19, 2016 at 10:47 PM, Harshal Dhumal < >>>> harshal.dhumal@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> PFA updated patch for table and all it's child nodes (Version 9). This >>>>> patch does not depend on any of existing table node patch. >>>>> >>>>> Major change in this patch: Unlike pgAdmin3 now in table create mode >>>>> any constraint(s) created (but not saved) will listen to table column >>>>> changes and adapt themselves accordingly. >>>>> >>>>> For e.g. >>>>> In table create mode user adds column definition with name "col1" then >>>>> adds constraint which includes column "col1". Now user changes column name >>>>> to "col2" then constraint will listen to this change and adapt the column >>>>> name from "col1" to "col2" in constraint definition. Also if column "col2" >>>>> is removed then constraint will also remove the column "col2" from it's >>>>> definition. >>>>> >>>>> >>>>> -- >>>>> *Harshal Dhumal* >>>>> *Software Engineer * >>>>> >>>>> >>>>> >>>>> EenterpriseDB >>>>> >>>>> >>>>> >>>>> -- >>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>>>> To make changes to your subscription: >>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>> >>>>> >>>> >>>> >>>> -- >>>> *Akshay Joshi* >>>> *Principal Software Engineer * >>>> >>>> >>>> >>>> *Phone: +91 20-3058-9517 <%2B91%2020-3058-9517>Mobile: +91 976-788-8246* >>>> >>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > --001a1140f9882e6d0605339a76d5 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On Mon, May 23, 2016 at 6:35 PM, Murtuza Zabuawala &= lt;= murtuza.zabuawala@enterprisedb.com> wrote:

H= i,

PFA patch, which will fixes below mentioned issu= es,
Committed.=C2=A0

- Fixed all the review comment= s given by Dave on tables & its child nodes.
Can you please list down, what has not yet been taken care in the = review comments?

Additional enhancements
- In Index node, We have upd= ated the way columns were added,=C2=A0
=C2=A0 earlier it was usin= g subnode control now we can insert/update=C2=A0
=C2=A0 values in= -place using DepsCell functionality

- In Type node= , We have updated the way Composite types were added,
=C2=A0 earl= ier it was using subnode control now we can insert/update=C2=A0
= =C2=A0 values in-place using DepsCell functionality

- In Constraints nodes, Updated error messages handling earlier it was=C2= =A0
=C2=A0 throwing error when we open create dialog and no input= has been
=C2=A0 provided by user.


Affected nodes by this patch:

  1. Table
  2. Column
  3. Check constr= aint
  4. Exclusion constraint
  5. Foreign key
  6. P= rimary key
  7. Unique
  8. Index
  9. Trigger
  10. Type
  11. Materialized view
<= p style=3D"margin:0pt">--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:=C2=A0Enterprise PostgreSQL Company


=C2=A0


--
Regards,<= /span>
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Co= mpany

On Sat, May 21, 2016 at 2:45 PM, Dave Page <= span dir=3D"ltr"><dpage@pgadmin.org> wrote:
I think that makes sense, yes.

Sent from my iPad
=
On 21 May 2016, at 04:12, Ashesh Vashi <ashesh.vashi@enterprisedb.com>= ; wrote:


On Sat, May 21, 2016 at 12:01 AM, Dave Page <dpage@pgadmi= n.org> wrote:
Hi
I just started to take a look at the table dialogue and fr= iends. Here are a few issues that we need to address - please take care of = them:

1) Move columns to their own tab. Vertical s= crolling is bad.
Should the 'inherit= from table' part of columns tab?=C2=A0

2) Similarly, move constraints to their o= wn tab.

3) Ensure all labels only have a capital l= etter on the first word, except if following words are keywords or acronyms= , e.g.

=C2=A0 With default values?
=C2= =A0 Has OIDs?
=C2=A0=C2=A0
4) s/System tabel?/System ta= ble?

5) Error messages on fields should not be sho= wn unless the field loses focus and has an error (see Create Table)

6) The sections on the Properties view are not as they sh= ould be. As I've pointed out before, the "General" section sh= ould have a limited subset of information, e.g. name, oid, owner, tablespac= e, comment and "is system?" Other properties should be in other a= ppropriate sections.

7) Variables grids should not= be on the Security tab (as also mentioned previously).

8) Field labels that imply a question (e.g. usually those with a Yes/= No switch for input) should end in a ? - e.g. "Deferrable?"
=

9) On the Trigger dialogue, "Fires" and follo= wing controls should move to a new tab.

10) On the= MV dialogue, VACUUM settings should be on their own tab, as on the Table d= ialogue.

11) Privileges controls on the Properties= lists should be in a "Security" group, not "General"

I think there are a couple of basic principle= s to follow here:

- Make properties lists and dial= ogues consistent with existing ones, from control grouping right down to sp= elling and case of labels.

- Dialogs should never = need vertical scrolling by default (e.g. for a new object with no columns/c= onstraints/whatever yet defined). If you need to scroll, then things should= be moved to a new tab, grouped as appropriate.

Th= anks.

On Fri, May 20, 2016 at 7:57 AM, Akshay Joshi &= lt;aksha= y.joshi@enterprisedb.com> wrote:
Thanks - Committed with minor changes.

On Thu, May 19, 2016 at 10:47= PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com>= wrote:
Hi,

PFA updated = patch for table and all it's child nodes (Version 9). This patch does n= ot depend on any of existing table node patch.

Major change in this patch: Unlike pgAdmin3 now in table = create mode any constraint(s) created (but not saved) will listen to table = column changes and adapt themselves accordingly.

For e.g.
In table create= mode user adds column definition with name "col1" then adds cons= traint which includes column "col1". Now user changes column name= to "col2" then constraint will listen to this change and adapt t= he column name from "col1" to "col2" in constraint defi= nition. Also if column "col2" is removed then constraint will als= o remove the column "col2" from it's definition.


--=C2=A0
Harshal Dhumal
Software Engineer=C2=A0


=



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=




--
Akshay = Joshi
Principal Software Engineer=C2=A0
=
=
Phone: +91 20-3058-9517<= br>Mobile: +91 976-788-8246



--
Dave Page
Blog: http://pgsnake.blogspot.= com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The = Enterprise PostgreSQL Company

<= /span>


--001a1140f9882e6d0605339a76d5--