Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fQ3vF-0004yV-DZ for pgadmin-hackers@arkaria.postgresql.org; Tue, 05 Jun 2018 04:50:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fQ3vE-0001eL-H2 for pgadmin-hackers@arkaria.postgresql.org; Tue, 05 Jun 2018 04:50:16 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fQ3qi-0005L7-Vf for pgadmin-hackers@lists.postgresql.org; Tue, 05 Jun 2018 04:45:37 +0000 Received: from mail-ot0-x233.google.com ([2607:f8b0:4003:c0f::233]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fQ3Fi-0001W6-88 for pgadmin-hackers@postgresql.org; Tue, 05 Jun 2018 04:07:28 +0000 Received: by mail-ot0-x233.google.com with SMTP id n1-v6so1122328otf.7 for ; Mon, 04 Jun 2018 21:07:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=mvcVZ/Dk6FAYingOZw4TKJhZalK2paq56NXnB3D60ms=; b=hHgIB9Kehvu3keHUzR5XVSjqR1NwStWTsaBHlKRImnuJ5FVVfiquLNbA2JpJ62iDiO +YxLPLnSJOqPGj76xcXO9sidryg4Env7YztTnLd4hFRz74e0TnbJ4Q6sHAGn3N6Yme2v GLhRIfGhZzg+ZctiCNex8IVzeoeRRML0j67XH6RTVCIVss5UNzn2wgyHD0cv+jTQSz0o s5TJsLPXS/ThngC2iEUgfxJJwoXOOJkWDn8qBt3nBhRMX3DEzKtagc0w6Zc4ZpauMXgn m9EElyFkMjCPj0qP2ykEGgtxHss2PobQI5SU+61pmkpQm+H/E2JnM8TAnRsGgkBC02lo Godg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=mvcVZ/Dk6FAYingOZw4TKJhZalK2paq56NXnB3D60ms=; b=ckBbIvCWLT8TBfgj2MdGLVAIGt5ih5dSWgcQD09mHBsLQY4fIMybR60vr6+zTayNGt wL1KKEXWugG7jJBCxacIBUvnWcHs11+gYoOAIxamYFVWkMU00tN0H+Z/SI/t7zkJ0Rii cxaHMMmk7ovPDRCtdIFHyKrt+7cyU6r9RFbtemv/Y556enUzfWODVWXsWlbiHAwv/VZv PZU5prJ4wSrDdVh2Lb3DL1rYFTnDaviOvzVNP0pE1l/7N33pBXThSRbTG7AIIMsSjicn FyNSMH/wFOrd8owgCah4IBCkv5hZScWRtxf7h+gio1l6EIxcf3kfy22Yi7uDxyGVqzlV vk4Q== X-Gm-Message-State: ALKqPwe5/2ySk1wB22/NFPcL0n/XwQ98TAvfF9kL+49ElLHFJO/hPvUs rIYhjiwLfSMsrknEg7xAxYfcyVRrjTheIqgnyYht+g== X-Google-Smtp-Source: ADUXVKKcRskttF7LWgSY+5YaDFVAgFyEg2/QCIYQ3Uhz9wAKIHA5/m/tnk75UaFQM9uAmd7ZzLPdE7r0mBhfWvu5lZY= X-Received: by 2002:a9d:4343:: with SMTP id y3-v6mr17130326oti.362.1528171641113; Mon, 04 Jun 2018 21:07:21 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ac9:7a54:0:0:0:0:0 with HTTP; Mon, 4 Jun 2018 21:07:00 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Tue, 5 Jun 2018 09:37:00 +0530 Message-ID: Subject: Re: pgAgent 4.0 patch To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000d3237f056ddd2f58" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000d3237f056ddd2f58 Content-Type: text/plain; charset="UTF-8" On Mon, Jun 4, 2018 at 10:04 PM, Dave Page wrote: > Hi > > Can you review the attached please Ashesh? > Hi Dave, Due to the wrong pattern in '.gitignore', it was ignoring the new file 'sql/pgagent--3.4--4.0.sql'. We should ignore only the '*.sql' in the root directory. Something like this. *$ git diff .gitignore* *diff --git a/.gitignore b/.gitignore* *index 9883354..40fe7a9 100644* *--- a/.gitignore* *+++ b/.gitignore* *@@ -6,7 +6,12 @@ CPackSourceConfig.cmake* * Makefile* * cmake_install.cmake* * install_manifest.txt* *-pgagent* *+# Ignore 'pgagent' & 'pgagent.control' in root directory only.* *+/pgagent* *+!/*/pgagent* * pgagent.control* *+!/*/pgagent.control* * *.log* *-*.sql* *+# Ignore '*.sql' files in root directory only.* *+/*.sql* *+!/*/*.sql* And, I am getting the following warning applying the patch. *$ git apply ~/Downloads/pgagent-4.0-update.diff* */Users/asheshvashi/Downloads/pgagent-4.0-update.diff:320: trailing whitespace.* *//* *warning: 1 line adds whitespace errors.* Otherwise - it looks good to me. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi * > > Thanks. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --000000000000d3237f056ddd2f58 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Mon, Jun 4, 2018 at 10:04 PM, Dave Page <dpage@p= gadmin.org> wrote:
Hi

Can you review the attached please Ashesh?
=
Hi Dave,

Due to the wrong pattern in '.gitignore&#= 39;, it was ignoring the new file 'sql/pgagent--3.4--4.0.sql'.
We should ignore only the '*.s= ql' in the root directory.
Something like this.
$=C2=A0git diff .gitignore
diff --git a/.gitignore b/.gitignore
index 9883354..40fe7a9 100644
--- a/.gitignore
+++ b/.gitignore
@@ -6,7 +6,12 @@ C= PackSourceConfig.cmake
=C2=A0Makefile
=C2=A0cmake_install.cmake
=C2=A0install_manifest.txt
= -pgagent
+# Ignore 'pgagent' & 'pgagent.control&= #39; in root directory only.
+/pgagent
+!/*/pgagent
=C2=A0pgagent.control
+!/*/pgagent.control
=C2=A0*.log
-*.sql
+# Ignore '*.sql' files in root directory only.
+/*.sql
<= div>
+!/*/*.sql

And, I am getting the following warning applying the = patch.
$=C2=A0git apply ~/Downloads/pgagent-4.0-update.diff
/Users/= asheshvashi/Downloads/pgagent-4.0-update.diff:320: trailing whitespace.
<= /div>
//
warning: 1 line adds whitespace errors.=

Otherwise - it looks g= ood to me.

--

= Thanks & Regards,=

Ashesh Vashi
<= span style=3D"font-style:italic">EnterpriseDB INDIA:=C2=A0Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi=C2=A0


T= hanks.

<= /div>--
Dave= Page
Blog: ht= tp://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: = http://www.enterp= risedb.com
The Enterprise PostgreSQL Company

--000000000000d3237f056ddd2f58--