Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b01l0-00059n-2q for pgadmin-hackers@arkaria.postgresql.org; Tue, 10 May 2016 07:07:02 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1b01kz-0001gu-LO for pgadmin-hackers@arkaria.postgresql.org; Tue, 10 May 2016 07:07:01 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1b01km-0001Dj-9Q for pgadmin-hackers@postgresql.org; Tue, 10 May 2016 07:06:48 +0000 Received: from mail-ig0-x232.google.com ([2607:f8b0:4001:c05::232]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1b01ki-0001zx-Q7 for pgadmin-hackers@postgresql.org; Tue, 10 May 2016 07:06:47 +0000 Received: by mail-ig0-x232.google.com with SMTP id s8so5080348ign.0 for ; Tue, 10 May 2016 00:06:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=T8NDy/7Pt+r10UkRbACe9Ib8byJ4AXoGT3rH3amxgPo=; b=WT63eYrg0jomcoH7jbMnS2Nqtjh1UpBP53ARGBnrgwNyldCX5SH+4pOoYtpomuoa2L Fg0sVpGyfeeZjCQZK83iu2ZgVnFhEqXzCaOfceb4vmFOR4w+sv/yO4f+lrYgUcwvp/7k RQb24ERQ/vEh8z5K4hZ8Ah1cEZ6DAa4m+EJV7yFwR9oG33ovgnAJcMtPywaZq3BSupPE xdYBH0hPV3emzd9IJhXUjf81Tz0GvaTEQCU9729O0rPHI4X9ygqtJlcg6K/XMSkhZVB7 YtriPaWdvACbfMBbdrWDj9LMOtUjSORef0d5Qv7I8UEqx3PPTT/NM1agxZ16CeRKpNTw zmTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=T8NDy/7Pt+r10UkRbACe9Ib8byJ4AXoGT3rH3amxgPo=; b=IydBqNrw/af2wgmYPIIDsW5c6YzfuSuglpYtT43wmpKn6fzoTQjh9uKzLWP9jAXr0Y qtqli0t4iJeWNs11yd6M6QvGqgMuSGZzjuCGxS5OEfd6cEpHIddjmDwbG2FDM9kmmUtX WHyP/13julad2shFrbmB4hlVibY4z2Y3J7ewusLqwBatjTPjLSUZmrNEfCyaZinLhymL aINJdXzXbmbDFqwOiwVBgldDNxyJ9zykPB+vrb0Y5UG1e2cDmnq0Q4T0C8rus5Surqow k9ZjKK/RedHi4oeoCEgUbg1LHCFZpqlJ+XRvBxaRhQoOO4GUbr6mTTPCHh2chDh5z1wh D39Q== X-Gm-Message-State: AOPr4FXwA/nudCBwkkG5LNq+R4zgPJ1rGdZxKQjq5uePJNZgKpO7kTYRRrdocnQHLAyxCy6nk/bJHOHHvEZunvWO X-Received: by 10.50.111.72 with SMTP id ig8mr15664355igb.35.1462864002834; Tue, 10 May 2016 00:06:42 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.31.209 with HTTP; Tue, 10 May 2016 00:06:23 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Tue, 10 May 2016 12:36:23 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: SQL Tab Validation To: Khushboo Vashi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=089e013a2b543e78cc05327791ee X-Pg-Spam-Score: -1.0 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --089e013a2b543e78cc05327791ee Content-Type: text/plain; charset=UTF-8 Thanks - committed after few tweaks. We will show 'incomplete definition' message instead of 'no change', which was included in your patch. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Tue, May 3, 2016 at 3:46 PM, Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi, > > Do not send the request to the server if a model contains any error on > selection of the SQL Tab, while creating/updating any Node. > > Please find the attached patch for the same. > > Thanks, > Khushboo > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > --089e013a2b543e78cc05327791ee Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thanks - committed after few tweaks.
We will show '= ;incomplete definition' message instead of 'no change', which w= as included in your patch.

--

Thanks & Regards,

= Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL= Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Tue, May 3, 2016 at 3:46 PM, Khushboo Vas= hi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Do not send the request to the server if a model contains any error on sel= ection of the SQL Tab, while creating/updating any Node.

= Please find the attached patch for the same.

Thanks,
<= /div>
Khushboo



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=


--089e013a2b543e78cc05327791ee--