Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1aFxqH-0007y4-6p for pgadmin-hackers@arkaria.postgresql.org; Mon, 04 Jan 2016 05:38:05 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1aFxqG-00037F-JR for pgadmin-hackers@arkaria.postgresql.org; Mon, 04 Jan 2016 05:38:04 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aFxqF-000378-Vv for pgadmin-hackers@postgresql.org; Mon, 04 Jan 2016 05:38:04 +0000 Received: from mail-lb0-x234.google.com ([2a00:1450:4010:c04::234]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1aFxqB-0005AQ-JA for pgadmin-hackers@postgresql.org; Mon, 04 Jan 2016 05:38:03 +0000 Received: by mail-lb0-x234.google.com with SMTP id sv6so146012573lbb.0 for ; Sun, 03 Jan 2016 21:37:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=QpHonyJM/DGgoIDvYWd2gElKWfjvXZA2f7AePAdIecw=; b=GLw/MB+jKp1bY+3PjBlQ0x64meze/Si/KAJpl1jW9WA1H29qeNDSFTdz8/Z3h3XFE0 br1n9Mb/kB7aQukUgsQmTVx0X8wLjEQa13uFIYfpgRRIptfUfRhGql0DhWkSHSkxvdRf /U+NT8g1/gCAnDekPLe3NJY08n5AqM7ECtBQu7IjDRe/nnsVxrVV+aXqV/8qzEzkWwgV I/JNpnjOZjGy/3LvlcpbJXAPNnTCMEDChwE2zVS/yTgJZYxVqo5HwexNxGdGx8pIEymL iLYHYaJ2CW3CRZW50DhQyKoWPlXQOLGwnPXBxHr7aIthl8f9qTrqS7ZVMk5t2zP545AZ KS6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=QpHonyJM/DGgoIDvYWd2gElKWfjvXZA2f7AePAdIecw=; b=WeLEm4nbZmfZOgcNwT6HfavrKVva6IFxY7wtQXbOFIm8SigkvPoon78dSLoYZOmllo 1DWVjipvOHdRbJ+pTUcpcIXpaud3IKxlzGXlfLWaTbAy+AWFtkI6sAnqQSVKn9u+Zvky RUWMqJZMS15WO3aIx3OG+1eH0OSAcWh0GoIC88MVtMYphCf+8wE3Sc1og4TQGTKxO9gA ACENpiTB9BjrWU62skJ428CySH1fuJwy/fKWHmOFeMzezOd67nLN7RYEOabM786Bfyxq V4QkkOYft8KpEoITfsVVBgYWotWwhpKieiUQChKHFRx++GOc7e0WXiWV0B2FsRaMHNva FA+A== X-Gm-Message-State: ALoCoQlTP2FCh3AkAapm9DjOmC5vQMWTPjA9q7Nb1mgEE6vAbY7zvoJoeGAEXHknMz+UghO+35NI5FBykjn7We++3LvNj1TQRTCddb8KL5Qek95eua+qurw= X-Received: by 10.112.140.34 with SMTP id rd2mr31589256lbb.24.1451885878200; Sun, 03 Jan 2016 21:37:58 -0800 (PST) MIME-Version: 1.0 Received: by 10.112.198.5 with HTTP; Sun, 3 Jan 2016 21:37:38 -0800 (PST) In-Reply-To: <28D414BF-856A-4D21-97BE-33EC3AAF6DF7@pgadmin.org> References: <567AA0E4.2030101@math.uni-goettingen.de> <567BDDEC.2070102@math.uni-goettingen.de> <28D414BF-856A-4D21-97BE-33EC3AAF6DF7@pgadmin.org> From: Ashesh Vashi Date: Mon, 4 Jan 2016 11:07:38 +0530 Message-ID: Subject: Re: pgAdmin3: check_option translated in View editing dialog To: Dave Page , Sebastian Albert , Neel Patel Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a11c266200651f305287b8603 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a11c266200651f305287b8603 Content-Type: text/plain; charset=UTF-8 On Wed, Dec 30, 2015 at 4:35 PM, Dave Page wrote: > Ashesh, can you review/commit please? Thanks. > Done. Thanks Sebastian for the report, and Neel for the quick fix. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK:http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On 28 Dec 2015, at 10:43, Neel Patel wrote: > > Hi Dave, > > I have fixed the issue. Can you please review the attached patch file ? > Let me know for any comments. > > @Sebastian - Can you please apply and test the attached patch file ? Let > us know for any issue. > > Thanks, > Neel Patel > > On Thu, Dec 24, 2015 at 5:44 PM, Neel Patel > wrote: > >> Hi Sebastian, >> >> Thank you for the information. Issue is reproduced with the given steps. >> I will submit the patch after the fix. >> >> Thanks, >> Neel Patel >> >> On Thu, Dec 24, 2015 at 5:28 PM, Sebastian Albert < >> albert@math.uni-goettingen.de> wrote: >> >>> -----BEGIN PGP SIGNED MESSAGE----- >>> Hash: SHA256 >>> >>> Hi Neel >>> >>> Thanks for looking into it. Dave is right, it's about the SQL >>> statement not working (because of translation appearing for a sort of >>> keyword) *unless* edited manually. You should not *have to* edit the >>> SQL manually, but due to the issue, you do, no matter what property of >>> the view you are trying to change. >>> >>> So, to reproduce: >>> 1. Create a view >>> 2. Set language of pgAdmin to German >>> 3. Try to change anything on the view, e.g., try to rename it, using >>> the properties dialog. >>> >>> Unless I edit the SQL statement, I am presented an SQL error, which >>> comes from the check_option setting being translated. >>> >>> Happy holidays >>> Sebastian >>> >>> On 24.12.2015 12:20, Dave Page wrote: >>> > On Thu, Dec 24, 2015 at 11:18 AM, Neel Patel >>> > wrote: >>> >> Hi Sebastian, >>> >> >>> >> We have just tried to reproduce the issue but not able to >>> >> understand the issue from the description. >>> >> >>> >> We followed below steps. >>> >> >>> >> 1. Change the language to German. 2. Open the existing View's >>> >> properties and try to change "With check option". 3. Open SQL >>> >> tab - According to change in option, we are able to see and edit >>> >> the query. >>> >> >>> >> Let me know if anything missing in above steps or Can you please >>> >> give steps to understand the issue ? >>> > >>> > Hi Neel, >>> > >>> > I believe the issue is that "no" is being translated to "nein" in >>> > the SQL: >>> > >>> > ALTER VIEW myview SET (check_option=nein); >>> > >>> -----BEGIN PGP SIGNATURE----- >>> Version: GnuPG v2 >>> >>> iQIcBAEBCAAGBQJWe93qAAoJEKZN7hpT3kUKTrgP/1wmrrScAtfvNc269K9+t1sa >>> UKyBfyMFvSgcMgydLC6bjsV5ECN2EVeV/qtNy6tGIlpWppzTtXccQxbKvQiwkyT1 >>> F3MHM6tp869kegB0N2ZU5mzE+8ko/PaFRAISQomSlpxpDsATZ+5nR3VnFnh5DMde >>> 4XYbPvdZWH4Kos9yrWDKTxi5FVHbCvj4m86Qxg8hMlOGUixRDlVx77t1dccchEjq >>> OJRenlQWO9x65iRQbobXJtJddyQLplulc7enBgSJapQahQ4QTqe4RTx7f4Qya2B8 >>> 9bIndvgIvbI08cnss7BQ8iJvK737gMoHc9CscwEAwadaI69/2QAlB4wtwS5bwIZp >>> DIeW+ulNJC40ZX6Ol/QMNZEvm1pBdwncLAUJBaiHht6M9rJcXld99uEPJDfP5wji >>> 2M9WAa3fjyLJFV3d1lA2GYujPgUBAr7KCRcAxgQSXopCj8KICYJzCOkP5skHIPlL >>> zYEMDML3uATmMPbabhy65/mf44WgzjebnQwM86iwnPRbWzfzSrWyK26fm+9CZ6aF >>> kgZvS9bWtQDViS/+6vTMuR3YQK4H+iU88RCIDbrHa8Kn53S8ryglg1f2CKtqrV9z >>> 2bNlK+iCNFxHoz1ApDw0CE8cJTKU31fL/B17+gB/bL6cCtnpzyCjNosRtO7vr89b >>> 7N9Y5AOnyVwbQD42/3EN >>> =KwP3 >>> -----END PGP SIGNATURE----- >>> >> >> > > > --001a11c266200651f305287b8603 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Wed, Dec 30, 2015 at 4:35 PM, Dave Page <dpage@pgadmin.org><= /span> wrote:
Ashesh, can you review/commit please? Thanks.
Done.

Thanks S= ebastian for the report, and Neel for the quick fix.


--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Compa= ny

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi

<= /div>

--=C2=A0
Dave Page
Blog:=C2=A0http://pgsnake.blogspot.com
Twitter: @pgsnake<= br>
EnterpriseDB UK:http://www.enterprisedb.com
The Enterprise PostgreSQL Company=

On 28 Dec 2015, at 10:4= 3, Neel Patel <neel.patel@enterprisedb.com> wrote:

Hi Dave,

I have fix= ed the issue. Can you please review the attached patch file ? Let me know f= or any comments.

@Sebastian - Can you please apply= and test the attached patch file ? Let us know for any issue.
Thanks,
Neel Patel

On Thu, Dec 24, 2015 at 5:44 PM, Neel P= atel <neel.patel@enterprisedb.com> wrote:
Hi Sebastian,=

Thank you for the information. Issue is reproduced with= the given steps.
I will submit the patch after the fix.

Thanks,
Neel Patel

On Thu, Dec 24, 2015 at 5= :28 PM, Sebastian Albert <albert@math.uni-goettingen.de>= ; wrote:
= -----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi Neel

Thanks for looking into it. Dave is right, it's about the SQL
statement not working (because of translation appearing for a sort of
keyword) *unless* edited manually. You should not *have to* edit the
SQL manually, but due to the issue, you do, no matter what property of
the view you are trying to change.

So, to reproduce:
1. Create a view
2. Set language of pgAdmin to German
3. Try to change anything on the view, e.g., try to rename it, using
the properties dialog.

Unless I edit the SQL statement, I am presented an SQL error, which
comes from the check_option setting being translated.

Happy holidays
Sebastian

On 24.12.2015 12:20, Dave Page wrote:
> On Thu, Dec 24, 2015 at 11:18 AM, Neel Patel
> <n= eel.patel@enterprisedb.com> wrote:
>> Hi Sebastian,
>>
>> We have just tried to reproduce the issue but not able to
>> understand the issue from the description.
>>
>> We followed below steps.
>>
>> 1. Change the language to German. 2. Open the existing View's<= br> >> properties and try to change "With check option". 3. Ope= n SQL
>> tab - According to change in option, we are able to see and edit >> the query.
>>
>> Let me know if anything missing in above steps or Can you please >> give steps to understand the issue ?
>
> Hi Neel,
>
> I believe the issue is that "no" is being translated to &quo= t;nein" in
> the SQL:
>
> ALTER VIEW myview SET (check_option=3Dnein);
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJWe93qAAoJEKZN7hpT3kUKTrgP/1wmrrScAtfvNc269K9+t1sa
UKyBfyMFvSgcMgydLC6bjsV5ECN2EVeV/qtNy6tGIlpWppzTtXccQxbKvQiwkyT1
F3MHM6tp869kegB0N2ZU5mzE+8ko/PaFRAISQomSlpxpDsATZ+5nR3VnFnh5DMde
4XYbPvdZWH4Kos9yrWDKTxi5FVHbCvj4m86Qxg8hMlOGUixRDlVx77t1dccchEjq
OJRenlQWO9x65iRQbobXJtJddyQLplulc7enBgSJapQahQ4QTqe4RTx7f4Qya2B8
9bIndvgIvbI08cnss7BQ8iJvK737gMoHc9CscwEAwadaI69/2QAlB4wtwS5bwIZp
DIeW+ulNJC40ZX6Ol/QMNZEvm1pBdwncLAUJBaiHht6M9rJcXld99uEPJDfP5wji
2M9WAa3fjyLJFV3d1lA2GYujPgUBAr7KCRcAxgQSXopCj8KICYJzCOkP5skHIPlL
zYEMDML3uATmMPbabhy65/mf44WgzjebnQwM86iwnPRbWzfzSrWyK26fm+9CZ6aF
kgZvS9bWtQDViS/+6vTMuR3YQK4H+iU88RCIDbrHa8Kn53S8ryglg1f2CKtqrV9z
2bNlK+iCNFxHoz1ApDw0CE8cJTKU31fL/B17+gB/bL6cCtnpzyCjNosRtO7vr89b
7N9Y5AOnyVwbQD42/3EN
=3DKwP3
-----END PGP SIGNATURE-----


<View_Fix.= patch>

--001a11c266200651f305287b8603--