Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1ZfQ8V-0002MU-SH for pgadmin-hackers@arkaria.postgresql.org; Fri, 25 Sep 2015 10:21:52 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1ZfQ8V-0005NU-EN for pgadmin-hackers@arkaria.postgresql.org; Fri, 25 Sep 2015 10:21:51 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1ZfQ8U-0005NJ-Q1 for pgadmin-hackers@postgresql.org; Fri, 25 Sep 2015 10:21:50 +0000 Received: from mail-la0-f41.google.com ([209.85.215.41]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1ZfQ8R-00047q-KV for pgadmin-hackers@postgresql.org; Fri, 25 Sep 2015 10:21:50 +0000 Received: by lahh2 with SMTP id h2so91913604lah.0 for ; Fri, 25 Sep 2015 03:21:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=Svhm1Y0R4YF4hADo4GiYjYKwJzcvm7eAiNrTmEgkRX4=; b=hlIcIabDTzhC7PCnnbcZvqYOOrjhIcRpQRdZWG74wIXJEWuUjVN2UjSYYdy5NqwN1k 79wnIoIYzgmTGLRyq9jsJJuOIqxv9XkWue8Eo9jTwCE/tAV9qW0W1ELrer0vL6DtTSM/ NUmM5H7avpRqZNxJd/apxDLgTFFmEekhN9H9RjeYU6JD3j3eZPHm8itornHl9erHymvo rG5WbUYEl0km17j6meTOdEIaTLFqiCxznvnIesmCyp5ETCFlRQJAN+FvbulrZYVvu0LM P0AC8n1hGe9ZR8Dw8cyYuu22kM6MHSr2whsMg4n9Gj1i/pE6Qe9Z+yUhydiEDyRimtfl OUQw== X-Gm-Message-State: ALoCoQlMI99J1tsmdrRTN/R3UkV2c1BvJfJZAXbqhu4vyKdSD4nCZu7SQvGV2J7rxM3nhkjAI+p6 X-Received: by 10.25.212.5 with SMTP id l5mr915442lfg.118.1443176506052; Fri, 25 Sep 2015 03:21:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.112.135.42 with HTTP; Fri, 25 Sep 2015 03:21:26 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Fri, 25 Sep 2015 15:51:26 +0530 Message-ID: Subject: Re: [PATCH] Add Commit/Rollback toolbar action version 2 To: Dave Page Cc: John Obaterspok , Sanket Mehta , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a11412922fde95d05208fb62c X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a11412922fde95d05208fb62c Content-Type: text/plain; charset=UTF-8 On Fri, Sep 25, 2015 at 1:30 PM, Ashesh Vashi wrote: > Yup. > It's in my plate, was updating the CHANGELOG only. > Done. Thanks John for the patch, and Sanket for reviewing the patch. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > > > > *http://www.linkedin.com/in/asheshvashi* > > > On Fri, Sep 25, 2015 at 1:28 PM, Dave Page wrote: > >> Ashesh, are you able to deal with this before Monday (when I'll be >> cutting the feature-frozen beta 1 tarballs)? >> >> On Fri, Sep 25, 2015 at 7:03 AM, John Obaterspok < >> john.obaterspok@gmail.com> wrote: >> >>> Thanks, appreciated. >>> >>> Can it be committed then? :) >>> >>> 2015-09-23 9:49 GMT+02:00 Sanket Mehta : >>> >>>> Hi John/Ashesh, >>>> >>>> I have reviewed the patch and it seems fine to me. >>>> >>>> Regards, >>>> Sanket Mehta >>>> Sr Software engineer >>>> Enterprisedb >>>> >>>> On Wed, Sep 23, 2015 at 11:08 AM, John Obaterspok < >>>> john.obaterspok@gmail.com> wrote: >>>> >>>>> Hi Sanket, >>>>> >>>>> Did you give the patch a try? I would really like it to for the next >>>>> release :) >>>>> >>>>> -- john >>>>> >>>>> 2015-09-16 20:27 GMT+02:00 John Obaterspok >>>>> : >>>>> >>>>>> Hi Sanket, >>>>>> >>>>>> Attached patch is rebased now. >>>>>> >>>>>> Regards, >>>>>> >>>>>> -- john >>>>>> >>>>>> >>>>>> 2015-09-16 11:20 GMT+02:00 Sanket Mehta < >>>>>> sanket.mehta@enterprisedb.com>: >>>>>> >>>>>>> Hi John, >>>>>>> >>>>>>> Patch is not proper. >>>>>>> I got below error when I try to apply the patch: >>>>>>> >>>>>>> error: patch failed: pgadmin/frm/frmQuery.cpp:2435 >>>>>>> error: pgadmin/frm/frmQuery.cpp: patch does not apply >>>>>>> >>>>>>> Please do provide the proper patch. >>>>>>> >>>>>>> >>>>>>> Regards, >>>>>>> Sanket Mehta >>>>>>> Sr Software engineer >>>>>>> Enterprisedb >>>>>>> >>>>>>> On Mon, Sep 14, 2015 at 10:51 AM, Sanket Mehta < >>>>>>> sanket.mehta@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Sure Ashesh, >>>>>>>> >>>>>>>> I will review the patch. >>>>>>>> >>>>>>>> Regards, >>>>>>>> Sanket Mehta >>>>>>>> Sr Software engineer >>>>>>>> Enterprisedb >>>>>>>> >>>>>>>> On Mon, Sep 14, 2015 at 1:12 PM, Ashesh Vashi < >>>>>>>> ashesh.vashi@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> Sanket, >>>>>>>>> >>>>>>>>> Can you please take a look at it? >>>>>>>>> >>>>>>>>> -- >>>>>>>>> >>>>>>>>> Thanks & Regards, >>>>>>>>> >>>>>>>>> Ashesh Vashi >>>>>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> *http://www.linkedin.com/in/asheshvashi* >>>>>>>>> >>>>>>>>> >>>>>>>>> On Mon, Sep 14, 2015 at 1:07 AM, John Obaterspok < >>>>>>>>> john.obaterspok@gmail.com> wrote: >>>>>>>>> >>>>>>>>>> Hello, >>>>>>>>>> >>>>>>>>>> I'm updated the patch to add commit/rollback actions in the >>>>>>>>>> toolbar with the following: >>>>>>>>>> 1) updated icons (based on existing pgadmin icon with arrows >>>>>>>>>> drawn by me) >>>>>>>>>> 2) add entry to menu as well >>>>>>>>>> 3) disable icons when not in a transaction >>>>>>>>>> 4) Ctrl+Shift C|R shortcut >>>>>>>>>> >>>>>>>>>> Hopefully all issues are resolved now! >>>>>>>>>> >>>>>>>>>> Regards, >>>>>>>>>> >>>>>>>>>> John >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Sent via pgadmin-hackers mailing list ( >>>>>>>>>> pgadmin-hackers@postgresql.org) >>>>>>>>>> To make changes to your subscription: >>>>>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > --001a11412922fde95d05208fb62c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Fri, Sep 25, 2015 at 1:30 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Yup.
It's in my plate, was up= dating the CHANGELOG only.
Done.

Thanks John for the patch, and Sanket for reviewing the patch.

--

Thanks & Regards,=

Ashesh Vashi
EnterpriseDB INDIA: <= a href=3D"http://www.enterprisedb.com" target=3D"_blank">Enterprise Postgre= SQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi

<= /div>

=

= --

= Thanks & Regards,
Ashesh Vash= i
E= nterpriseDB INDIA: Enterprise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Fri, Sep 25= , 2015 at 1:28 PM, Dave Page <dpage@pgadmin.org> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">
Ashesh, a= re you able to deal with this before Monday (when I'll be cutting the f= eature-frozen beta 1 tarballs)?
<= br>
On Fri, Sep 25, 2015 at 7:03 AM, John Obaters= pok <john.obaterspok@gmail.com> wrote:
Thanks, appreciate= d.=C2=A0

Can it be committed then? :)

2015-09-23 9:4= 9 GMT+02:00 Sanket Mehta <sanket.mehta@enterprisedb.com>= ;:
Hi John/Ashesh,

I have reviewed the patch and it se= ems fine to me.

Regards,
Sanket Mehta
Sr Softwa= re engineer
Enterprisedb

On Wed, Sep 23, 2015 at 11:= 08 AM, John Obaterspok <john.obaterspok@gmail.com> w= rote:
Hi Sanket,

Did you give the patch a try? I would really= like it to for the next release :)

-- john

2015-09-16 20:27 GMT+02:00 John O= baterspok <john.obaterspok@gmail.com>:
Hi Sanket,
Attached patch is rebased now.

Regards= ,

-- john
=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0=C2=A0

2015-09-16 11:20 GMT+02:00 Sanket Mehta = <sank= et.mehta@enterprisedb.com>:
Hi John,

P= atch is not proper.
I got below error when I try to apply the patc= h:

error: patch failed: pgadmin/frm/frmQuery.cpp:2435
error: pgad= min/frm/frmQuery.cpp: patch does not apply

Please do provide t= he proper patch.
=C2=A0

Regards,
Sanket Mehta
= Sr Software engineer
Enterprisedb

On Mon, Sep 14, 2015 at 10:= 51 AM, Sanket Mehta <sanket.mehta@enterprisedb.com> wrote:
Sure Ashesh,

I will review the patch.
<= div class=3D"gmail_extra">
Rega= rds,
Sanket Mehta
Sr Software engineer
Enterprisedb=

On Mon, Sep 14, 2015 at 1:12 PM, Ashesh Vash= i <ashesh.vashi@enterprisedb.com> wrote:
Sanket,=

Can you please take a look at it?

--

Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Mon, Sep 14, 2015 at 1:07 AM, J= ohn Obaterspok <john.obaterspok@gmail.com> wrote:
Hello,

I'm updated the patch to add c= ommit/rollback actions in the toolbar with the following:
1) updated ic= ons (based on existing pgadmin icon with arrows drawn by me)
2) a= dd entry to menu as well
3) disable icons when not in a trans= action
4) Ctrl+Shift C|R shortcut

Hopefu= lly all issues are resolved now!

Regards,

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 John



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=











<= /div>--
Dave Page
Blog: http://pgsnake.blogspot.= com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The = Enterprise PostgreSQL Company

--001a11412922fde95d05208fb62c--