Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1ZecLz-000817-87 for pgadmin-hackers@arkaria.postgresql.org; Wed, 23 Sep 2015 05:12:27 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1ZecLy-0007KQ-QH for pgadmin-hackers@arkaria.postgresql.org; Wed, 23 Sep 2015 05:12:26 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1ZecLk-0006pd-OA for pgadmin-hackers@postgresql.org; Wed, 23 Sep 2015 05:12:13 +0000 Received: from mail-la0-f52.google.com ([209.85.215.52]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1ZecLh-0007th-Qi for pgadmin-hackers@postgresql.org; Wed, 23 Sep 2015 05:12:11 +0000 Received: by lagj9 with SMTP id j9so37176560lag.2 for ; Tue, 22 Sep 2015 22:12:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=PnEdVmeIBb4zaTRsvV/gTtlbQMEnmb4P1CikhUXXl6w=; b=JjPC2PJFDfcYOS2rNrsn7pMNwhz6HL3maQ5s0ngBOLIYipPUdiuo3y9RsRsuQm5GEJ xgO1m3lKwKxNMMYyvIkxFnmxx8MPzZ6x088H+lQwiXh9jvoEEwXkmHC3e/Y07aocnjYv KG+vd+xt/RV/SDpXbz/ZDgcS1gCxNSCRO7cLrUumWzMmqCkOC0CHIe7Gp2VqrHx+OkIa M0BNR2aLPHHxqZ7ghRxMzY861rwQA02TtsfZOEiZvWkVxgPTdnJ2utqO4fCT/MRPoFDA nGDRs7KaOqrKWHDuFH2I0sOqr1mYWGgo4E0FYyQC66yF/Q0MJoRvm2sNOdZPw2YIjk0V V8Jg== X-Gm-Message-State: ALoCoQmXW3itQqFTuJo3j/YhhwUKtm46hH8eH7JrM9gd5AZV5z8uVqYZarJKJwvecgnE4XdNaR8I X-Received: by 10.152.23.199 with SMTP id o7mr9106987laf.76.1442985127844; Tue, 22 Sep 2015 22:12:07 -0700 (PDT) MIME-Version: 1.0 Received: by 10.112.135.42 with HTTP; Tue, 22 Sep 2015 22:11:48 -0700 (PDT) In-Reply-To: References: <87246063.20150923075305@mail.ru> From: Ashesh Vashi Date: Wed, 23 Sep 2015 10:41:48 +0530 Message-ID: Subject: Re: pgAdmin III commit: Resolved an issue related enable/disable menu items To: "J.F. Oster" Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=089e0158c95af6285305206327d9 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --089e0158c95af6285305206327d9 Content-Type: text/plain; charset=UTF-8 On Wed, Sep 23, 2015 at 10:36 AM, Ashesh Vashi < ashesh.vashi@enterprisedb.com> wrote: > > On Wed, Sep 23, 2015 at 10:27 AM, Ashesh Vashi < > ashesh.vashi@enterprisedb.com> wrote: > >> On Wed, Sep 23, 2015 at 10:23 AM, J.F. Oster wrote: >> >>> Hi Ashesh, >>> >>> Favourite's issue is resolved, but looks like Edit - Cut/Copy/Paste >>> items are disabled all the time (seen on Ubuntu, Kubuntu). >>> >> I've tested the patch couple of times on Ubuntu, and OSX both before >> committing the changes. >> >> Do you have time to look into it? >> > Got the reason. > Thanks for the report. > Thanks once again. Please check now. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* > > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > > > > *http://www.linkedin.com/in/asheshvashi* > > > >> >> -- >> >> Thanks & Regards, >> >> Ashesh Vashi >> EnterpriseDB INDIA: Enterprise PostgreSQL Company >> >> >> >> *http://www.linkedin.com/in/asheshvashi* >> >> >>> >>> Tuesday, September 22, 2015, 10:56:32 AM, you wrote: >>> >>> AV> Resolved an issue related enable/disable menu items in Query Editor >>> AV> specifically for Unity Desktop Environment. >>> >>> AV> wxWidgets was not able to identify the current focused control in >>> some >>> AV> cases, during certain event generation. And, that was resulting into >>> AV> disabling the wrong menu items. >>> AV> i.e. >>> AV> Copy, Paste, Undo, Redo, Cut, Paste, Add/Manage favourite menu(s) >>> >>> AV> In order to resolve the issue, we will not consider the events >>> AV> generated, but - no control gets focused, while enabling/disabling >>> the >>> AV> menus. >>> >>> AV> Branch >>> AV> ------ >>> AV> master >>> >>> AV> Details >>> AV> ------- >>> AV> >>> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=cd9f615564334ed91d4760c971beae249cf9bd83 >>> >>> AV> Modified Files >>> AV> -------------- >>> AV> CHANGELOG | 3 +++ >>> AV> pgadmin/frm/frmQuery.cpp | 59 >>> AV> +++++++++++++++++++++++++++------------------- >>> AV> 2 files changed, 38 insertions(+), 24 deletions(-) >>> >>> >>> >>> >>> >>> -- >>> Best regards, >>> J.F. >>> >>> >> > --089e0158c95af6285305206327d9 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Wed,= Sep 23, 2015 at 10:36 AM, Ashesh Vashi <ashesh.vashi@enterpri= sedb.com> wrote:
=

= On Wed, Sep 23, 2015 at 10:27 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
=
On Wed, Sep 23, 2015 at 10:23 AM, J.F. Os= ter <jinfroster@mail.ru> wrote:
Hi Ashesh,

Favourite's issue is resolved, but looks like Edit - Cut/Copy/Paste
items are disabled all the time (seen on Ubuntu, Kubuntu).
=
I've tested the patch couple of times on Ubuntu, and OSX bo= th before committing the changes.

Do you have = time to look into it?
G= ot the reason.
Thanks for the report.
=
Thanks once again.
Please check now.

--=

Thanks & Regards,

<= span style=3D"font-style:italic">Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL = Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi

<= /div>

--=

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company=

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi

<= /div>

Tuesday, September 22, 2015, 10:56:32 AM, you wrote:

AV> Resolved an issue related enable/disable menu items in Query Editor<= br> AV> specifically for Unity Desktop Environment.

AV> wxWidgets was not able to identify the current focused control in so= me
AV> cases, during certain event generation. And, that was resulting into=
AV> disabling the wrong menu items.
AV> i.e.
AV> Copy, Paste, Undo, Redo, Cut, Paste, Add/Manage favourite menu(s)
AV> In order to resolve the issue, we will not consider the events
AV> generated, but - no control gets focused, while enabling/disabling t= he
AV> menus.

AV> Branch
AV> ------
AV> master

AV> Details
AV> -------
AV> http://git.postgresql.org/gitweb?p=3Dpgadmin3.git;a=3Dcommi= tdiff;h=3Dcd9f615564334ed91d4760c971beae249cf9bd83

AV> Modified Files
AV> --------------
AV> CHANGELOG=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |= =C2=A0 =C2=A0 3 +++
AV> pgadmin/frm/frmQuery.cpp |=C2=A0 =C2=A059
AV> +++++++++++++++++++++++++++-------------------
AV> 2 files changed, 38 insertions(+), 24 deletions(-)





--
Best regards,
=C2=A0J.F.




--089e0158c95af6285305206327d9--