Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b2vfl-0000kB-Uo for pgadmin-hackers@arkaria.postgresql.org; Wed, 18 May 2016 07:13:38 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1b2vfl-0004z5-HD for pgadmin-hackers@arkaria.postgresql.org; Wed, 18 May 2016 07:13:37 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1b2vfY-0004kC-6C for pgadmin-hackers@postgresql.org; Wed, 18 May 2016 07:13:24 +0000 Received: from mail-io0-x22c.google.com ([2607:f8b0:4001:c06::22c]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1b2vfT-0006v4-8n for pgadmin-hackers@postgresql.org; Wed, 18 May 2016 07:13:23 +0000 Received: by mail-io0-x22c.google.com with SMTP id 190so53877701iow.1 for ; Wed, 18 May 2016 00:13:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=e7hIHCfAkUIiNkR8h/T6aFDPrgTEQs44jm7hRVTfg1k=; b=daOCZDfu4PgcfnMuyfF7x/BEEUO5dcXRhUyXg6z05KpvIcPcbUkp3blh5bKvm89POz yD9orh1xcdBOmee/cbMOhVhiO4QwYp1ZJ9YDFo8Ngp7tIYBOJp7LH7mR03ZqnLetTn8T xmSn3URRKFVyfwTqg8Gf8tld6q95ai70mYy+j1e8lWpMEvcfl7S86VX+dN0aLfQaHPhQ C7mk+0rb3LYtk7ydO9O186qMJ2miQzomWHk9cineL4zj2XmrJkhe796C2oEyUjV5KL/H cF+htNJ1woYx3JD1R2Ku/gMeNZDh6M+b6i72FLN75qzYbEaQJt+5eRK/OEm6nAj5pG4z 2G+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=e7hIHCfAkUIiNkR8h/T6aFDPrgTEQs44jm7hRVTfg1k=; b=PqeVM/AcqYTIxj3IMuAZfa/Q8+FMAZ8lugjefvgFp4KmroBZhMgK1WiYcL8HIgfsdK jwPJC7BmlIUGcsKVDKms7/CiRoLVxI3bPjDUWVUQUEn0IRK8fHxRuatIrPKPBqvpxsYJ YMOkHeUrpSbHlH3+JOfVTaTk9uU2X956Ba5PzsMmZz8s/TUE7Pdqa9+we1M5hnF1IzxD mf3oZRAAL/nXobP0K6MfJ5Zd2ItMCjsnBGxMelNxQ5lBePy1lKJrjci8Bw03/E4zTaT/ lqTTdax7QvVHMZyljyO35c1glXY+2KUipIP3KeZJWeYxlqhJk6AkU6QdWHixmhe6wgJa 0d4A== X-Gm-Message-State: AOPr4FU0GG0gBh/KQKjV3psaZ8NqWBC+a/tLsqLhALxG3BgayZH2qnuY+3jBTTdp/7Fgzivb+2j5MslV8fIK+gzU X-Received: by 10.36.37.73 with SMTP id g70mr15719671itg.51.1463555597056; Wed, 18 May 2016 00:13:17 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.31.209 with HTTP; Wed, 18 May 2016 00:12:57 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Wed, 18 May 2016 12:42:57 +0530 Message-ID: Subject: Re: PATCH: FTS configuration node To: Sanket Mehta Cc: Harshal Dhumal , Akshay Joshi , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a1145a85078d77c0533189749 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1145a85078d77c0533189749 Content-Type: text/plain; charset=UTF-8 On Wed, May 18, 2016 at 12:41 PM, Sanket Mehta < sanket.mehta@enterprisedb.com> wrote: > Hi, > > PFA the revised patch. > Response is lnline. > > Regards, > Sanket Mehta > Sr Software engineer > Enterprisedb > > On Tue, May 17, 2016 at 12:54 PM, Harshal Dhumal < > harshal.dhumal@enterprisedb.com> wrote: > >> Hi Sanket, >> >> Please find my review comments below: >> >> 1. In create mode it generates wrong sql. >> >> CREATE TEXT SEARCH CONFIGURATION test.asdf ( >> COPY= >> ); >> >> steps to reproduce: >> a] Fill up any necessary fields in general tab. >> b] On definition tab set Copy config filed and navigate to SQL tab. >> c] Come back again to definition tab clear Copy config field and set >> Parser field and again navigate to SQL tab >> > Fixed > >> >> 2. Create new FTS configuration with parser throws below error. >> >> provide atleast copy config or parser. >> >> (this is because you have used key name for parser in js as "prsname" and >> in python you have applied validations on key "parser") >> > Fixed > >> >> 3. When we clear dictionary for any token using cross (x) button in >> select2; JavaScript code for selecct2 fails. (see attached screenshot) >> > This occurs due to issue in select2 control. Its a generalized issue which > will be resolved later. > When you say - it is common issue, can you please point where else you've seen this behaviour? -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* > >> >> >> >> >> >> -- >> *Harshal Dhumal* >> *Software Engineer * >> >> >> >> EenterpriseDB >> >> On Mon, May 16, 2016 at 7:37 PM, Sanket Mehta < >> sanket.mehta@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Revised patch is attached with this mail. >>> My response is inline. >>> >>> >>> Regards, >>> Sanket Mehta >>> Sr Software engineer >>> Enterprisedb >>> >>> On Fri, May 13, 2016 at 6:20 PM, Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> Hi Sanket >>>> >>>> Below are my review comments: >>>> >>>> >>>> - Add button should be disabled in Tokens tab while creating. >>>> >>>> Done >>> >>>> >>>> - Unable to click on down arrow for token select control. >>>> >>>> Done >>> >>>> >>>> - Title should be change from "Create FTS-dictionaries" to "Create >>>> FTS-Configuration". >>>> >>>> Done >>> >>>> >>>> - Tree node is not getting refreshed on name change. >>>> >>>> Done >>> >>>> >>>> - Unable to rename FTS Configuration when name contains any capital >>>> letter. >>>> >>>> Done >>> >>>> >>>> - If user tries to add already existing token then respective row >>>> in the backgrid should be highlighted. >>>> >>>> Done >>> >>>> >>>> - "URL not found" when click on SQL help icon from the properties >>>> dialog. >>>> >>>> Done >>> >>>> >>>> - SQL should not be generated when remove and add the same token >>>> again. Currently it is creating two sql's one for remove and >>>> another is for add. >>>> - *Fix for the above issue is*: - Add "keys: ['token']," to >>>> TokenModel in your js file. >>>> >>>> Done >>> >>> >>>> >>>> On Fri, May 13, 2016 at 2:58 PM, Sanket Mehta < >>>> sanket.mehta@enterprisedb.com> wrote: >>>> >>>>> Hi All, >>>>> >>>>> Last patch for FTS configuration does not contain node.ui.js file >>>>> Kindly ignore it. >>>>> >>>>> Here is the new revised patch attached with this mail. >>>>> Please do review it and let me know if any changes required >>>>> >>>>> Regards, >>>>> Sanket Mehta >>>>> Sr Software engineer >>>>> Enterprisedb >>>>> >>>>> On Thu, May 12, 2016 at 4:38 PM, Sanket Mehta < >>>>> sanket.mehta@enterprisedb.com> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> PFA the revised patch. >>>>>> Please do review it and let me know if anything is not proper. >>>>>> >>>>>> Regards, >>>>>> Sanket Mehta >>>>>> Sr Software engineer >>>>>> Enterprisedb >>>>>> >>>>>> On Thu, May 5, 2016 at 8:19 PM, Harshal Dhumal < >>>>>> harshal.dhumal@enterprisedb.com> wrote: >>>>>> >>>>>>> + patch link >>>>>>> >>>>>>> >>>>>>> http://www.postgresql.org/message-id/CAFiP3vwkka+=1FOJ7kr2zbC4AzecoCa9eO9DZ34-Oyy_9gE92g@mail.gmail.com >>>>>>> >>>>>>> -- >>>>>>> *Harshal Dhumal* >>>>>>> *Software Engineer * >>>>>>> >>>>>>> >>>>>>> >>>>>>> EenterpriseDB >>>>>>> >>>>>>> On Thu, May 5, 2016 at 8:18 PM, Sanket Mehta < >>>>>>> sanket.mehta@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi, >>>>>>>> >>>>>>>> PFA first patch for FTS configuration node. >>>>>>>> >>>>>>>> It depends upon backgrid select2cell multi select control, for >>>>>>>> which Harshal has sent the patch recently. >>>>>>>> Please do apply his patch first and then apply this patch. >>>>>>>> >>>>>>>> Please do review it and let me know if any changes are required. >>>>>>>> >>>>>>>> >>>>>>>> Regards, >>>>>>>> Sanket Mehta >>>>>>>> Sr Software engineer >>>>>>>> Enterprisedb >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Sent via pgadmin-hackers mailing list ( >>>>>>>> pgadmin-hackers@postgresql.org) >>>>>>>> To make changes to your subscription: >>>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>>>> To make changes to your subscription: >>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>> >>>>> >>>> >>>> >>>> -- >>>> *Akshay Joshi* >>>> *Principal Software Engineer * >>>> >>>> >>>> >>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>>> >>> >>> >>> >>> -- >>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>> To make changes to your subscription: >>> http://www.postgresql.org/mailpref/pgadmin-hackers >>> >>> >> > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > --001a1145a85078d77c0533189749 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On Wed, May 18, 2016 at 12:41 PM, Sanket Mehta <<= a href=3D"mailto:sanket.mehta@enterprisedb.com" target=3D"_blank">sanket.me= hta@enterprisedb.com> wrote:

<= div class=3D"gmail_quote">
Hi,

PFA the revised patch.
Response i= s lnline.

Regards,
Sanket Mehta
Sr Softwar= e engineer
Enterprisedb

On Tue, May 17, 2016= at 12:54 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.co= m> wrote:
Hi Sanket,

Please find my review comments below:
1. In create mode it generates wrong sql.

CREATE TEXT SEA= RCH CONFIGURATION test.asdf (
=C2=A0=C2=A0=C2=A0 COPY=3D
);

steps to reproduce:
=C2=A0=C2=A0=C2=A0 a] Fill up = any necessary fields in general tab.
=C2=A0=C2=A0=C2=A0 b] On definition= tab set Copy config filed and navigate to SQL tab.
=C2=A0=C2=A0= =C2=A0 c] Come back again to definition tab clear Copy config field and set= Parser field and again navigate to SQL tab
Fixed=C2=A0

2. Create new FTS configuration with parser throws be= low error.

provide atl= east copy config or parser.

(this is be= cause you have used key name for parser in js as "prsname" and in= python you have applied validations on key "parser")
Fixed=C2=A0

3. When we clear dictionary= for any token using cross (x) button in select2; JavaScript code for selec= ct2 fails. (see attached screenshot)
This= occurs due to issue in select2 control. Its a generalized issue which will= be resolved later.
When you say -= it is common issue, can you please point where else you've seen this b= ehaviour?

--=

Thanks & R= egards,

Ashesh Vashi
EnterpriseDB INDIA:=C2=A0Enterprise P= ostgreSQL Company


http://www.linkedin.com/in/asheshvashi= =C2=A0

=





--=C2=A0
Harshal Dhumal
Software Engineer=C2=A0



=

On Mon, May 16, 2016 at 7:3= 7 PM, Sanket Mehta <sanket.mehta@enterprisedb.com> wrote:
Hi,

Revis= ed patch is attached with this mail.
My response is inline.
=


Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Fri, May 13, 2016 at 6:20 PM= , Akshay Joshi <akshay.joshi@enterprisedb.com> w= rote:
Hi Sanket=C2=A0
Below are my review comments:

    =
  • Add button should be disabled in Tokens tab while creating.
Done=C2=A0
  • Unable to click on down arrow for token se= lect control.=C2=A0
Done= =C2=A0
  • Title shou= ld be change from "Create FTS-dictionaries" to "= ;Create FTS-Configuration".
Done=C2=A0
  • Tree node is not getting refreshed on name change.
    • <= /ul>
Done=C2=A0
  • Unable to rename FTS Config= uration when name contains any capital letter.
Done=C2=A0
  • If user tries to add already existing token then respective= row in the backgrid should be highlighted.
Done=C2=A0
  • "URL not found" when click on SQL= help icon from the properties dialog.=C2=A0
<= /div>
Done=C2=A0
=
  • SQL should not be generated when= remove and add the same token again. Currently it is creating two sq= l's one for remove and another is for add.
    • Fix fo= r the above issue is: - Add "keys: ['token']," to TokenModel in your js file.
Done
=C2=A0

O= n Fri, May 13, 2016 at 2:58 PM, Sanket Mehta <sanket.mehta@en= terprisedb.com> wrote:
H= i All,

Last patch for FTS configuration does not contain= node.ui.js file
Kindly ignore it.

Here = is the new revised patch attached with this mail.
Please do revie= w it and let me know if any changes required

Regards,
San= ket Mehta
Sr Software engineer
Enterprisedb
=

On Thu, May 12, 2016 at 4:3= 8 PM, Sanket Mehta <sanket.mehta@enterprisedb.com> wrote:
Hi,

PFA t= he revised patch.
Please do review it and let me know if anything= is not proper.

Regards,
Sanket Mehta
Sr Softwa= re engineer
Enterprisedb

On Thu, May 5, 2016 at 8:19= PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com>= wrote:

--=C2=A0
Ha= rshal Dhumal
Software Engineer=C2=A0

On Thu, May 5, 2016 at 8:18 PM, Sa= nket Mehta <sanket.mehta@enterprisedb.com> wrote= :
Hi,

PFA first patch for FTS configuration node.

It depends upon backgrid select2cell multi select control, for which Har= shal has sent the patch recently.
Please do apply his patch first= and then apply this patch.

Please do review it an= d let me know if any changes are required.


Regards,
Sanket Mehta
S= r Software engineer
Enterprisedb


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=






--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=




--
Akshay Joshi
Principal Softw= are Engineer=C2=A0
<= span style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;= border-collapse:collapse">
<= /b>
=
Phone: +91 20-3058-9517
Mobile: +91 976-788-8246<= /font>



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=





--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=


--001a1145a85078d77c0533189749--