Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aueLw-00019Q-7B for pgadmin-hackers@arkaria.postgresql.org; Mon, 25 Apr 2016 11:06:56 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1aueLu-0003G6-JK for pgadmin-hackers@arkaria.postgresql.org; Mon, 25 Apr 2016 11:06:54 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1aueLh-00031w-35 for pgadmin-hackers@postgresql.org; Mon, 25 Apr 2016 11:06:41 +0000 Received: from mail-ig0-x235.google.com ([2607:f8b0:4001:c05::235]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1aueLd-0005Mw-K4 for pgadmin-hackers@postgresql.org; Mon, 25 Apr 2016 11:06:39 +0000 Received: by mail-ig0-x235.google.com with SMTP id m9so60543742ige.1 for ; Mon, 25 Apr 2016 04:06:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=4GQXFVl/Cwll/03kLHRzRnh454ku3hUGWAt6PpSn1DI=; b=QhT2UjBNK8Uel/1RNx8o+ixiUPviNcd2KMDiMgaZhLGz/YYpnFSlqJtLuBL6+WsAZR Nuy+P/si9wPcN3aBvJii8FpliXsiJNaDND2QVtMed6tYv4kt4wrekTVFw5P1oM3/uplq cNn+iRzWfPTi4kx0Ufnu3gmpMtmSAWvh2NO+5mve/EYYvYGsXH8TDMzZI4uOirjFsjWz oeTHmpNZSypbOMeMCNQJuHUmS1hGDn+r/rTyIzwvB6IBKemALcyI/GJH1WqHBkVocN4/ Lj09kheGwviqFKD5jk4mesOxFAwZimHtyZHtUtY95EespYDp6ZmXIYtMGx1TF7LMVIr4 J4gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=4GQXFVl/Cwll/03kLHRzRnh454ku3hUGWAt6PpSn1DI=; b=JVnpY/Y+6pkffobQzYukcEUEoOKdfOvHKFpFPTaGDQZiw0Tmkka3oDpHIpe75hud7Q KaFOTeIilnhGhrdXbRnvmPiZFbZSRh1BVUzLI2Xiq2QU6FchDJCvvK+hxz6FDz9ENxc8 w6z7qSK4iEte5UHMCG0x87ccojdRJ6sbEzVSx4C3ZcAcs+Md3lFo1unkRXe/Ba63ckuO qJYuih+iBgKek1hD+IUMwRnnegDSWDk49eHOYYfknYbi4dj8vOYKztm1/vRo7PKwMoa2 ToQ59Mj1lWFcT0n9I/9KU+HnUyX3S/P3YgO3fiv273aecnriQfHbL82xdaMLUvrm0cNe 0CFg== X-Gm-Message-State: AOPr4FXfxO2E7qFXgvaUW10b7GGs8pwhCYeiiUNXT9dIM3eRgXUDZru+nffISoo3nWF4UeCc5YwTWFLJt/T1etqe X-Received: by 10.50.189.233 with SMTP id gl9mr11120850igc.73.1461582396266; Mon, 25 Apr 2016 04:06:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.39.5 with HTTP; Mon, 25 Apr 2016 04:06:16 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Mon, 25 Apr 2016 16:36:16 +0530 Message-ID: Subject: Re: PATCH: Graphincal explain integrated in sql editor To: Sanket Mehta Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=14dae934078d8a4c6205314d2bec X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --14dae934078d8a4c6205314d2bec Content-Type: text/plain; charset=UTF-8 Hi Sanket, Please find the review comments. - Please add the missing 'explain.css'. - The application should be smart enough to handle conflict in options. i.e. Buffer is not a valid options without EXPLAIN ANALYZE. - A statement having EXPLAIN keywords with different format should at least render the output in the data-grid. i.e. EXPLAIN (FORMAT xml) SELECT * FROM xyz; - Please use the keywords used in the EXPLAIN statement in capital. - Explain should not work with empty string. - Font size in the tooltip is very small. - Smoothing the zoom functionality. - Arrow marker is hardly visible. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Mon, Apr 25, 2016 at 3:06 PM, Sanket Mehta wrote: > Hi, > > This patch includes the patch sent earlier for stand alone graphical > explain. > > And also "horizontal lines are not proper" bug is fixed in the same which > was reported by Dave in previous patch. > > Regards, > Sanket Mehta > Sr Software engineer > Enterprisedb > > On Thu, Apr 21, 2016 at 8:38 PM, Sanket Mehta < > sanket.mehta@enterprisedb.com> wrote: > >> Hi Team, >> >> PFA the first patch for graphical explain integrated in sql editor. >> >> Below are the few things which are different from previous patch which >> was sent for stand alone graphical explain. >> >> - Now user can select Explain/Explain Analyze with four optional >> properties (Verbose, costs, timing and buffers) >> >> - Initially graph will be scale (according to only its width not height) >> to fit to screen so no blank space will be there in case of very large >> graph. >> >> - Along with zoom in/out button, "zoom to original" button is also >> provided, by clicking on which graph will be scale to its original size >> (not same as initial one which is according to screen size). >> >> Please do review this patch and let me know in case you have any comments. >> >> >> Regards, >> Sanket Mehta >> Sr Software engineer >> Enterprisedb >> > > --14dae934078d8a4c6205314d2bec Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Sanket,

Please find the review comme= nts.
- Please add the missing 'explain.css'.
- = The application should be smart enough to handle conflict in options.
=
=C2=A0 =C2=A0i.e.
=C2=A0 =C2=A0Buffer is not a valid options= without EXPLAIN ANALYZE.
- A statement having EXPLAIN keywords w= ith different format should at least render the output in the data-grid.
=C2=A0 i.e. EXPLAIN (FORMAT xml) SELECT * FROM xyz;
- Ple= ase use the keywords used in the EXPLAIN statement in capital.
- = Explain should not work with empty string.
- Font size in the too= ltip is very small.
- Smoothing the zoom functionality.
- Arrow marker is hardly visible.


--

Th= anks & Regards,

Ashesh Vashi
Enterpri= seDB INDIA: Enterprise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Mon, Apr 25, 2016 at 3:06 PM, Sanket Meht= a <sanket.mehta@enterprisedb.com> wrote:
Hi,

This pat= ch includes the patch sent earlier for stand alone graphical explain.
=

And also "horizontal lines are not proper" bu= g is fixed in the same which was reported by Dave in previous patch.
<= /div>

Regards,
Sanket Mehta
Sr Software engineer=
Enterprisedb

On Thu, Apr 21= , 2016 at 8:38 PM, Sanket Mehta <sanket.mehta@enterprisedb.com= > wrote:
H= i Team,

PFA the first patch for graphical explain integr= ated in sql editor.

Below are the few things which= are different from previous patch which was sent for stand alone graphical= explain.

=C2=A0- =C2=A0Now user can select Explai= n/Explain Analyze with four optional properties (Verbose, costs, timing and= buffers)

=C2=A0- Initially graph will be scale (a= ccording to only its width not height) to fit to screen so no blank space w= ill be there in case of very large graph.

- Along = with zoom in/out button, "zoom to original" button is also provid= ed, by clicking on which graph will be scale to its original size (not same= as initial one which is according to screen size).

Please do review this patch and let me know in case you have any comments= .


Reg= ards,
Sanket Mehta
Sr Software engineer
Enterprised= b


--14dae934078d8a4c6205314d2bec--