Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b0vlE-0002QJ-0s for pgadmin-hackers@arkaria.postgresql.org; Thu, 12 May 2016 18:55:00 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1b0vlD-00049m-B7 for pgadmin-hackers@arkaria.postgresql.org; Thu, 12 May 2016 18:54:59 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1b0vkz-0003fM-7t for pgadmin-hackers@postgresql.org; Thu, 12 May 2016 18:54:45 +0000 Received: from mail-ig0-x22e.google.com ([2607:f8b0:4001:c05::22e]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1b0vkw-0004h7-3G for pgadmin-hackers@postgresql.org; Thu, 12 May 2016 18:54:44 +0000 Received: by mail-ig0-x22e.google.com with SMTP id m9so58139001ige.1 for ; Thu, 12 May 2016 11:54:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ATfCBVE7+bmSoAolc/8QwV0hg0PQ/O5BWHNW7YWo9xE=; b=n/5Pn37njwDU+z3JD9ayEzwhYXFA9vsdoBuYXOkHaJCjvmxS62zNSw6N2wmD9Y4jQB hudLvlDlhIQklNbaQkeNETagk3sVD+17N+kXLu8tssuXpyQE0FSmPy9C3oRGxRc//DIM nped03O3eLG0Bi44RxIeZnDCbF0tFtwj24lJU4OoQhxwq4wP+krwFy61QDPKP7Yl+6Nf EZ5tJPA4h/r69fTMhjYKfUL1W2sw63gR56MMZ/Qr4NXi2gif5o34Szcd9jxnNPQcrR4m nIZvrMcqQT9oK8LfYam6qye+/6ySD1GytJgfFdsyUBApYZWA2CtdxKzI4Uup8j6ShxSz oc0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ATfCBVE7+bmSoAolc/8QwV0hg0PQ/O5BWHNW7YWo9xE=; b=XsmxF84ijyaI3dXIx1V3RsZrlxrRld3JDbUV6aSPwLK2oqgqOVCt2dhkxZTGLX0IjT 2IUhulOawQYB0mjCMXmcuidY7cnAMpXeJ90MbFM6YjTeHX+h/ef4qFjItBjdnt49ikGo 6rRHmk2nKD+OYlTfzHEtPKENJ23hs8Jj0kfHM3IKmc+VCZQkbEE2piO2UQyLnoc9JA/T HVOOtsn+SH268vLcMpxZTRR1PJjY0gPTlgib8tfpiCkdrRsQR2Ijw5McVnMVSfcSMC9m JjY+GTdMOfh8nZWP4im6jzCwuSIhksd9lKZITdgvI8H57WtlhzOJrqppWEAPfrlq0h9G 5nSQ== X-Gm-Message-State: AOPr4FXX+xXVBRn3Xy69j/tG1oNh6K50juLATNJG89D8krudlEu3luZBf4Rase/5KhGYkfScTevZcwaE1CchWnP9 X-Received: by 10.50.111.72 with SMTP id ig8mr28627768igb.35.1463079280747; Thu, 12 May 2016 11:54:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.31.209 with HTTP; Thu, 12 May 2016 11:54:21 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Fri, 13 May 2016 00:24:21 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: File Manager & Backform FileControl To: Surinder Kumar Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=089e013a2b54cf064e0532a9b078 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --089e013a2b54cf064e0532a9b078 Content-Type: text/plain; charset=UTF-8 Hi Surinder, Thanks - it was committed! As discussed personally, there are few improvement needed. * Do not show non applicable buttons, whenever no files/directory available in the storage root directory. * In crate mode, use dimmer with the overwrite warning, so that - it does not allow to deselect the current selection. * The default selection for the file type selection combo box should be other than 'All Files'. * File type selection combo box should support file type description. i.e. Query/SQL File (*.sql) CSV File (*.csv) All Files (*.* | *) Please put that in the TODO file, we will handle that in future. I must apologies for a mistake for not giving you the credit for the work, I forgot to set the author while committing it. I tried setting it again to set the author without any success. :-( Thanks for the patch. I will be more careful next time. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Thu, May 12, 2016 at 12:18 AM, Surinder Kumar < surinder.kumar@enterprisedb.com> wrote: > Hi, > > PFA updated patch with following issues fixed: > 1. not listing files based on default file type selected. > 2. load css file using 'get_own_stylesheets' method instead of loading > from 'base.html'. > 3. setting custom dialog title and button not working. > > On Wed, May 11, 2016 at 3:03 PM, Surinder Kumar < > surinder.kumar@enterprisedb.com> wrote: > >> >> ---------- Forwarded message ---------- >> From: Surinder Kumar >> Date: Tue, May 10, 2016 at 11:43 PM >> Subject: Re: [pgadmin-hackers][pgAdmin4][Patch]: File Manager & Backform >> FileControl >> To: Neel Patel >> Cc: pgadmin-hackers >> >> >> Hi, >> >> Please find updated path with couple of review comments given by Ashesh >> Vashi. >> 1. Add variable *STORAGE_DIR* in configuration settings which decides >> the directory to list when *File manager* is opens, previously >> we have provided this option in preferences which is removed due to >> security issues. >> 2. List all available Volumes by default when *STORAGE_DIR *is set to >> empty for *Windows* platform. >> 3. Also, added support to allow user to provide >> *Dialog title and custom name for primary(OK) button,* >> >> Usage: >> >> 1. Set variable *STORAGE_DIR *to some value in config.py. >> 2. Import it in your module as following: >> * import config* >> * config.**STORAGE_DIR* >> >> *Usage*: Backform FilleControl >> >> schema:[{ >> id: 'select_file', label: '{{ _('Select File')}}', >> type: 'text', *control*: *Backform.FileControl*, >> *dialog_type: '*select_file*'*, *supp_types: [*'*', 'pdf', 'text', >> 'patch', 'py'*],* >> * dialog_title: '*Title to appear on dialog*", * >> * btn_primary: '*Save File*'* >> }] >> >> Please review the patch. >> >> On Wed, May 4, 2016 at 6:35 PM, Surinder Kumar < >> surinder.kumar@enterprisedb.com> wrote: >> >>> Hi >>> >>> PFA updated patch with resolved review comments. >>> >>> On Thu, Apr 28, 2016 at 6:39 PM, Neel Patel >> > wrote: >>> >>>> Hi Surinder, >>>> >>>> Please find additional comments as below. >>>> >>>> 1. In Windows OS, when we try to open the dialog with default >>>> preference value then it gives error as below. >>>> >>>> 2016-04-28 13:07:44,716: ERROR pgadmin: Exception on >>>> /file_manager/filemanager/2530270/ [POST] >>>> Traceback (most recent call last): >>>> File "C:\Projects\venv_python_2_7\Lib\site-packages\flask\app.py", >>>> line 1817, in wsgi_app >>>> response = self.full_dispatch_request() >>>> File "C:\Projects\venv_python_2_7\Lib\site-packages\flask\app.py", >>>> line 1477, in full_dispatch_request >>>> rv = self.handle_user_exception(e) >>>> File "C:\Projects\venv_python_2_7\Lib\site-packages\flask\app.py", >>>> line 1381, in handle_user_exception >>>> reraise(exc_type, exc_value, tb) >>>> File "C:\Projects\venv_python_2_7\Lib\site-packages\flask\app.py", >>>> line 1475, in full_dispatch_request >>>> rv = self.dispatch_request() >>>> File "C:\Projects\venv_python_2_7\Lib\site-packages\flask\app.py", >>>> line 1461, in dispatch_request >>>> return self.view_functions[rule.endpoint](**req.view_args) >>>> File "C:\Projects\venv_python_2_7\Lib\site-packages\flask_login.py", >>>> line 758, in decorated_view >>>> return func(*args, **kwargs) >>>> File >>>> "C:\Projects\pgadmin4\web\pgadmin\misc\file_manager\__init__.py", line 629, >>>> in file_manager >>>> return getattr(myFilemanager, mode)(**kwargs) >>>> File >>>> "C:\Projects\pgadmin4\web\pgadmin\misc\file_manager\__init__.py", line 421, >>>> in getfolder >>>> filelist = self.list_filesystem(dir, path, trans_data, file_type) >>>> File >>>> "C:\Projects\pgadmin4\web\pgadmin\misc\file_manager\__init__.py", line 331, >>>> in list_filesystem >>>> for f in sorted(os.listdir(orig_path)): >>>> WindowsError: [Error 161] The specified path is invalid: '//*.*' >>>> >>>> Now the default path will always be the users directory. I have used *os.path.expanduser('~') >>> *which prints user directory. It works for all operating systems. >>> >>>> >>>> 2. Folder having write only permission should not allow to read the >>>> directory. Same way read only permission folder should not allow to create >>>> the folder. Currently it gives below error. >>>> >>>> PermissionError: [Errno 13] Permission denied: >>>> '/home/neel/Projects/pgadmin4_file_manager/write_only_premission/' >>>> >>> Fixed. >>> >>>> >>>> 3. In Windows OS, when we open the file manager dialog, no directories >>>> listed though we have directories in the folder. Due to that we are not >>>> able to >>>> test all the functionality in windows. Once we fix this issue then >>>> we test all the functionality in windows OS. >>>> >>>> We debug the issue and found that issue is with the json response >>>> which includes the HTML tags. >>>> >>> Fixed. It still have issues in very older browsers. I will fix it. >>> >>>> >>>> 4. In Windows OS, file manager dialog have issue with layout. We are >>>> getting some margin at top before buttons. >>>> >>> Fixed. >>> >>>> >>>> 5. When we give any special characters to folder name that it gives >>>> error saying "Folder does not exist". >>>> Same is applicable when we give dialog_type to create_file >>>> >>> Fixed. >>> >>>> >>>> 6. In create_file mode, after giving the filename it should display the >>>> name of the file to text control. >>>> >>> Fixed. >>> >>>> >>>> 7. In create_file mode, when user gives the filename and click on the >>>> any blank area of dialog then name is getting cleared. >>>> >>> Fixed. >>> >>>> >>>> 8. When we upload the new file through file manager then it is not >>>> showing in the list though we have selected "All files" options. >>>> >>> Fixed. >>> >>>> >>>> 9. When we rename the folder in "Table mode" then font-family gets >>>> changed. It is not happened in "Grid" mode. >>>> >>> Fixed. >>> >>>> >>>> 10. When we try to download the file then it goes into loop and opens >>>> up 20-30 dialogs at the same time. >>>> >>> Fixed. >>> >>>> >>>> 11. "Rename" button is enabled even though we have not selected the >>>> files/folder to rename and when we click on the "Rename" button it gives >>>> below >>>> error. >>>> >>>> TypeError: orig_value is undefined >>>> >>> Fixed. >>> >>>> 12. "Delete" button is enabled even though we have not selected the >>>> files/folder to delete and when we click on the "Delete" button it gives >>>> below error. >>>> TypeError: path is undefined >>>> >>> Fixed. >>> >>>> >>>> Do let us know if you have queries. >>>> >>>> Thanks, >>>> Neel Patel >>>> >>>> On Wed, Apr 27, 2016 at 9:15 PM, Neel Patel < >>>> neel.patel@enterprisedb.com> wrote: >>>> >>>>> Hi Surinder, >>>>> >>>>> I have applied the patch file and below are some observations. >>>>> >>>>> - When we create the new folder and hit the enter then we are >>>>> getting the below error. >>>>> >>>>> TypeError: argument of type 'NoneType' is not >>>>> iterable >>>>> >>>>> - I have just added the new control in "Import" dialog and >>>>> observed that new control is getting added in new tab called "General". I >>>>> think it should not create the new "General" tab. >>>>> - "Select" and "Cancel" buttons font is different then other >>>>> dialogs. >>>>> >>>>> >>>>> Thanks, >>>>> Neel Patel >>>>> >>>>> On Wed, Apr 27, 2016 at 6:18 PM, Surinder Kumar < >>>>> surinder.kumar@enterprisedb.com> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> The patch is for *File Manager and Backform FileControl*. >>>>>> >>>>>> *File Manager:* It allows user to store their files at one place. >>>>>> The user can set path to this directory in preferences which file manger >>>>>> will use. >>>>>> >>>>>> It will be used by various modules of pgAdmin4 such as >>>>>> *import data from file, query tool, backup & recovery tool* so on.. >>>>>> It allows user to perform various operations such as: >>>>>> >>>>>> - File deletion >>>>>> - File upload >>>>>> - Create new directory >>>>>> - File rename >>>>>> - File download and >>>>>> - List files & folders in list and grid view. >>>>>> >>>>>> *FileControl: *This control is used with *File Manager. *It can be >>>>>> used for: >>>>>> >>>>>> - File Selection >>>>>> - Folder Selection >>>>>> - File Creation >>>>>> - Storage Manager Dialog.( it supports all operations listed >>>>>> above). >>>>>> >>>>>> >>>>>> Usage*:* >>>>>> >>>>>> schema:[{ >>>>>> id: 'select_file', label: '{{ _('Select File')}}', >>>>>> type: 'text', *control*: *Backform.FileControl*, >>>>>> *dialog_type: 'select_file'*, *supp_types: ['*', 'pdf', 'text', >>>>>> 'patch', 'py']* >>>>>> } >>>>>> >>>>>> Where: >>>>>> >>>>>> - *control* - It should be *Backform.FileControl* >>>>>> - *dialog_type *- the type of dialog to use. >>>>>> - options can be: *select_file, select_folder, create_file & >>>>>> storage_dialog*. >>>>>> - *supp_types(*not mandatory) - the types of files allowed to >>>>>> show and upload. >>>>>> >>>>>> Please review the patch and let me know for the review comments. >>>>>> >>>>>> >>>>>> Thanks >>>>>> Surinder Kumar >>>>>> >>>>>> >>>>>> -- >>>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org >>>>>> ) >>>>>> To make changes to your subscription: >>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>>> >>>>>> >>>>> >>>> >>> >> >> > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > --089e013a2b54cf064e0532a9b078 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Surinder,

Thanks - it was committed!=

As discussed personally, there are few improvemen= t needed.

* Do not show non applicable buttons, wh= enever no files/directory available in the storage root directory.
* In crate mode, use dimmer with the overwrite warning, so that - it does= not allow to deselect the current selection.
* The default selec= tion for the file type selection combo box should be other than 'All Fi= les'.
* File type selection combo box should support file typ= e description.
=C2=A0 i.e.
Query/SQL File (*.sql)
=
CSV File (*.csv)
All Files (*.* | *)

Please put that in the TODO file, we will handle that in future.
I must apologies for a mistake for not giving you the cred= it for the work, I forgot to set the author while committing it.
<= div>I tried setting it again to set the author without any success. :-(

Thanks for the patch.
I will be more carefu= l next time.

=

<= span style=3D"font-style:italic">--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company<= /p>

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Thu, May 12, 2016 at 12:18 AM, Surinder K= umar <surinder.kumar@enterprisedb.com> wrote:<= br>
Hi,

P= FA updated patch with following issues fixed:
1. not listing file= s based on default file type selected.
2. load css file using = 9;get_own_stylesheets' method instead of loading from 'base.html= 9;.
3. setting custom dialog title and button not working.
<= /div>
On Wed, May 11, 2016 at 3:03 PM, Surinder Kumar= <surinder.kumar@enterprisedb.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">

---------- Forwarded message ----------
From: Surinder Kumar <surinder.kumar@enterpri= sedb.com>
Date: Tue, May 10, 2016 at 11:43 PM
Subject: = Re: [pgadmin-hackers][pgAdmin4][Patch]: File Manager & Backform FileCon= trol
To: Neel Patel <neel.patel@enterprisedb.com>
Cc: pgadmin-hackers= <pg= admin-hackers@postgresql.org>


Hi,
Please find updated path with couple of review comments given = by Ashesh Vashi.
1. Add variable STORAGE_DIR in configurat= ion settings which decides the directory to list when File manager i= s opens, previously
we have provided this option in preferences w= hich is removed due to security issues.
2. List all available Vol= umes by default when=C2=A0STORAGE_DIR is set to empty for Windows= platform.
3. Also, added support to allow user to provide
Dialog title and custom name for primary(OK) button,

Usage:

1. Set variable=C2= =A0STORAGE_DIR to some value=C2=A0in config.py.
2. Import = it in your module as following:
=C2=A0 =C2=A0import config=
=C2=A0 =C2=A0config.STORAGE_DIR

Usage: Backform=C2=A0FilleControl

schema:= [{
=C2=A0 id: 'select_file', label: '{{ _('Select File'= ;)}}',=C2=A0
=C2=A0 type: 'text',=C2=A0control:=C2=A0Backform.FileControl,
=C2=A0=C2=A0dialog_type: 'sel= ect_file',=C2=A0supp_types: ['*', 'pdf', = 'text', 'patch', 'py'],
=C2=A0 dialog_ti= tle: 'Title to appear on dialog",=C2=A0
=C2=A0 btn_primary: 'Save Fi= le'
}]

Please review= the patch.

On Wed, May 4, 2016 at 6:35 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
Hi

PFA updated patc= h with resolved review comments.

On Thu, Apr 28, 2016 at 6:39 PM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi Surinder,

Please fin= d additional comments as below.

1.=C2=A0 In W= indows OS, when we try to open the dialog with default preference value the= n it gives error as below.

2016-04-28 13:07:44,716= : ERROR =C2=A0pgadmin: =C2=A0 =C2=A0 =C2=A0 =C2=A0Exception on /file_manage= r/filemanager/2530270/ [POST]
Traceback (most recent call last):<= /div>
=C2=A0 File "C:\Projects\venv_python_2_7\Lib\site-packages\f= lask\app.py", line 1817, in wsgi_app
=C2=A0 =C2=A0 response = =3D self.full_dispatch_request()
=C2=A0 File "C:\Projects\ve= nv_python_2_7\Lib\site-packages\flask\app.py", line 1477, in full_disp= atch_request
=C2=A0 =C2=A0 rv =3D self.handle_user_exception(e)
=C2=A0 File "C:\Projects\venv_python_2_7\Lib\site-packages\fl= ask\app.py", line 1381, in handle_user_exception
=C2=A0 =C2= =A0 reraise(exc_type, exc_value, tb)
=C2=A0 File "C:\Project= s\venv_python_2_7\Lib\site-packages\flask\app.py", line 1475, in full_= dispatch_request
=C2=A0 =C2=A0 rv =3D self.dispatch_request()
=C2=A0 File "C:\Projects\venv_python_2_7\Lib\site-packages\flas= k\app.py", line 1461, in dispatch_request
=C2=A0 =C2=A0 retu= rn self.view_functions[rule.endpoint](**req.view_args)
=C2=A0 Fil= e "C:\Projects\venv_python_2_7\Lib\site-packages\flask_login.py",= line 758, in decorated_view
=C2=A0 =C2=A0 return func(*args, **k= wargs)
=C2=A0 File "C:\Projects\pgadmin4\web\pgadmin\misc\fi= le_manager\__init__.py", line 629, in file_manager
=C2=A0 = =C2=A0 return getattr(myFilemanager, mode)(**kwargs)
=C2=A0 File = "C:\Projects\pgadmin4\web\pgadmin\misc\file_manager\__init__.py",= line 421, in getfolder
=C2=A0 =C2=A0 filelist =3D self.list_file= system(dir, path, trans_data, file_type)
=C2=A0 File "C:\Pro= jects\pgadmin4\web\pgadmin\misc\file_manager\__init__.py", line 331, i= n list_filesystem
=C2=A0 =C2=A0 for f in sorted(os.listdir(orig_p= ath)):
WindowsError: [Error 161] The specified path is invalid: &= #39;//*.*'

Now= the default path will always be the users directory. I have used os.pat= h.expanduser('~') which prints user directory.=C2=A0It works fo= r all operating systems.=C2=A0

2. Folder having write only permission= should not allow to read the directory. Same way read only permission fold= er should not allow to create the folder. =C2=A0 =C2=A0 Currently it gives = below error.

=C2=A0 =C2=A0PermissionError: [Errno = 13] Permission denied: '/home/neel/Projects/pgadmin4_file_manager/write= _only_premission/'
Fixed.=C2= =A0

3= . In Windows OS, when we open the file manager dialog, no directories liste= d though we have directories in the folder. Due to that we are not able to= =C2=A0
=C2=A0 =C2=A0 test all the functionality in windows. Once = we fix this issue then we test all the functionality in windows OS.
=C2=A0 =C2=A0
=C2=A0 =C2=A0We debug the issue and found that i= ssue is with the json response which includes the HTML tags.
Fixed. It still have issues in very older brows= ers. I will fix it.
=
4. In Windows OS, file manager dialog have issue with layout= . We are getting some margin at top before buttons.
Fixed.=C2=A0

5. When we give any special characters to folder= name that it gives error saying "Folder does not exist".
=C2=A0 =C2=A0 Same is applicable when we give dialog_type to create_file=
Fixed.=C2=A0
=C2=A0 =C2=A0
6. In create_fi= le mode, after giving the filename it should display the name of the file t= o text control.
Fixed.=C2=A0

7. In cre= ate_file mode, when user gives the filename and click on the any blank area= of dialog then name is getting cleared.
Fixed.=C2=A0

8. When we upload the new file through file manager then it= is not showing in the list though we have selected "All files" o= ptions.
Fixed.=C2=A0
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;pa= dding-left:1ex">

9. When we rename= the folder in "Table mode" then font-family gets changed. It is = not happened in "Grid" mode.
Fixed.=C2=A0
<= br>
10. When we try to download the file then it goes into loop a= nd opens up 20-30 dialogs at the same time.
<= /span>
Fixed.=C2=A0
=

11. "Rename" button is enabled even though we= have not selected the files/folder to rename and when we click on the &quo= t;Rename" button it gives below=C2=A0
=C2=A0 =C2=A0 =C2=A0er= ror.

=C2=A0 =C2=A0 TypeError: orig_value is undefi= ned
Fixed.=C2=A0
12. "Delete" button is enabled even though we= have not selected the files/folder to delete and when we click on the &quo= t;Delete" button it gives below error.
=C2=A0 =C2=A0 =C2=A0T= ypeError: path is undefined
Fixed= .=C2=A0

Do let us know if you have queries.

T= hanks,
Neel Patel

On Wed, Apr 27, 2016 at 9:15 PM, Neel Patel= <neel.patel@enterprisedb.com> wrote:
Hi Surinder,

I have applied the= patch file and below are some observations.
  • When we crea= te the new folder and hit the enter then we are getting the below error.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0TypeError: argument of type 'NoneType' is not iterable
<= /div>
  • I have just added the new control in "Import" d= ialog and observed that new control is getting added in new tab called &quo= t;General". I think it should not create the new "General" t= ab.
  • "Select" and "Cancel" buttons font is diffe= rent then other dialogs.

Thanks,
Neel Patel

On Wed, Apr 27, 2016 at 6:18 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
Hi,

The pat= ch is for File Manager and Backform=C2=A0FileControl.

=
File Manager:=C2=A0It allows user to store their f= iles at one place. The user can set path to this directory in preferences w= hich file manger will use.

It will be used by vari= ous modules of pgAdmin4 such as
import data from file, query t= ool, backup & recovery tool=C2=A0so on.. It allows user to perform = various operations such as:=C2=A0
  • File deletion
    • <= li>File upload
  • Create new directory
  • File rename
  • Fil= e download and=C2=A0
  • List files & folders in list and grid = view.
FileControl:=C2=A0This control = is used with=C2=A0File Manager.=C2=A0It=C2=A0can be used for:
<= div>
  • File Selection =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0
  • Folder=C2=A0Selection=C2=A0 =C2=A0 =C2=A0=C2=A0
  • File Crea= tion =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0
  • Storage Ma= nager Dialog.( it supports all operations listed above).

Usage:<= /font>

=
schema:[{
=C2=A0 id: 'select_file', label: '= ;{{ _('Select File')}}',=C2=A0
=C2=A0 type: 'text',=C2=A0control:=C2=A0<= b>Backform.FileControl,
=C2=A0=C2=A0dialog_type: 'select_file',=C2=A0supp_typ= es: ['*', 'pdf', 'text', 'patch', 'py&#= 39;]
}
<= /div>

Where:
  • control=C2=A0- It = should be=C2=A0Backform.FileCont= rol
  • dialog_type=C2=A0- the type of dialog to use.
  • options can be:=C2=A0=C2=A0select_file, select_folder, create_= file & storage_dialog.
  • supp_types(not mandatory)= =C2=A0- the types of files allowed to show and upload.
Please review the patch and let me know for the review c= omments.


Thanks
Surinder Kumar


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=









--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=


--089e013a2b54cf064e0532a9b078--