Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1ZfNwL-0004rL-8J for pgadmin-hackers@arkaria.postgresql.org; Fri, 25 Sep 2015 08:01:09 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1ZfNwK-0003u6-QV for pgadmin-hackers@arkaria.postgresql.org; Fri, 25 Sep 2015 08:01:08 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1ZfNwK-0003ty-5f for pgadmin-hackers@postgresql.org; Fri, 25 Sep 2015 08:01:08 +0000 Received: from mail-la0-f46.google.com ([209.85.215.46]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1ZfNwH-0001UE-Gl for pgadmin-hackers@postgresql.org; Fri, 25 Sep 2015 08:01:07 +0000 Received: by lacrr8 with SMTP id rr8so10523933lac.2 for ; Fri, 25 Sep 2015 01:01:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=rfEj+pFebwpB+1w4ovYDJOTdMvTBEysO9GK966Zqwnw=; b=fJ7js26NMk7Demrv1X9kNt+fAdFrK54h4HHuPlH6X12IUppUAwC/3JY1ucc74OERZZ i8phh4/lGxVUnZgSalfiXtqMfNfFX7Iw6DtFL5stgGwDPOA0iXwyHzwi10+rz3Q50j1O ax4s9X92PVQBVvIjjLjz0fC2AFopPuUrULlU41XJwxVJhCzO5QvDd5I4f0ci9WM78XCx qE+UADYKM/h9A6zBpm97rDAWlyl8SjTDtidIhhj45m2UZPSfSQMNkpXfzJCRtDE6Kzh8 rDpIENDooqnr55oPMog44NoApnO9PjydCzmCdz1soXIIncg2YXUZtv26EQyIDSrXWX0y f51g== X-Gm-Message-State: ALoCoQlxVnJXkCghUyqGOKJgquJnSCDbFbH3ViWvqoZPYAIBAi3w1AWyh7f0baF/f7G4EZ+04h3o X-Received: by 10.152.27.9 with SMTP id p9mr1202445lag.118.1443168063882; Fri, 25 Sep 2015 01:01:03 -0700 (PDT) MIME-Version: 1.0 Received: by 10.112.135.42 with HTTP; Fri, 25 Sep 2015 01:00:44 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Fri, 25 Sep 2015 13:30:44 +0530 Message-ID: Subject: Re: [PATCH] Add Commit/Rollback toolbar action version 2 To: Dave Page Cc: John Obaterspok , Sanket Mehta , pgadmin-hackers Content-Type: multipart/alternative; boundary=089e0160a3accca12705208dbf50 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --089e0160a3accca12705208dbf50 Content-Type: text/plain; charset=UTF-8 Yup. It's in my plate, was updating the CHANGELOG only. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Fri, Sep 25, 2015 at 1:28 PM, Dave Page wrote: > Ashesh, are you able to deal with this before Monday (when I'll be cutting > the feature-frozen beta 1 tarballs)? > > On Fri, Sep 25, 2015 at 7:03 AM, John Obaterspok < > john.obaterspok@gmail.com> wrote: > >> Thanks, appreciated. >> >> Can it be committed then? :) >> >> 2015-09-23 9:49 GMT+02:00 Sanket Mehta : >> >>> Hi John/Ashesh, >>> >>> I have reviewed the patch and it seems fine to me. >>> >>> Regards, >>> Sanket Mehta >>> Sr Software engineer >>> Enterprisedb >>> >>> On Wed, Sep 23, 2015 at 11:08 AM, John Obaterspok < >>> john.obaterspok@gmail.com> wrote: >>> >>>> Hi Sanket, >>>> >>>> Did you give the patch a try? I would really like it to for the next >>>> release :) >>>> >>>> -- john >>>> >>>> 2015-09-16 20:27 GMT+02:00 John Obaterspok : >>>> >>>>> Hi Sanket, >>>>> >>>>> Attached patch is rebased now. >>>>> >>>>> Regards, >>>>> >>>>> -- john >>>>> >>>>> >>>>> 2015-09-16 11:20 GMT+02:00 Sanket Mehta >>>> >: >>>>> >>>>>> Hi John, >>>>>> >>>>>> Patch is not proper. >>>>>> I got below error when I try to apply the patch: >>>>>> >>>>>> error: patch failed: pgadmin/frm/frmQuery.cpp:2435 >>>>>> error: pgadmin/frm/frmQuery.cpp: patch does not apply >>>>>> >>>>>> Please do provide the proper patch. >>>>>> >>>>>> >>>>>> Regards, >>>>>> Sanket Mehta >>>>>> Sr Software engineer >>>>>> Enterprisedb >>>>>> >>>>>> On Mon, Sep 14, 2015 at 10:51 AM, Sanket Mehta < >>>>>> sanket.mehta@enterprisedb.com> wrote: >>>>>> >>>>>>> Sure Ashesh, >>>>>>> >>>>>>> I will review the patch. >>>>>>> >>>>>>> Regards, >>>>>>> Sanket Mehta >>>>>>> Sr Software engineer >>>>>>> Enterprisedb >>>>>>> >>>>>>> On Mon, Sep 14, 2015 at 1:12 PM, Ashesh Vashi < >>>>>>> ashesh.vashi@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Sanket, >>>>>>>> >>>>>>>> Can you please take a look at it? >>>>>>>> >>>>>>>> -- >>>>>>>> >>>>>>>> Thanks & Regards, >>>>>>>> >>>>>>>> Ashesh Vashi >>>>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> *http://www.linkedin.com/in/asheshvashi* >>>>>>>> >>>>>>>> >>>>>>>> On Mon, Sep 14, 2015 at 1:07 AM, John Obaterspok < >>>>>>>> john.obaterspok@gmail.com> wrote: >>>>>>>> >>>>>>>>> Hello, >>>>>>>>> >>>>>>>>> I'm updated the patch to add commit/rollback actions in the >>>>>>>>> toolbar with the following: >>>>>>>>> 1) updated icons (based on existing pgadmin icon with arrows drawn >>>>>>>>> by me) >>>>>>>>> 2) add entry to menu as well >>>>>>>>> 3) disable icons when not in a transaction >>>>>>>>> 4) Ctrl+Shift C|R shortcut >>>>>>>>> >>>>>>>>> Hopefully all issues are resolved now! >>>>>>>>> >>>>>>>>> Regards, >>>>>>>>> >>>>>>>>> John >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Sent via pgadmin-hackers mailing list ( >>>>>>>>> pgadmin-hackers@postgresql.org) >>>>>>>>> To make changes to your subscription: >>>>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --089e0160a3accca12705208dbf50 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Yup.
It's in my plate, was updating the = CHANGELOG only.

=

--

Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Fri, Sep 25, 2015 at 1:28 PM, Dave Page <= span dir=3D"ltr"><dpage@pgadmin.org> wrote:
=
Ashesh, are you able to deal with this before Monday (when= I'll be cutting the feature-frozen beta 1 tarballs)?

On F= ri, Sep 25, 2015 at 7:03 AM, John Obaterspok <john.obaterspok@gma= il.com> wrote:
Thanks, appreciated.=C2=A0

Can it be committed then= ? :)

2015-09-23 9:49 GMT+02:00 Sanket Mehta <sanket.mehta@= enterprisedb.com>:
Hi John/Ashesh,

I have reviewed the patch and i= t seems fine to me.

Regards,
Sanket Mehta
Sr = Software engineer
Enterprisedb

On Wed, Sep 23, 2015 at 11:= 08 AM, John Obaterspok <john.obaterspok@gmail.com> w= rote:
Hi Sanket,
Did you give the patch a try? I would really like it to for the= next release :)

-- = john

2015-09-16 20:27 GMT+02:00 John Obaterspok <john.obaterspok@gmail.com>:
Hi Sanket,

Attached patch is rebased = now.

Regards,

-- john
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0

2015-09-16 11:20 GMT+02= :00 Sanket Mehta <sanket.mehta@enterprisedb.com>= :
Hi John= ,

Patch is not proper.
I got below error when I try t= o apply the patch:

error: patch failed: pgadmin/frm/frmQuery.cpp:243= 5
error: pgadmin/frm/frmQuery.cpp: patch does not apply

Ple= ase do provide the proper patch.
=C2=A0

Regards,
Sanket = Mehta
Sr Software engineer
Enterprisedb

On Mon, Sep 14, 2015 at 10:= 51 AM, Sanket Mehta <sanket.mehta@enterprisedb.com> wrote:
Sure Ashesh,<= div>
I will review the patch.

Regards,
Sanket Meh= ta
Sr Software engineer
Enterprisedb
<= /div>

On Mon, Sep 14, 2015 at 1:12 PM, Ashesh Vash= i <ashesh.vashi@enterprisedb.com> wrote:
Sanket,

Can y= ou please take a look at it?

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Mon, Sep 14, 2015 at 1:07 AM, J= ohn Obaterspok <john.obaterspok@gmail.com> wrote:
Hell= o,

I'm updated the patch to add commit/rollback acti= ons in the toolbar with the following:
1) updated icons (based on exist= ing pgadmin icon with arrows drawn by me)
2) add entry to menu as= well
3) disable icons when not in a transaction
4)= Ctrl+Shift C|R shortcut

Hopefully all issues are = resolved now!

Regards,

= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 John



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=











<= /div>--
Dave PageBlog: http://pg= snake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.= com
The Enterprise PostgreSQL Company
--089e0160a3accca12705208dbf50--