Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b21vZ-00024N-Ip for pgadmin-hackers@arkaria.postgresql.org; Sun, 15 May 2016 19:42:13 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1b21vZ-0008Aa-5T for pgadmin-hackers@arkaria.postgresql.org; Sun, 15 May 2016 19:42:13 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1b21vX-00089p-Mi for pgadmin-hackers@postgresql.org; Sun, 15 May 2016 19:42:11 +0000 Received: from mail-io0-x232.google.com ([2607:f8b0:4001:c06::232]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1b21vT-00020a-3C for pgadmin-hackers@postgresql.org; Sun, 15 May 2016 19:42:11 +0000 Received: by mail-io0-x232.google.com with SMTP id i75so183100262ioa.3 for ; Sun, 15 May 2016 12:42:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=4MPES8WzPEggrd1U7mlzhHTYPg5I685/qP0S0aZ5BME=; b=sRZMH0i8+PqHH52IlwNrh3yOm5v4YPnTALDNhzKwgyAKFdDMZaNg42ifLCNquefgt9 BFXpH6Y0EFG9hVBkyhuW5zOlcXVkCYzruJX/s5FiYbKadDoJbA9/sCfdl/2xGWxptNl5 NCR5UHcETLMxAAZqKy9xATE135M+e73QqkjPtyVx2hUQUep4K/9WT7ohJ/kcBvAp7dlG LPBs8JMmlL8OAMZBsVxbxGgJ6Fm79DBtUYA32im+Y1GEEB7jbMhZUY0FTgQc/f0FMXde VXOUVwRc1RKZjgz4ebb8Tft6JqjqY/Jbwb/4kyy8nMftTN5agukY6QnAkhJCyiKxN8G+ nbTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=4MPES8WzPEggrd1U7mlzhHTYPg5I685/qP0S0aZ5BME=; b=d+WHvwNYBQ/oj3HkNpK3551BArKtRQTqOSWGjisG8Cg2+ZjLfvzzMVqmcY0f+wS0WZ i8kEuDCkBmk5VrWoDHApjX5JmbFuA2QE0oIEtFvFKzAPBjVgCSFyDLZLGkEKcyrRkWkO gQhF4p+jhCApY18P1vagwhrV4zpENd615IYA0QJN+VyrDo7lBi+4t53Slt6sjso6fiUV RgCwDSO+nJyojHaP58LaWA5y6f1obGkrau+MPOYucHF0YpNwtJPulLvdeRTEQLl3CXTK xnasHOerkzBt5VgxQlc7gDwN1scIdwyG9zdyeDdzMWA6gjsBYBa6RiOSBDoCetpFLgvp DRBw== X-Gm-Message-State: AOPr4FUX8fu0x/1UWt5936/C7fwJvPTG35A3OoNm/OUIiUe/i+Jb0rwcngnRbSDxKCxnkVlx6Q4qYyTc2AeiQT2z X-Received: by 10.36.37.73 with SMTP id g70mr6464337itg.51.1463341324561; Sun, 15 May 2016 12:42:04 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.31.209 with HTTP; Sun, 15 May 2016 12:41:45 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Mon, 16 May 2016 01:11:45 +0530 Message-ID: Subject: Re: PATCH: Graphincal explain integrated in sql editor To: Sanket Mehta Cc: Akshay Joshi , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a1145a850d649fd0532e6b32b X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1145a850d649fd0532e6b32b Content-Type: text/plain; charset=UTF-8 On Fri, May 13, 2016 at 4:01 PM, Sanket Mehta wrote: > Hi, > > Apart from resolving all the issues mentioned in previous mail, All the > explain options and auto rollback/auto commit are also added to preferences > dialog. > Any change to explains options or auto-rollback/auto-commit in sql editor > will directly reflect its corresponding option in preference dialog. > Thanks - committed. Looking forward to a minimap kind of functionality for better zooming, and sliding functionalities integrated with the explain module. Also - added nice to have TODO list for the 'Graphical Explain' module. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* > > > Regards, > Sanket Mehta > Sr Software engineer > Enterprisedb > > On Fri, May 13, 2016 at 3:55 PM, Sanket Mehta < > sanket.mehta@enterprisedb.com> wrote: > >> Hi, >> >> Revised patch is attached >> Response in inline. >> >> >> Regards, >> Sanket Mehta >> Sr Software engineer >> Enterprisedb >> >> On Tue, May 10, 2016 at 2:54 PM, Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Hi Sanket >>> >>> On Tue, May 10, 2016 at 12:21 PM, Sanket Mehta >> enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> As previous patch was not applicable to latest pgadmin4 source code, >>>> here is the new patch accommodating latest code. >>>> Please do review it and send comments. >>>> >>> >>> Following is my review comments >>> >>> - Remove Demo and sample code which you have used for testing before >>> integration. >>> >>> Fixes >> >>> >>> - Facing issue to open QueryTool as there is some problem in require >>> module. >>> >>> Fixed >> >>> >>> - Please add 'codemirror/addon/fold/foldgutter', 'codemirror/addon/fold/foldcode', >>> 'codemirror/addon/fold/pgadmin-sqlfoldcode' files which has been >>> removed from your patch. >>> >>> Fixed >> >>> >>> - Remove below code from sqleditor.js which is duplicated in >>> _execute function >>> - >>> - self.trigger( >>> - 'pgadmin-sqleditor:loading-icon:show', >>> - '{{ _('Initializing the query execution!') }}' >>> - ) >>> >>> Fixed >> >>> >>> - Clear the existing contents of the Explain tab when execute the >>> query without explain. >>> >>> Fixed >> >>> >>> - If schema name is exists then please prefix the schema name to the >>> node. >>> >>> Fixed >> >>> >>> - Please check the data is available before working on it in >>> sqleditor.js at line no 1043 inside _render(). In case of "View >>> Data" it throws an error. >>> >>> Fixed >> >>> >>> >>>> >>>> Regards, >>>> Sanket Mehta >>>> Sr Software engineer >>>> Enterprisedb >>>> >>>> On Mon, May 9, 2016 at 11:56 PM, Sanket Mehta < >>>> sanket.mehta@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> Please ignore previous patch as there was an error in it. >>>>> >>>>> Error: >>>>> Tooltip was not getting disappear when user moves cursor out of image. >>>>> >>>>> I have attached a proper patch with this mail. >>>>> Please consider it for testing. >>>>> >>>>> Regards, >>>>> Sanket Mehta >>>>> Sr Software engineer >>>>> Enterprisedb >>>>> >>>>> On Mon, May 9, 2016 at 8:49 PM, Sanket Mehta < >>>>> sanket.mehta@enterprisedb.com> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> PFA revised patch according to Ashesh's comments. >>>>>> Please find my response inline. >>>>>> >>>>>> I am currently adding minimap feature in graphical explain. >>>>>> I will send a new patch for the same. >>>>>> >>>>>> Regards, >>>>>> Sanket Mehta >>>>>> Sr Software engineer >>>>>> Enterprisedb >>>>>> >>>>>> On Mon, Apr 25, 2016 at 4:36 PM, Ashesh Vashi < >>>>>> ashesh.vashi@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Sanket, >>>>>>> >>>>>>> Please find the review comments. >>>>>>> - Please add the missing 'explain.css'. >>>>>>> >>>>>> Done >>>>>> >>>>>>> - The application should be smart enough to handle conflict in >>>>>>> options. >>>>>>> i.e. >>>>>>> Buffer is not a valid options without EXPLAIN ANALYZE. >>>>>>> >>>>>> Done >>>>>> >>>>>>> - A statement having EXPLAIN keywords with different format should >>>>>>> at least render the output in the data-grid. >>>>>>> i.e. EXPLAIN (FORMAT xml) SELECT * FROM xyz; >>>>>>> >>>>>> Done >>>>>> >>>>>>> - Please use the keywords used in the EXPLAIN statement in capital. >>>>>>> >>>>>> Done >>>>>> >>>>>>> - Explain should not work with empty string. >>>>>>> >>>>>> Done >>>>>> >>>>>>> - Font size in the tooltip is very small. >>>>>>> >>>>>> Done >>>>>> >>>>>>> >>>>>>> >>>>>> - Smoothing the zoom functionality. >>>>>>> >>>>>> Minimap will be added and zoom functionality will be removed. So it >>>>>> is ignored. >>>>>> >>>>>> - Arrow marker is hardly visible. >>>>>>> >>>>>> Done. >>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> >>>>>>> Thanks & Regards, >>>>>>> >>>>>>> Ashesh Vashi >>>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>>>>> >>>>>>> >>>>>>> >>>>>>> *http://www.linkedin.com/in/asheshvashi* >>>>>>> >>>>>>> >>>>>>> On Mon, Apr 25, 2016 at 3:06 PM, Sanket Mehta < >>>>>>> sanket.mehta@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi, >>>>>>>> >>>>>>>> This patch includes the patch sent earlier for stand alone >>>>>>>> graphical explain. >>>>>>>> >>>>>>>> And also "horizontal lines are not proper" bug is fixed in the same >>>>>>>> which was reported by Dave in previous patch. >>>>>>>> >>>>>>>> Regards, >>>>>>>> Sanket Mehta >>>>>>>> Sr Software engineer >>>>>>>> Enterprisedb >>>>>>>> >>>>>>>> On Thu, Apr 21, 2016 at 8:38 PM, Sanket Mehta < >>>>>>>> sanket.mehta@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> Hi Team, >>>>>>>>> >>>>>>>>> PFA the first patch for graphical explain integrated in sql editor. >>>>>>>>> >>>>>>>>> Below are the few things which are different from previous patch >>>>>>>>> which was sent for stand alone graphical explain. >>>>>>>>> >>>>>>>>> - Now user can select Explain/Explain Analyze with four optional >>>>>>>>> properties (Verbose, costs, timing and buffers) >>>>>>>>> >>>>>>>>> - Initially graph will be scale (according to only its width not >>>>>>>>> height) to fit to screen so no blank space will be there in case of very >>>>>>>>> large graph. >>>>>>>>> >>>>>>>>> - Along with zoom in/out button, "zoom to original" button is also >>>>>>>>> provided, by clicking on which graph will be scale to its original size >>>>>>>>> (not same as initial one which is according to screen size). >>>>>>>>> >>>>>>>>> Please do review this patch and let me know in case you have any >>>>>>>>> comments. >>>>>>>>> >>>>>>>>> >>>>>>>>> Regards, >>>>>>>>> Sanket Mehta >>>>>>>>> Sr Software engineer >>>>>>>>> Enterprisedb >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>>> >>>> -- >>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>>> To make changes to your subscription: >>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>> >>>> >>> >>> >>> -- >>> *Akshay Joshi* >>> *Principal Software Engineer * >>> >>> >>> >>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>> >> >> > --001a1145a850d649fd0532e6b32b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On Fri, May 13, 2016 at 4:01 PM, Sanket Mehta <sanket.meh= ta@enterprisedb.com> wrote:

Hi,

Apart from resolving all the issues mentioned in previous mail, All = the explain options and auto rollback/auto commit are also added to prefere= nces dialog.
Any change to explains options or auto-rollback/auto= -commit in sql editor will directly reflect its corresponding option in pre= ference dialog.
Thanks - committed.
=
Looking forward to a minimap kind of functionality for bette= r zooming, and sliding functionalities integrated with the explain module.<= /div>
Also - added nice to have TODO list for the 'Graphical Explai= n' module.

--

Thanks &a= mp; Regards,

Ashesh Vashi
EnterpriseDB INDIA:=C2= =A0Enterp= rise PostgreSQL Company




Reg= ards,
Sanket Mehta
Sr Software engineer
Enterprised= b

On Fri, May 13= , 2016 at 3:55 PM, Sanket Mehta <sanket.mehta@enterprisedb.com= > wrote:
Hi,

Revised patch is attached
Response in inline.
<= br>

Regards,
Sanket Mehta
Sr Software engineer
<= div>Enterprisedb

On Tue, May 10, 2016 at 2:54 PM= , Akshay Joshi <akshay.joshi@enterprisedb.com> w= rote:
Hi Sanket

On Tue, May 10, 2016 = at 12:21 PM, Sanket Mehta <<= a href=3D"mailto:sanket.mehta@enterprisedb.com" target=3D"_blank">san= ket.mehta@enterprisedb.com> = wrote:
Hi,

=
As previous patch was not applicable to latest pgadmin4 source code, h= ere is the new patch accommodating latest code.
Please do review = it and send comments.

= =C2=A0 =C2=A0 Following is my review comments=C2=A0
  • Remov= e Demo and sample code which you have used for testing before integration.<= /li>
Fixes=C2=A0
=
  • Facing issue to open=C2=A0Query= Tool=C2=A0as there is some problem in require module.
Fixed=C2=A0
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);pa= dding-left:1ex">
  • Please add=C2=A0'codemirror/addon<= /span>/fold/foldgutter', 'codemirror/addon/fold/foldcode', 'codemirror/addon/fold/pgadmin-sqlfoldcode' files which has b= een removed from your patch.
=
Fixed=C2=A0
  • Remove below = code from=C2=A0sqleditor.js=C2=A0which is duplicated in _execute funct= ion
    • self.trigger(
    • =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0'pgadmin-sqleditor:loading-icon:sho= w',
    • =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 '{{ _('In= itializing the query execution!') }}'
    • =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 )
Fixed=C2=A0
  • Clear the existin= g contents of the Explain tab when execute the query without explain.
    • <= /ul>
Fixed=C2=A0
  • If schema name is exists then please prefix the = schema name to the node.=C2=A0
Fixed=C2=A0
  • Please check= the data is available before working on it in=C2=A0sqleditor.js=C2=A0= at line no 1043 inside _render().=C2=A0 In case of "View Data" it= throws an error.
Fixed=C2=A0
=C2=A0
=

Regards,
Sanket Mehta
Sr Software engineer
=
Enterprisedb

On Mon, May 9, 2016 at 11:5= 6 PM, Sanket Mehta <sanket.mehta@enterprisedb.com> wrote:
Hi,

Pleas= e ignore previous patch as there was an error in it.

Error:
Tooltip was not getting disappear when user moves curso= r out of image.

I have attached a proper patch wit= h this mail.
Please consider it for testing.

Regards,
= Sanket Mehta
Sr Software engineer
Enterprisedb

On Mon, May 9, 2016 at 8:49= PM, Sanket Mehta <sanket.mehta@enterprisedb.com> wrote:
Hi,

PFA re= vised patch according to Ashesh's comments.
Please find my re= sponse inline.

I am currently adding minimap featu= re in graphical explain.
I will send a new patch for the same.

Regards,
Sanket Mehta
Sr Software engineer
En= terprisedb

On Mon, Apr 25, 2016 at 4:36 PM= , Ashesh Vashi <ashesh.vashi@enterprisedb.com> w= rote:
Hi Sanket,

Pl= ease find the review comments.
- Please add the missing 'expl= ain.css'.
Done=C2=A0
- The application should be smart enoug= h to handle conflict in options.
=C2=A0 =C2=A0i.e.
=C2= =A0 =C2=A0Buffer is not a valid options without EXPLAIN ANALYZE.
Done=C2=A0
- A statement having EXPLAIN keywords with different format s= hould at least render the output in the data-grid.
=C2=A0 i.e. EX= PLAIN (FORMAT xml) SELECT * FROM xyz;
D= one=C2=A0
- Please use th= e keywords used in the EXPLAIN statement in capital.
Done=C2=A0
= - Explain should not work with empty string.
Done=C2=A0
- Font s= ize in the tooltip is very small.
Done= =C2=A0
=C2=A0
=
- Smoothing the zoom fu= nctionality.
Minimap will be added and = zoom functionality will be removed. So it is ignored.

<= /div>
- Arrow marker is hardly visibl= e.
Done.=C2=A0

--<= /p>

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQ= L Company


http://www.linkedin.com/in/asheshvashi


On Mon, Apr 25, 2016 at 3:06 PM, Sanket Meht= a <sanket.mehta@enterprisedb.com> wrote:
Hi,

This patch includes th= e patch sent earlier for stand alone graphical explain.

And also "horizontal lines are not proper" bug is fixed in = the same which was reported by Dave in previous patch.

Regard= s,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Thu, Apr 21, 2016 at 8:3= 8 PM, Sanket Mehta <sanket.mehta@enterprisedb.com> wrote:
Hi Team,

= PFA the first patch for graphical explain integrated in sql editor.

Below are the few things which are different from previou= s patch which was sent for stand alone graphical explain.

=C2=A0- =C2=A0Now user can select Explain/Explain Analyze with four= optional properties (Verbose, costs, timing and buffers)

=C2=A0- Initially graph will be scale (according to only its width = not height) to fit to screen so no blank space will be there in case of ver= y large graph.

- Along with zoom in/out button, &q= uot;zoom to original" button is also provided, by clicking on which gr= aph will be scale to its original size (not same as initial one which is ac= cording to screen size).

Please do review this pat= ch and let me know in case you have any comments.

=
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb







--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=




--
Akshay Joshi<= /span>
Principal Software Engineer=C2=A0


Phone: +91 20-3058-9517
Mobil= e: +91 976-788-8246


--001a1145a850d649fd0532e6b32b--