Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnK3L-0006WM-DZ for pgadmin-hackers@arkaria.postgresql.org; Fri, 23 Sep 2016 06:33:43 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bnK3L-0002gq-0B for pgadmin-hackers@arkaria.postgresql.org; Fri, 23 Sep 2016 06:33:43 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bnK37-0002R2-FG for pgadmin-hackers@postgresql.org; Fri, 23 Sep 2016 06:33:29 +0000 Received: from mail-it0-x22c.google.com ([2607:f8b0:4001:c0b::22c]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bnK34-00041U-Jp for pgadmin-hackers@postgresql.org; Fri, 23 Sep 2016 06:33:28 +0000 Received: by mail-it0-x22c.google.com with SMTP id r192so6619562ita.0 for ; Thu, 22 Sep 2016 23:33:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=MeGZqVZg6B4LixvxQ/j13NXq6c+7vZmkuONxOjfcMog=; b=ivkwxQI1KZMTbu7y33PoP4WkHmx1guGDqFcjVVT4jU77aWi1HDs/aY/d24iNofJ+DG yv3I0HUXO1cRf9+L8PmNTHAdVrAoCmtlnJWWaCqamloOpfogIDawQ/3c3P3X3U4W50Ht C/hnGM6zTywyjFVK3kDx3fq0ZLgXa/g3H5i4Rzetep/v4+ltOhh3F0NatJs/YSt9H5Kc ELtE94PoPiuz5UBVm3g1h0D/APvyubZLN9329Rps4O4oXOPyZjexkft0w4wpqeRBWGU/ vaQJDOi4gjbotFaf+xnM3hVzJ0yfakyOJSVm425+ZGc/lxQ81inEICkdEbCeyAtZdE3o HDNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=MeGZqVZg6B4LixvxQ/j13NXq6c+7vZmkuONxOjfcMog=; b=Oh6VBufUjIe71DydE2t3OsPQYNIAcURFucSS/bz0gXndHJevy5lLUtRseBKceb302c wBEZPBwcYswN5dpMVui0ODnI1+O4Oq50mZ6z3k5Q6VWunqBYIgAg/GQF0UO39NdPboHi bEWEBKdRMYOtrsbFpbHALA5Z2Bf7piSsM2hJiaqUTh9ejEtiaa62uDzsa8X9/9Yq46px q71vLW0E7hdMKNGa0kCa1YYKDhPsogZNqKs1+uFo2K/ikq+cpvVif/sQ6Je0J072UGN9 tmPuZyS04lcwfssqDpYP09p/HXro7T91wyV4Zor1Ha6APjLhc09cG9kjnxfjTuHnv5fS KF1A== X-Gm-Message-State: AA6/9RkYEmHqs9bixkkYVAoWhNcZtDGO6CA4yqM8mYclIOKzby1ThFZOJBUZMAXRRvUErYaZeLJDuTXkAYOlJwNP X-Received: by 10.36.25.14 with SMTP id b14mr1466002itb.29.1474612405488; Thu, 22 Sep 2016 23:33:25 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.50.212 with HTTP; Thu, 22 Sep 2016 23:33:04 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Fri, 23 Sep 2016 12:03:04 +0530 Message-ID: Subject: Re: PATCH: pgAgent support To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary=001a1144b0c49cbae4053d26f402 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1144b0c49cbae4053d26f402 Content-Type: multipart/alternative; boundary=001a1144b0c49cbade053d26f400 --001a1144b0c49cbade053d26f400 Content-Type: text/plain; charset=UTF-8 Hi Dave, On Thu, Sep 22, 2016 at 8:01 PM, Dave Page wrote: > Hi > > On Thu, Sep 22, 2016 at 11:47 AM, Ashesh Vashi < > ashesh.vashi@enterprisedb.com> wrote: > >> Hi Dave, >> >> Please find the patch for support for paAgent in pgAdmin 4. >> > > Did you forget the binary switch? > > piranha:web dpage$ git apply --binary ~/Downloads/pgagent_v2.patch > error: cannot apply binary patch to 'web/pgadmin/browser/server_ > groups/servers/pgAgent/schedules/static/img/coll-pga_schedule.png' > without full index line > error: web/pgadmin/browser/server_groups/servers/pgAgent/ > schedules/static/img/coll-pga_schedule.png: patch does not apply > error: cannot apply binary patch to 'web/pgadmin/browser/server_ > groups/servers/pgAgent/schedules/static/img/pga_schedule.png' without > full index line > error: web/pgadmin/browser/server_groups/servers/pgAgent/ > schedules/static/img/pga_schedule.png: patch does not apply > error: cannot apply binary patch to 'web/pgadmin/browser/server_ > groups/servers/pgAgent/static/img/coll-pga_job.png' without full index > line > error: web/pgadmin/browser/server_groups/servers/pgAgent/static/img/coll-pga_job.png: > patch does not apply > error: cannot apply binary patch to 'web/pgadmin/browser/server_ > groups/servers/pgAgent/static/img/pga_job-disabled.png' without full > index line > error: web/pgadmin/browser/server_groups/servers/pgAgent/static/img/pga_job-disabled.png: > patch does not apply > error: cannot apply binary patch to 'web/pgadmin/browser/server_ > groups/servers/pgAgent/static/img/pga_job.png' without full index line > error: web/pgadmin/browser/server_groups/servers/pgAgent/static/img/pga_job.png: > patch does not apply > error: cannot apply binary patch to 'web/pgadmin/browser/server_ > groups/servers/pgAgent/steps/static/img/coll-pga_jobstep.png' without > full index line > error: web/pgadmin/browser/server_groups/servers/pgAgent/steps/ > static/img/coll-pga_jobstep.png: patch does not apply > error: cannot apply binary patch to 'web/pgadmin/browser/server_ > groups/servers/pgAgent/steps/static/img/pga_jobstep.png' without full > index line > error: web/pgadmin/browser/server_groups/servers/pgAgent/steps/static/img/pga_jobstep.png: > patch does not apply > >> >> I have also attached another patch for miscellaneous fixes, and adding >> new controls. >> It includes: >> - Added DatetimepickerControl, MomentCell (using moment.js) >> - Used the 'DatetimepickerControl' in Role (Also - resolved an issue, >> when unset the datetime for 'Valid Until'.) >> - Added a 'Select All/Unselect All' adaptor for Select2 used by pgAgent >> nodes. >> - Fixed an issue with SubNodeCollectionControl, which was not starting >> the modification session of the child model, when created default value for >> collection is not null/undefined. And, hence - validation on the child >> model was not working. >> - Fixed a memory leak with SqlFieldControl, and SqlTabControl, which was >> not releasing the CodeMirror properly. >> > > Urgh, that's big. > I know. That's reason - I was reluctant to send earlier. > Applied - but can you look at the following please? > > - Account expires has a hint of 'MMM D YYYY HH:mm:ss.SSS Z". Are > milliseconds really needed? I also get 00 as a fractional timezone offset. > Perhaps we should hide that, when it's 00? > Changed to 'YYYY-MM-DD HH:mm:ss Z'. > > - The date format differs from the ISO format displayed by the query tool. > They should be consistent - and really should be either based on the > client's locale settings, or ISO format. > Done -- Thanks & Regards, Ashesh Vashi > > Thanks. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a1144b0c49cbade053d26f400 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Hi Dave,


On= Thu, Sep 22, 2016 at 8:01 PM, Dave Page <dpage@pgadmin.org>= wrote:

Hi

On T= hu, Sep 22, 2016 at 11:47 AM, Ashesh Vashi <ashesh.vashi@enter= prisedb.com> wrote:
Hi Dave,

Please find t= he patch for support for paAgent in pgAdmin 4.

Did you forget the binary switch?

piranha:web dpage$ git apply --binary ~/Downloads/pgagent_v2.patch= =C2=A0
error: cannot apply binary patch to 'web/pgadmin/brows= er/server_groups/servers/pgAgent/schedules/static/img/coll-pga_schedule.png' without full index line
error: web/pgadmin/b= rowser/server_groups/servers/pgAgent/schedules/static/img/coll-pg= a_schedule.png: patch does not apply
error: cannot apply bin= ary patch to 'web/pgadmin/browser/server_groups/servers/pgAgent/schedules/static/img/pga_schedule.png' without full index line<= /div>
error: web/pgadmin/browser/server_groups/servers/pgAgent/schedules/static/img/pga_schedule.png: patch does not apply
error: cannot apply binary patch to 'web/pgadmin/browser/server_= groups/servers/pgAgent/static/img/coll-pga_job.png' without full i= ndex line
error: web/pgadmin/browser/server_groups/servers/p= gAgent/static/img/coll-pga_job.png: patch does not apply
err= or: cannot apply binary patch to 'web/pgadmin/browser/server_group= s/servers/pgAgent/static/img/pga_job-disabled.png' without full in= dex line
error: web/pgadmin/browser/server_groups/servers/pg= Agent/static/img/pga_job-disabled.png: patch does not apply
= error: cannot apply binary patch to 'web/pgadmin/browser/server_gr= oups/servers/pgAgent/static/img/pga_job.png' without full index li= ne
error: web/pgadmin/browser/server_groups/servers/pgAgent/= static/img/pga_job.png: patch does not apply
error: cannot a= pply binary patch to 'web/pgadmin/browser/server_groups/servers/pg= Agent/steps/static/img/coll-pga_jobstep.png' without full ind= ex line
error: web/pgadmin/browser/server_groups/servers/pgA= gent/steps/static/img/coll-pga_jobstep.png: patch does not apply<= /div>
error: cannot apply binary patch to 'web/pgadmin/browser/serv= er_groups/servers/pgAgent/steps/static/img/pga_jobstep.png' w= ithout full index line
error: web/pgadmin/browser/server_gro= ups/servers/pgAgent/steps/static/img/pga_jobstep.png: patch does not a= pply=C2=A0

I have also attached= another patch for miscellaneous fixes, and adding new controls.
= It includes:
- Added DatetimepickerControl, MomentCell (using mom= ent.js)
- Used the 'DatetimepickerControl' in Role (Also = - resolved an issue, when unset the datetime for 'Valid Until'.)
- Added a 'Select All/Unselect All' adaptor for Select2 use= d by pgAgent nodes.
- Fixed an issue with SubNodeCollectionContro= l, which was not starting the modification session of the child model, when= created default value for collection is not null/undefined. And, hence - v= alidation on the child model was not working.
- Fixed a memory le= ak with SqlFieldControl, and SqlTabControl, which was not releasing the Cod= eMirror properly.

Urgh, = that's big.
I know.
= That's reason - I was reluctant to send earlier.=C2=A0
Applied - but can you look at the = following please?=C2=A0

- Account ex= pires has a hint of 'MMM D YYYY HH:mm:ss.SSS Z". Are milliseconds = really needed? I also get 00 as a fractional timezone offset. Perhaps we sh= ould hide that, when it's 00?
= Changed to 'YYYY-MM-DD HH:mm:ss Z'.=C2=A0
<= div>

- The date format differs from the ISO format displ= ayed by the query tool. They should be consistent - and really should be ei= ther based on the client's locale settings, or ISO format.
<= /div>
Done

--
Tha= nks & Regards,

Ashesh Vashi

Thanks.

--

--001a1144b0c49cbade053d26f400-- --001a1144b0c49cbae4053d26f402 Content-Type: application/octet-stream; name="rolvaliduntil_format.patch" Content-Disposition: attachment; filename="rolvaliduntil_format.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_itfe4wzi0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vw cy9zZXJ2ZXJzL3JvbGVzL3RlbXBsYXRlcy9yb2xlL2pzL3JvbGUuanMgYi93 ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9yb2xl cy90ZW1wbGF0ZXMvcm9sZS9qcy9yb2xlLmpzCmluZGV4IGMwMmJhODguLmU2 NTc0YzUgMTAwNjQ0Ci0tLSBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVy X2dyb3Vwcy9zZXJ2ZXJzL3JvbGVzL3RlbXBsYXRlcy9yb2xlL2pzL3JvbGUu anMKKysrIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3Nl cnZlcnMvcm9sZXMvdGVtcGxhdGVzL3JvbGUvanMvcm9sZS5qcwpAQCAtNDA2 LDcgKzQwNiw3IEBAIGZ1bmN0aW9uKCQsIF8sIFMsIHBnQWRtaW4sIHBnQnJv d3NlciwgYWxlcnRpZnksIEJhY2tmb3JtKSB7CiAgICAgICAgICAgaWQ6ICdy b2x2YWxpZHVudGlsJywgZGlzYWJsZWQ6ICdyZWFkb25seScsIHR5cGU6ICd0 ZXh0JywKICAgICAgICAgICBncm91cDogJ3t7IF8oJ0RlZmluaXRpb24nKSB9 fScsIGxhYmVsOiAne3sgXygnQWNjb3VudCBleHBpcmVzJykgfX0nLAogICAg ICAgICAgIG1vZGU6IFsncHJvcGVydGllcycsICdlZGl0JywgJ2NyZWF0ZSdd LCBjb250cm9sOiAnZGF0ZXRpbWVwaWNrZXInLAotICAgICAgICAgIGRlcHM6 IFsncm9sY2FubG9naW4nXQorICAgICAgICAgIGRlcHM6IFsncm9sY2FubG9n aW4nXSwgb3B0aW9uczoge2Zvcm1hdDogJ1lZWVktTU0tREQgSEg6bW06c3Mg Wid9CiAgICAgICAgIH0sewogICAgICAgICAgIGlkOiAncm9sY29ubmxpbWl0 JywgIHR5cGU6ICdpbnQnLCBncm91cDogJ3t7IF8oJ0RlZmluaXRpb24nKSB9 fScsCiAgICAgICAgICAgbGFiZWw6ICd7eyBfKCdDb25uZWN0aW9uIGxpbWl0 JykgfX0nLCBjZWxsOiAnbnVtYmVyJywK --001a1144b0c49cbae4053d26f402 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a1144b0c49cbae4053d26f402--