Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bX6yj-0002jJ-4H for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 Aug 2016 13:21:57 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bX6yi-0001bF-NJ for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 Aug 2016 13:21:56 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bX6yV-0001N2-AE for pgadmin-hackers@postgresql.org; Tue, 09 Aug 2016 13:21:43 +0000 Received: from mail-it0-x234.google.com ([2607:f8b0:4001:c0b::234]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bX6yR-0005ay-Iv for pgadmin-hackers@postgresql.org; Tue, 09 Aug 2016 13:21:42 +0000 Received: by mail-it0-x234.google.com with SMTP id f6so13732134ith.0 for ; Tue, 09 Aug 2016 06:21:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=j7s4vgxyMmR1/IjKEqtJtD6qMvvtTV7qB0liwDHwVfo=; b=lHO2Cku2cbowEfpeBaqw94su6lE1CJyXfu3LPdxndwK1pAcGISWEGUXYRNKHiiwk60 vtGXe3PFzRh6SUpUtCx5HGvlXHOqJuoU9xTqz723x1j/Pwt+iJjfRcqoR3ujW2S5RYT3 FDbTDtiU3RJYM/rOfblMT2SwkmnBufuQE5atl0Q/GvTBbES1W3VlX0yBz7EUGsAd2aam EbXwZcU1uaOGZXKgHVSeZ5PC/ZSx/eDP/OjxD1b3pzGyPAXY0Z3SWSd8ifiLjPUDxxRr kQi8989x6zTaU5A3pA48mcN1XGhd1Jg9dis0tZhQAVi7LYDcy/bmoKx9kYTtIk2d9NL1 0b/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=j7s4vgxyMmR1/IjKEqtJtD6qMvvtTV7qB0liwDHwVfo=; b=e5GE0kMp7V4z2crH02Pcjwx5MTC0+SqM+ql9Dx74KGfwntIEhzLc53zMbKwkr3szDS wNIMzClvlNZUrtD/yc+u/++ux53IlYLh2fHQWD1Mp8nyNUPJT8qp9HnJBDUTKFZroQJ+ sPefRNDAN7SG1AzXgjzyREqpxjcUILwSq/WT7XdyeOPddjaHfLHqy6QN5Bd/b6yQWPhj e0pu/2W3wms3aEvoyCSFTavvuHtr2V3KOCqYSp+Z5nigkVwES50k/3Hk6T5TZxBmHVfP 3beneFBj5PE83f8Gwm6aXyszj8Q9itYo8+b7lElyZbO++kQp2BEy9tytSnc9l+kLJkXe +sCw== X-Gm-Message-State: AEkoouvac88iZBiQR1lcqlTTOGryn6OTAHHImfXQcKCzbn6zSEEK7j18UxfWbsHoBKFAhQ/2mRklWAfVWBqMhhFH X-Received: by 10.36.124.141 with SMTP id a135mr23480080itd.25.1470748896816; Tue, 09 Aug 2016 06:21:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.6.76 with HTTP; Tue, 9 Aug 2016 06:21:16 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Tue, 9 Aug 2016 18:51:16 +0530 Message-ID: Subject: Re: PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4) To: Dave Page Cc: Murtuza Zabuawala , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a114a967a8c848c0539a369d5 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a114a967a8c848c0539a369d5 Content-Type: text/plain; charset=UTF-8 On Tue, Aug 9, 2016 at 6:47 PM, Dave Page wrote: > > > On Tue, Aug 9, 2016 at 2:07 PM, Ashesh Vashi < > ashesh.vashi@enterprisedb.com> wrote: > >> On Tue, Aug 9, 2016 at 6:34 PM, Dave Page wrote: >> >>> >>> >>> On Tue, Aug 9, 2016 at 2:01 PM, Ashesh Vashi < >>> ashesh.vashi@enterprisedb.com> wrote: >>> >>>> On Tue, Aug 9, 2016 at 6:28 PM, Dave Page wrote: >>>> >>>>> Hi >>>>> >>>>> On Tue, Aug 9, 2016 at 8:07 AM, Murtuza Zabuawala >>>>> wrote: >>>>> > Hi, >>>>> > >>>>> > PFA patch to fix the issue where message panel was showing >>>>> incomplete info. >>>>> > We may still miss some messages from Psycopg2 driver due to limited >>>>> size of >>>>> > notices queue. >>>>> > (RM#1523) >>>>> >>>>> A few thoughts on this (mostly based on my discussions with Ashesh): >>>>> >>>>> 1) You seem to have removed the poll delay. I assume that is to try to >>>>> avoid missing messages? Can we re-introduce the delay (to avoid >>>>> excessive network requests), but collect messages while we're waiting? >>>>> >>>> Using thread? >>>> Start a thread during the timeout? >>>> >>> >>> Not necessarily. If we want a 2 second polling delay, we could just >>> sleep for 0.5 secs, collect messages, sleep for 0.5 sec, collect messages, >>> return to client. >>> >> That's a very huge delay in practical. >> We were hardly waiting for during poll (that was in milliseconds), but - >> still we were loosing a lot of the messages. (a lot more from the current >> implementation). >> > > What was the original delay? Now there appears to be none at all. > That was 10 milliseconds. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* > > >> >> -- >> >> Thanks & Regards, >> >> Ashesh Vashi >> EnterpriseDB INDIA: Enterprise PostgreSQL Company >> >> >> >> *http://www.linkedin.com/in/asheshvashi* >> >> >>> >>> >>>> >>>>> 2) If I run VACUUM, whilst I see messages as I should now, there is no >>>>> query time summary as there is for a query that returns data. >>>>> >>>> >>>>> 3) Can we incrementally display messages? e.g. each time we poll, we >>>>> add the new messages to the messages div, and scroll to the end >>>>> automatically? >>>> >>>> Yeah - that's a good idea. >>>> >>>> -- >>>> >>>> Thanks & Regards, >>>> >>>> Ashesh Vashi >>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>> >>>> >>>> >>>> *http://www.linkedin.com/in/asheshvashi* >>>> >>>> >>>>> >>>> >>>> >>>> >>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>>> >>>>> -- >>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>>>> To make changes to your subscription: >>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>> >>>> >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a114a967a8c848c0539a369d5 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On Tue, Aug 9, 2016 at 6:47 PM, Dav= e Page <dpage@pgadmin.org> wrote:

<= /div>


On Tu= e, Aug 9, 2016 at 2:07 PM, Ashesh Vashi <ashesh.vashi@enterpri= sedb.com> wrote:

On Tue, Aug 9, 2016 at 6:34 PM, Dave Page <dpage@pgadmin.org> wrote:

=


=
On Tue, Aug 9, 2016 at 2:01 PM, Ashesh Vas= hi <ashesh.vashi@enterprisedb.com> wrote:
<= div data-smartmail=3D"gmail_signature">

On Tue, Aug 9, 2016 at 6:28 PM, Dave= Page <dpage@pgadmin.org> wrote:

Hi

On Tue, Aug 9, 2016 at 8:07 AM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi,
>
> PFA patch to fix the issue where message panel was showing incomplete = info.
> We may still miss some messages from Psycopg2 driver due to limited si= ze of
> notices queue.
> (RM#1523)

A few thoughts on this (mostly based on my discussions with Ashesh):=

1) You seem to have removed the poll delay. I assume that is to try to
avoid missing messages? Can we re-introduce the delay (to avoid
excessive network requests), but collect messages while we're waiting?<= br>
Using thread?
Start a thread during t= he timeout?

= Not necessarily. If we want a 2 second polling delay, we could just sleep f= or 0.5 secs, collect messages, sleep for 0.5 sec, collect messages, <rep= eat...> return to client.
That's a very huge delay in practical.
We were hardly waiti= ng for during poll (that was in milliseconds), but - still we were loosing = a lot of the messages. (a lot more from the current implementation).
<= /div>

What was the origi= nal delay? Now there appears to be none at all.
That was 10 milliseconds.

--

<= span style=3D"font-family:"courier new",monospace">Thanks & Regards,

Ashe= sh Vashi
EnterpriseDB INDIA:=C2=A0Enterprise PostgreSQL Company


<= div class=3D"gmail_extra">
=C2=A0

--

= Thanks & Regards,

A= shesh Vashi
EnterpriseDB INDIA:=C2=A0Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi=

=C2=A0
=

2) If I run VACUUM, whilst I see messages as I should now, there is no
query time summary as there is for a query that returns data.

3) Can we incrementally display messages? e.g. each time we poll, we
add the new messages to the messages div, and scroll to the end
automatically?
Yeah - that's a good idea.
=

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:=C2=A0Enterprise PostgreSQL C= ompany


<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);pa= dding-left:1ex">=C2=A0
=C2=A0

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


 --
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers




--
Dave Page
Blog: http://pgsnake.blogspot= .com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The= Enterprise PostgreSQL Company




--
Dave PageBlog: http://pgs= nake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.= com
The Enterprise PostgreSQL Company

--001a114a967a8c848c0539a369d5--