Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMYZC-0003Ui-QS for pgadmin-hackers@arkaria.postgresql.org; Mon, 11 Jul 2016 10:35:58 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bMYZB-00035V-Lq for pgadmin-hackers@arkaria.postgresql.org; Mon, 11 Jul 2016 10:35:57 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bMYYx-0002r8-S7 for pgadmin-hackers@postgresql.org; Mon, 11 Jul 2016 10:35:44 +0000 Received: from mail-io0-x22c.google.com ([2607:f8b0:4001:c06::22c]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bMYYq-0000We-Aw for pgadmin-hackers@postgresql.org; Mon, 11 Jul 2016 10:35:42 +0000 Received: by mail-io0-x22c.google.com with SMTP id s93so52903561ioi.3 for ; Mon, 11 Jul 2016 03:35:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=cwJAnDrVS1UCqrjEcEeiSO9PWVj93pwPGHXQhhILlec=; b=U6UTBmMED1bUicVp1/9UFRlUr9riq4lviNSQDccxD+E3eZaA2Kt7xii0io5Z46kp97 c4vF8QQ1uCuKWYO/mGFIzVMD4gYOUorRG7Apeki9PrP+8syZIo+0JWBynUZabCu1AJwh mzjJ3e+2izCLBNih6Cw3OT6HdWNJI3RPhJCdFFgUiaG1IHhutZIHirudTua7zZsH9X70 zKOh2/XYbo5jBXpDw8/IDjJgOCafs9sZXksSZmnRSCEx6WDZS33f7Alqg86cmX0AtHPj octnN7tsTYc9bq9SVL1diMAhbs32W67waATUS447J04pp7fVSopR+3nBLQ64XQF6Rerd /0Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=cwJAnDrVS1UCqrjEcEeiSO9PWVj93pwPGHXQhhILlec=; b=X5ArArA0uzMhaXRSD5dutPo7Az3IO6pqeamqKN84RUNXeKMWfwzhQ8+FAvmuZ0r0OZ vhH50WHNhFQgOupkzwlEn+iYDLgxWV0JdBgxk//J2UCPhhAXpXRhRpFKCWsecua1/M+D Yx4MjgYHSsUnDZS3iKS1rynjVKZMrzeKUKGn1SEIvIx7Lss2NjYGkCeM+CNPT9EY+LUo uXBTNDbFSMW4HHZODPLOTB89XnVbZxZlu7FQea2Cf3U/8plSgFoHte7WyxgqDtIlEWoS KnBjLEev2tUrZYz1Qc+3lojwAa4lp0VJj5wk7gRvf9dYRhNiJeic0fxUJye4i147DX3P rQHw== X-Gm-Message-State: ALyK8tLueg1u4t1h8joCadV9g/0uGQ3prAk5dIFoP4k28GT7a5cENHMw7CpkxvU8YIxZwrQXBgcoSKTMQc/csHIy X-Received: by 10.107.37.69 with SMTP id l66mr18287835iol.117.1468233335510; Mon, 11 Jul 2016 03:35:35 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.133.217 with HTTP; Mon, 11 Jul 2016 03:35:15 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Mon, 11 Jul 2016 16:05:15 +0530 Message-ID: Subject: Re: PATCH: To fix salt generation in session.py To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary=001a1140ea026942cd053759b6cc X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1140ea026942cd053759b6cc Content-Type: multipart/alternative; boundary=001a1140ea026942c7053759b6ca --001a1140ea026942c7053759b6ca Content-Type: text/plain; charset=UTF-8 Hi Murtuza, Can you please test this patch for the same? -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Mon, Jul 11, 2016 at 12:44 PM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi, > > Please hold on in this patch, Need additional changes. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Mon, Jul 11, 2016 at 12:41 PM, Murtuza Zabuawala < > murtuza.zabuawala@enterprisedb.com> wrote: > >> Hi, >> >> With latest pull session.py fails with below error with python3 because >> in python3 strings 'lowercase' method has been renamed to >> 'ascii_lowercase', PFA patch to fix the issue. >> >> Issue: >> ---------- >> * File "../pgadmin4/web/pgadmin/utils/session.py", line 59, in sign* >> * self.randval = ''.join(random.sample(string.lowercase+string.digits, >> 20))* >> *AttributeError: module 'string' has no attribute 'lowercase'* >> >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > --001a1140ea026942c7053759b6ca Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Murtuza,

Can you please test this pa= tch for the same?

<= div>

--

Thanks & Regards,

Ashesh Vashi
Enterp= riseDB INDIA: Enterprise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Mon, Jul 11, 2016 at 12:44 PM, Murtuza Za= buawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

Please hold on in this patch, Need additional changes.
<= div class=3D"gmail_extra">
--Regards,
Murtuza Zabuawala
EnterpriseDB:=C2= =A0http://www.enterprisedb.com=
The Enterprise PostgreSQL Company

On Mon, Jul 11= , 2016 at 12:41 PM, Murtuza Zabuawala <murtuza.zabuawala@= enterprisedb.com> wrote:
Hi,

With latest pull session.py fails wit= h below error with python3 because in python3 strings 'lowercase' m= ethod has been renamed to 'ascii_lowercase', PFA patch to fix the i= ssue.

Issue:
----------
<= i>=C2=A0 File "../pgadmin4/web/pgadmin/utils/session.py", line 59= , in sign
=C2=A0 =C2=A0 self.randval =3D ''.join(r= andom.sample(string.lowercase+string.digits, 20))
Attribut= eError: module 'string' has no attribute 'lowercase'


--
Regards,<= /span>
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Co= mpany


--001a1140ea026942c7053759b6ca-- --001a1140ea026942cd053759b6cc Content-Type: application/octet-stream; name="hmac_python3.patch" Content-Disposition: attachment; filename="hmac_python3.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iqhw7drp0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3V0aWxzL3Nlc3Npb24ucHkgYi93 ZWIvcGdhZG1pbi91dGlscy9zZXNzaW9uLnB5CmluZGV4IDlmNzQwZjUuLmVm NjVmZDEgMTAwNjQ0Ci0tLSBhL3dlYi9wZ2FkbWluL3V0aWxzL3Nlc3Npb24u cHkKKysrIGIvd2ViL3BnYWRtaW4vdXRpbHMvc2Vzc2lvbi5weQpAQCAtMzks NyArMzksMTEgQEAgZnJvbSB3ZXJremV1Zy5kYXRhc3RydWN0dXJlcyBpbXBv cnQgQ2FsbGJhY2tEaWN0CiAKIAogZGVmIF9jYWxjX2htYWMoYm9keSwgc2Vj cmV0KToKLSAgICByZXR1cm4gYmFzZTY0LmI2NGVuY29kZShobWFjLm5ldyhz ZWNyZXQsIGJvZHksIGhhc2hsaWIuc2hhMSkuZGlnZXN0KCkpCisgICAgcmV0 dXJuIGJhc2U2NC5iNjRlbmNvZGUoCisgICAgICAgIGhtYWMubmV3KAorICAg ICAgICAgICAgc2VjcmV0LmVuY29kZSgpLCBib2R5LmVuY29kZSgpLCBoYXNo bGliLnNoYTEKKyAgICAgICAgKS5kaWdlc3QoKQorICAgICkuZGVjb2RlKCkK IAogCiBjbGFzcyBNYW5hZ2VkU2Vzc2lvbihDYWxsYmFja0RpY3QsIFNlc3Np b25NaXhpbik6CkBAIC01Niw3ICs2MCwxNCBAQCBjbGFzcyBNYW5hZ2VkU2Vz c2lvbihDYWxsYmFja0RpY3QsIFNlc3Npb25NaXhpbik6CiAKICAgICBkZWYg c2lnbihzZWxmLCBzZWNyZXQpOgogICAgICAgICBpZiBub3Qgc2VsZi5obWFj X2RpZ2VzdDoKLSAgICAgICAgICAgIHNlbGYucmFuZHZhbCA9ICcnLmpvaW4o cmFuZG9tLnNhbXBsZShzdHJpbmcubG93ZXJjYXNlK3N0cmluZy5kaWdpdHMs IDIwKSkKKyAgICAgICAgICAgIGlmIGhhc2F0dHIoc3RyaW5nLCAnbG93ZXJj YXNlJyk6CisgICAgICAgICAgICAgICAgcG9wdWxhdGlvbiA9IHN0cmluZy5s b3dlcmNhc2UKKyAgICAgICAgICAgICMgSWYgc2NyaXB0IGlzIHJ1bm5pbmcg dW5kZXIgcHl0aG9uMworICAgICAgICAgICAgZWxpZiBoYXNhdHRyKHN0cmlu ZywgJ2FzY2lpX2xvd2VyY2FzZScpOgorICAgICAgICAgICAgICAgIHBvcHVs YXRpb24gPSBzdHJpbmcuYXNjaWlfbG93ZXJjYXNlCisgICAgICAgICAgICBw b3B1bGF0aW9uICs9IHN0cmluZy5kaWdpdHMKKworICAgICAgICAgICAgc2Vs Zi5yYW5kdmFsID0gJycuam9pbihyYW5kb20uc2FtcGxlKHBvcHVsYXRpb24s IDIwKSkKICAgICAgICAgICAgIHNlbGYuaG1hY19kaWdlc3QgPSBfY2FsY19o bWFjKCclczolcycgJSAoc2VsZi5zaWQsIHNlbGYucmFuZHZhbCksIHNlY3Jl dCkKIAogCkBAIC0xNjMsNyArMTc0LDcgQEAgY2xhc3MgRmlsZUJhY2tlZFNl c3Npb25NYW5hZ2VyKFNlc3Npb25NYW5hZ2VyKToKICAgICAgICAgICAgIGZu YW1lID0gb3MucGF0aC5qb2luKHNlbGYucGF0aCwgc2lkKQogCiAgICAgICAg ICMgdG91Y2ggdGhlIGZpbGUKLSAgICAgICAgd2l0aCBvcGVuKGZuYW1lLCAn dycpOgorICAgICAgICB3aXRoIG9wZW4oZm5hbWUsICd3YicpOgogICAgICAg ICAgICAgcGFzcwogCiAgICAgICAgIHJldHVybiBNYW5hZ2VkU2Vzc2lvbihz aWQ9c2lkKQpAQCAtMTc4LDcgKzE4OSw3IEBAIGNsYXNzIEZpbGVCYWNrZWRT ZXNzaW9uTWFuYWdlcihTZXNzaW9uTWFuYWdlcik6CiAKICAgICAgICAgaWYg b3MucGF0aC5leGlzdHMoZm5hbWUpOgogICAgICAgICAgICAgdHJ5OgotICAg ICAgICAgICAgICAgIHdpdGggb3BlbihmbmFtZSkgYXMgZjoKKyAgICAgICAg ICAgICAgICB3aXRoIG9wZW4oZm5hbWUsICdyYicpIGFzIGY6CiAgICAgICAg ICAgICAgICAgICAgIHJhbmR2YWwsIGhtYWNfZGlnZXN0LCBkYXRhID0gbG9h ZChmKQogICAgICAgICAgICAgZXhjZXB0OgogICAgICAgICAgICAgICAgIHBh c3MKQEAgLTIwMyw3ICsyMTQsNyBAQCBjbGFzcyBGaWxlQmFja2VkU2Vzc2lv bk1hbmFnZXIoU2Vzc2lvbk1hbmFnZXIpOgogICAgICAgICAgICAgc2Vzc2lv bi5zaWduKHNlbGYuc2VjcmV0KQogCiAgICAgICAgIGZuYW1lID0gb3MucGF0 aC5qb2luKHNlbGYucGF0aCwgc2Vzc2lvbi5zaWQpCi0gICAgICAgIHdpdGgg b3BlbihmbmFtZSwgJ3cnKSBhcyBmOgorICAgICAgICB3aXRoIG9wZW4oZm5h bWUsICd3YicpIGFzIGY6CiAgICAgICAgICAgICBkdW1wKAogICAgICAgICAg ICAgICAgIChzZXNzaW9uLnJhbmR2YWwsIHNlc3Npb24uaG1hY19kaWdlc3Qs IGRpY3Qoc2Vzc2lvbikpLAogICAgICAgICAgICAgICAgIGYK --001a1140ea026942cd053759b6cc Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a1140ea026942cd053759b6cc--