MIME-Version: 1.0
From: Ashesh Vashi <ashesh.vashi@enterprisedb.com>
Date: Mon, 11 Jun 2018 09:55:06 +0530
Message-ID: 
 <CAG7mmoy7ruK=HZGOt5GTFsuSF5e4+zHnagU0hJfuMUhqjZs=mw@mail.gmail.com>
Subject: [PATCH] pgAgent segfault
To: Dave Page <dave.page@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="00000000000093f5e1056e562341"
Precedence: bulk

--00000000000093f5e1056e562341
Content-Type: multipart/alternative; boundary="00000000000093f5de056e56233f"

--00000000000093f5de056e56233f
Content-Type: text/plain; charset="UTF-8"

Hi Dave,

While debugging the issue
<https://www.postgresql.org/message-id/CAG7mmoxXB0DsLZyvZ7qevoG17x7bJyw2DWdd0SXEgFg2Uc993A%40mail.gmail.com>
reported by Rob, I found one segfault.
Please find the attached patch to find that fix along with another one.

1. Connection object was being accessed, which was already released.

2. Changed the logic for checking the connection object existence.

We're using "if (!ms_primaryCon)", which should convert the logic as
boolean operator explicitly, which we defined for the 'DBconn' class.

I suspect some compilers (specifically windows one) may not behave that
way, and instead of using the boolean operator, it checks for the pointer
is NULL or not.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com>


*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

--00000000000093f5de056e56233f
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Dave,<div><br></div><div>While debugging the <a href=3D=
"https://www.postgresql.org/message-id/CAG7mmoxXB0DsLZyvZ7qevoG17x7bJyw2DWd=
d0SXEgFg2Uc993A%40mail.gmail.com">issue</a> reported by Rob, I found one se=
gfault.</div><div>Please find the attached patch to find that fix along wit=
h another one.</div><div><br></div><div>1. Connection object was being acce=
ssed, which was already released.</div><div><br></div><div>2. Changed the l=
ogic for checking the connection object existence.</div><div><br></div><div=
>We&#39;re using &quot;if (!ms_primaryCon)&quot;, which should convert the =
logic as boolean operator explicitly, which we defined for the &#39;DBconn&=
#39; class.</div><div><br></div><div>I suspect some compilers (specifically=
 windows one) may not=C2=A0behave that way, and instead of using the boolea=
n operator, it checks for the pointer is NULL or not.</div><div><br clear=
=3D"all"><div><div class=3D"gmail_signature" data-smartmail=3D"gmail_signat=
ure"><div dir=3D"ltr"><div><div dir=3D"ltr"><div style=3D"margin:0pt 0pt 8p=
x"><p style=3D"margin:0pt"><span style=3D"font-family:courier new,monospace=
"><span style=3D"font-style:italic"><span>--</span></span></span></p><p sty=
le=3D"margin:0pt"><span style=3D"font-family:courier new,monospace"><span s=
tyle=3D"font-style:italic"><span>Thanks &amp; Regards,</span></span><br sty=
le=3D"font-style:italic"><br style=3D"font-style:italic"><span style=3D"fon=
t-style:italic">Ashesh Vashi</span><br style=3D"font-style:italic"><span st=
yle=3D"font-style:italic">EnterpriseDB INDIA: </span><a href=3D"http://www.=
enterprisedb.com" target=3D"_blank">Enterprise PostgreSQL Company</a></span=
></p>
<p style=3D"margin:0pt"><span style=3D"font-family:courier new,monospace"><=
br></span></p>
<p style=3D"margin:0pt"><span style=3D"font-family:courier new,monospace"><=
a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank"><i>http=
://www.linkedin.com/in/asheshvashi</i></a></span></p></div></div></div></di=
v></div></div>
</div></div>

--00000000000093f5de056e56233f--

--00000000000093f5e1056e562341
Content-Type: application/octet-stream; name="pgagent_segfault.patch"
Content-Disposition: attachment; filename="pgagent_segfault.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_ji9r7o4m0

ZGlmZiAtLWdpdCBhL2Nvbm5lY3Rpb24uY3BwIGIvY29ubmVjdGlvbi5jcHAKaW5kZXggMTVmNjA2
Ny4uYTk2MTgzMSAxMDA2NDQKLS0tIGEvY29ubmVjdGlvbi5jcHAKKysrIGIvY29ubmVjdGlvbi5j
cHAKQEAgLTE2MCw3ICsxNjAsNyBAQCBEQmNvbm4gKkRCY29ubjo6SW5pdENvbm5lY3Rpb24oY29u
c3Qgc3RkOjp3c3RyaW5nICZjb25uZWN0U3RyaW5nKQogCQkJKTsKIAl9CiAKLQlpZiAoIW1zX3By
aW1hcnlDb25uKQorCWlmIChtc19wcmltYXJ5Q29ubi0+bV9jb25uID09IE5VTEwpCiAJewogCQlz
dGQ6OndzdHJpbmcgZXJyb3IgPSBtc19wcmltYXJ5Q29ubi0+R2V0TGFzdEVycm9yKCk7CiAJCWRl
bGV0ZSBtc19wcmltYXJ5Q29ubjsKZGlmZiAtLWdpdCBhL3BnQWdlbnQuY3BwIGIvcGdBZ2VudC5j
cHAKaW5kZXggNjkyOGU0ZC4uMzZiMzgzNSAxMDA2NDQKLS0tIGEvcGdBZ2VudC5jcHAKKysrIGIv
cGdBZ2VudC5jcHAKQEAgLTIwNyw3ICsyMDcsNyBAQCB2b2lkIE1haW5Mb29wKCkKIAkJCU1haW5S
ZXN0YXJ0TG9vcChzZXJ2aWNlQ29ubik7CiAJCX0KIAotCQlMb2dNZXNzYWdlKChib29zdDo6d2Zv
cm1hdChMIkNvdWxkbid0IGNyZWF0ZSB0aGUgcHJpbWFyeSBjb25uZWN0aW9uIChhdHRlbXB0ICVk
KTogJXMiKSAlIGF0dGVtcHRDb3VudCAlIHNlcnZpY2VDb25uLT5HZXRMYXN0RXJyb3IoKSkuc3Ry
KCksIExPR19TVEFSVFVQKTsKKwkJTG9nTWVzc2FnZSgoYm9vc3Q6Ondmb3JtYXQoTCJDb3VsZG4n
dCBjcmVhdGUgdGhlIHByaW1hcnkgY29ubmVjdGlvbiBbQXR0ZW1wdCAjJWRdIikgJSBhdHRlbXB0
Q291bnQpLnN0cigpLCBMT0dfU1RBUlRVUCk7CiAKIAkJREJjb25uOjpDbGVhckNvbm5lY3Rpb25z
KHRydWUpOwogCg==
--00000000000093f5e1056e562341--