Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1evafF-0004tI-TH for pgadmin-hackers@arkaria.postgresql.org; Tue, 13 Mar 2018 03:31:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1evafE-0007lL-8G for pgadmin-hackers@arkaria.postgresql.org; Tue, 13 Mar 2018 03:31:48 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1evafD-0007lB-Rk for pgadmin-hackers@lists.postgresql.org; Tue, 13 Mar 2018 03:31:48 +0000 Received: from mail-io0-x243.google.com ([2607:f8b0:4001:c06::243]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1evafA-0004xL-2o for pgadmin-hackers@postgresql.org; Tue, 13 Mar 2018 03:31:46 +0000 Received: by mail-io0-x243.google.com with SMTP id d21so6625727ioc.5 for ; Mon, 12 Mar 2018 20:31:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=h5GNjv+9xCmuVZEATiNhAL0ieCrR1+95k3992wH9W70=; b=Az7Pg6dd2YxTc3mpAmeURJkfJnNqZZ9SRfCRA5uz/MOrxs0sU1Xhc1c1vRYN934Hpz 1yS6NOIMDf6CapxLTEMi8OYRs4ynxeHrYCXicQM15OizpXK3GiqYyDknGuwCNoI3BXDc 5K1awG0msp/tq8yb3ppa19VSjeEn+Dk2TFHJajldIfiqQiM4a11BICwBa0X/sJy22oa/ hx0LqxzJ7ecblmpkoWtGv4RPzzPcBB5f0hMcgoDOP68BX52A+2L0xB3H8SbpgdMjyA3U Vw9LkWKKPrIpOpONrX4nziiw6eF9UH5oteVPEV2IMp7n8ZspuT3p/zepBf05WtT343uq hFcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=h5GNjv+9xCmuVZEATiNhAL0ieCrR1+95k3992wH9W70=; b=eoe0KVNATwXpWYVhLo/9OKY1RpTf6qUsdwcWG/RKqBBpDdmwtSb3lkhUZLXkbEmB3T Prs3bUez60nqpBllQv8Nq1RLCqHwmduV6EkXnj/wztaWjWgx+pHeiKh5ayTxlkhQMFKf 87Do/g62TsIWGd0NAhGt5GqbuWB4eFSReLoHQqXwsE9JoM3hFr0h/jJY5LB8frprRFAs UK5nWsLT4nNy3mHhNu4EvYjL9MxvZyE3eT4fq2aMhGITbkIFkSJsRA9Fb/AedTaaCoTO TDryU/rGEefceYCyWeHaACQ1/WrwMePCCrglIxm9ae50tANEiGZls68Ld3e4ht3SX6Qg 0DTw== X-Gm-Message-State: AElRT7H3U9PMH6FAgpxsgxloQj52HCSiAaoiKi6bs9bmToDNTDX3/ss/ OxbBmmpNak6WX3XpcwxstI7EBj5tuaW7f9Hkaf/u4g== X-Google-Smtp-Source: AG47ELuGBFjNK//HZ8eS1HXZLfNvO3jxJG2d5Gg1on/0CAmaiF2M4fUzjoM/fcoFzN0JifCFC+i1vboC7cfNKPRqHmU= X-Received: by 10.107.12.230 with SMTP id 99mr1940040iom.117.1520911902875; Mon, 12 Mar 2018 20:31:42 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.141.195 with HTTP; Mon, 12 Mar 2018 20:31:22 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Tue, 13 Mar 2018 09:01:22 +0530 Message-ID: Subject: Re: [pgAdmin4][RM#3140] Add service parameter To: Murtuza Zabuawala , Dave Page Cc: Joao De Almeida Pereira , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a113f8efcb4c921056742e558" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a113f8efcb4c921056742e558 Content-Type: text/plain; charset="UTF-8" Murtuza/Dave, I have to reviewed/seen the patch yet. But - I have a question. Have we used the service file in the external tools for backup, restore, and import/export functionalities? If not - we should fix that asap. We had missed that during SSL support, and now - we're fixing that. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Tue, Mar 13, 2018 at 6:18 AM, Dave Page wrote: > Hi > > On Mon, Mar 12, 2018 at 5:18 PM, Joao De Almeida Pereira < > jdealmeidapereira@pivotal.io> wrote: > >> Hi Dave and Murtuza, >> >> Regarding this patch we refactored the Javascript code so that is lives >> in a different file and added some tests. >> >> Also we found an issue with karma-jasmine that does not allow us to use >> jasmine 3.1 yet. You can find attached a patch that reverts that commit. >> > > Sounds good, but neither patch will apply (in fact, the Jasmine one looks > entirely backwards). One of the error messages was changed in Murtuza's > patch, and wasn't reflected in your update for example. > > Can you rebase please? > > Thanks. > > >> >> Thanks >> Victoria && Joao >> >> On Mon, Mar 12, 2018 at 4:46 PM Dave Page wrote: >> >>> Thanks, patch applied! >>> >>> On Mon, Mar 12, 2018 at 3:31 AM, Murtuza Zabuawala < >>> murtuza.zabuawala@enterprisedb.com> wrote: >>> >>>> Hi Dave, >>>> >>>> PFA updated patch. >>>> >>>> -- >>>> Regards, >>>> Murtuza Zabuawala >>>> EnterpriseDB: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> >>>> On Fri, Mar 9, 2018 at 9:29 PM, Murtuza Zabuawala < >>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>> >>>>> Hi Dave, >>>>> >>>>> I'll change the name and send you updated patch. >>>>> >>>>> >>>>> On Fri, Mar 9, 2018 at 9:25 PM, Dave Page wrote: >>>>> >>>>>> HI >>>>>> >>>>>> On Fri, Mar 9, 2018 at 11:47 AM, Murtuza Zabuawala < >>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> PFA patch to add service parameter in server dialog. >>>>>>> - Docs updated >>>>>>> - Test case added for Service ID parameter >>>>>>> >>>>>>> Please note, >>>>>>> I have extracted Connection class and Server manager class from our >>>>>>> own custom Psycopg2 driver module. >>>>>>> >>>>>>> Patch also covers RM#3120 >>>>>>> >>>>>> >>>>>> This patch seems a little confused. The "Service" and "Service ID" >>>>>> fields from pgAdmin 3 are very different things. The Redmine ticket seems >>>>>> to be asking for the Service field (the pg_service.conf service name), >>>>>> *not* Service ID (the operating system's service ID, used to start/stop the >>>>>> database server service). >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>> >>>>> >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a113f8efcb4c921056742e558 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Murtuza/Dave,

I have to reviewed/se= en the patch yet.
But - I have a question.<= /div>
Have we used the service file in the extern= al tools for backup, restore, and import/export functionalities?
If not - we should fix that asap.

We had missed that during SSL su= pport, and now - we're fixing that.
<= div dir=3D"ltr">

<= span style=3D"font-family:courier new,monospace">--

<= span>Thanks & Regards,
Ashesh Vashi=
En= terpriseDB INDIA: Enterprise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Tue, Mar 13, 2018 at 6:18 AM, Dave Page <= span dir=3D"ltr"><dpage@pgadmin.org> wrote:
=
Hi

On Mon, Mar 12, 2018 at 5:18 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hi Dave and Murtuza,

R= egarding this patch we refactored the Javascript code so that is lives in a= different file and added some tests.

Also we foun= d an issue with karma-jasmine that does not allow us to use jasmine 3.1 yet= . You can find attached a patch that reverts that commit.

Sounds good, but neither patch will apply= (in fact, the Jasmine one looks entirely backwards). One of the error mess= ages was changed in Murtuza's patch, and wasn't reflected in your u= pdate for example.

Can you rebase please?

Thanks.
=
=C2=A0

<= /div>
Thanks
Victoria && Joao

On Mon, Mar 12, 2018 at 4:46 PM Dave Page <dpage@pgadmin.org> w= rote:
Thanks, patc= h applied!

O= n Mon, Mar 12, 2018 at 3:31 AM, Murtuza Zabuawala <murtuz= a.zabuawala@enterprisedb.com> wrote:
Hi Dave,

PFA updated patch.

<= div dir=3D"ltr">--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://ww= w.enterprisedb.com
The Enterprise PostgreSQL Company

=

On Fri, Mar 9, 2018 at 9:29 PM, Murtuza Zabu= awala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,

I'll change the name and s= end you updated patch.
<= div dir=3D"ltr">

=

On Fri, Mar 9, 2018 at 9:25 PM, Dave Page <= dpage@pgadmin.org> wrote:
<= div dir=3D"ltr">HI

On Fri, Mar 9, 2018 at 11:47 AM, Murtuza Zabuawala &= lt;= murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to add=C2=A0service parameter in se= rver dialog.
- Docs updated
- Test case added for Service ID parameter

Please note,
I have= extracted Connection class and Server manager class from our own custom Ps= ycopg2 driver module.

Patch also covers RM#3120
<= br>
=C2=A0This patch seems a little confused. The "Service&q= uot; and "Service ID" fields from pgAdmin 3 are very different th= ings. The Redmine ticket seems to be asking for the Service field (the pg_s= ervice.conf service name), *not* Service ID (the operating system's ser= vice ID, used to start/stop the database server service).
=

--
Dave Page
Blog: http://pgsnake.blogspot.com
= Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise = PostgreSQL Company





--
Dave Pag= e
Blog: http:/= /pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprise= db.com
The Enterprise PostgreSQL Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Enterpri= seDB UK: http://w= ww.enterprisedb.com
The Enterprise PostgreSQL Company

--001a113f8efcb4c921056742e558--