Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b3xLQ-0005yL-6x for pgadmin-hackers@arkaria.postgresql.org; Sat, 21 May 2016 03:12:52 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1b3xLO-0003sA-Op for pgadmin-hackers@arkaria.postgresql.org; Sat, 21 May 2016 03:12:50 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1b3xLN-0003s1-QW for pgadmin-hackers@postgresql.org; Sat, 21 May 2016 03:12:50 +0000 Received: from mail-ig0-x232.google.com ([2607:f8b0:4001:c05::232]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1b3xLK-0006g1-GC for pgadmin-hackers@postgresql.org; Sat, 21 May 2016 03:12:48 +0000 Received: by mail-ig0-x232.google.com with SMTP id fh2so1467737igd.1 for ; Fri, 20 May 2016 20:12:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=rr5zbdvF5jrhfHB4ZQguURNyuM5e/uhESrqOhha1oCI=; b=j2fhMyMHyHku45PZcsi2v+RnXucJ5wIZbjC5dN3Xmh9GB/EulvBoEZYeXN0wQoLjDU MsZmCrqZ3zuJCwqF/pNNvy2ZCaRoUaklpFXSRGstONQDSRfYaSybrZIDi68+Rbz81exE x+LgLKPSpW4LULRGYEN0kp3xzcNKZaGrwkoUrsoZ1KAp1M0CA4BsuBTGNBXQoI3ZM0ge nwtqpV07usRpjTSbYiFT8uL6VbSPOXyLAX4VhOC0zQhPAt8nOgmtfcg3HB2UFR09w1G1 dJEi8CR5yPJLZjB1ah3b2R8xCmrWOT1jn09wdH1pE/xT2uDy/pce5udQTWbIwX5FK96Y HubA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=rr5zbdvF5jrhfHB4ZQguURNyuM5e/uhESrqOhha1oCI=; b=jDZKQzJl4WZcg6Q2+GRN6oQnFFgL2jrdHK56BdwyhJW0LO8alT3znXVswQJMHLtXUA cRQKS4k3yL+R0MbZXxGBX1Gn1o/NqfYXk+xjku25Kl1hhxJd2x1s9IH/FlMAuvsiEWBa vDE/c1MwJW1sToQoDu0dE6zCKLTrzpMzW4rA9vdGXAqM7H8VcbZ6Gs+3wuLgg0jzP2oc wxaZwJNOnIARCnmaaWSAXe4h+Cy5iPQ/YRZP7NyDAaz7ggLqn70ryJ7aDZCnxksqFAsB iffEXuzXnX0VKMb7rKEQCOT195024DkOFdNPfXKxz24vYgQN2N/6uqpW+hGKXbv0D4hW Y88A== X-Gm-Message-State: AOPr4FU/v0mkJFuJ3jWqPVOtNS7WZdA6LLOcheqZQwFhN3/glWMonbPp+OwshXEPhZWA5VRKwEx5JzQABbRmUFUP X-Received: by 10.50.228.175 with SMTP id sj15mr5486420igc.35.1463800364565; Fri, 20 May 2016 20:12:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.31.209 with HTTP; Fri, 20 May 2016 20:12:24 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Sat, 21 May 2016 08:42:24 +0530 Message-ID: Subject: Re: [PATCH] Tables node (pgAdmin4) To: Dave Page Cc: Akshay Joshi , Harshal Dhumal , pgadmin-hackers Content-Type: multipart/alternative; boundary=f46d04289c77c0a69a05335194b5 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --f46d04289c77c0a69a05335194b5 Content-Type: text/plain; charset=UTF-8 On Sat, May 21, 2016 at 12:01 AM, Dave Page wrote: > Hi > > I just started to take a look at the table dialogue and friends. Here are > a few issues that we need to address - please take care of them: > > 1) Move columns to their own tab. Vertical scrolling is bad. > Should the 'inherit from table' part of columns tab? > > 2) Similarly, move constraints to their own tab. > > 3) Ensure all labels only have a capital letter on the first word, except > if following words are keywords or acronyms, e.g. > > With default values? > Has OIDs? > > 4) s/System tabel?/System table? > > 5) Error messages on fields should not be shown unless the field loses > focus and has an error (see Create Table) > > 6) The sections on the Properties view are not as they should be. As I've > pointed out before, the "General" section should have a limited subset of > information, e.g. name, oid, owner, tablespace, comment and "is system?" > Other properties should be in other appropriate sections. > > 7) Variables grids should not be on the Security tab (as also mentioned > previously). > > 8) Field labels that imply a question (e.g. usually those with a Yes/No > switch for input) should end in a ? - e.g. "Deferrable?" > > 9) On the Trigger dialogue, "Fires" and following controls should move to > a new tab. > > 10) On the MV dialogue, VACUUM settings should be on their own tab, as on > the Table dialogue. > > 11) Privileges controls on the Properties lists should be in a "Security" > group, not "General" > > I think there are a couple of basic principles to follow here: > > - Make properties lists and dialogues consistent with existing ones, from > control grouping right down to spelling and case of labels. > > - Dialogs should never need vertical scrolling by default (e.g. for a new > object with no columns/constraints/whatever yet defined). If you need to > scroll, then things should be moved to a new tab, grouped as appropriate. > > Thanks. > > On Fri, May 20, 2016 at 7:57 AM, Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Thanks - Committed with minor changes. >> >> On Thu, May 19, 2016 at 10:47 PM, Harshal Dhumal < >> harshal.dhumal@enterprisedb.com> wrote: >> >>> Hi, >>> >>> PFA updated patch for table and all it's child nodes (Version 9). This >>> patch does not depend on any of existing table node patch. >>> >>> Major change in this patch: Unlike pgAdmin3 now in table create mode any >>> constraint(s) created (but not saved) will listen to table column changes >>> and adapt themselves accordingly. >>> >>> For e.g. >>> In table create mode user adds column definition with name "col1" then >>> adds constraint which includes column "col1". Now user changes column name >>> to "col2" then constraint will listen to this change and adapt the column >>> name from "col1" to "col2" in constraint definition. Also if column "col2" >>> is removed then constraint will also remove the column "col2" from it's >>> definition. >>> >>> >>> -- >>> *Harshal Dhumal* >>> *Software Engineer * >>> >>> >>> >>> EenterpriseDB >>> >>> >>> >>> -- >>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>> To make changes to your subscription: >>> http://www.postgresql.org/mailpref/pgadmin-hackers >>> >>> >> >> >> -- >> *Akshay Joshi* >> *Principal Software Engineer * >> >> >> >> *Phone: +91 20-3058-9517 <%2B91%2020-3058-9517>Mobile: +91 976-788-8246* >> > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --f46d04289c77c0a69a05335194b5 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Sat, May= 21, 2016 at 12:01 AM, Dave Page <dpage@pgadmin.org> wrote:<= br>
Hi

I just started to take a look at the table dialogue and friends. Here ar= e a few issues that we need to address - please take care of them:

1) Move columns to their own tab. Vertical scrolling is ba= d.
Should the 'inherit from table= 9; part of columns tab?=C2=A0

2) Similarly, move constraints to their o= wn tab.

3) Ensure all labels only have a capital l= etter on the first word, except if following words are keywords or acronyms= , e.g.

=C2=A0 With default values?
=C2= =A0 Has OIDs?
=C2=A0=C2=A0
4) s/System tabel?/System ta= ble?

5) Error messages on fields should not be sho= wn unless the field loses focus and has an error (see Create Table)

6) The sections on the Properties view are not as they sh= ould be. As I've pointed out before, the "General" section sh= ould have a limited subset of information, e.g. name, oid, owner, tablespac= e, comment and "is system?" Other properties should be in other a= ppropriate sections.

7) Variables grids should not= be on the Security tab (as also mentioned previously).

8) Field labels that imply a question (e.g. usually those with a Yes/= No switch for input) should end in a ? - e.g. "Deferrable?"
=

9) On the Trigger dialogue, "Fires" and follo= wing controls should move to a new tab.

10) On the= MV dialogue, VACUUM settings should be on their own tab, as on the Table d= ialogue.

11) Privileges controls on the Properties= lists should be in a "Security" group, not "General"

I think there are a couple of basic principle= s to follow here:

- Make properties lists and dial= ogues consistent with existing ones, from control grouping right down to sp= elling and case of labels.

- Dialogs should never = need vertical scrolling by default (e.g. for a new object with no columns/c= onstraints/whatever yet defined). If you need to scroll, then things should= be moved to a new tab, grouped as appropriate.

Th= anks.

On Fri, May 20, 2016 at 7:57 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks - Committed with minor changes.<= /div>

On= Thu, May 19, 2016 at 10:47 PM, Harshal Dhumal <harshal.dhum= al@enterprisedb.com> wrote:
Hi,

PFA updated patch for table and all it's = child nodes (Version 9). This patch does not depend on any of existing tabl= e node patch.

Major change in= this patch: Unlike pgAdmin3 now in table create mode any constraint(s) cre= ated (but not saved) will listen to table column changes and adapt themselv= es accordingly.

For e.g.
In table create mode user adds column definition= with name "col1" then adds constraint which includes column &quo= t;col1". Now user changes column name to "col2" then constra= int will listen to this change and adapt the column name from "col1&qu= ot; to "col2" in constraint definition. Also if column "col2= " is removed then constraint will also remove the column "col2&qu= ot; from it's definition.


--=C2=A0
Harshal Dhumal
Software Engineer= =C2=A0






--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=




--
Akshay Joshi
Principal Software= Engineer=C2=A0

=
Phone: +91 20-3058-9517
Mobile: +91 976-788-8246=



--
Dave Page
Blog: http://pgsnake.blogsp= ot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
T= he Enterprise PostgreSQL Company

--f46d04289c77c0a69a05335194b5--