Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b5PPy-00064L-HP for pgadmin-hackers@arkaria.postgresql.org; Wed, 25 May 2016 03:23:34 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1b5PPx-00034D-Ok for pgadmin-hackers@arkaria.postgresql.org; Wed, 25 May 2016 03:23:33 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1b5PPw-000345-He for pgadmin-hackers@postgresql.org; Wed, 25 May 2016 03:23:32 +0000 Received: from mail-io0-x22c.google.com ([2607:f8b0:4001:c06::22c]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1b5PPt-0005xs-4J for pgadmin-hackers@postgresql.org; Wed, 25 May 2016 03:23:31 +0000 Received: by mail-io0-x22c.google.com with SMTP id 190so24581346iow.1 for ; Tue, 24 May 2016 20:23:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=uSMPobLTNGdXwm+OnEK+/L7Nad2XUN4X0mkxbiLsRsE=; b=bgHkqYr3XGMAL8PUbGPKfYuxGMxO26/ha9YbEyIC0lCMgW7Svp3CsNbZPlQX69jrnt FqGmTbOJnWZaCzqgGPBN9Wj+6vIW/usEzJDiyvh2rzjXxUdexDOqfJ48xioZvECo5jhM j+E39qLFQboGBO5k0Tk/YEHsqfJjOnqdb6zAHhFzesY/h8RUCt3YWEK4Md0q+d7U3vka JZbgfohJ56cHyMVW2xmOlo/txlBBA0oulhDIs0EAGOYQSeTspzp+iboo2dhTn09/x46w RFHnRJmGYtP74Iog85Uf/hNjTN1rdsGY65up3jjrz/NV282LO2AcbeJXEiycg48VLVM9 1u3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=uSMPobLTNGdXwm+OnEK+/L7Nad2XUN4X0mkxbiLsRsE=; b=epfUCEFVbhHydb3h7ibWodl2gfatbB5khbJF0YojWgx9bbIJe5ImkwU56go7Rs/Y07 IuQQ7mxImOlZjOWerI0xqeNDt6LAegdQnW1T7mdtwMJRv/UnNnCR7G7ToetL1lr0rWYN N6AN3VUw4EX3wwdidMO/Hrb/DIqQYAPmu+C+HdeVrX+Qlzy4u66xRy0uU74mGCEGfNUc PaQPCGZNpnJmkrewL6+kDD4rE1HPLxFfcZLCKHTcUlIqiaStrdrf4nabmW8OZx3vDvp7 Zyj8x7bV4D/NmjP0Q1py0Y3yfsSl0dA8TIGK7+wJd2KXuYRB/IV6fJRzGp5TX6C+fF9a DShA== X-Gm-Message-State: ALyK8tKLjYx63D25SW5yunsZpKNZsASNCV28D0r5XEWOgo8rm9XMM0MSkfdiyZvtHPVK7Hs/Zz9xLIsqAQCCFOwj X-Received: by 10.107.32.79 with SMTP id g76mr1728971iog.117.1464146607647; Tue, 24 May 2016 20:23:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.142.86 with HTTP; Tue, 24 May 2016 20:23:07 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Wed, 25 May 2016 08:53:07 +0530 Message-ID: Subject: Re: [PATCH] Tables node (pgAdmin4) To: Thom Brown Cc: Murtuza Zabuawala , Dave Page , Akshay Joshi , Harshal Dhumal , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a1140bfb872f42a0533a23244 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1140bfb872f42a0533a23244 Content-Type: text/plain; charset=UTF-8 Hi Thom, Can you please create RM cases for the same, it will be easy to track those issues? We're using "https://redmine.postgresql.org/projects/pgadmin4/" for the same. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Wed, May 25, 2016 at 6:42 AM, Thom Brown wrote: > On 25 May 2016 at 02:00, Thom Brown wrote: > > On 25 May 2016 at 00:29, Thom Brown wrote: > >> On 24 May 2016 at 19:09, Ashesh Vashi > wrote: > >>> > >>> On Mon, May 23, 2016 at 6:35 PM, Murtuza Zabuawala > >>> wrote: > >>>> > >>>> Hi, > >>>> > >>>> PFA patch, which will fixes below mentioned issues, > >>> > >>> Committed. > >> > >> > >> In the Create Table dialog, on the Advanced tab, the "Of type" drop-down > >> lists tables and composite types, but those are supposed to just be > >> composite types. > >> > >> Also, when using OF in CREATE TABLE, LIKE is no longer valid, so LIKE > should > >> be disabled when using OF. Also, there should probably be a way of > setting > >> options for the columns taken from the composite type. For example: > >> > >> CREATE TYPE inventory AS (product_id bigint, product_name text, weight > >> numeric); > >> > >> CREATE TABLE stock OF inventory ( > >> PRIMARY KEY (product_id), > >> weight WITH OPTIONS DEFAULT 0 > >> ); > >> > >> There's currently no way of doing this (neither the primary key, nor the > >> default value for any columns). It should probably automatically > populate > >> the columns from the composite type on the columns tab. > >> > >> Also, could the generated SQL have an empty line between each statement? > > > > Another thing I've noticed is that, when adding columns, the "Is > > primary key?" column is greyed out. Why not just make those > > modifiable in that view rather than having to go into the details for > > each column? > > > > When there's something that hasn't been set up correctly, like adding > > variables for a column, but not actually selecting a variable, the SQL > > pane, correctly, doesn't show an output, but the error message, > > "Please provide input for variable." isn't enough to identify what > > needs checking. Could the relevant tab and field/row be > > highlighted/coloured in red/bold? This is more general, so doesn't > > just apply to the create table dialog. > > Last issue today: > > When using "Of type", it's not valid to allow additional columns to be > added, so those should be prevented. > > Thom > --001a1140bfb872f42a0533a23244 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Thom,

Can you please create RM cases= for the same, it will be easy to track those issues?

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Wed, May 25, 2016 at 6:42 AM, Thom Brown = <t= hom@linux.com> wrote:
On 25 May 2016 at 02:00, Thom Brown <= thom@linux.com> wrote:
> On 25 May 2016 at 00:29, Thom Brown <thom@linux.com> wrote:
>> On 24 May 2016 at 19:09, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
>>>
>>> On Mon, May 23, 2016 at 6:35 PM, Murtuza Zabuawala
>>> <murt= uza.zabuawala@enterprisedb.com> wrote:
>>>>
>>>> Hi,
>>>>
>>>> PFA patch, which will fixes below mentioned issues,
>>>
>>> Committed.
>>
>>
>> In the Create Table dialog, on the Advanced tab, the "Of type= " drop-down
>> lists tables and composite types, but those are supposed to just b= e
>> composite types.
>>
>> Also, when using OF in CREATE TABLE, LIKE is no longer valid, so L= IKE should
>> be disabled when using OF.=C2=A0 Also, there should probably be a = way of setting
>> options for the columns taken from the composite type.=C2=A0 For e= xample:
>>
>> CREATE TYPE inventory AS (product_id bigint, product_name text, we= ight
>> numeric);
>>
>> CREATE TABLE stock OF inventory (
>>=C2=A0 =C2=A0 =C2=A0PRIMARY KEY (product_id),
>>=C2=A0 =C2=A0 =C2=A0weight WITH OPTIONS DEFAULT 0
>> );
>>
>> There's currently no way of doing this (neither the primary ke= y, nor the
>> default value for any columns).=C2=A0 It should probably automatic= ally populate
>> the columns from the composite type on the columns tab.
>>
>> Also, could the generated SQL have an empty line between each stat= ement?
>
> Another thing I've noticed is that, when adding columns, the "= ;Is
> primary key?" column is greyed out.=C2=A0 Why not just make those=
> modifiable in that view rather than having to go into the details for<= br> > each column?
>
> When there's something that hasn't been set up correctly, like= adding
> variables for a column, but not actually selecting a variable, the SQL=
> pane, correctly, doesn't show an output, but the error message, > "Please provide input for variable." isn't enough to ide= ntify what
> needs checking.=C2=A0 Could the relevant tab and field/row be
> highlighted/coloured in red/bold?=C2=A0 This is more general, so doesn= 't
> just apply to the create table dialog.

Last issue today:

When using "Of type", it's not valid to allow additional colu= mns to be
added, so those should be prevented.

Thom

--001a1140bfb872f42a0533a23244--