MIME-Version: 1.0
From: Ashesh Vashi <ashesh.vashi@enterprisedb.com>
Date: Thu, 17 Jan 2019 19:39:56 +0530
Message-ID: 
 <CAG7mmoy_yxF8V842aPYKKzpT4+JEikFwhai8MpQXw_ABqSfp0g@mail.gmail.com>
Subject: Remove hacky way to open/close the dropdown-submenu
To: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>,
	"khushboo.vashi" <khushboo.vashi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000aa880a057fa7f359"
Precedence: bulk

--000000000000aa880a057fa7f359
Content-Type: multipart/alternative; boundary="000000000000aa8806057fa7f357"

--000000000000aa8806057fa7f357
Content-Type: text/plain; charset="UTF-8"

Hi Aditya/Khushboo,

I can see a hacky way to open/close the dropdown-submenu in the menu.js
file.
I've followed a more general way to open/close any submenu in the dropdown
list, instead of just 'Objects' menu.

Can you please review it, and let me know your thoughts?
Let me know if you have any other better approach.


--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com>


*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

--000000000000aa8806057fa7f357
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Aditya/Khushboo,<div><br></div><div>I can see a hacky w=
ay to open/close the dropdown-submenu in the menu.js file.</div><div>I&#39;=
ve followed a more general way to open/close any submenu in the dropdown li=
st, instead of just &#39;Objects&#39; menu.</div><div><br></div><div>Can yo=
u please review it, and let me know your thoughts?</div><div>Let me know if=
 you have any other better approach.</div><div>=C2=A0<br clear=3D"all"><div=
><div dir=3D"ltr" class=3D"gmail_signature" data-smartmail=3D"gmail_signatu=
re"><div dir=3D"ltr"><div><div dir=3D"ltr"><div style=3D"margin:0pt 0pt 8px=
"><p style=3D"margin:0pt"><span style=3D"font-family:courier new,monospace"=
><span style=3D"font-style:italic"><span>--</span></span></span></p><p styl=
e=3D"margin:0pt"><span style=3D"font-family:courier new,monospace"><span st=
yle=3D"font-style:italic"><span>Thanks &amp; Regards,</span></span><br styl=
e=3D"font-style:italic"><br style=3D"font-style:italic"><span style=3D"font=
-style:italic">Ashesh Vashi</span><br style=3D"font-style:italic"><span sty=
le=3D"font-style:italic">EnterpriseDB INDIA: </span><a href=3D"http://www.e=
nterprisedb.com" target=3D"_blank">Enterprise PostgreSQL Company</a></span>=
</p>
<p style=3D"margin:0pt"><span style=3D"font-family:courier new,monospace"><=
br></span></p>
<p style=3D"margin:0pt"><span style=3D"font-family:courier new,monospace"><=
a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank"><i>http=
://www.linkedin.com/in/asheshvashi</i></a></span></p></div></div></div></di=
v></div></div></div></div>

--000000000000aa8806057fa7f357--

--000000000000aa880a057fa7f359
Content-Type: application/octet-stream; name="pgadmin_submenu_open.patch"
Content-Disposition: attachment; filename="pgadmin_submenu_open.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_jr0oyoku0>
X-Attachment-Id: f_jr0oyoku0

ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc3RhdGljL2pzL2Jyb3dzZXIuanMgYi93
ZWIvcGdhZG1pbi9icm93c2VyL3N0YXRpYy9qcy9icm93c2VyLmpzCmluZGV4IGNjMmVhMDUuLjkx
YTA4MWIgMTAwNjQ0Ci0tLSBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc3RhdGljL2pzL2Jyb3dzZXIu
anMKKysrIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zdGF0aWMvanMvYnJvd3Nlci5qcwpAQCAtMzQ5
LDcgKzM0OSw2IEBAIGRlZmluZSgncGdhZG1pbi5icm93c2VyJywgWwogICAgICAgICAgIH1dLCBm
YWxzZSk7CiAgICAgICAgICRvYmpfbW51LmFwcGVuZChjcmVhdGVfc3VibWVudS4kZWwpOwogICAg
ICAgfQotICAgICAgcGdBZG1pbi5Ccm93c2VyLlN1Ym1lbnVFdmVudHMoJG9ial9tbnUpOwogICAg
IH0sCiAgICAgc2F2ZV9jdXJyZW50X2xheW91dDogZnVuY3Rpb24ob2JqKSB7CiAgICAgICBpZihv
YmouZG9ja2VyKSB7CmRpZmYgLS1naXQgYS93ZWIvcGdhZG1pbi9icm93c2VyL3N0YXRpYy9qcy9t
ZW51LmpzIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zdGF0aWMvanMvbWVudS5qcwppbmRleCA1YzUw
OWRhLi40ZGIyYjEyIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9icm93c2VyL3N0YXRpYy9qcy9t
ZW51LmpzCisrKyBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc3RhdGljL2pzL21lbnUuanMKQEAgLTM0
NywzMSArMzQ3LDYgQEAgZGVmaW5lKFsKICAgICByZXR1cm4gKGxlbiA+IDApOwogICB9OwogCi0g
IHBnQWRtaW4uQnJvd3Nlci5TdWJtZW51RXZlbnRzID0gZnVuY3Rpb24oJG1udSkgewotICAgIGxl
dCBzdWJNZW51Q2xvc2UgPSBmdW5jdGlvbihldmVudCkgewotICAgICAgbGV0ICRkcm9wRG93biA9
ICQoZXZlbnQuY3VycmVudFRhcmdldCkuY2xvc2VzdCgnLmRyb3Bkb3duJyk7Ci0gICAgICAkZHJv
cERvd24uZmluZCgnLmRyb3Bkb3duLXN1Ym1lbnUgLmRyb3Bkb3duLW1lbnUnKS5yZW1vdmVDbGFz
cygnc2hvdycpOwotICAgICAgJGRyb3BEb3duLmZpbmQoJy5kcm9wZG93bi1zdWJtZW51JykucmVt
b3ZlQ2xhc3MoJ2Ryb3Bkb3duLXN1Ym1lbnUtdmlzaWJsZScpOwotICAgIH07Ci0KLSAgICBsZXQg
JG5hdmxpbmsgPSAkbW51LnNpYmxpbmdzKCcubmF2LWxpbmsnKTsKLSAgICAkbmF2bGluay5vZmYo
J2NsaWNrJywgc3ViTWVudUNsb3NlKS5vbignY2xpY2snLCBzdWJNZW51Q2xvc2UpOwotICAgICRt
bnUucGFyZW50KCcuZHJvcGRvd24nKS5vZmYoJ3Nob3cuYnMuZHJvcGRvd24nLHN1Yk1lbnVDbG9z
ZSkKLSAgICAgIC5vbignc2hvdy5icy5kcm9wZG93bicsc3ViTWVudUNsb3NlKTsKLQotICAgICRt
bnUuZmluZCgnLmRyb3Bkb3duLWl0ZW0nKS5vZmYoJ21vdXNlb3ZlcicpLm9uKCdtb3VzZW92ZXIn
LCAoZXZlbnQpPT4gewotICAgICAgbGV0ICRkcm9wU3ViTWVudSA9ICQoZXZlbnQuY3VycmVudFRh
cmdldCkuY2xvc2VzdCgnLmRyb3Bkb3duLW1lbnUnKS5maW5kKCcuZHJvcGRvd24tc3VibWVudScp
OwotICAgICAgLyogQ2xvc2UgYWxsIG90aGVyIHN1Ym1lbnVzIGlmIGFueSAqLwotICAgICAgJGRy
b3BTdWJNZW51LmZpbmQoJy5kcm9wZG93bi1tZW51JykucmVtb3ZlQ2xhc3MoJ3Nob3cnKTsKLSAg
ICAgICRkcm9wU3ViTWVudS5yZW1vdmVDbGFzcygnZHJvcGRvd24tc3VibWVudS12aXNpYmxlJyk7
Ci0gICAgICAvKiBPcGVuIHRoZSBjdXJyZW50IHN1Ym1lbnUgaWYgYW55ICovCi0gICAgICBpZigk
KGV2ZW50LmN1cnJlbnRUYXJnZXQpLnBhcmVudCgpLmhhc0NsYXNzKCdkcm9wZG93bi1zdWJtZW51
JykpewotICAgICAgICAkKGV2ZW50LmN1cnJlbnRUYXJnZXQpLnBhcmVudCgpLmZpbmQoJy5kcm9w
ZG93bi1tZW51JykuYWRkQ2xhc3MoJ3Nob3cnKTsKLSAgICAgICAgJChldmVudC5jdXJyZW50VGFy
Z2V0KS5wYXJlbnQoKS5hZGRDbGFzcygnZHJvcGRvd24tc3VibWVudS12aXNpYmxlJyk7Ci0gICAg
ICB9Ci0gICAgfSk7Ci0gIH07Ci0KICAgLy8gTUVOVSBQVUJMSUMgQ0xBU1MgREVGSU5JVElPTgog
ICAvLyA9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KICAgdmFyIE1lbnUgPSBmdW5jdGlv
bihlbGVtZW50LCBvcHRpb25zKSB7CkBAIC00NDMsMTEgKzQxOCwyMSBAQCBkZWZpbmUoWwogICAg
IC5vbigKICAgICAgICdmb2N1cy5wZy5tZW51LmRhdGEtYXBpIGJsdXIucGcubWVudS5kYXRhLWFw
aScsCiAgICAgICAnW2RhdGEtdG9nZ2xlXj0icGctbWVudSJdJywKLSAgICAgIGZ1bmN0aW9uKGUp
IHsKLSAgICAgICAgJChlLnRhcmdldCkuY2xvc2VzdCgnLm1lbnUnKS50b2dnbGVDbGFzcygKLSAg
ICAgICAgICAnZm9jdXMnLCAvXmZvY3VzKGluKT8kLy50ZXN0KGUudHlwZSkKKyAgICAgIGZ1bmN0
aW9uKGV2KSB7CisgICAgICAgICQoZXYudGFyZ2V0KS5jbG9zZXN0KCcubWVudScpLnRvZ2dsZUNs
YXNzKAorICAgICAgICAgICdmb2N1cycsIC9eZm9jdXMoaW4pPyQvLnRlc3QoZXYudHlwZSkKICAg
ICAgICAgKTsKLSAgICAgIH0pOworICAgICAgfSkKKyAgICAub24oJ21vdXNlZW50ZXInLCAnLmRy
b3Bkb3duLXN1Ym1lbnUnLCBmdW5jdGlvbihldikgeworICAgICAgJChldi5jdXJyZW50VGFyZ2V0
KS5yZW1vdmVDbGFzcygnZHJvcGRvd24tc3VibWVudS12aXNpYmxlJykKKyAgICAgICAgLmFkZENs
YXNzKCdkcm9wZG93bi1zdWJtZW51LXZpc2libGUnKTsKKyAgICAgICQoZXYuY3VycmVudFRhcmdl
dCkuZmluZCgnLmRyb3Bkb3duLW1lbnUnKS5maXJzdCgpLmFkZENsYXNzKCdzaG93Jyk7CisgICAg
fSkKKyAgICAub24oJ21vdXNlbGVhdmUnLCAnLmRyb3Bkb3duLXN1Ym1lbnUnLCBmdW5jdGlvbihl
dikgeworICAgICAgJChldi5jdXJyZW50VGFyZ2V0KS5yZW1vdmVDbGFzcygnZHJvcGRvd24tc3Vi
bWVudS12aXNpYmxlJyk7CisgICAgICAkKGV2LmN1cnJlbnRUYXJnZXQpLmZpbmQoJy5kcm9wZG93
bi1tZW51JykuZmlyc3QoKS5yZW1vdmVDbGFzcygnc2hvdycpOworICAgICk7CisgICAgfSk7CiAK
ICAgcmV0dXJuIHBnQWRtaW4uQnJvd3Nlci5NZW51SXRlbTsKIH0pOwo=
--000000000000aa880a057fa7f359--