Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3FU1-0007pb-Ff for pgadmin-hackers@arkaria.postgresql.org; Wed, 26 Apr 2017 05:27:21 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d3FU0-0003wG-9c for pgadmin-hackers@arkaria.postgresql.org; Wed, 26 Apr 2017 05:27:20 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d3FTl-0003Xf-6H for pgadmin-hackers@postgresql.org; Wed, 26 Apr 2017 05:27:05 +0000 Received: from mail-io0-x22b.google.com ([2607:f8b0:4001:c06::22b]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d3FTh-00025U-VM for pgadmin-hackers@postgresql.org; Wed, 26 Apr 2017 05:27:03 +0000 Received: by mail-io0-x22b.google.com with SMTP id k87so231021593ioi.0 for ; Tue, 25 Apr 2017 22:27:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=kz4DcVOAN/j5l6mgdtXdycmAn0AM+gkuDFZHYH3bliM=; b=zxxjZ1z16Rp/UaWPtS0cb7h8/EI6OarBBoW/AXSI3zqAHfIBxv+H3bM5l/mj3nhWf2 getET8iahFRB7hduYVidPE7OkV5524Ck0IMr7a6sUuD+n1tu3Ed4QJQAOU/yFEkCytFu sqLycZ1PgnHSPPV9Klm1dWsrFMb4eozg1fIKd6q2rEiMb4vJwKBsOlwptU6GSBH3ZZUI 6ATI/bB66jUzZLynYy3o95B7wCtTQBEJJHnV7movOQSPHZlqVZWO/y5/aVPd/WC4I4F2 8q/zEYoD8Cbb71OQbjml6yboFDBI3OAm2ih+gzTJJ//lldss0z25hIq+yGGtuV0RqvGj aQgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=kz4DcVOAN/j5l6mgdtXdycmAn0AM+gkuDFZHYH3bliM=; b=Uer18gVSIfdwW4Iq6hEqjkefR+9czTvQ2Yq215AFVPCanDCNAvZhs0xNaUVELrDJDX o+mHvolQkbOZotCpx1q1wQ2bTfDvaf13Z1Nxm8kWApwjpzfzngEi+ibAVo3i8cGtsIap QAZQ8prykayttqPW7bnraXOyTNDIjilWWJjAPdAZ+pZeL7m58ApKHcH6l98l437XEUq/ nmSBEH4MaFgfZk6bxgcfbPh5AI0ukKipRfDO3m0btJbMCvjXkLdp+YNEPcr4zmye8HGx r0NnmKHl5QhX/Vd7B+/+uMOVEfd7dILyodgkNkSxJaQHnpFHqmLOnq4tZqsEraBtLhQs 92cw== X-Gm-Message-State: AN3rC/5Jnp4xoknyy4MszGDXwylGrSSg+cwX6wu6sFnZlaFOkytGo4Te jHUvJGbbZOFJPnfq6jqJQ7D0Bb0cq7s0 X-Received: by 10.107.136.93 with SMTP id k90mr17655633iod.51.1493184420497; Tue, 25 Apr 2017 22:27:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.178.134 with HTTP; Tue, 25 Apr 2017 22:26:39 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Wed, 26 Apr 2017 10:56:39 +0530 Message-ID: Subject: Re: [patch] Dependents and Dependencies in GreenPlum To: Dave Page Cc: Joao Pedro De Almeida Pereira , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a113ed512f81f9d054e0b1675 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113ed512f81f9d054e0b1675 Content-Type: text/plain; charset=UTF-8 On Mon, Apr 24, 2017 at 4:43 PM, Dave Page wrote: > Ashesh, can you review/commit this please? > > On Fri, Apr 21, 2017 at 8:42 PM, Joao Pedro De Almeida Pereira < > jdealmeidapereira@pivotal.io> wrote: > >> Hi Hackers, >> >> We found out that when you are connected to a GreenPlum database and try >> to get Dependents and Dependencies of an object the application was >> returning a SQL error. >> >> This patch splits the SQL query used to retrieve the Dependents, >> Dependencies, and Roles SQL file into multiple versioned files. >> Add Unit Tests for each file. >> Also added __init__.py files to other test directories to run the tests >> in them. >> > Hi Joao & Sarah, Why do we need to add __init__.py in the template directory? I didn't understand the purpose of the adding __init__.py files in the template directories. NOTE: The headers in those files are not consistent with the other project files. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* > Add ORDER BY into Copy Selection Feature test to ensure the results are >> retrieved always in the same order >> Renamed the Scenario of the xss_checks_pgadmin_debugger_test and skip it >> for versions less than 9.1 >> >> Thanks >> >> Joao & Sarah >> >> >> -- >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >> To make changes to your subscription: >> http://www.postgresql.org/mailpref/pgadmin-hackers >> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a113ed512f81f9d054e0b1675 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On M= on, Apr 24, 2017 at 4:43 PM, Dave Page <dpage@pgadmin.org> w= rote:
Ashesh, can you review/commit this please?

On Fri, Apr 21= , 2017 at 8:42 PM, Joao Pedro De Almeida Pereira <jdealmeidaper= eira@pivotal.io> wrote:
H= i Hackers,

We found out that when you are connected to a= GreenPlum database and try to get Dependents and Dependencies of an object= the application was returning a SQL error.

This p= atch splits the SQL query used to retrieve the Dependents, Dependencies, an= d Roles SQL file into multiple versioned files.
Add Unit Tests fo= r each file.
Also added __init__.py files to other test directori= es to run the tests in them.
Hi Joao & Sarah,

Why do we need to ad= d __init__.py in the template directory?
I didn't understand = the purpose of the adding __init__.py files in the template directories.

NOTE: The headers in those files are not consistent = with the other project files.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:=C2=A0Enterprise PostgreSQL Company<= /p>


http://www.linkedin.com/in/asheshvashi=

Add ORDER BY into Copy Selection Feature test t= o ensure the results are retrieved always in the same order
Renam= ed the Scenario of the=C2=A0xss_checks_pgadmin_debugger_test and skip = it for versions less than 9.1

Thanks
Joao & Sarah


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterp= rise PostgreSQL Company

--001a113ed512f81f9d054e0b1675--