Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bX6lV-00029w-2r for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 Aug 2016 13:08:17 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bX6lU-0006Tu-LW for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 Aug 2016 13:08:16 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bX6lH-0006Em-7J for pgadmin-hackers@postgresql.org; Tue, 09 Aug 2016 13:08:03 +0000 Received: from mail-io0-x22a.google.com ([2607:f8b0:4001:c06::22a]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bX6lD-0003VG-7c for pgadmin-hackers@postgresql.org; Tue, 09 Aug 2016 13:08:02 +0000 Received: by mail-io0-x22a.google.com with SMTP id b62so10677404iod.3 for ; Tue, 09 Aug 2016 06:07:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=VxgKMjBpfAI/6c4qPIZhd0qCTznBb2jvwpabLhUoq20=; b=offWCxO5ZjNaLtjTyUqXFHeSGoIHtuOi9S2LyYCfU7P5XhQS+5/Rfmy4Xcpwm3qsN/ qWV7qFfhJ23dZXoWd/lDCaQ9RfOTaHdYENgWQpQ07iyT2S4masjxxQkE0o1Us6I2SC3w FG3mxfuYrEov+RMoPt+6zxU/7J8z2KGfw4h9T32prSHNlcoI+0SANNgI5KT3keDGQWGO wH5W5PyU3G9VZZArBodgTgHGc69fP6OEXgvu1qac+Fb+DlEsgG3bwsvmzFvdxCZhb+hd o3UgTaIAov8pYjbBvRBz/s2ag+gV9QzdHtHStwWwJHcm86MvZMHryAgDRQQH9fJQxWSe mLbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=VxgKMjBpfAI/6c4qPIZhd0qCTznBb2jvwpabLhUoq20=; b=ZWgjQyv9jmvRTSlmTJT4Qz9ahdKCw8Lyf4/ouLH9oYf1P+NLihKU1wo0dWSAwjosTO VsXpQRN56taUAZpI5lzCJHXfRnokhySul0cxTF/wwUrvGFvHITFDjwvR2FqUz9KVfQXl er3/BezCuqJBLHjezhkjPddwY205//lTAjnCx3bdxqx37DegspxxJBqzftGelrGUlZxI rCftLnGMGfnBxoTbRKr/EYTh1N4AWybPy8n7B8lrqaLlRX6tr+CZ/JrmWmUHBRA2OR3a +gYgg5zO1mQRpn26x9QuGQ9Uhns7/Svr9bMcos94vgPrqszt3BGdp2DruX+/Td0VQW1x H26Q== X-Gm-Message-State: AEkooutchHm2pnPLcSHpygQa0ICtxb5JhSjk6kSijVR3eM1rtPQqNcI1Gi0KuYOaz61GzqDcQClf41DSXUrF2u50 X-Received: by 10.107.162.16 with SMTP id l16mr112723743ioe.106.1470748078135; Tue, 09 Aug 2016 06:07:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.6.76 with HTTP; Tue, 9 Aug 2016 06:07:37 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Tue, 9 Aug 2016 18:37:37 +0530 Message-ID: Subject: Re: PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4) To: Dave Page Cc: Murtuza Zabuawala , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a1140a1b4c081d00539a33875 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1140a1b4c081d00539a33875 Content-Type: text/plain; charset=UTF-8 On Tue, Aug 9, 2016 at 6:34 PM, Dave Page wrote: > > > On Tue, Aug 9, 2016 at 2:01 PM, Ashesh Vashi < > ashesh.vashi@enterprisedb.com> wrote: > >> On Tue, Aug 9, 2016 at 6:28 PM, Dave Page wrote: >> >>> Hi >>> >>> On Tue, Aug 9, 2016 at 8:07 AM, Murtuza Zabuawala >>> wrote: >>> > Hi, >>> > >>> > PFA patch to fix the issue where message panel was showing incomplete >>> info. >>> > We may still miss some messages from Psycopg2 driver due to limited >>> size of >>> > notices queue. >>> > (RM#1523) >>> >>> A few thoughts on this (mostly based on my discussions with Ashesh): >>> >>> 1) You seem to have removed the poll delay. I assume that is to try to >>> avoid missing messages? Can we re-introduce the delay (to avoid >>> excessive network requests), but collect messages while we're waiting? >>> >> Using thread? >> Start a thread during the timeout? >> > > Not necessarily. If we want a 2 second polling delay, we could just sleep > for 0.5 secs, collect messages, sleep for 0.5 sec, collect messages, > return to client. > That's a very huge delay in practical. We were hardly waiting for during poll (that was in milliseconds), but - still we were loosing a lot of the messages. (a lot more from the current implementation). -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* > > >> >>> 2) If I run VACUUM, whilst I see messages as I should now, there is no >>> query time summary as there is for a query that returns data. >>> >> >>> 3) Can we incrementally display messages? e.g. each time we poll, we >>> add the new messages to the messages div, and scroll to the end >>> automatically? >> >> Yeah - that's a good idea. >> >> -- >> >> Thanks & Regards, >> >> Ashesh Vashi >> EnterpriseDB INDIA: Enterprise PostgreSQL Company >> >> >> >> *http://www.linkedin.com/in/asheshvashi* >> >> >>> >> >> >> >> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> >>> -- >>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>> To make changes to your subscription: >>> http://www.postgresql.org/mailpref/pgadmin-hackers >>> >> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a1140a1b4c081d00539a33875 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On Tue, Aug 9, 2016 at 6:34 PM, Dav= e Page <dpage@pgadmin.org> wrote:

<= /div>


On Tu= e, Aug 9, 2016 at 2:01 PM, Ashesh Vashi <ashesh.vashi@enterpri= sedb.com> wrote:

On Tue, Aug 9, 2016 at 6:28 PM, Dave Page <dpage@pgadmin.org> wrote:

=
Hi

On Tue, Aug 9, 2016 at 8:07 AM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi,
>
> PFA patch to fix the issue where message panel was showing incomplete = info.
> We may still miss some messages from Psycopg2 driver due to limited si= ze of
> notices queue.
> (RM#1523)

A few thoughts on this (mostly based on my discussions with Ashesh):=

1) You seem to have removed the poll delay. I assume that is to try to
avoid missing messages? Can we re-introduce the delay (to avoid
excessive network requests), but collect messages while we're waiting?<= br>
Using thread?
Start a thread during t= he timeout?

= Not necessarily. If we want a 2 second polling delay, we could just sleep f= or 0.5 secs, collect messages, sleep for 0.5 sec, collect messages, <rep= eat...> return to client.
That&= #39;s a very huge delay in practical.
We were hardly waiting for = during poll (that was in milliseconds), but - still we were loosing a lot o= f the messages. (a lot more from the current implementation).

--

Thanks & Regards,=

Ashesh Vashi
<= span style=3D"font-style:italic">EnterpriseDB INDIA:=C2=A0Enterprise PostgreSQL Comp= any


http://www.linkedin.com= /in/asheshvashi

=C2=A0

2) If I run VACUUM, whilst I see messages as I should now, there is no
query time summary as there is for a query that returns data.

3) Can we incrementally display messages? e.g. each time we poll, we
add the new messages to the messages div, and scroll to the end
automatically?
Yeah - that's a good idea.
=

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:=C2=A0Enterprise PostgreSQL C= ompany


<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);pa= dding-left:1ex">=C2=A0
=C2=A0

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


 --
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers




--
Dave PageBlog: http://pgs= nake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.= com
The Enterprise PostgreSQL Company

--001a1140a1b4c081d00539a33875--