Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1ZpZP3-0006kl-7A for pgadmin-support@arkaria.postgresql.org; Fri, 23 Oct 2015 10:16:53 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1ZpZP2-0006W8-Pu for pgadmin-support@arkaria.postgresql.org; Fri, 23 Oct 2015 10:16:52 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1ZpZP2-0006W1-Fw for pgadmin-support@postgresql.org; Fri, 23 Oct 2015 10:16:52 +0000 Received: from mail-lf0-x22d.google.com ([2a00:1450:4010:c07::22d]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1ZpZOy-0000EQ-VW for pgadmin-support@postgresql.org; Fri, 23 Oct 2015 10:16:51 +0000 Received: by lfbn126 with SMTP id n126so43653671lfb.2 for ; Fri, 23 Oct 2015 03:16:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb_com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=afaHujTeAW2MvCcx9xk1rA4ZZslSPyHIdtPge53tszU=; b=yXdnNzdMleZ56ohjHmsBBOq+dkJ8XpGMbPUN9tPhsd9GJ4C8K9yqmTdkHtr3/JXsgO rAj0T9XKx9RNnFXjc2TEFf15JKFU2R3j04K0XLO01OqKjdyucSw3M1BDZVbJq9QOnrkv yQ2NEjxst/4NLeMxYI8o9woVS70H0H9mXETjc64aOT8U9TurJbjlboMCpfe00d9et9Un o3FLIZWkBa2KOscNnODdR42SWq7FtYpX3I3ulhZ+7xWlyGg6X/s7IO6jjxzhTvBesM0m tjzqQMee0r0fRbWlR8x7cuOUugcIx7z/wIJErH1ejinCna9671EQCdiasTia68oryIv/ VsuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=afaHujTeAW2MvCcx9xk1rA4ZZslSPyHIdtPge53tszU=; b=FOtX+BK1PvC1F8R2kmlW00vtQgHhotbUEztCzpVgWzEvLKucrYc5fULjLhM64Aqu66 Zyp54Q/CEH4kb2VnyXG+EYyqlVCh+dqFYoMsv3zqX3kjOuctejv9YNdRDLYlln1QVwDR f5OgrFNxNpWXsnzXRPLapLizpIhx6AXS/ARYBNglKnzu0diuLOLvlWqvPOyfby6miiH6 nWFWwbML6Lmipbg6lKBF1ETyxf/XcX3vfxxS/bAAUDaXoFpAxkcFGHltn0CrTfxq2AmK vqr0yKIC07QNZbh9HKylXRQkKqwGGK51+0HwXfFJFgb784rA0MucKzkmWaVvpJMP4WC1 tbeQ== X-Gm-Message-State: ALoCoQnPCi0j6bR//VXu5VgW436/CR4YiKXvj8mybhttwQ+XwLZW8bmEttA6lSBuNGFV+m1CBvbp X-Received: by 10.112.163.99 with SMTP id yh3mr11014789lbb.121.1445595407962; Fri, 23 Oct 2015 03:16:47 -0700 (PDT) MIME-Version: 1.0 Received: by 10.112.181.37 with HTTP; Fri, 23 Oct 2015 03:16:28 -0700 (PDT) In-Reply-To: References: <1444887919111-5870044.post@n5.nabble.com> From: Ashesh Vashi Date: Fri, 23 Oct 2015 15:46:28 +0530 Message-ID: Subject: Re: Error about inherited table of column in pgadmin1.20.0 To: Akshay Joshi , JasmineLiu Cc: pgadmin-support , pgadmin-hackers Content-Type: multipart/alternative; boundary=089e011605f4c7e98e0522c2e853 X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-support Precedence: bulk Sender: pgadmin-support-owner@postgresql.org --089e011605f4c7e98e0522c2e853 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, Oct 23, 2015 at 2:59 PM, Akshay Joshi wrote: > Hi Ashesh > > On Fri, Oct 23, 2015 at 1:27 PM, Ashesh Vashi < > ashesh.vashi@enterprisedb.com> wrote: > >> On Fri, Oct 16, 2015 at 5:40 PM, Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Hi Ashesh >>> >> Hi Akshay, >> >> I've modified the patch a little bit for betterment. >> Can you please review and test it? >> > > Patch looks good to me. I have tested it, works fine. > Akshay, Thanks - checked in! Liu Yuanyuan, Thanks for the report. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* > >> -- >> Thanks & Regards, >> Ashesh Vashi >> >>> >>> >>> On Thu, Oct 15, 2015 at 1:51 PM, Ashesh Vashi >> .com> wrote: >>> >>>> On Thu, Oct 15, 2015 at 11:15 AM, JasmineLiu >>> > wrote: >>>> >>>>> Hi, all ! >>>>> >>>>> This is Liu Yuanyuan. >>>>> I find the inherited table of column shown in pgadmin 1.20.0, sometim= es >>>>> isn=E2=80=99t right. That should be a bug. >>>>> Hope someone to do something about this problem! >>>>> Here is my example: >>>>> >>>>> First I execute the following sql in pgadmin 1.20.0 by query tool: >>>>> create schema test; >>>>> create table test.a1(id int); >>>>> create table test.a2(id int, name varchar); >>>>> create table test.a3(age int); >>>>> create table test.aa() inherits(test.a1,test.a2,test.a3); >>>>> >>>>> >>>>> Then in main view of pgadmin 1.20.0=EF=BC=9A >>>>> It shows the column age is inherited from table test.a2, this is not >>>>> right. >>>>> >>>>> >>>>> >>>> Looks like a bug to me. >>>> >>>> Akshay, >>>> >>>> Can you please take a look at it? >>>> >>> >>> I have fixed the issue, attached is the patch file. Can you please >>> review it and if it looks good can you please commit the code. >>> >>>> >>>> -- >>>> >>>> Thanks & Regards, >>>> >>>> Ashesh Vashi >>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>> >>>> >>>> >>>> *http://www.linkedin.com/in/asheshvashi* >>>> >>>> >>>> >>>>> >>>>> I also check the code of pgadmin 1.20.0, I think the method to specif= y >>>>> the >>>>> inherited table of columns is not correct,especially when the inherit= ed >>>>> tables have same column. >>>>> >>>>> Thanks and hope to hear from you soon! >>>>> >>>>> Best wishes! >>>>> Liu Yuanyuan >>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> View this message in context: >>>>> http://postgresql.nabble.com/Error-about-inherited-table-of-column-in= -pgadmin1-20-0-tp5870044.html >>>>> Sent from the PostgreSQL - pgadmin support mailing list archive at >>>>> Nabble.com. >>>>> >>>>> >>>>> -- >>>>> Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org= ) >>>>> To make changes to your subscription: >>>>> http://www.postgresql.org/mailpref/pgadmin-support >>>>> >>>> >>>> >>> >>> >>> -- >>> *Akshay Joshi* >>> *Principal Software Engineer * >>> >>> >>> >>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>> >> >> > > > -- > *Akshay Joshi* > *Principal Software Engineer * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > --089e011605f4c7e98e0522c2e853 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On F= ri, Oct 23, 2015 at 2:59 PM, Akshay Joshi <akshay.joshi@enterp= risedb.com> wrote:
Hi Ashesh

On Fri, Oct 23, 2015 at 1:27 PM, Ashes= h Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Fri= , Oct 16, 2015 at 5:40 PM, Akshay Joshi <akshay.joshi@enterpri= sedb.com> wrote:
Hi Ashesh
Hi Akshay,

=
I've modified the patch a little bit for betterment.
Can you please review and test it?

=C2=A0 =C2=A0Patch looks good to me. I have tes= ted it, works fine.
Akshay,
Thanks - checked in!

Liu Yuanyuan,
Thanks for the rep= ort.

--

Thanks & Regards,

Ashesh Vashi<= /span>
Ent= erpriseDB INDIA: Enterprise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi

= =C2=A0
=

--
=
Thanks & Regards,
Ashesh Vashi


On Thu, Oct 15, 2= 015 at 1:51 PM, Ashesh Vashi &l= t;= ashesh.vashi@enterprisedb.com> wrote:
On Thu, Oct 1= 5, 2015 at 11:15 AM, JasmineLiu <liuyuanyuangogo@gmail.com>= wrote:
Hi= , all !

This is Liu Yuanyuan.
I find the inherited table of column shown in pgadmin 1.20.0, sometimes
isn=E2=80=99t right. That should be a bug.
Hope someone to do something about this problem!
Here is my example:

First I execute the following sql in pgadmin 1.20.0 by query tool:
create schema test;
create table test.a1(id int);
create table test.a2(id int, name varchar);
create table test.a3(age int);
create table test.aa() inherits(test.a1,test.a2,test.a3);


Then in main view of pgadmin 1.20.0=EF=BC=9A
It shows the column age is inherited from table test.a2, this is not right.=
<http://postgresql.nabble.com/file/n5870044/1.jpg= >
<http://postgresql.nabble.com/file/n5870044/2.jpg= >
Looks like a bug to me.

A= kshay,

Can you please take a look at it?
<= /div>

=C2=A0 =C2=A0I have fixed the = issue, attached is the patch file. Can you please review it and if it looks= good can you please commit the code.=C2=A0
<= div class=3D"gmail_quote">

--

Thanks & Regards,

= Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL= Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi

= =C2=A0

I also check the code of pgadmin 1.20.0, I think the method to specify the<= br> inherited table of columns is not correct,especially when the inherited
tables have same column.

Thanks and hope to hear from you soon!

Best wishes!
Liu Yuanyuan




--
View this message in context: http://postgresql.nabble.com/Error-about-inheri= ted-table-of-column-in-pgadmin1-20-0-tp5870044.html
Sent from the PostgreSQL - pgadmin support mailing list archive at Nabble.c= om.


--
Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-support=




--
Akshay Joshi


<= b>Phone: +91 20-3058-9517
Mobile: +91 976-788= -8246




--
<= b>Akshay Joshi
Principal Software Enginee= r=C2=A0

=