Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bUR1l-0002mX-0p for pgadmin-hackers@arkaria.postgresql.org; Tue, 02 Aug 2016 04:10:01 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bUR1k-0001iX-Jw for pgadmin-hackers@arkaria.postgresql.org; Tue, 02 Aug 2016 04:10:00 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bUR1W-0001Tg-IY for pgadmin-hackers@postgresql.org; Tue, 02 Aug 2016 04:09:46 +0000 Received: from mail-io0-x22e.google.com ([2607:f8b0:4001:c06::22e]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bUR1R-0000nX-Ro for pgadmin-hackers@postgresql.org; Tue, 02 Aug 2016 04:09:46 +0000 Received: by mail-io0-x22e.google.com with SMTP id 38so201853284iol.0 for ; Mon, 01 Aug 2016 21:09:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=JkJZuGOG42MfCi7RvYe4y/IZnJE82kNEZPYfeV7AVnU=; b=HRzqAUk6YdO/SfmabqbfekxhxFrL0xDLnWXjW1Y2tXY9AV4Tu0a9gOQpv967qB22o6 JwIn2SChh7xJdT47ao4fEQitsHhzNIpM7Z+bWxAIaPiWtOyTZWcWrPxSSpiQbCsWO4n7 /qen77u0gw6ZGIwQfy48+45gxpM7sgGAUoBBxLLo3o97XQlpiDJ4dXhJI+lxlFOqKt// SshdfNEFDGVUK7Dy7uWUH1Vzfr31xqTOty5HstxqBWte9Of/QiW4xZaCjE4xuatq1u9/ 5Lri0jU2d2dL0x+Pnp0JDXpcMyN6tRWOOfOvdp+yVW3KtCHWrUGr/D9pXkt2I6sa271A UyfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=JkJZuGOG42MfCi7RvYe4y/IZnJE82kNEZPYfeV7AVnU=; b=e7idWh5g3MT8H1LnuStjJFlI2pYiVFbTeGqaniKOK+MQO9Gb+lfc7O2OwlqztC6SwQ xbmVXbLkJMg/7vpn+5FT3p/cx6/sXvsOPwLzmPEQEwl3DRN2Q2f+5f780qrM7YQmzeX9 hkM7vYUnnCMq58I6TlvyYGrYVtHb6bnDIDXzYojQSmjsP7C4OsK99jQQsWVUovnJqp7P 0WUaqLov8nHx1lYfwxyxirGawFYR3zhH/Umdntm1+rkkIVlCcRY+yrFTRd36wqXcnsdj pH26xPHxawUfA6w0AKYlVDRZ1cUbONOZOGYRNCRjTbj7LvsujuwBP9PFwodflBMyNXt9 KV4w== X-Gm-Message-State: AEkoouu/lxRYvU5IporQFcNZeLd0lKYxn1xYBWlRzyqKSg/H5iRNOJdt6Ec4qOE/7ZvmmJioScQ08VpEHtr6oCWe X-Received: by 10.107.162.16 with SMTP id l16mr67881885ioe.106.1470110979821; Mon, 01 Aug 2016 21:09:39 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.6.76 with HTTP; Mon, 1 Aug 2016 21:09:19 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Tue, 2 Aug 2016 09:39:19 +0530 Message-ID: Subject: Re: patch for issue RM1260 [pgAdmin4] To: Dave Page Cc: Harshal Dhumal , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a1140a1b4bba9e905390ee2a8 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1140a1b4bba9e905390ee2a8 Content-Type: text/plain; charset=UTF-8 Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Wed, Jul 27, 2016 at 7:41 PM, Dave Page wrote: > Ashesh; please review and commit this. > > Thanks. > > On Wed, Jul 27, 2016 at 3:07 PM, Harshal Dhumal < > harshal.dhumal@enterprisedb.com> wrote: > >> Hi, >> >> PFA updated patch for RM1260 (V4). >> >> Fixed create and delete operations for foreign table. >> >> >> -- >> *Harshal Dhumal* >> *Software Engineer* >> >> EnterpriseDB India: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> On Wed, Jul 27, 2016 at 6:53 PM, Ashesh Vashi < >> ashesh.vashi@enterprisedb.com> wrote: >> >>> Hi Harshal, >>> >>> During testing, I found that create, and delete operation on foreign >>> table is not working. >>> Foreign table node uses, it's own version of Select2 Control, which >>> should have used maximum functionalities from the original >>> NodeAjaxOptionsControl for consistency reason. >>> Hence - I have made the changes. >>> >>> Can you please take a look at the create, and delete operations, and >>> submit combined patch for all those problems? >>> >>> -- >>> >>> Thanks & Regards, >>> >>> Ashesh Vashi >>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>> >>> >>> >>> *http://www.linkedin.com/in/asheshvashi* >>> >>> >>> On Wed, Jul 27, 2016 at 3:54 PM, Harshal Dhumal < >>> harshal.dhumal@enterprisedb.com> wrote: >>> >>>> and patch file >>>> >>>> -- >>>> *Harshal Dhumal* >>>> *Software Engineer* >>>> >>>> EnterpriseDB India: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> On Wed, Jul 27, 2016 at 3:49 PM, Harshal Dhumal < >>>> harshal.dhumal@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> PFA updated patch for RM1260. >>>>> >>>>> In addition to RM1260 issue I have added following changes in this >>>>> patch. >>>>> 1] datamodel.js: Added option check against undefined. >>>>> 2] foreign key: fixed first empty option issue. >>>>> >>>>> -- >>>>> *Harshal Dhumal* >>>>> *Software Engineer* >>>>> >>>>> EnterpriseDB India: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>>> On Thu, Jul 7, 2016 at 5:08 PM, Ashesh Vashi < >>>>> ashesh.vashi@enterprisedb.com> wrote: >>>>> >>>>>> Sure - I will do. >>>>>> >>>>>> -- >>>>>> >>>>>> Thanks & Regards, >>>>>> >>>>>> Ashesh Vashi >>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>>>> >>>>>> >>>>>> >>>>>> *http://www.linkedin.com/in/asheshvashi* >>>>>> >>>>>> >>>>>> On Thu, Jul 7, 2016 at 2:33 PM, Dave Page wrote: >>>>>> >>>>>>> Ashesh, can you review/commit please? >>>>>>> >>>>>>> Thanks. >>>>>>> >>>>>>> On Thu, Jul 7, 2016 at 7:50 AM, Harshal Dhumal < >>>>>>> harshal.dhumal@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi, >>>>>>>> >>>>>>>> By mistake I deleted a line which was not supposed to be deleted, >>>>>>>> and that line of code was initialization of select2. >>>>>>>> >>>>>>>> -- >>>>>>>> *Harshal Dhumal* >>>>>>>> *Software Engineer* >>>>>>>> >>>>>>>> EnterpriseDB India: http://www.enterprisedb.com >>>>>>>> The Enterprise PostgreSQL Company >>>>>>>> >>>>>>>> On Thu, Jul 7, 2016 at 12:13 PM, Ashesh Vashi < >>>>>>>> ashesh.vashi@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> Hi Harshal, >>>>>>>>> >>>>>>>>> Can you please explain - what was missing in the last patch? >>>>>>>>> >>>>>>>>> -- >>>>>>>>> >>>>>>>>> Thanks & Regards, >>>>>>>>> >>>>>>>>> Ashesh Vashi >>>>>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> *http://www.linkedin.com/in/asheshvashi* >>>>>>>>> >>>>>>>>> >>>>>>>>> On Thu, Jul 7, 2016 at 12:12 PM, Harshal Dhumal < >>>>>>>>> harshal.dhumal@enterprisedb.com> wrote: >>>>>>>>> >>>>>>>>>> Hi, >>>>>>>>>> >>>>>>>>>> PFA updated patch for issue RM1260 >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> *Harshal Dhumal* >>>>>>>>>> *Software Engineer* >>>>>>>>>> >>>>>>>>>> EnterpriseDB India: http://www.enterprisedb.com >>>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>>> >>>>>>>>>> On Thu, Jul 7, 2016 at 12:04 PM, Harshal Dhumal < >>>>>>>>>> harshal.dhumal@enterprisedb.com> wrote: >>>>>>>>>> >>>>>>>>>>> Hi, >>>>>>>>>>> Please ignore this patch as this has some minor issue. I'll sent >>>>>>>>>>> updated one. >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> *Harshal Dhumal* >>>>>>>>>>> *Software Engineer* >>>>>>>>>>> >>>>>>>>>>> EnterpriseDB India: http://www.enterprisedb.com >>>>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>>>> >>>>>>>>>>> On Wed, Jul 6, 2016 at 5:30 PM, Harshal Dhumal < >>>>>>>>>>> harshal.dhumal@enterprisedb.com> wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi, >>>>>>>>>>>> >>>>>>>>>>>> PFA patch for issue RM1260. >>>>>>>>>>>> >>>>>>>>>>>> Changes: Issue wasn't related to foreign table but was due the >>>>>>>>>>>> Select2 control. Now I have improved select2 control to handle null value >>>>>>>>>>>> in multi-select mode. Initial it was returning "null" instead it should >>>>>>>>>>>> return [] (empty array). >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> *Harshal Dhumal* >>>>>>>>>>>> *Software Engineer* >>>>>>>>>>>> >>>>>>>>>>>> EnterpriseDB India: http://www.enterprisedb.com >>>>>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Sent via pgadmin-hackers mailing list ( >>>>>>>>>> pgadmin-hackers@postgresql.org) >>>>>>>>>> To make changes to your subscription: >>>>>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Dave Page >>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>> Twitter: @pgsnake >>>>>>> >>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>> The Enterprise PostgreSQL Company >>>>>>> >>>>>> >>>>>> >>>>> >>>> >>> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a1140a1b4bba9e905390ee2a8 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thanks - committed!

--

<= span style=3D"font-family:courier new,monospace">Thanks & Regards,

Ash= esh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Wed, Jul 27, 2016 at 7:41 PM, Dave Page <= span dir=3D"ltr"><dpage@pgadmin.org> wrote:
=
Ashesh; please review and commit this.

= Thanks.

On Wed, Jul 27, 2016 at 3:07 PM, = Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,
PFA updated patch for RM1260 (V4).

Fixed create and delete o= perations for foreign table.


<= div dir=3D"ltr">
--=C2=A0
Harshal Dhumal
Software Engineer
Ent= erpriseDB India:=C2=A0http://www.ent= erprisedb.com
The Enterprise PostgreS= QL Company
=

On Wed, Jul 27, 2016 at 6:5= 3 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Harshal,
During testing, I found that create, and delete operation = on foreign table is not working.
Foreign table node uses, it'= s own version of Select2 Control, which should have used maximum functional= ities from the original NodeAjaxOptionsControl for consistency reason.
Hence - I have made the changes.

Can you ple= ase take a look at the create, and delete operations, and submit combined p= atch for all those problems?

--

Thanks &= amp; Regards,

Ashesh Vashi
EnterpriseDB IN= DIA: Enter= prise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Wed, Jul 27, 2016 at 3:5= 4 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com>= ; wrote:
and patc= h file

--=C2=A0
Harshal Dhumal
So= ftware Engineer

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company
=

On Wed, Jul 27, 2016 at 3:4= 9 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com>= ; wrote:
Hi,

PFA updated patch for RM1260.

In = addition to RM1260 issue I have added following changes in this patch.
<= /div>1] datamodel.js: Added option check against undefined.
2] for= eign key: fixed first empty option issue.

--=C2=A0
Harshal Dhumal
Software Engineer

Enterpr= iseDB India:=C2=A0http://www.enterpr= isedb.com
The Enterprise PostgreSQL C= ompany

On Thu, Jul 7, 2016 at 5:08= PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Sure - I will d= o.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Thu, Jul 7, 2016 at 2:33= PM, Dave Page <dpage@pgadmin.org> wrote:
Ashesh, can you review/commit please?
=
Thanks.

=
On Thu, Jul 7, 2016 at 7:50 AM, Harshal Dhumal <= span dir=3D"ltr"><harshal.dhumal@enterprisedb.com> wrote:
Hi,

By mista= ke I deleted a line which was not supposed to be deleted, and that line of = code was initialization of select2.

=
--=C2=A0
Hars= hal Dhumal
Software Engineer

EnterpriseDB= India:=C2=A0http://www.enterprisedb= .com
The Enterprise PostgreSQL Comp= any
<= /div>

On Thu, Jul 7, 2016 at 12:1= 3 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Harshal,
Can you please explain - what was missing in the last patc= h?

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Thu, Jul 7, 2016 at 12:12 PM, H= arshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA updated patch for issue RM1260
=

=
--=C2=A0
Harshal Dhumal
Software Enginee= r

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
T= he Enterprise PostgreSQL Company

On Thu, Jul 7, 2016 at 12:04 PM= , Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,
Plea= se ignore this patch as this has some minor issue. I'll sent updated on= e.

<= div>
--=C2=A0
Harshal Dhumal
Soft= ware Engineer

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 6, 2016 at 5:30= PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com>= wrote:
Hi,

PFA patch for issue RM1260.

Changes: Issue w= asn't related to foreign table but was due the Select2 control. Now I h= ave improved select2 control to handle null value in multi-select mode. Ini= tial it was returning "null" instead it should return [] (empty a= rray).


--=C2=A0
Harshal Dhumal
=
Software Engineer

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company




--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=






<= font color=3D"#888888">--
Dave = Page
Blog: htt= p://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: <= a href=3D"http://www.enterprisedb.com" target=3D"_blank">http://www.enterpr= isedb.com
The Enterprise PostgreSQL Company








--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @= pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL= Company

--001a1140a1b4bba9e905390ee2a8--