Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1a3hzD-0000iN-R0 for pgadmin-hackers@arkaria.postgresql.org; Tue, 01 Dec 2015 10:16:40 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1a3hzD-000626-8n for pgadmin-hackers@arkaria.postgresql.org; Tue, 01 Dec 2015 10:16:39 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1a3hyz-0005nJ-FU for pgadmin-hackers@postgresql.org; Tue, 01 Dec 2015 10:16:25 +0000 Received: from mail-lf0-x232.google.com ([2a00:1450:4010:c07::232]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1a3hyv-0000fr-Ul for pgadmin-hackers@postgresql.org; Tue, 01 Dec 2015 10:16:24 +0000 Received: by lfdl133 with SMTP id l133so1717167lfd.2 for ; Tue, 01 Dec 2015 02:16:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=M1AlbnwWZafzu8HE+nbziAcndOTjhDo5T2aTVJLhlmY=; b=snwZWVHyaiXOHzlnIWao1xFa3sPqJkBEE4adyEcO3Ul7vRSZzHiBefD5Laz9UcuP0B Y65tzSGdWD98lmRsN+cPLIqN/GXy4r1G2I+dvKAoubEK//doqhgSETuwzJ6GrCKz0m06 QDdXhCDsL7NKmwr5/qA+NTFbML3B/evnR5RxsGzDglgig60u5hf9Yn9jryMN2kpCbXTF 12EgwywGbFNfLrPFiypt2ktSLFYH5IMYQjTL5enIZDokgsOLasDvtIRHGGaSk+CoFhrr QckwY4RNPmBhlvZ/VvdBdf8v7bvgsaFaGyzsJpnZvh20JwKi69ynjejsqxL2yoL6JunG ZLHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=M1AlbnwWZafzu8HE+nbziAcndOTjhDo5T2aTVJLhlmY=; b=OlETrQ/PrvTPCAPW38jVy1D8RL7hPfcZtqjsGoH5HGduQr8oGVTjKqh1fV22LyC1r9 /HNdMFvdqM3da6Q3/43uqoPMusUD7dW1PZnGzdQNA20HiWSMRiV/RZA/6MPb/jgqWFyQ vuMAvK9eOT8HfvCYz+0OdsL79CSukYtav6koEWwkhe00AES0+fTXGRsjrCuDtUak1iNJ Hs4cFJrNaUF+6hbnN9sPV6wPopmEQFOH3J9gdBcYuU2WLDLio11smFamMYnSsWgA1EBt yykq6OQvsUf33/4v49XeZwYsYI5vZID1sxYTSlTTIufl0F9IOmY7efaQKrzdwmRLPAQK K+7g== X-Gm-Message-State: ALoCoQkgDaPx7unPTldVByu2BRG6e3i80pbuFyKL/VrcS/O9UwEl+pXRTKqCiNRQakz/QpfwK2QD X-Received: by 10.25.21.151 with SMTP id 23mr22469773lfv.165.1448964979928; Tue, 01 Dec 2015 02:16:19 -0800 (PST) MIME-Version: 1.0 Received: by 10.112.95.38 with HTTP; Tue, 1 Dec 2015 02:16:00 -0800 (PST) In-Reply-To: References: From: Ashesh Vashi Date: Tue, 1 Dec 2015 15:46:00 +0530 Message-ID: Subject: Re: pgagent job failing to halt on failed step To: Dave Page Cc: Sanket Mehta , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a11406aaeebcc610525d37268 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a11406aaeebcc610525d37268 Content-Type: text/plain; charset=UTF-8 Yes. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Tue, Dec 1, 2015 at 2:52 PM, Dave Page wrote: > This is what you just committed right Ashesh? > > On Tue, Dec 1, 2015 at 5:36 AM, Sanket Mehta > wrote: > > > > Hi, > > > > There is an issue in current pgagent code as explained below: > > > > Issue: > > In batch mode if user creates a job with multiple job steps then if first > > jobstep gets executed successfully then even if 2nd step is a failure, > job > > will not halt at that point and will complete its execution. which is not > > the expected result. > > > > Analysis: > > The main reason for this issue is that in batch mode, when first step is > > executed successfully, flag succeeded will be set to true, but when the > 2nd > > step gets failed, its not getting reset to false which is why job does > not > > halt at the same instance and continues executing next steps. > > > > I have resolved this issue and patch is attached with this mail for > review. > > Please do review the patch and let me know in case anything is missing. > > Regards, > > Sanket Mehta > > Sr Software engineer > > Enterprisedb > > > > > > -- > > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > > To make changes to your subscription: > > http://www.postgresql.org/mailpref/pgadmin-hackers > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a11406aaeebcc610525d37268 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Yes.

--

Thanks & Rega= rds,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise Pos= tgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Tue, Dec 1, 2015 at 2:52 PM, Dave Page <= dpage@pgadmin.org> wrote:
T= his is what you just committed right Ashesh?

On Tue, Dec 1, 2015 at 5:36 AM, Sanket Mehta
<sanket.mehta@enterpris= edb.com> wrote:
>
> Hi,
>
> There is an issue in current pgagent code as explained below:
>
> Issue:
> In batch mode if user creates a job with multiple job steps then if fi= rst
> jobstep gets executed successfully then even if 2nd step is a failure,= job
> will not halt at that point and will complete its execution. which is = not
> the expected result.
>
> Analysis:
> The main reason for this issue is that in batch mode, when first step = is
> executed successfully, flag succeeded will be set to true, but when th= e 2nd
> step gets failed, its not getting reset to false which is why job does= not
> halt at the same instance and continues executing next steps.
>
> I have resolved this issue and patch is attached with this mail for re= view.
> Please do review the patch and let me know in case anything is missing= .
> Regards,
> Sanket Mehta
> Sr Software engineer
> Enterprisedb
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-ha= ckers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a11406aaeebcc610525d37268--