Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bn5JN-0005N0-Hu for pgadmin-hackers@arkaria.postgresql.org; Thu, 22 Sep 2016 14:49:17 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bn5JM-0008GY-Gg for pgadmin-hackers@arkaria.postgresql.org; Thu, 22 Sep 2016 14:49:16 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bn5JL-0008Dp-He for pgadmin-hackers@postgresql.org; Thu, 22 Sep 2016 14:49:15 +0000 Received: from mail-io0-x233.google.com ([2607:f8b0:4001:c06::233]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bn5JI-0003kC-Eo for pgadmin-hackers@postgresql.org; Thu, 22 Sep 2016 14:49:14 +0000 Received: by mail-io0-x233.google.com with SMTP id r145so88084051ior.0 for ; Thu, 22 Sep 2016 07:49:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=QaBXB7jbK9VU/7znvs0T5yq/V/Cd3ooBx8/q8DI/OnQ=; b=GVtkKAK+y8df/zSkLyygFxLvDbfCHZdUXTHRSLDFDmQnArNdb86aNDeTBm8iENx+RI BLMLQCuLHGXntVA1dK9dfBu24Y9MwnGYndjvM/qNIs0GTzL1IfrbTp5K6VgRN6DWrIbE qkwbN/X+MbmmbV94qBZourATqjqMFAlFvOvKaxxlgjsCnuv++tiBwp+haMlq6a/fte8Z mEcUTDgRRvwNFXDXgNrzTN+vQ8TcxkE9z/TzjZDFdu9ifWA6mMPJssgrxuEoI8SlwUQl 63K8ffNKBx5qPIgZ/4nFE+J+CtKwXi/joznVobCvcz62Gd3Sb4Qqe4H4nHgSVM8DECX/ INcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=QaBXB7jbK9VU/7znvs0T5yq/V/Cd3ooBx8/q8DI/OnQ=; b=eqH0jaYDaW6tJq2XAMg8TpyvJRUPBIFXy6xoAmFe4XKw5mfD/sLcJh2QAHNVGWPgoc QPOXNDGnL17E1zlaC8AM9135cq9aIwJRQWVIz4GMWQUM13D6h76YhR+ReFCcqqPsqzK3 /+P1qFN0iILqQaDMDzbBonDQUbjsANaRBFszqflOhpDcV6V4R5G6OXCO7PNb1rrL1fmQ l+ODEs2OQ+eLDvVFOrevMaGtdoq5i+dljAEQJWs4MsNP8sEpGreDWxzAImqFn6Zj2MwE IJqwSOJLgkJ9fpTyH1/DMMY0ycJBGst+CxzVcYueHAJJussM24sF+KyxGjzUUQinZSKc /8FQ== X-Gm-Message-State: AA6/9RkbG1Thi4JiVn8tRh/rRkYNvWDy/vuMYkQNayAXysG1+jzZ7qiSaeWBuRHZu28nrajJn6xHahm7wbFZjLkW X-Received: by 10.107.35.209 with SMTP id j200mr3185367ioj.26.1474555751407; Thu, 22 Sep 2016 07:49:11 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.50.212 with HTTP; Thu, 22 Sep 2016 07:49:10 -0700 (PDT) Received: by 10.107.50.212 with HTTP; Thu, 22 Sep 2016 07:49:10 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Thu, 22 Sep 2016 20:19:10 +0530 Message-ID: Subject: Re: PATCH: pgAgent support To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a1141b946c3dce6053d19c39e X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1141b946c3dce6053d19c39e Content-Type: text/plain; charset=UTF-8 Will look at them. On Sep 22, 2016 20:08, "Dave Page" wrote: > Hmm - that was clearly hiding from me. I'll take a look now. > > Did you see the rest of my comments? > > On Thu, Sep 22, 2016 at 3:37 PM, Ashesh Vashi > wrote: > > I sent an updated patch immediately. > > > > > > On Sep 22, 2016 20:01, "Dave Page" wrote: > >> > >> Hi > >> > >> On Thu, Sep 22, 2016 at 11:47 AM, Ashesh Vashi > >> wrote: > >>> > >>> Hi Dave, > >>> > >>> Please find the patch for support for paAgent in pgAdmin 4. > >> > >> > >> Did you forget the binary switch? > >> > >> piranha:web dpage$ git apply --binary ~/Downloads/pgagent_v2.patch > >> error: cannot apply binary patch to > >> 'web/pgadmin/browser/server_groups/servers/pgAgent/ > schedules/static/img/coll-pga_schedule.png' > >> without full index line > >> error: > >> web/pgadmin/browser/server_groups/servers/pgAgent/ > schedules/static/img/coll-pga_schedule.png: > >> patch does not apply > >> error: cannot apply binary patch to > >> 'web/pgadmin/browser/server_groups/servers/pgAgent/ > schedules/static/img/pga_schedule.png' > >> without full index line > >> error: > >> web/pgadmin/browser/server_groups/servers/pgAgent/ > schedules/static/img/pga_schedule.png: > >> patch does not apply > >> error: cannot apply binary patch to > >> 'web/pgadmin/browser/server_groups/servers/pgAgent/static/ > img/coll-pga_job.png' > >> without full index line > >> error: > >> web/pgadmin/browser/server_groups/servers/pgAgent/static/ > img/coll-pga_job.png: > >> patch does not apply > >> error: cannot apply binary patch to > >> 'web/pgadmin/browser/server_groups/servers/pgAgent/static/ > img/pga_job-disabled.png' > >> without full index line > >> error: > >> web/pgadmin/browser/server_groups/servers/pgAgent/static/ > img/pga_job-disabled.png: > >> patch does not apply > >> error: cannot apply binary patch to > >> 'web/pgadmin/browser/server_groups/servers/pgAgent/static/ > img/pga_job.png' > >> without full index line > >> error: > >> web/pgadmin/browser/server_groups/servers/pgAgent/static/ > img/pga_job.png: > >> patch does not apply > >> error: cannot apply binary patch to > >> 'web/pgadmin/browser/server_groups/servers/pgAgent/steps/ > static/img/coll-pga_jobstep.png' > >> without full index line > >> error: > >> web/pgadmin/browser/server_groups/servers/pgAgent/steps/ > static/img/coll-pga_jobstep.png: > >> patch does not apply > >> error: cannot apply binary patch to > >> 'web/pgadmin/browser/server_groups/servers/pgAgent/steps/ > static/img/pga_jobstep.png' > >> without full index line > >> error: > >> web/pgadmin/browser/server_groups/servers/pgAgent/steps/ > static/img/pga_jobstep.png: > >> patch does not apply > >>> > >>> > >>> I have also attached another patch for miscellaneous fixes, and adding > >>> new controls. > >>> It includes: > >>> - Added DatetimepickerControl, MomentCell (using moment.js) > >>> - Used the 'DatetimepickerControl' in Role (Also - resolved an issue, > >>> when unset the datetime for 'Valid Until'.) > >>> - Added a 'Select All/Unselect All' adaptor for Select2 used by pgAgent > >>> nodes. > >>> - Fixed an issue with SubNodeCollectionControl, which was not starting > >>> the modification session of the child model, when created default > value for > >>> collection is not null/undefined. And, hence - validation on the child > model > >>> was not working. > >>> - Fixed a memory leak with SqlFieldControl, and SqlTabControl, which > was > >>> not releasing the CodeMirror properly. > >> > >> > >> Urgh, that's big. Applied - but can you look at the following please? > >> > >> - Account expires has a hint of 'MMM D YYYY HH:mm:ss.SSS Z". Are > >> milliseconds really needed? I also get 00 as a fractional timezone > offset. > >> Perhaps we should hide that, when it's 00? > >> > >> - The date format differs from the ISO format displayed by the query > tool. > >> They should be consistent - and really should be either based on the > >> client's locale settings, or ISO format. > >> > >> Thanks. > >> > >> -- > >> Dave Page > >> Blog: http://pgsnake.blogspot.com > >> Twitter: @pgsnake > >> > >> EnterpriseDB UK: http://www.enterprisedb.com > >> The Enterprise PostgreSQL Company > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a1141b946c3dce6053d19c39e Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Will look at them.


On Sep 22, 2016 2= 0:08, "Dave Page" <dpage@= pgadmin.org> wrote:
Hmm - that was clearly hiding from me. I'll take a look now.

Did you see the rest of my comments?

On Thu, Sep 22, 2016 at 3:37 PM, Ashesh Vashi
<ashesh.vashi@enterpris= edb.com> wrote:
> I sent an updated patch immediately.
>
>
> On Sep 22, 2016 20:01, "Dave Page" <dpage@pgadmin.org> wrote:
>>
>> Hi
>>
>> On Thu, Sep 22, 2016 at 11:47 AM, Ashesh Vashi
>> <ashesh.vashi@= enterprisedb.com> wrote:
>>>
>>> Hi Dave,
>>>
>>> Please find the patch for support for paAgent in pgAdmin 4. >>
>>
>> Did you forget the binary switch?
>>
>> piranha:web dpage$ git apply --binary ~/Downloads/pgagent_v2.patch=
>> error: cannot apply binary patch to
>> 'web/pgadmin/browser/server_groups/servers/pgAgent/s= chedules/static/img/coll-pga_schedule.png'
>> without full index line
>> error:
>> web/pgadmin/browser/server_groups/servers/pgAgent/schedu= les/static/img/coll-pga_schedule.png:
>> patch does not apply
>> error: cannot apply binary patch to
>> 'web/pgadmin/browser/server_groups/servers/pgAgent/s= chedules/static/img/pga_schedule.png'
>> without full index line
>> error:
>> web/pgadmin/browser/server_groups/servers/pgAgent/schedu= les/static/img/pga_schedule.png:
>> patch does not apply
>> error: cannot apply binary patch to
>> 'web/pgadmin/browser/server_groups/servers/pgAgent/static= /img/coll-pga_job.png'
>> without full index line
>> error:
>> web/pgadmin/browser/server_groups/servers/pgAgent/static/img/coll-pga_job.png:
>> patch does not apply
>> error: cannot apply binary patch to
>> 'web/pgadmin/browser/server_groups/servers/pgAgent/static= /img/pga_job-disabled.png'
>> without full index line
>> error:
>> web/pgadmin/browser/server_groups/servers/pgAgent/static/img/pga_job-disabled.png:
>> patch does not apply
>> error: cannot apply binary patch to
>> 'web/pgadmin/browser/server_groups/servers/pgAgent/static= /img/pga_job.png'
>> without full index line
>> error:
>> web/pgadmin/browser/server_groups/servers/pgAgent/static/img/pga_job.png:
>> patch does not apply
>> error: cannot apply binary patch to
>> 'web/pgadmin/browser/server_groups/servers/pgAgent/steps/= static/img/coll-pga_jobstep.png'
>> without full index line
>> error:
>> web/pgadmin/browser/server_groups/servers/pgAgent/steps/= static/img/coll-pga_jobstep.png:
>> patch does not apply
>> error: cannot apply binary patch to
>> 'web/pgadmin/browser/server_groups/servers/pgAgent/steps/= static/img/pga_jobstep.png'
>> without full index line
>> error:
>> web/pgadmin/browser/server_groups/servers/pgAgent/steps/= static/img/pga_jobstep.png:
>> patch does not apply
>>>
>>>
>>> I have also attached another patch for miscellaneous fixes, an= d adding
>>> new controls.
>>> It includes:
>>> - Added DatetimepickerControl, MomentCell (using moment.js) >>> - Used the 'DatetimepickerControl' in Role (Also - res= olved an issue,
>>> when unset the datetime for 'Valid Until'.)
>>> - Added a 'Select All/Unselect All' adaptor for Select= 2 used by pgAgent
>>> nodes.
>>> - Fixed an issue with SubNodeCollectionControl, which was not = starting
>>> the modification session of the child model, when created defa= ult value for
>>> collection is not null/undefined. And, hence - validation on t= he child model
>>> was not working.
>>> - Fixed a memory leak with SqlFieldControl, and SqlTabControl,= which was
>>> not releasing the CodeMirror properly.
>>
>>
>> Urgh, that's big. Applied - but can you look at the following = please?
>>
>> - Account expires has a hint of 'MMM D YYYY HH:mm:ss.SSS Z&quo= t;. Are
>> milliseconds really needed? I also get 00 as a fractional timezone= offset.
>> Perhaps we should hide that, when it's 00?
>>
>> - The date format differs from the ISO format displayed by the que= ry tool.
>> They should be consistent - and really should be either based on t= he
>> client's locale settings, or ISO format.
>>
>> Thanks.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--001a1141b946c3dce6053d19c39e--