MIME-Version: 1.0
In-Reply-To: <E1ewQlp-000480-RR@gothos.postgresql.org>
References: <E1ewQlp-000480-RR@gothos.postgresql.org>
From: Ashesh Vashi <ashesh.vashi@enterprisedb.com>
Date: Thu, 15 Mar 2018 16:44:22 +0530
Message-ID: 
 <CAG7mmozECtBM6SrZ6pYLbUmH4HWN-quSa8dCiivADVW9tA+bBw@mail.gmail.com>
Subject: Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py
 when runn
To: Dave Page <dpage@pgadmin.org>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="001a1141fad23b7e5205677199d5"
Precedence: bulk

--001a1141fad23b7e5205677199d5
Content-Type: text/plain; charset="UTF-8"

Hi,

I have just noticed, we're ignoring migrations directory too.
Should we not also check code styling for migrations directory?

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com>


*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

On Thu, Mar 15, 2018 at 4:40 PM, Dave Page <dpage@pgadmin.org> wrote:

> Ignore config_local.py and config_distro.py when running PEP-8 checks.
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=
> 53ae960aeba0dde6109b91c171f22758b1b04ebe
>
> Modified Files
> --------------
> web/.pycodestyle | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>

--001a1141fad23b7e5205677199d5
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi,<div><br></div><div>I have just noticed, we&#39;re igno=
ring migrations directory too.</div><div>Should we not also check code styl=
ing for migrations directory?<br><div class=3D"gmail_extra"><br clear=3D"al=
l"><div><div class=3D"gmail_signature" data-smartmail=3D"gmail_signature"><=
div dir=3D"ltr"><div><div dir=3D"ltr"><div style=3D"margin:0pt 0pt 8px"><p =
style=3D"margin:0pt"><span style=3D"font-family:courier new,monospace"><spa=
n style=3D"font-style:italic"><span>--</span></span></span></p><p style=3D"=
margin:0pt"><span style=3D"font-family:courier new,monospace"><span style=
=3D"font-style:italic"><span>Thanks &amp; Regards,</span></span><br style=
=3D"font-style:italic"><br style=3D"font-style:italic"><span style=3D"font-=
style:italic">Ashesh Vashi</span><br style=3D"font-style:italic"><span styl=
e=3D"font-style:italic">EnterpriseDB INDIA: </span><a href=3D"http://www.en=
terprisedb.com" target=3D"_blank">Enterprise PostgreSQL Company</a></span><=
/p>
<p style=3D"margin:0pt"><span style=3D"font-family:courier new,monospace"><=
br></span></p>
<p style=3D"margin:0pt"><span style=3D"font-family:courier new,monospace"><=
a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank"><i>http=
://www.linkedin.com/in/asheshvashi</i></a></span></p></div></div></div></di=
v></div></div>
<br><div class=3D"gmail_quote">On Thu, Mar 15, 2018 at 4:40 PM, Dave Page <=
span dir=3D"ltr">&lt;<a href=3D"mailto:dpage@pgadmin.org" target=3D"_blank"=
>dpage@pgadmin.org</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quot=
e" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">=
Ignore config_local.py and config_distro.py when running PEP-8 checks.<br>
<br>
Branch<br>
------<br>
master<br>
<br>
Details<br>
-------<br>
<a href=3D"https://git.postgresql.org/gitweb?p=3Dpgadmin4.git;a=3Dcommitdif=
f;h=3D53ae960aeba0dde6109b91c171f22758b1b04ebe" rel=3D"noreferrer" target=
=3D"_blank">https://git.postgresql.org/<wbr>gitweb?p=3Dpgadmin4.git;a=3D<wb=
r>commitdiff;h=3D<wbr>53ae960aeba0dde6109b91c171f227<wbr>58b1b04ebe</a><br>
<br>
Modified Files<br>
--------------<br>
web/.pycodestyle | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
</blockquote></div><br></div></div></div>

--001a1141fad23b7e5205677199d5--