Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1j9Opj-0000IH-D0 for pgadmin-hackers@arkaria.postgresql.org; Wed, 04 Mar 2020 07:52:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1j9Opi-0003nE-69 for pgadmin-hackers@arkaria.postgresql.org; Wed, 04 Mar 2020 07:52:46 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1j9Oph-0003n7-RJ for pgadmin-hackers@lists.postgresql.org; Wed, 04 Mar 2020 07:52:45 +0000 Received: from mail-ot1-x344.google.com ([2607:f8b0:4864:20::344]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1j9Opf-0000Yv-AQ for pgadmin-hackers@postgresql.org; Wed, 04 Mar 2020 07:52:44 +0000 Received: by mail-ot1-x344.google.com with SMTP id a20so1141050otl.0 for ; Tue, 03 Mar 2020 23:52:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=D1wYCmelh18MIZ9TSbKlOQJOYn3caIrhR9Ipb4WdWVA=; b=wDRdYjW4rJaDN5z1Pg4q3l+8RQQaj3HfC7tOvjtYA/FPxZt7qLCgoeKRw2WyGPAgnx ZeMElzNidV0T8EzFUMPTUafhoW83YGvj6bDzwFgCuYf+iepv1pwlnTHn8PU9I8kSsadH TkRLEfNrc4pQ9K1sS9bMm1iWWaFvoW+EAAHWBIRFQPtqORqmQgxFxsggjlwXUCUY1Lu6 2/vOemmBael7lANFMhVPaeuxyuTZkKYj0lNDiY24SUz6ULk0K8cZb/17ZhrpgLct/xfo CbclVsCx5c4nUc5/vbvAssZDmVGNrvRQOCi6yRz6TJy6KIhSIrey22RplOFQe+wXNkHJ BUXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=D1wYCmelh18MIZ9TSbKlOQJOYn3caIrhR9Ipb4WdWVA=; b=D68IhDbzbYsFHm+OSDpZCKqVSsB9lTz0pK1UwY9DOYVBJQRDJYzfkZAIogzQnx5tou uER5MKWEacvFKbaCLRrtIJTldBHqXJgaNod50e/itKbSegn/Dei4SfH6pgbqypMkjfAi mKgCZr4YWhavI0AffsNZ6JvZAO/lwWObTqXMleOFv0ZU2HDyyJao5EhGgGMpSRgYC7/I aJcvD+fL/OrQ8cU72uPDECBdkFjdla8dRANKy0I2HV3Ga+fNNBY4kCbdpWmzVDLol7Lj 4R9iSCekK9ZeF5hX7KuOy4UGDA4vuS/evSSyO7ApG7MJyFkueRannSKR/lpx/o8zRfvx DKWA== X-Gm-Message-State: ANhLgQ083RJ8sXBkHI6GJ5nsIS3Fmqgg44XoCLZPYn+fT9yRfWYOwIej Pf4U3zRBnggTMP1VCGnUAOfG5oYY3g6sMO997lSzmt5NNYw3hBM2NK7orbTMvb6nG/MJq30OTrA vPqsbyzlz54mfO+ZvAVuESAS8Hj10sAnxeOrYheWSSFfJDePKrAtv3pNifGLOl3R1ZLW0ZCCulK sD6NCiCMuFi3yye8XD7BLa7WExaXJQAwSCOwxA7ArLnB2aTZ0idZI= X-Google-Smtp-Source: ADFU+vtu+yCB/0OycnQcvJ9a4zH4X9Ja00mlP6ACkb4gpv1nFS78r39VtvL7frM5fTU+Ry/0lYZwxU3KT/Ve7IDqrTg= X-Received: by 2002:a9d:3f5:: with SMTP id f108mr1453294otf.131.1583308362597; Tue, 03 Mar 2020 23:52:42 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Ashesh Vashi Date: Wed, 4 Mar 2020 13:22:31 +0530 Message-ID: Subject: Re: PgAgent leap year problem To: Neel Patel Cc: =?UTF-8?Q?Mehmet_Emin_KARAKA=C5=9E?= , Dave Page , pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000085dc8805a002b4f9" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000085dc8805a002b4f9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Mar 4, 2020 at 12:36 PM Neel Patel wrote: > Hi Ashesh, > > I have reviewed it and looks good. I have updated the sql version in > header of each sql file. > Thanks Neel. Committed the patch with the change suggested offline regarding the updated version in the windows resource (.rc) files. -- Thanks, Ashesh > > Thanks, > Neel Patel > > On Wed, Mar 4, 2020 at 12:22 PM Ashesh Vashi < > ashesh.vashi@enterprisedb.com> wrote: > >> On Wed, Mar 4, 2020 at 10:53 AM Neel Patel >> wrote: >> >>> Hi Mehmet, >>> >>> It was a bug in pgAgent. Thank you for sharing the patch. I have >>> reviewed and tested, it is working fine. >>> >>> Dave/Ashesh:- Can we commit this patch ? >>> >> Mehmet, >> >> Thanks for your patch. >> Changes look good except it does not take care of the upgrade scenarios. >> >> Hence - updated the patch for the same. >> >> Neel, >> >> Would you please review the updated patch with the upgrade scenarios? >> >> >> -- Thanks, Ashesh >> >>> >>> Thanks, >>> Neel Patel >>> >>> On Mon, Mar 2, 2020 at 5:26 PM Mehmet Emin KARAKA=C5=9E >>> wrote: >>> >>>> Hi, >>>> >>>> Scheduled tasks set as the last day of February this year did not work= . >>>> In your schedule function have a small bug. Leap year function get ye= ar >>>> parameter, but your code is sending day as a parameter. Fixing patch >>>> attached in this mail. >>>> >>>> Best Regards... >>>> >>>> -- >>>> MEHMET EM=C4=B0N KARAKA=C5=9E >>>> PostgreSQL DBA >>>> >>>> Turksat Satellite Communication and Cable TV Operations >>>> Konya Yolu 40. Km. 06839 Golbasi / ANKARA - T=C3=9CRK=C4=B0YE >>>> Tel : +90 312 615 32 73 >>>> Faks : +90 312 615 32 77 >>>> >>> --00000000000085dc8805a002b4f9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Mar 4, 2020 at 12:36 PM Neel Pate= l <neel.patel@enterprised= b.com> wrote:
Hi Ashesh,

I have reviewed it and looks=C2=A0good.=C2=A0 I have updated the s= ql version in header of each sql file.
Thanks = Neel.
Committed the patch with the change suggested offline regar= ding the updated version in the windows resource (.rc) files.
-- Thanks, Ashesh=C2=A0=C2=A0

Thanks,
Neel Patel

On Wed, Mar 4, 2020 at 12:22 PM Ashesh Vashi <ashesh.vashi@en= terprisedb.com> wrote:
On Wed, Mar 4, 2020 at 10:5= 3 AM Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi Mehmet,

It was a bug in pgAgent. Thank you f= or sharing the patch. I have reviewed and tested, it is working fine.
=

Dave/Ashesh:-=C2=A0 Can we commit this patch ?
Mehmet,

Thanks for your patch= .
Changes look good except it does not take care of the upgrade s= cenarios.

Hence - updated the patch for the same.<= /div>

Neel,=C2=A0

Would you ple= ase review the updated patch with the upgrade scenarios?


-- Thanks, Ashesh=C2=A0

Thanks,
Neel Patel

On Mon, Mar 2, 2020 at 5:26 PM Mehmet Emin KARAKA=C5= =9E <emin100@gmai= l.com> wrote:
Hi,

Scheduled tasks set as the las= t day of February this year did not work. In your schedule function have a = small bug.=C2=A0 Leap year function get year parameter, but your code is se= nding day as a parameter.=C2=A0 Fixing patch attached in this mail.

Best Regards...

--
MEHMET EM=C4=B0N KARAKA=C5=9E
PostgreSQL DBA

Turksat Satellite Communication a= nd Cable TV Operations
Konya Yolu 40. Km. 06839 Golbasi / ANKARA - T=C3= =9CRK=C4=B0YE
Tel=C2=A0 =C2=A0=C2=A0 :=C2=A0 +90 312 615 32 73
Faks= =C2=A0 :=C2=A0 +90 312 615 32 77
--00000000000085dc8805a002b4f9--