Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnMX0-0005j5-7A for pgadmin-hackers@arkaria.postgresql.org; Fri, 23 Sep 2016 09:12:30 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bnMWz-0003dl-OC for pgadmin-hackers@arkaria.postgresql.org; Fri, 23 Sep 2016 09:12:29 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bnMWz-0003df-1f for pgadmin-hackers@postgresql.org; Fri, 23 Sep 2016 09:12:29 +0000 Received: from mail-io0-x22c.google.com ([2607:f8b0:4001:c06::22c]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bnMWv-0002p9-Ms for pgadmin-hackers@postgresql.org; Fri, 23 Sep 2016 09:12:28 +0000 Received: by mail-io0-x22c.google.com with SMTP id e66so22461525iod.1 for ; Fri, 23 Sep 2016 02:12:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=LQRXvUV4tNTfIt55Q7vGYPB08sEKN5U50P0oaaFkPgM=; b=L7zcaOad+gi5bCcGZ6KrDtMvC3B/SgknYpWX21N16G8rt100/pdGkZXAh5Z5bSk4tI WHgFg8rwE1lF5LY9tIdJLO6dUFVSqwcTArID0Y2m7UxvVbfwTBsDiQpUI2vnrqGbBsbi fu99NVSMlJMcflffB1FunrJXgJBObOmdCyIE9VEpXp/hjC2EY67t3g0/2jvxoSCkNl83 LElp9aa/L5BA2kjQ1gQWwdeflqwIRy/ZeKgs6ALr98WdoIltiCB9xPNF65lbPymclFki nuYhK83TJIKR0IKEw+sRpecfc5zMRxrvQuaJ0PA+MPZcxw4KhS5gd3B5vVnZAEnZLHBU OO0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=LQRXvUV4tNTfIt55Q7vGYPB08sEKN5U50P0oaaFkPgM=; b=SH5OevFUKyTxPo63OKqgKLtp71i1MIM71jXr6nWnkymYO4pWIu6OZISUfaXsEJLHWi jU90gh/F//dqP76QfDLEIqvOOr9sEavo2FI5A3vzVtWCf0hHvlqWahTHfW6iuD0ctv+f ZJrRqCE9v80HD5/E9fChEFNsUCwpHybRbmRd5wlM9aJVoIX9nOwobOF0twFdp9pM1xIb 8dIvOc1M2eL2gApEpeEUgb8G4HHSta1l2/X6lB/ezBFII8+UwjCJMERGYSluWu7v7jTD 20va6YcupvU0KaTexHfmJhBKsPUyKB0eLzRORiDhCAYPQmE20z1o7W2agLCqKw5sf9P1 KtgA== X-Gm-Message-State: AA6/9RkjjW11m90QksUtNYqlfkBzOI0jTLbSutEAKUnRl0xkziWGbJmw5vsybkDUW9y3wm91u6L8Y33mOewvVv0N X-Received: by 10.107.15.42 with SMTP id x42mr7847041ioi.219.1474621943825; Fri, 23 Sep 2016 02:12:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.50.212 with HTTP; Fri, 23 Sep 2016 02:12:03 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Fri, 23 Sep 2016 14:42:03 +0530 Message-ID: Subject: Re: PATCH: pgAgent support To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a113edc6423dd30053d292dec X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113edc6423dd30053d292dec Content-Type: text/plain; charset=UTF-8 Thanks - working on the rest of the comments. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Fri, Sep 23, 2016 at 2:40 PM, Dave Page wrote: > Thanks, applied. > > On Fri, Sep 23, 2016 at 7:33 AM, Ashesh Vashi > wrote: > > Hi Dave, > > > > > > On Thu, Sep 22, 2016 at 8:01 PM, Dave Page wrote: > >> > >> Hi > >> > >> On Thu, Sep 22, 2016 at 11:47 AM, Ashesh Vashi > >> wrote: > >>> > >>> Hi Dave, > >>> > >>> Please find the patch for support for paAgent in pgAdmin 4. > >> > >> > >> Did you forget the binary switch? > >> > >> piranha:web dpage$ git apply --binary ~/Downloads/pgagent_v2.patch > >> error: cannot apply binary patch to > >> 'web/pgadmin/browser/server_groups/servers/pgAgent/ > schedules/static/img/coll-pga_schedule.png' > >> without full index line > >> error: > >> web/pgadmin/browser/server_groups/servers/pgAgent/ > schedules/static/img/coll-pga_schedule.png: > >> patch does not apply > >> error: cannot apply binary patch to > >> 'web/pgadmin/browser/server_groups/servers/pgAgent/ > schedules/static/img/pga_schedule.png' > >> without full index line > >> error: > >> web/pgadmin/browser/server_groups/servers/pgAgent/ > schedules/static/img/pga_schedule.png: > >> patch does not apply > >> error: cannot apply binary patch to > >> 'web/pgadmin/browser/server_groups/servers/pgAgent/static/ > img/coll-pga_job.png' > >> without full index line > >> error: > >> web/pgadmin/browser/server_groups/servers/pgAgent/static/ > img/coll-pga_job.png: > >> patch does not apply > >> error: cannot apply binary patch to > >> 'web/pgadmin/browser/server_groups/servers/pgAgent/static/ > img/pga_job-disabled.png' > >> without full index line > >> error: > >> web/pgadmin/browser/server_groups/servers/pgAgent/static/ > img/pga_job-disabled.png: > >> patch does not apply > >> error: cannot apply binary patch to > >> 'web/pgadmin/browser/server_groups/servers/pgAgent/static/ > img/pga_job.png' > >> without full index line > >> error: > >> web/pgadmin/browser/server_groups/servers/pgAgent/static/ > img/pga_job.png: > >> patch does not apply > >> error: cannot apply binary patch to > >> 'web/pgadmin/browser/server_groups/servers/pgAgent/steps/ > static/img/coll-pga_jobstep.png' > >> without full index line > >> error: > >> web/pgadmin/browser/server_groups/servers/pgAgent/steps/ > static/img/coll-pga_jobstep.png: > >> patch does not apply > >> error: cannot apply binary patch to > >> 'web/pgadmin/browser/server_groups/servers/pgAgent/steps/ > static/img/pga_jobstep.png' > >> without full index line > >> error: > >> web/pgadmin/browser/server_groups/servers/pgAgent/steps/ > static/img/pga_jobstep.png: > >> patch does not apply > >>> > >>> > >>> I have also attached another patch for miscellaneous fixes, and adding > >>> new controls. > >>> It includes: > >>> - Added DatetimepickerControl, MomentCell (using moment.js) > >>> - Used the 'DatetimepickerControl' in Role (Also - resolved an issue, > >>> when unset the datetime for 'Valid Until'.) > >>> - Added a 'Select All/Unselect All' adaptor for Select2 used by pgAgent > >>> nodes. > >>> - Fixed an issue with SubNodeCollectionControl, which was not starting > >>> the modification session of the child model, when created default > value for > >>> collection is not null/undefined. And, hence - validation on the child > model > >>> was not working. > >>> - Fixed a memory leak with SqlFieldControl, and SqlTabControl, which > was > >>> not releasing the CodeMirror properly. > >> > >> > >> Urgh, that's big. > > > > I know. > > That's reason - I was reluctant to send earlier. > >> > >> Applied - but can you look at the following please? > >> > >> - Account expires has a hint of 'MMM D YYYY HH:mm:ss.SSS Z". Are > >> milliseconds really needed? I also get 00 as a fractional timezone > offset. > >> Perhaps we should hide that, when it's 00? > > > > Changed to 'YYYY-MM-DD HH:mm:ss Z'. > >> > >> > >> - The date format differs from the ISO format displayed by the query > tool. > >> They should be consistent - and really should be either based on the > >> client's locale settings, or ISO format. > > > > Done > > > > -- > > Thanks & Regards, > > > > Ashesh Vashi > >> > >> > >> Thanks. > >> > >> -- > >> Dave Page > >> Blog: http://pgsnake.blogspot.com > >> Twitter: @pgsnake > >> > >> EnterpriseDB UK: http://www.enterprisedb.com > >> The Enterprise PostgreSQL Company > > > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a113edc6423dd30053d292dec Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thanks - working on the rest of the comments.


On Fri, Sep 23, 2016 at 2:40 PM, Dave Page <= span dir=3D"ltr"><dpage@pgadmin.org> wrote:
= Thanks, applied.

On Fri, Sep 23, 2016 at 7:33 AM, Ashesh Vashi
<ashesh.vashi@enterprisedb.com> wrote:
> Hi Dave,
>
>
> On Thu, Sep 22, 2016 at 8:01 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Hi
>>
>> On Thu, Sep 22, 2016 at 11:47 AM, Ashesh Vashi
>> <ashesh.vashi@= enterprisedb.com> wrote:
>>>
>>> Hi Dave,
>>>
>>> Please find the patch for support for paAgent in pgAdmin 4. >>
>>
>> Did you forget the binary switch?
>>
>> piranha:web dpage$ git apply --binary ~/Downloads/pgagent_v2.patch=
>> error: cannot apply binary patch to
>> 'web/pgadmin/browser/server_groups/servers/pgAgent/s= chedules/static/img/coll-pga_schedule.png'
>> without full index line
>> error:
>> web/pgadmin/browser/server_groups/servers/pgAgent/schedu= les/static/img/coll-pga_schedule.png:
>> patch does not apply
>> error: cannot apply binary patch to
>> 'web/pgadmin/browser/server_groups/servers/pgAgent/s= chedules/static/img/pga_schedule.png'
>> without full index line
>> error:
>> web/pgadmin/browser/server_groups/servers/pgAgent/schedu= les/static/img/pga_schedule.png:
>> patch does not apply
>> error: cannot apply binary patch to
>> 'web/pgadmin/browser/server_groups/servers/pgAgent/static= /img/coll-pga_job.png'
>> without full index line
>> error:
>> web/pgadmin/browser/server_groups/servers/pgAgent/static/img/coll-pga_job.png:
>> patch does not apply
>> error: cannot apply binary patch to
>> 'web/pgadmin/browser/server_groups/servers/pgAgent/static= /img/pga_job-disabled.png'
>> without full index line
>> error:
>> web/pgadmin/browser/server_groups/servers/pgAgent/static/img/pga_job-disabled.png:
>> patch does not apply
>> error: cannot apply binary patch to
>> 'web/pgadmin/browser/server_groups/servers/pgAgent/static= /img/pga_job.png'
>> without full index line
>> error:
>> web/pgadmin/browser/server_groups/servers/pgAgent/static/img/pga_job.png:
>> patch does not apply
>> error: cannot apply binary patch to
>> 'web/pgadmin/browser/server_groups/servers/pgAgent/steps/= static/img/coll-pga_jobstep.png'
>> without full index line
>> error:
>> web/pgadmin/browser/server_groups/servers/pgAgent/steps/= static/img/coll-pga_jobstep.png:
>> patch does not apply
>> error: cannot apply binary patch to
>> 'web/pgadmin/browser/server_groups/servers/pgAgent/steps/= static/img/pga_jobstep.png'
>> without full index line
>> error:
>> web/pgadmin/browser/server_groups/servers/pgAgent/steps/= static/img/pga_jobstep.png:
>> patch does not apply
>>>
>>>
>>> I have also attached another patch for miscellaneous fixes, an= d adding
>>> new controls.
>>> It includes:
>>> - Added DatetimepickerControl, MomentCell (using moment.js) >>> - Used the 'DatetimepickerControl' in Role (Also - res= olved an issue,
>>> when unset the datetime for 'Valid Until'.)
>>> - Added a 'Select All/Unselect All' adaptor for Select= 2 used by pgAgent
>>> nodes.
>>> - Fixed an issue with SubNodeCollectionControl, which was not = starting
>>> the modification session of the child model, when created defa= ult value for
>>> collection is not null/undefined. And, hence - validation on t= he child model
>>> was not working.
>>> - Fixed a memory leak with SqlFieldControl, and SqlTabControl,= which was
>>> not releasing the CodeMirror properly.
>>
>>
>> Urgh, that's big.
>
> I know.
> That's reason - I was reluctant to send earlier.
>>
>> Applied - but can you look at the following please?
>>
>> - Account expires has a hint of 'MMM D YYYY HH:mm:ss.SSS Z&quo= t;. Are
>> milliseconds really needed? I also get 00 as a fractional timezone= offset.
>> Perhaps we should hide that, when it's 00?
>
> Changed to 'YYYY-MM-DD HH:mm:ss Z'.
>>
>>
>> - The date format differs from the ISO format displayed by the que= ry tool.
>> They should be consistent - and really should be either based on t= he
>> client's locale settings, or ISO format.
>
> Done
>
> --
> Thanks & Regards,
>
> Ashesh Vashi
>>
>>
>> Thanks.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a113edc6423dd30053d292dec--