Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fSHGQ-0005ht-MN for pgadmin-hackers@arkaria.postgresql.org; Mon, 11 Jun 2018 07:29:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fSHGP-0004vB-GB for pgadmin-hackers@arkaria.postgresql.org; Mon, 11 Jun 2018 07:29:17 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fSHGP-0004uz-1P for pgadmin-hackers@lists.postgresql.org; Mon, 11 Jun 2018 07:29:17 +0000 Received: from mail-ot0-x22a.google.com ([2607:f8b0:4003:c0f::22a]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fSHGL-0001Gi-NR for pgadmin-hackers@postgresql.org; Mon, 11 Jun 2018 07:29:15 +0000 Received: by mail-ot0-x22a.google.com with SMTP id d19-v6so17077555oti.8 for ; Mon, 11 Jun 2018 00:29:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=cIZUvQJ6woRQweW5HUBCWyyRw+IPb7ZxQ+xLSVcQdek=; b=fPmwYTi0AGzdgqkCqScNfHalvXR8RJAjQwWs8lqyjcbdvCUm8lAFZWFkCNfce/IV0D IqE4u6WFBPhQNDc9uUisKR33ue4geyK0cYSWphwPLI2AkW7EtRsnr15Wi8SlsPaUKjST UuZHphGJw+4OiKv16BAIcEFw/Mq/v/H3wtzlpULloIHbcYSXe7varl8bock9TZ6JN6YB 3JfnMrZF495SYVx3cJ//n5dX0ZqDBwobrtw/wKkHhhbMYnnvZMa0PmkWsG3ceTfHYGaX khq0xnWAikBOe9RuV8b5oTq4vNNdlVRGPZB8BB+gxOj4UP+iQOzxNfwqH6gxQFT3x/hc fzMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=cIZUvQJ6woRQweW5HUBCWyyRw+IPb7ZxQ+xLSVcQdek=; b=K3J6YkYa1P8PHkPOaqoJRJ5Ms8M650u/rp6Uu886sV5DUuTEXukcqZ2QSolcfZka9u VCZsP/U2a8DqSrKk/PckTdRhUnSLT8lPjD/UNLQacqynw6SHukcgEQINqftCzosVzZfP mTWIzeqEWhwMmIruNpOKQFK8E2ZDPCze/m8aBbw9Nic1cZex3X0gCElNaU2hP5rUSufD dWeOCIxBSV6PyI1f1KJ8jMGIBjVK81E8yMhYNKi+ZMRfjoPaQEDHU0AtTKQyPZSSt1DV unI/VBCZvGDKxywrGqdTfG1IccNHcfRotfwoeosL4MwfT+H2fmFUj9qerCEYPpg8j0mB ZESg== X-Gm-Message-State: APt69E0kEUT6m2bEh9h85bm87q4BHOh0O/uUPZkRY07uNXci4HKl6yDJ Kam0FzxbFn9gurrmhBcpvJUTgL+jZ1pU1iO4eTC3FQ== X-Google-Smtp-Source: ADUXVKLsRuSuTZj+QaaeMsP5FPlHyxP4lpvai4nc8QD+14BX0whOO6onD35yo2wESQxwiJOUjZBDHf/y8GrFvPWwEvk= X-Received: by 2002:a9d:86c:: with SMTP id 99-v6mr9761710oty.226.1528702152249; Mon, 11 Jun 2018 00:29:12 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ac9:7a54:0:0:0:0:0 with HTTP; Mon, 11 Jun 2018 00:28:51 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Mon, 11 Jun 2018 12:58:51 +0530 Message-ID: Subject: Re: PGAgent 4.0 error feedback To: Rob Emery Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000c0c317056e58b4ee" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000c0c317056e58b4ee Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Rob, On Mon, Jun 11, 2018 at 12:50 PM, Rob Emery wrote: > Hi Ashesh, > > Log-level wise I was using the same command for both versions: > > ./pgagent -f -l 2 -t 1 -r 1 'hostaddr=3Dserver user=3Dusername > password=3Dpassword dbname=3Dpostgres' > > and messing up the connection string in various ways (missing dbname, > incorrect password, incorrect hostaddr) > > This was built and tested on Debian GNU/Linux 9.4 (stretch). > If you're working on the source, would please test the patch sent by me? > > I've attached an example of the differing output when the dbname is missi= ng > from the connectionstring; basically it's the same for all errors. > Thanks a lot for the information. -- Thanks, Ashesh > > Many Thanks, > Rob > > On 11/06/2018, Ashesh Vashi wrote: > > Hi Rob, > > > > On Sun, Jun 10, 2018 at 2:26 AM, Rob Emery > > wrote: > > > >> Hi Guys, > >> > >> I've been testing out PGAgent 4 (build today from master at commit > >> 86ca5c5ed1ad572075ba27e05e4680ebdf5b9feb) to check the connection > >> handling on error is still fixed with the boost reimplementation > >> (which it is!) > >> and noticed a few issues compared to PGAgent 3 around feedback to the > >> user if the connection string is incorrect. > >> > >> I've tested with incorrect username and password, user not in the hba, > >> db doesn't exist, postgresql not running on the host (or incorrect > >> hostaddr) and 4 seems to always returns the error : > >> ` > >> ERROR: Couldn't find the function 'pgagent_schema_version' - please > >> run pgagent_upgrade.sql. > >> ` > >> > >> whereas 3.4.1 tends to output from the pgconnection itself like: > >> ` > >> Sat Jun 9 21:32:13 2018 : WARNING: Couldn't create the primary > >> connection (attempt 1): FATAL: no pg_hba.conf entry for host > >> "172.30.0.16", user "pgagent_login_role", database > >> "pgagent_login_role", SSL on > >> FATAL: no pg_hba.conf entry for host "172.30.0.16", user > >> "pgagent_login_role", database "pgagent_login_role", SSL off > >> ` > >> > >> which at least points the user towards the actual error! > >> > >> Not sure if this is known already, but I thought I'd raise it prior to > >> release. > >> > > Thanks for sharing the information. > > > > Is it possible for you to share the logs with log level set to debug? > > Also - please share the operating system details? > > > > -- > > > > Thanks & Regards, > > > > Ashesh Vashi > > EnterpriseDB INDIA: Enterprise PostgreSQL Company > > > > > > > > *http://www.linkedin.com/in/asheshvashi* > > > > > > > > > >> > >> Thanks, > >> Rob > >> -- > >> > >> -- > >> > >> > >> > >> Codeweavers May Newsletter > >> l Codeweavers > >> April > >> Finance Trends > >> > >> > >> > >> April=E2=80=99s Dealer Highlights > >> > >> march-car-finance-trends > >> > > >> > >> _ > >> _ > >> > >> > >> > >> *Phone:* 0800 021 0888 Email: contactus@codeweavers.net > >> > >> Codeweavers Ltd | Barn 4 | Dunston > >> Business Village | Dunston | ST18 9AB > >> Registered in England and Wales No. > >> 04092394 | VAT registration no. 974 9705 63 > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > > > > -- > > > > Codeweavers May Newsletter > l Codeweavers > April > Finance Trends > > > > April=E2=80=99s Dealer Highlights > > > > > _ > _ > > > > *Phone:* 0800 021 0888 Email: contactus@codeweavers.net > > Codeweavers Ltd | Barn 4 | Dunston > Business Village | Dunston | ST18 9AB > Registered in England and Wales No. > 04092394 | VAT registration no. 974 9705 63 > > > > > > > > > > --000000000000c0c317056e58b4ee Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
<= div style=3D"margin:0pt 0pt 8px">

Hi Rob,


On Mon, Jun 11, 2018 at 12:50 PM, Rob Emery <re-pgsql@codewe= avers.net> wrote:
Hi Ashes= h,

Log-level wise I was using the same command for both versions:

=C2=A0./pgagent -f -l 2 -t 1 -r 1 'hostaddr=3Dserver user=3Dusername password=3Dpassword dbname=3Dpostgres'

and messing up the connection string in various ways (missing dbname,
incorrect password, incorrect hostaddr)

This was built and tested on=C2=A0 Debian GNU/Linux 9.4 (stretch).
If you're working on the source, would please test the pat= ch sent by me?=C2=A0

I've attached an example of the differing output when the dbname is mis= sing
from the connectionstring; basically it's the same for all errors.
<= /blockquote>

Thanks a lot for the information.

-- Thanks, Ashesh=C2=A0

Many Thanks,
Rob

On 11/06/2018, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
> Hi Rob,
>
> On Sun, Jun 10, 2018 at 2:26 AM, Rob Emery <re-pgsql@codeweavers.net>
> wrote:
>
>> Hi Guys,
>>
>> I've been testing out PGAgent 4 (build today from master at co= mmit
>> 86ca5c5ed1ad572075ba27e05e4680ebdf5b9feb) to check the connec= tion
>> handling on error is still fixed with the boost reimplementation >> (which it is!)
>> and noticed a few issues compared to PGAgent 3 around feedback to = the
>> user if the connection string is incorrect.
>>
>> I've tested with incorrect username and password, user not in = the hba,
>> db doesn't exist, postgresql not running on the host (or incor= rect
>> hostaddr) and 4 seems to always returns the error :
>> `
>> ERROR: Couldn't find the function 'pgagent_schema_version&= #39; - please
>> run pgagent_upgrade.sql.
>> `
>>
>> whereas 3.4.1 tends to output from the pgconnection itself like: >> `
>> Sat Jun=C2=A0 9 21:32:13 2018 : WARNING: Couldn't create the p= rimary
>> connection (attempt 1): FATAL:=C2=A0 no pg_hba.conf entry for host=
>> "172.30.0.16", user "pgagent_login_role", data= base
>> "pgagent_login_role", SSL on
>> FATAL:=C2=A0 no pg_hba.conf entry for host "172.30.0.16"= , user
>> "pgagent_login_role", database "pgagent_login_role&= quot;, SSL off
>> `
>>
>> which at least points the user towards the actual error!
>>
>> Not sure if this is known already, but I thought I'd raise it = prior to
>> release.
>>
> Thanks for sharing the information.
>
> Is it possible for you to share the logs with log level set to debug?<= br> > Also - please share the operating system details?
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com/>
>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.li= nkedin.com/in/asheshvashi>
>
>
>
>>
>> Thanks,
>> Rob
>> --
>>
>> --
>>=C2=A0 <https://codeweavers.net>
>>
>>
>> Codeweavers May Newsletter
>> <https://mailchi.mp/codeweavers/= march-edition-336883>=C2=A0 l=C2=A0 Codeweavers
>> April
>> Finance Trends
>> <https://codeweaver= s.net/company-blog/codeweavers-april-finance-trends>
>>
>>
>> April=E2=80=99s Dealer Highlights
>> <https://codeweavers.net/company-blog/aprils-dealer-highlights>
>> <https://codewe= avers.net/company-blog/codeweavers-march-car-finance-trends >> >
>>
>> _
>> _
>>
>>
>>
>> *Phone:* 0800 021 0888=C2=A0 =C2=A0Email: contactus@codeweavers.net
>> <mailto:contactus@= codeweavers.net>
>> Codeweavers Ltd | Barn 4 | Dunston
>> Business Village | Dunston | ST18 9AB
>> Registered in England and Wales No.
>> 04092394 | VAT registration no. 974 9705 63
>>
>>
>>
>>
>> <https://www.linkedin.com/compa= ny/codeweavers-limited>
>> <https://vimeo.com/codeweaversltd>
>> <https://plus.google.com/= b/105942302039373248738/+CodeweaversNet>
>> <https://twitter.com/CodeweaversTeam>
>>
>>
>>
>

--
=C2=A0<https://codeweavers.net>


Codeweavers May Newsletter
<https://mailchi.mp/codeweavers/march-edi= tion-336883>=C2=A0=C2=A0l=C2=A0 Codeweavers April
Finance Trends
<https://codeweavers.net/company-blog/codeweavers-april-finance-trends>


April=E2=80=99s Dealer Highlights
<https://codeweavers.net/compan= y-blog/aprils-dealer-highlights>
<https://codeweavers.net= /company-blog/codeweavers-march-car-finance-trends>

_
_



*Phone:*=C2=A00800 021 0888=C2=A0=C2=A0=C2=A0Email:=C2=A0contactus@codeweavers.net
<mailto:contactus@codeweave= rs.net>
Codeweavers Ltd=C2=A0| Barn 4 | Dunston
Business Village | Dunston | ST18 9AB
Registered in England and Wales No.
04092394 | VAT registration no. 974 9705 63=C2=A0




<https://www.linkedin.com/company/codewe= avers-limited>=C2=A0=C2=A0
<https://vimeo.com/codeweaversltd>=C2=A0=C2=A0
<https://plus.google.com/b/10= 5942302039373248738/+CodeweaversNet>=C2=A0=C2=A0
<https://twitter.com/CodeweaversTeam>


--000000000000c0c317056e58b4ee--