Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1ZecHB-0007o4-IF for pgadmin-hackers@arkaria.postgresql.org; Wed, 23 Sep 2015 05:07:29 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1ZecHA-0005jz-U8 for pgadmin-hackers@arkaria.postgresql.org; Wed, 23 Sep 2015 05:07:28 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1ZecGx-0005VS-Bq for pgadmin-hackers@postgresql.org; Wed, 23 Sep 2015 05:07:15 +0000 Received: from mail-la0-f49.google.com ([209.85.215.49]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1ZecGp-0005Ee-Go for pgadmin-hackers@postgresql.org; Wed, 23 Sep 2015 05:07:14 +0000 Received: by lahh2 with SMTP id h2so12833914lah.0 for ; Tue, 22 Sep 2015 22:07:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=b5vHYCkIMQzWm5cn8V1efIry6FEkqY5h47u0h26rHrg=; b=bgMVHyjpVi8R5wpCkTsu2vT+5T+jRrRZ4YoAxStdcbjy6MX5pwmsLVmyFqWwnQL6Ro Gznb/SxqR3QBc8xPPtgdmBs8XEihfvVYkSdr2iKCoZdV34Tg5rxl+R3YzMkptRV0XBNl OSJCeX1ANsSslbkADRjGoPSJNdPAFbsJwme9bqVmZICKPj5SQcZnxhT2TwV2cYTXsBBD XKdyBouuJXk1TYX3w7hOGENDuFFWQ5F217KNf715qcONPRb2ViBTiWcD+Xx3KODPDgnl +M7vkb78pH0D+MA0/5SKIpfDzvc49Q6J73GEihXofIMzsc0wZLNsx685w4AYd31Hsn5U XerA== X-Gm-Message-State: ALoCoQkMKNjVtD4hwPz2RxkYW1y7EcRSd3pmK8bS9QraLzVN4jJ/sCYtEaGMeDuT2tZunuwc9xAC X-Received: by 10.112.163.99 with SMTP id yh3mr10812510lbb.121.1442984826007; Tue, 22 Sep 2015 22:07:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.112.135.42 with HTTP; Tue, 22 Sep 2015 22:06:46 -0700 (PDT) In-Reply-To: References: <87246063.20150923075305@mail.ru> From: Ashesh Vashi Date: Wed, 23 Sep 2015 10:36:46 +0530 Message-ID: Subject: Re: pgAdmin III commit: Resolved an issue related enable/disable menu items To: "J.F. Oster" Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=089e011605f4f88fe205206315df X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --089e011605f4f88fe205206315df Content-Type: text/plain; charset=UTF-8 On Wed, Sep 23, 2015 at 10:27 AM, Ashesh Vashi < ashesh.vashi@enterprisedb.com> wrote: > On Wed, Sep 23, 2015 at 10:23 AM, J.F. Oster wrote: > >> Hi Ashesh, >> >> Favourite's issue is resolved, but looks like Edit - Cut/Copy/Paste >> items are disabled all the time (seen on Ubuntu, Kubuntu). >> > I've tested the patch couple of times on Ubuntu, and OSX both before > committing the changes. > > Do you have time to look into it? > Got the reason. Thanks for the report. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > > > > *http://www.linkedin.com/in/asheshvashi* > > >> >> Tuesday, September 22, 2015, 10:56:32 AM, you wrote: >> >> AV> Resolved an issue related enable/disable menu items in Query Editor >> AV> specifically for Unity Desktop Environment. >> >> AV> wxWidgets was not able to identify the current focused control in some >> AV> cases, during certain event generation. And, that was resulting into >> AV> disabling the wrong menu items. >> AV> i.e. >> AV> Copy, Paste, Undo, Redo, Cut, Paste, Add/Manage favourite menu(s) >> >> AV> In order to resolve the issue, we will not consider the events >> AV> generated, but - no control gets focused, while enabling/disabling the >> AV> menus. >> >> AV> Branch >> AV> ------ >> AV> master >> >> AV> Details >> AV> ------- >> AV> >> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=cd9f615564334ed91d4760c971beae249cf9bd83 >> >> AV> Modified Files >> AV> -------------- >> AV> CHANGELOG | 3 +++ >> AV> pgadmin/frm/frmQuery.cpp | 59 >> AV> +++++++++++++++++++++++++++------------------- >> AV> 2 files changed, 38 insertions(+), 24 deletions(-) >> >> >> >> >> >> -- >> Best regards, >> J.F. >> >> > --089e011605f4f88fe205206315df Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

= On Wed, Sep 23, 2015 at 10:27 AM, Ashesh Vashi <ashesh.vashi@e= nterprisedb.com> wrote:
On Wed, Sep 23, 2015 at 10:23 AM, J.F. Oster <j= infroster@mail.ru> wrote:
Hi Ashesh,

Favourite's issue is resolved, but looks like Edit - Cut/Copy/Paste
items are disabled all the time (seen on Ubuntu, Kubuntu).
=
I've tested the patch couple of times on Ubuntu, and OSX bo= th before committing the changes.

Do you have = time to look into it?
Got the = reason.
Thanks for the report.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi

= =C2=A0

--

Thanks & Regards,
=
Ashesh Va= shi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi

<= /div>

Tuesday, September 22, 2015, 10:56:32 AM, you wrote:

AV> Resolved an issue related enable/disable menu items in Query Editor<= br> AV> specifically for Unity Desktop Environment.

AV> wxWidgets was not able to identify the current focused control in so= me
AV> cases, during certain event generation. And, that was resulting into=
AV> disabling the wrong menu items.
AV> i.e.
AV> Copy, Paste, Undo, Redo, Cut, Paste, Add/Manage favourite menu(s)
AV> In order to resolve the issue, we will not consider the events
AV> generated, but - no control gets focused, while enabling/disabling t= he
AV> menus.

AV> Branch
AV> ------
AV> master

AV> Details
AV> -------
AV> http://git.postgresql.org/gitweb?p=3Dpgadmin3.git;a=3Dcommi= tdiff;h=3Dcd9f615564334ed91d4760c971beae249cf9bd83

AV> Modified Files
AV> --------------
AV> CHANGELOG=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |= =C2=A0 =C2=A0 3 +++
AV> pgadmin/frm/frmQuery.cpp |=C2=A0 =C2=A059
AV> +++++++++++++++++++++++++++-------------------
AV> 2 files changed, 38 insertions(+), 24 deletions(-)





--
Best regards,
=C2=A0J.F.



--089e011605f4f88fe205206315df--