Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gp5Qi-0002Ca-4s for pgadmin-hackers@arkaria.postgresql.org; Thu, 31 Jan 2019 06:02:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gp5Qg-0003pv-Tb for pgadmin-hackers@arkaria.postgresql.org; Thu, 31 Jan 2019 06:02:26 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gp5Qg-0003fy-AH for pgadmin-hackers@lists.postgresql.org; Thu, 31 Jan 2019 06:02:26 +0000 Received: from mail-ot1-x32b.google.com ([2607:f8b0:4864:20::32b]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gp5Qd-0005lT-1t for pgadmin-hackers@postgresql.org; Thu, 31 Jan 2019 06:02:24 +0000 Received: by mail-ot1-x32b.google.com with SMTP id a11so1814371otr.10 for ; Wed, 30 Jan 2019 22:02:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7pebS4o8FXYbAfHDiptuSywvquAd39XzOik3Xsw/hLw=; b=kwMsDcFUe0RH1kfEJWYovD6t4yFgrcEJmT7ejM8+dFWGXfU0DpkwXfDiUFvF4Ev+py zrH7f65/FxX45W53IUfzDXOgeSBAQ1VmKBnqWiIapd6DxklyFv2boXoLwvhrc1sVPN5h lUBhXXDo8fe5XktJOvPw2QbbTgylQ4rm6eAMIehwvXvz/OT0xNGOZUhEcIaVz1/E+Bk+ OZLeyaca4Xd5fUoffvmIkmkud+Zu1NMoSZu52bTAgfAmWCisHYKKivJXybi6c5fgPtXi p5QPrJcD6jLPOfAZs4lU/SMQsuorEAm+RG++vtZfIU8j274s12FvKQ2FaQpM/MGLAIOK Xmfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7pebS4o8FXYbAfHDiptuSywvquAd39XzOik3Xsw/hLw=; b=US1rl0xEQuJc0+BV/QN1pAqVHmAHsbKrXl+DJvv6ixVt8/x2KozpS6K9EDieYguFpl BeJDY0NSWs4kON/RiqfZBZPB1u8cA+LPJw0GSmAQhb/7xx+s7YNTY8VO4kfcGyg2+KK0 vUfh89y6gKpsUIjr7CxgwEjIbL7oSLScMFja8PhxjVuo/xE7+refekMcVBxww/u8wgmF EXjleaXR7Cm26r3NMtMy2slsIqGHGMWsGkyEW6JSUPf+qS1Di2jw7M0bQygubC/km/Zz GVK/C7o4KVo4W2g3P7KXSSLXFaa/BGO378J8DzVFROoV7hySZ6mfCeSLmCxt0jbVszP6 qK3w== X-Gm-Message-State: AJcUukeRDZK8z2JSdfSClNvILJzQh4YrfcM791KEa5DRkWXABJeEYIo/ 55MrKJl379mh8o1sctU9WFosnWOF23AEsVEBk0hq7Q== X-Google-Smtp-Source: ALg8bN7dO6VQOV831Hw1xBbeFhTZmt58APPDF81Pc5u5BmDH4MGmoozM/pAh+P+mMcRUjl2B+wJOaaACJMleHq8o0UU= X-Received: by 2002:a9d:641:: with SMTP id 59mr23128814otn.215.1548914541912; Wed, 30 Jan 2019 22:02:21 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Ashesh Vashi Date: Thu, 31 Jan 2019 11:32:10 +0530 Message-ID: Subject: Re: Remove hacky way to open/close the dropdown-submenu To: Aditya Toshniwal Cc: "khushboo.vashi" , pgadmin-hackers Content-Type: multipart/mixed; boundary="0000000000000f27e00580bac580" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000000f27e00580bac580 Content-Type: multipart/alternative; boundary="0000000000000f27dc0580bac57e" --0000000000000f27dc0580bac57e Content-Type: text/plain; charset="UTF-8" Hi Aditya, On Tue, Jan 22, 2019 at 10:25 AM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Ashesh, > > I am getting a syntax error on bundle. > After fixing that, please look into this scenario: > Using keyboard shortcuts open object menu, for eg on table node. Go to any > submenu using keyboard and go to any submenu and press enter. > Now open object menu again using keyboard shortcut, the submenu remains > open. It should be closed. > Please find the updated patch with all comments fixed. Now - whenever the callback for the menu is called (menu toggling), it will close the existing submenu(s) too. Please review it, and let me know. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi * > > Everything looks fine to me except the above. > > > On Tue, Jan 22, 2019 at 10:07 AM Ashesh Vashi < > ashesh.vashi@enterprisedb.com> wrote: > >> Any update? >> >> -- >> >> Thanks & Regards, >> >> Ashesh Vashi >> EnterpriseDB INDIA: Enterprise PostgreSQL Company >> >> >> >> *http://www.linkedin.com/in/asheshvashi* >> >> >> >> On Thu, Jan 17, 2019 at 7:39 PM Ashesh Vashi < >> ashesh.vashi@enterprisedb.com> wrote: >> >>> Hi Aditya/Khushboo, >>> >>> I can see a hacky way to open/close the dropdown-submenu in the menu.js >>> file. >>> I've followed a more general way to open/close any submenu in the >>> dropdown list, instead of just 'Objects' menu. >>> >>> Can you please review it, and let me know your thoughts? >>> Let me know if you have any other better approach. >>> >>> >>> -- >>> >>> Thanks & Regards, >>> >>> Ashesh Vashi >>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>> >>> >>> >>> *http://www.linkedin.com/in/asheshvashi* >>> >>> >> > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > --0000000000000f27dc0580bac57e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Aditya,

On Tue, Jan= 22, 2019 at 10:25 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
= Hi Ashesh,

I am getting a syntax error on b= undle.=C2=A0
After fixin= g that,=C2=A0 please look=C2=A0into this scenario:
Using keyboard shortcuts open object menu, for e= g on table node. Go to any submenu using keyboard and go to any submenu and= press enter.
Now open o= bject menu again using keyboard shortcut, the submenu remains open. It shou= ld be closed.
Please find the updated patch wi= th all comments fixed.
Now - whenever the callback for the menu i= s called (menu toggling), it will close the existing submenu(s) too.
<= div>
Please review it, and let me know.

<= div>

--

Thanks & Regards,
=
Ashesh Va= shi
EnterpriseDB INDIA:=C2=A0Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

=C2=A0

Everything looks fine to me except the above.


On Tue, Jan 22, 2019 at 10:07 AM A= shesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Any update?

<= div>

<= span>--

Thanks & Regards,
=
Ashesh Va= shi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi



On Thu, Jan 17, 2019 at 7:39 PM Ashesh Vashi <ashesh.vashi@= enterprisedb.com> wrote:
Hi Aditya/Khushboo,

I c= an see a hacky way to open/close the dropdown-submenu in the menu.js file.<= /div>
I've followed a more general way to open/close any submenu in= the dropdown list, instead of just 'Objects' menu.

<= /div>
Can you please review it, and let me know your thoughts?
Let me know if you have any other better approach.
=C2=A0

--

Thanks & Regards,<= /span>

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Co= mpany


http://www.linkedin.com/in/asheshvashi



--
=
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB Software Sol= utions |=C2=A0Pune
"Don't Complain about Heat, Plant a tr= ee"
--0000000000000f27dc0580bac57e-- --0000000000000f27e00580bac580 Content-Type: application/octet-stream; name="pgadmin_submenu_open_v2.patch" Content-Disposition: attachment; filename="pgadmin_submenu_open_v2.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jrk7pcpz0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc3RhdGljL2pzL2Jyb3dzZXIuanMgYi93 ZWIvcGdhZG1pbi9icm93c2VyL3N0YXRpYy9qcy9icm93c2VyLmpzCmluZGV4IDJhY2NkMTguLjUx OTliYzggMTAwNjQ0Ci0tLSBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc3RhdGljL2pzL2Jyb3dzZXIu anMKKysrIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zdGF0aWMvanMvYnJvd3Nlci5qcwpAQCAtMzQ5 LDcgKzM0OSw2IEBAIGRlZmluZSgncGdhZG1pbi5icm93c2VyJywgWwogICAgICAgICAgIH1dLCBm YWxzZSk7CiAgICAgICAgICRvYmpfbW51LmFwcGVuZChjcmVhdGVfc3VibWVudS4kZWwpOwogICAg ICAgfQotICAgICAgcGdBZG1pbi5Ccm93c2VyLlN1Ym1lbnVFdmVudHMoJG9ial9tbnUpOwogICAg IH0sCiAgICAgc2F2ZV9jdXJyZW50X2xheW91dDogZnVuY3Rpb24ob2JqKSB7CiAgICAgICBpZihv YmouZG9ja2VyKSB7CmRpZmYgLS1naXQgYS93ZWIvcGdhZG1pbi9icm93c2VyL3N0YXRpYy9qcy9t ZW51LmpzIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zdGF0aWMvanMvbWVudS5qcwppbmRleCA1YzUw OWRhLi43ZGFhZDNmIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9icm93c2VyL3N0YXRpYy9qcy9t ZW51LmpzCisrKyBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc3RhdGljL2pzL21lbnUuanMKQEAgLTM0 NywzMSArMzQ3LDYgQEAgZGVmaW5lKFsKICAgICByZXR1cm4gKGxlbiA+IDApOwogICB9OwogCi0g IHBnQWRtaW4uQnJvd3Nlci5TdWJtZW51RXZlbnRzID0gZnVuY3Rpb24oJG1udSkgewotICAgIGxl dCBzdWJNZW51Q2xvc2UgPSBmdW5jdGlvbihldmVudCkgewotICAgICAgbGV0ICRkcm9wRG93biA9 ICQoZXZlbnQuY3VycmVudFRhcmdldCkuY2xvc2VzdCgnLmRyb3Bkb3duJyk7Ci0gICAgICAkZHJv cERvd24uZmluZCgnLmRyb3Bkb3duLXN1Ym1lbnUgLmRyb3Bkb3duLW1lbnUnKS5yZW1vdmVDbGFz cygnc2hvdycpOwotICAgICAgJGRyb3BEb3duLmZpbmQoJy5kcm9wZG93bi1zdWJtZW51JykucmVt b3ZlQ2xhc3MoJ2Ryb3Bkb3duLXN1Ym1lbnUtdmlzaWJsZScpOwotICAgIH07Ci0KLSAgICBsZXQg JG5hdmxpbmsgPSAkbW51LnNpYmxpbmdzKCcubmF2LWxpbmsnKTsKLSAgICAkbmF2bGluay5vZmYo J2NsaWNrJywgc3ViTWVudUNsb3NlKS5vbignY2xpY2snLCBzdWJNZW51Q2xvc2UpOwotICAgICRt bnUucGFyZW50KCcuZHJvcGRvd24nKS5vZmYoJ3Nob3cuYnMuZHJvcGRvd24nLHN1Yk1lbnVDbG9z ZSkKLSAgICAgIC5vbignc2hvdy5icy5kcm9wZG93bicsc3ViTWVudUNsb3NlKTsKLQotICAgICRt bnUuZmluZCgnLmRyb3Bkb3duLWl0ZW0nKS5vZmYoJ21vdXNlb3ZlcicpLm9uKCdtb3VzZW92ZXIn LCAoZXZlbnQpPT4gewotICAgICAgbGV0ICRkcm9wU3ViTWVudSA9ICQoZXZlbnQuY3VycmVudFRh cmdldCkuY2xvc2VzdCgnLmRyb3Bkb3duLW1lbnUnKS5maW5kKCcuZHJvcGRvd24tc3VibWVudScp OwotICAgICAgLyogQ2xvc2UgYWxsIG90aGVyIHN1Ym1lbnVzIGlmIGFueSAqLwotICAgICAgJGRy b3BTdWJNZW51LmZpbmQoJy5kcm9wZG93bi1tZW51JykucmVtb3ZlQ2xhc3MoJ3Nob3cnKTsKLSAg ICAgICRkcm9wU3ViTWVudS5yZW1vdmVDbGFzcygnZHJvcGRvd24tc3VibWVudS12aXNpYmxlJyk7 Ci0gICAgICAvKiBPcGVuIHRoZSBjdXJyZW50IHN1Ym1lbnUgaWYgYW55ICovCi0gICAgICBpZigk KGV2ZW50LmN1cnJlbnRUYXJnZXQpLnBhcmVudCgpLmhhc0NsYXNzKCdkcm9wZG93bi1zdWJtZW51 JykpewotICAgICAgICAkKGV2ZW50LmN1cnJlbnRUYXJnZXQpLnBhcmVudCgpLmZpbmQoJy5kcm9w ZG93bi1tZW51JykuYWRkQ2xhc3MoJ3Nob3cnKTsKLSAgICAgICAgJChldmVudC5jdXJyZW50VGFy Z2V0KS5wYXJlbnQoKS5hZGRDbGFzcygnZHJvcGRvd24tc3VibWVudS12aXNpYmxlJyk7Ci0gICAg ICB9Ci0gICAgfSk7Ci0gIH07Ci0KICAgLy8gTUVOVSBQVUJMSUMgQ0xBU1MgREVGSU5JVElPTgog ICAvLyA9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KICAgdmFyIE1lbnUgPSBmdW5jdGlv bihlbGVtZW50LCBvcHRpb25zKSB7CkBAIC0zODgsNiArMzYzLDE3IEBAIGRlZmluZShbCiAgICAg ICBldi5wcmV2ZW50RGVmYXVsdCgpOwogICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KKworICAg IHNldFRpbWVvdXQoCisgICAgICAoKSA9PiAoCisgICAgICAgIHRoaXMuJGVsZW1lbnQucGFyZW50 cygnLm5hdi1pdGVtLmRyb3Bkb3duJykKKyAgICAgICAgICAuZmluZCgnLmRyb3Bkb3duLXN1Ym1l bnUuZHJvcGRvd24tc3VibWVudS12aXNpYmxlJykKKyAgICAgICAgICAucmVtb3ZlQ2xhc3MoJ2Ry b3Bkb3duLXN1Ym1lbnUtdmlzaWJsZScpCisgICAgICAgICAgLmZpbmQoJy5kcm9wZG93bi1tZW51 LnNob3cnKQorICAgICAgICAgIC5yZW1vdmVDbGFzcygnc2hvdycpCisgICAgICApLCAxCisgICAg KTsKKwogICAgIHZhciBkID0gdGhpcy4kZWxlbWVudC5kYXRhKCdwZ01lbnUnKTsKICAgICBpZiAo ZC5jYikgewogICAgICAgdmFyIGNiID0gZC5tb2R1bGUgJiYgZC5tb2R1bGVbJ2NhbGxiYWNrcydd ICYmIGQubW9kdWxlWydjYWxsYmFja3MnXVtkLmNiXSB8fCBkLm1vZHVsZSAmJiBkLm1vZHVsZVtk LmNiXTsKQEAgLTQ0MywxMSArNDI5LDIwIEBAIGRlZmluZShbCiAgICAgLm9uKAogICAgICAgJ2Zv Y3VzLnBnLm1lbnUuZGF0YS1hcGkgYmx1ci5wZy5tZW51LmRhdGEtYXBpJywKICAgICAgICdbZGF0 YS10b2dnbGVePSJwZy1tZW51Il0nLAotICAgICAgZnVuY3Rpb24oZSkgewotICAgICAgICAkKGUu dGFyZ2V0KS5jbG9zZXN0KCcubWVudScpLnRvZ2dsZUNsYXNzKAotICAgICAgICAgICdmb2N1cycs IC9eZm9jdXMoaW4pPyQvLnRlc3QoZS50eXBlKQorICAgICAgZnVuY3Rpb24oZXYpIHsKKyAgICAg ICAgJChldi50YXJnZXQpLmNsb3Nlc3QoJy5tZW51JykudG9nZ2xlQ2xhc3MoCisgICAgICAgICAg J2ZvY3VzJywgL15mb2N1cyhpbik/JC8udGVzdChldi50eXBlKQogICAgICAgICApOwotICAgICAg fSk7CisgICAgICB9KQorICAgIC5vbignbW91c2VlbnRlcicsICcuZHJvcGRvd24tc3VibWVudScs IGZ1bmN0aW9uKGV2KSB7CisgICAgICAkKGV2LmN1cnJlbnRUYXJnZXQpLnJlbW92ZUNsYXNzKCdk cm9wZG93bi1zdWJtZW51LXZpc2libGUnKQorICAgICAgICAuYWRkQ2xhc3MoJ2Ryb3Bkb3duLXN1 Ym1lbnUtdmlzaWJsZScpOworICAgICAgJChldi5jdXJyZW50VGFyZ2V0KS5maW5kKCcuZHJvcGRv d24tbWVudScpLmZpcnN0KCkuYWRkQ2xhc3MoJ3Nob3cnKTsKKyAgICB9KQorICAgIC5vbignbW91 c2VsZWF2ZScsICcuZHJvcGRvd24tc3VibWVudScsIGZ1bmN0aW9uKGV2KSB7CisgICAgICAkKGV2 LmN1cnJlbnRUYXJnZXQpLnJlbW92ZUNsYXNzKCdkcm9wZG93bi1zdWJtZW51LXZpc2libGUnKTsK KyAgICAgICQoZXYuY3VycmVudFRhcmdldCkuZmluZCgnLmRyb3Bkb3duLW1lbnUnKS5maXJzdCgp LnJlbW92ZUNsYXNzKCdzaG93Jyk7CisgICAgfSk7CiAKICAgcmV0dXJuIHBnQWRtaW4uQnJvd3Nl ci5NZW51SXRlbTsKIH0pOwo= --0000000000000f27e00580bac580--